Commits · 05e08edf70d5ce2a6f99f9c0e4d7e12acf1eb1ef · Chen Yisong / angle

29 Jan, 2020 11 commits

Disable skipValidation when context is lost. · 05e08edf

authored Dec 26, 2019

Lost no-error contexts should gracefully handle GetProgramiv, etc.

Includes test that a lost no-error context doesn't crash on getProgramiv.
Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1601703

Bug: angleproject:4244
Change-Id: I8c37df37e83308ab85ad958df6dab46b0ab348e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003239Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

05e08edf

Roll third_party/glslang/src 07a55839eed5..9a80305c0897 (1 commits) · 13c44dfe

authored Jan 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/07a55839eed5..9a80305c0897


Created with:
  gclient setdep -r third_party/glslang/src@9a80305c0897

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I3161499b3a6b2e3ad96ef5952782c4409289fa1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027195Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

13c44dfe

Roll third_party/vulkan-tools/src e39b5cf6a1b6..ebe1b7497acb (1 commits) · 71508b20

authored Jan 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e39b5cf6a1b6..ebe1b7497acb

git log e39b5cf6a1b6..ebe1b7497acb --date=short --first-parent --format='%ad %ae %s'
2020-01-28 charles@lunarg.com vulkaninfo: use patch version from instance

Created with:
  gclient setdep -r third_party/vulkan-tools/src@ebe1b7497acb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I878644e5a636c1a21740dda675b6199a86b9f118
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027217Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

71508b20

Roll third_party/SwiftShader 34e16df059f8..6c3dc3581eaf (2 commits) · 1f4ddc96

authored Jan 29, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/34e16df059f8..6c3dc3581eaf

git log 34e16df059f8..6c3dc3581eaf --date=short --first-parent --format='%ad %ae %s'
2020-01-28 capn@google.com Support LLVM 8+ build changes
2020-01-28 bclayton@google.com SpirvShaderDebugger: Fix double nesting of struct members

Created with:
  gclient setdep -r third_party/SwiftShader@6c3dc3581eaf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ie221229f552143cbb8c98b731b5bd4fdd3a17195
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027194Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1f4ddc96

Vulkan: Set fragment output locations in SPIR-V · 5ca050d1

authored Jan 20, 2020

The shader translator outputs arbitrary location indices for fragment
outputs.  Once compiled by glslang, the SPIR-V transformer modifies
these decorations.

Bug: angleproject:3394
Change-Id: Ib9d8336bccc392e789e4d93031fdcce9c466b7a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011214
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5ca050d1

Vulkan: Set vertex attribute locations in SPIR-V · bef8ca7d

authored Jan 20, 2020

The shader translator outputs arbitrary location indices for vertex
attributes.  Once compiled by glslang, the SPIR-V transformer modifies
these decorations.

Bug: angleproject:3394
Change-Id: I88453b44e3a8770f51e79228148233ff308f1885
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011212
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

bef8ca7d

Vulkan: Set set/binding in SPIR-V · 71e6afb1

authored Jan 14, 2020

This change introduces a SPIR-V transformer that modifies shader
interface variable decorations directly in SPIR-V instead of
manipulating the input GLSL. Currently, descriptor set and binding
indices are set by the transformer.

The shader translator outputs arbitrary set and binding indices. Once
compiled by glslang, the SPIR-V transformer modifies these decorations.
The ultimate goal is to be able to modify the SPIR-V again when program
pipeline objects decide a different set/binding is necessary.

Bug: angleproject:3394
Change-Id: If358265a72bf1fe9f5676562b39a632cb2e05dc4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001477Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

71e6afb1

Fuchsia: Blacklist swiftshader on Fuchsia · 2bc9cc12

authored Jan 24, 2020

This doesn't work and is highly misleading as the tests run with the real
GPU.

Bug: angleproject:4353
Change-Id: Id9139436e39d5e8e063bcc679b7c63f589d3b748
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023912
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2bc9cc12

Fuchsia: Disable GLES3 testing on Fuchsia ARM · 44c75073

authored Jan 20, 2020

The vulkan driver is missing required extensions so these tests are all
failing.

Bug: angleproject:4352
Change-Id: Id1af7c40798d8844fbf832c6066260fe3a8bfeda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023911
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

44c75073

Vulkan: Fix handling of inactive fragment outputs · e28883de

authored Jan 25, 2020

These were never assigned a location.  They are now removed by the
translator similar to other inactive variables.

Bug: angleproject:4313
Change-Id: I3398d06e1dea3f43b84f206cca07cde5b44b21a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2021734Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e28883de

Vulkan: Disable global merge for volk · bab2b3de

authored Jan 22, 2020

This optimization pass breaks the build by exporting volk's internal
binding symbols from libGLESv2.so. Since the test binary also links volk,
this causes a SEGV as the wrong (uninitialized) function pointer is
called.

This is an LLVM bug and will be fixed upstream:
https://reviews.llvm.org/D73235

Bug: angleproject:4351
Change-Id: Iebe0eabd975f8109231df30eef8c9074af8190e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023910Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>

bab2b3de

28 Jan, 2020 15 commits

Fuchsia: Implement SystemInfo on Fuchsia · b630bf9e

authored Jan 24, 2020

The Android vulkan code is reusable, so move that to a new file
SystemInfo_vulkan.cpp and call it in the Android & Fuchsia
implementations. This is necessary to skip tests based on GPU.

Bug: angleproject:4349, angleproject:4352
Change-Id: I8330cfcdbd41f4d51391bd5ed7f0820c55e02801
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023909
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b630bf9e

Disable 'nodiscard' warning on MSVC for dEQP. · e3ba0d7d

authored Jan 28, 2020

Bug: angleproject:4358
Change-Id: I774b4ba442e27935a676f2ce82356e8c77a0db27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024334
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e3ba0d7d

Fuchsia: Switch to gfx_tests sandbox configuration · 4a8fa19f

authored Jan 27, 2020

The default sandbox config for tests built in chromium doesn't allow
access to the GPU or display. Switch to the gfx_tests sandbox config
to allow the tests to run.

Bug: angleproject:4350
Change-Id: Ib80db196ef55df694369cfc7a3cf18327ce7c952
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023908
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4a8fa19f

Turn on clampArrayAccess globally but off for compute shaders · 571ceb5f

authored Jan 24, 2020

out-of-bounds-uniform-array-access.html could fail on Linux Nvidia
OpenGL even if GL_KHR_robust_buffer_access_behavior is available.
Turning clampArrayAccess on globally but turn it off for Compute Shader,
which is not used by WebGL so should be okay.

FYI: The failures when turning this on globally are all in compute shaders.
One could be fixed by using int cast instead of float for the clamp
modifier. The other is due to array.length() couldn't return correct
result for array in SSBO.

Bug: chromium:1042252
Change-Id: Ic6f7adae4600d35207646881b18990a0c25a889a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2020463
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

571ceb5f

D3D11: Fix uninitialized BufferEx SRV. · cc414d57

authored Jan 28, 2020

This was causing an unrelated error that was complicating diagnosing
test failures with the command graph refactor.

Bug: angleproject:4029
Change-Id: I31df76e7ea1c7fb731b49e97ac8a527a165efd48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024331Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cc414d57

Fix overlay build. · af5e3822

authored Jan 28, 2020

The overlay define was placed in the libANGLE target instead of in the
config. This was causing a compile error in the capture-enabled build.

Bug: None
Change-Id: I9df02faaf57683119ca49a9b44e41ff049b05556
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023479Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

af5e3822

Roll third_party/vulkan-headers/src 881bbb347a08..726435870206 (1 commits) · e3906550

authored Jan 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/881bbb347a08..726435870206

git log 881bbb347a08..726435870206 --date=short --first-parent --format='%ad %ae %s'
2020-01-21 oddhack@sonic.net Update for Vulkan-Docs 1.2.132

Created with:
  gclient setdep -r third_party/vulkan-headers/src@726435870206

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=tobine@google.com

Bug: None
Change-Id: Id4cb30292b4e2ac7f47d56eae2461acf1a1dbd91
Tbr: tobine@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2025050Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e3906550

Vulkan: SwiftShader now getting correct sample positions · a6dfa11f

authored Jan 28, 2020

This was fixed in SwiftShader and I verified it

Bug: angleproject:4213
Change-Id: I6f591b81a62ec4c586d4abb7e6a2345794602833
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2025066Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

a6dfa11f

Roll third_party/spirv-tools/src 1b3441036a8f..97f1d485b763 (1 commits) · ccfe9890

authored Jan 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b3441036a8f..97f1d485b763


Created with:
  gclient setdep -r third_party/spirv-tools/src@97f1d485b763

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com,syoussefi@google.com
Change-Id: I51395f4148ecce27c60eb6e2743a3e067cc23620
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2025056Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ccfe9890

Add a test to expose location'ed varying link bug · 7488a096

authored Jan 27, 2020

Bug: angleproject:4355
Change-Id: I2b914d3e6bf74ccf5d3f42d7bd010e44e45645ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023921Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

7488a096

Make run_code_generation fail if git cl format fails. · f144b77b

authored Jan 28, 2020

The lack of error code was hiding errors in the Skia auto-roller.

Bug: skia:9812
Change-Id: Ib43e5eb1749161e9fa0186bfd4a293dadaf82f8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024178Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f144b77b

Roll third_party/vulkan-loader/src 310fb8617946..44ac9b2f406f (2 commits) · 77f99a5a

authored Jan 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/310fb8617946..44ac9b2f406f

git log 310fb8617946..44ac9b2f406f --date=short --first-parent --format='%ad %ae %s'
2020-01-28 charles@lunarg.com Fix spelling mistakes
2020-01-27 lenny@lunarg.com loader: Update comments for shared aliases

Created with:
  gclient setdep -r third_party/vulkan-loader/src@44ac9b2f406f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I59345f736941fb7d09073b23eedb369ec928998f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024579Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

77f99a5a

Roll third_party/glslang/src b0ada80356ca..07a55839eed5 (6 commits) · 27389e6e

authored Jan 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b0ada80356ca..07a55839eed5


Created with:
  gclient setdep -r third_party/glslang/src@07a55839eed5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ib661a6253054f7afb03dd0efc331814bb6fd152f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024580Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

27389e6e

Roll third_party/vulkan-tools/src b181c1a7ddb5..e39b5cf6a1b6 (1 commits) · 49032645

authored Jan 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/b181c1a7ddb5..e39b5cf6a1b6

git log b181c1a7ddb5..e39b5cf6a1b6 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 charles@lunarg.com vulkaninfo: update readme, move vulkansdk.exe note

Created with:
  gclient setdep -r third_party/vulkan-tools/src@e39b5cf6a1b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ia9354d6ec422d61ea6d8c2b9d78969e7a5844015
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024322Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

49032645

Roll third_party/SwiftShader 748ad200897b..34e16df059f8 (6 commits) · 43c07019

authored Jan 28, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/748ad200897b..34e16df059f8

git log 748ad200897b..34e16df059f8 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 sugoi@google.com Revert "VK_EXT_shader_stencil_export support"
2020-01-27 sugoi@google.com Sample location fix
2020-01-27 capn@google.com Avoid ignoring unsuccessful routine creation
2020-01-27 capn@google.com Implement byte swizzle operations
2020-01-27 bclayton@google.com Docs: Add VulkanShaderDebugging.md
2020-01-27 sugoi@google.com VK_EXT_shader_stencil_export support

Created with:
  gclient setdep -r third_party/SwiftShader@34e16df059f8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I8b32f7b78a5d813b47059889cf869e31ba8e5bbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2024578Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

43c07019

27 Jan, 2020 9 commits

Return the correct location count for matrices in structs · 086aded3

authored Jan 26, 2020

GetLocationCount() returned secondary size for fields of a struct.  For
matrices however, the correct value would be the primary size.

This is a similar fix to 6423b7fc.

Bug: angleproject:4200
Change-Id: I2c69b9454729993010766fcde0cabec986b7429d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2021738Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

086aded3

Vulkan: Allow user to specify preferred device · d0b4eaf6

authored Jan 16, 2020

On a platform with multiple graphics devices (e.g. laptop with
integrated and descrete devices) it's handy to be able
to specify the specific device we want ANGLE to use.
Setting the environment variable ANGLE_PREFERRED_DEVICE to the device
name as returned by VkPhysicalDeviceProperties.deviceName will select
that device.

Bug: angleproject:4305
Change-Id: Ib16895add2c36a59135942b52401ceb7b6bc0895
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2002737
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d0b4eaf6

Fix atomicAdd validation w.r.t to swizzles · 2d1d9d35

authored Jan 27, 2020

Bug: angleproject:4150
Change-Id: I22c0c0382a2b208dd983fa1981ffc75f1b1945e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2022359Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2d1d9d35

Expose eglGetMscRateCHROMIUM from EGL_CHROMIUM_sync_control · 1a1a1427

authored Jan 23, 2020

When ANGLE is using the GL backend on GLX, we can expose
eglGetMscRateCHROMIUM via glXGetMscRateOML. Otherwise, this function
should return false.

Bug: chromium:1042393
Change-Id: Id9b308c2217e07ee9860e2869be0e23b7a0c7411
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2017048
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

1a1a1427

Vulkan: updateActiveImages: process each image once · a1f1cce6

authored Jan 27, 2020

There are two issues with processing the images multiple times:

- The graph trips up because on the first addWriteDependency, the
  current writer pointer of the image will be set to the recorder, and
  which on the next addWriteDependency creates a self-dependency.
- We transition the layout of the whole of the image, so doing that
  multiple times is inefficient.

Bug: angleproject:4312
Change-Id: Ibae72e8698edf5db97139f48d68624d3e9a1d5db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2022355Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

a1f1cce6

Roll third_party/vulkan-loader/src 37d3a235af2c..310fb8617946 (1 commits) · 60a3d848

authored Jan 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/37d3a235af2c..310fb8617946

git log 37d3a235af2c..310fb8617946 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 shannon@lunarg.com loader: Update copyright date to include 2020

Created with:
  gclient setdep -r third_party/vulkan-loader/src@310fb8617946

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Id295d999da84a9787906274b29a5cf2704f41d5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2022607Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

60a3d848

Roll third_party/spirv-tools/src b97057e7f747..1b3441036a8f (6 commits) · 78fdcee1

authored Jan 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b97057e7f747..1b3441036a8f


Created with:
  gclient setdep -r third_party/spirv-tools/src@1b3441036a8f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I74460814982034369877ec0f33a803c9d181a656
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2022605Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

78fdcee1

Roll third_party/SwiftShader 5ef91b82cbed..748ad200897b (6 commits) · 41a98380

authored Jan 27, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/5ef91b82cbed..748ad200897b

git log 5ef91b82cbed..748ad200897b --date=short --first-parent --format='%ad %ae %s'
2020-01-24 capn@google.com Don't override vkQueuePresentKHR() failure codes with VK_SUBOPTIMAL_KHR
2020-01-24 capn@google.com Discern between per-swapchain and vkQueuePresent command results
2020-01-24 amaiorano@google.com Subzero: replace globals with external memory for constant vectors
2020-01-24 amaiorano@google.com SubzeroReactor: implement missing atomic ops
2020-01-24 bclayton@google.com Regres: add cmd/run_testlist
2020-01-24 bclayton@google.com Regres: Restructure directories for main packages

Created with:
gclient setdep -r third_party/SwiftShader@748ad200897b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I413c92d71d802c0df2d06d416c93d0f313e8a51e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2022606Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

41a98380

Roll third_party/vulkan-tools/src 93ab50fc27de..b181c1a7ddb5 (4 commits) · 589b1875

authored Jan 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/93ab50fc27de..b181c1a7ddb5

git log 93ab50fc27de..b181c1a7ddb5 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 charles@lunarg.com vulkaninfo: use gpu version instead of instance
2020-01-24 shannon@lunarg.com vulkaninfo: Update copyright date to include 2020
2020-01-24 shannon@lunarg.com winRT: Update copyright date to include 2020
2020-01-24 charles@lunarg.com vulkaninfo: remove duplicate flags/bitmasks

Created with:
gclient setdep -r third_party/vulkan-tools/src@b181c1a7ddb5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I1e713740496a8749fc0b8c82b542ef16f2d12855
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2022604Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

589b1875

25 Jan, 2020 4 commits

For GGP builds, define __ggp__ manually. · fcef6dcb

authored Jan 24, 2020

Unlike other platforms' definitions, the GGP SDK expects the project files to
define this instead of having the compiler define it for us.

Bug: angleproject:4237
Change-Id: I8f10311fdff785a74c5e49fc53a512f1c050bff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2021010Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

fcef6dcb

Vulkan: Update active textures before setupDraw(). · 52ef28dc

authored Jan 24, 2020

The linear command graph prohibits rendering outside the render pass
*after* we begin a renderpass. The prior code would render outside a
render pass (changing image layouts) even after a RenderPass was
started in setupDraw(). The new code changes the image layouts in
ContextVk::syncState so we no longer need to "prepend" image layout
changes after we started a RenderPass. Now we record layout changes
followed by the draw calls or other renderpass ops.

Bug: angleproject:4029
Bug: angleproject:3539
Change-Id: I420858907ac38f995400c1b566c856d966a4e979
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2015940
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

52ef28dc

Implement EGL_IMG_context_priority · 564eb6f2

authored Nov 22, 2019

Change RendererVk to have 3 VkQueues instead of one.
Each queue has a priority. To match extension: Low, Med, High.
gl::Context contains priority.
ContextVk contains a reference to one of the queues.
Every call to vulkan that uses queue, uses the associated context queue.

Bug: angleproject:3962
Change-Id: Ibd913a07a81c77bd975921d6dbae6a222842e88b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978154
Commit-Queue: Jeff Vigil <j.vigil@samsung.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

564eb6f2

Tests: Add a perf test using traces · 080d711b

authored Jan 08, 2020

This test will load traces and cycle through a set of frames.

The new tests are:

    TracePerfTest.Run/gl_trex_200_210
    TracePerfTest.Run/gl_trex_800_810
    TracePerfTest.Run/gl_trex_900_910
    TracePerfTest.Run/gl_trex_1300_1310

To download the traces, you must be granted access and authenticate
with the cloud.  See the steps in RestrictedTraces.md for this.

Then add the following to the end of your .gclient file:

    "custom_vars": {
      "checkout_angle_internal":"True"
    },

And run `glcient runhooks`.

To enable building the test, add the following GN arg:

    build_angle_trace_perf_tests = true

See the new markdown document for ways to execute the tests.

Bug: angleproject:3630
Change-Id: Ic25cd94fb36b35fcf187e88d3bf9548c65f59755
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949605
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

080d711b

24 Jan, 2020 1 commit

Vulkan: Command graph linearization (Step 1). · 3712b2e4

authored Jan 24, 2020

This initial prototype introduces a new feature to the Vulkan back-end
that disables the deferred command recording. The intent is to have a
lower CPU overhead during submission calls which currently walk a DAG.

The feature is not complete. Currently it only passes the ANGLE
SimpleOperationTests. Moreover it is extremely simple and only allows
use of one command buffer at a time. In the future we'll allow open
command buffers for recording outside and inside render pass commands
at the same time. We'll also support collapsing RenderPasses together
for some use cases.

Currently the prototype only passes "SimpleOperationTest". There are
quite a few unimplemented features like queries, XFB, etc.

Bug: angleproject:4029
Change-Id: I82760986683f55e37ac4ea559de6f4cffb6ef84e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953485
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

3712b2e4