Suspect possible NVIDIA driver issue as unable to repro on some NVIDIA,
Windows, NVIDIA configurations.

Test:
    angle_end2end_tests --gtest_filter=GLSLTest.NestedPowStatements/ES3_Vulkan

Bug: chromium:1127866
Change-Id: Ic6a95915af72aab086753a0e0199ac1dee8bfb62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410560Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The parameter linkedShaderStages is passed to
GlslangGetShaderSpirvCode(), but is unused. This CL uses the parameter,
rather than gl::AllShaderTypes().

This CL also removes the unused parameter variableInfoMap from the call
chain.

Bug: angleproject:3570
Change-Id: Ic60084e87cb2aa2a245e3e963598851331379e89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412364
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This config is unfortunately not covered on the ANGLE CQ.

Test: local GN CrOS build
Bug: angleproject:3943
Bug: chromium:1129075
Change-Id: Ie1a9b2fdfb47f2a4631e118ab88eccfb7ad7eaf8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415186Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When a descriptor pool is created, a list of descriptor types and counts
are given to vkCreateDescriptorPool(). Later, when allocating a
descriptor set from the pool, we pass along a descriptor set layout to
vkAllocateDescriptorSets() which is used to determine how many of each
type of descriptor (i.e. binding) to allocate from the pool.

In order for our "free descriptor set" counts to be accurate for each
pool, the descriptor pools need to be created with descriptor counts
that match the descriptor set layout binding counts.

This change fixes a bug where the descriptor set layouts were created
with more bindings than the descriptor pool sizes, causing the "free
descriptor set" count to be inaccurate, leading to allocating too many
descriptor sets from a pool.

Bug: angleproject:3570
Test: VulkanDescriptorSetTest
Change-Id: I660bf02d29a1291391fb15f39e6479bf348d0f83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391114
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

When the standalone tests shut down they would not wait for
the watchdog thread to exit cleanly. Fix this by setting a
flag that shuts down the watchdog and attempting to wait.

This was detected by running angle_end2end_tests with TSAN.

Bug: angleproject:3162
Bug: b/168744561
Change-Id: I765ce7a21c3be11703619470a81adb1882b009e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415175
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Required an upstream fix:
https://github.com/KhronosGroup/Vulkan-Tools/pull/437

Also a workaround filed as an issue:
https://github.com/KhronosGroup/Vulkan-Tools/issues/445

Bug: angleproject:4950
Change-Id: I21333464d2a8e52d5d85d35654f0e6372f9650db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358517Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This was causing a build break on ChromeOS builers and brekaing the
ANGLE roll into Chromium.

Bug: chromium:1129075
Bug: angleproject:3943
Change-Id: Ic7976c0b506f5af67823da8de1f8c850e43abee0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415169Reviewed-by: Jamie Madill <jmadill@chromium.org>

The location index of a vertex shader input's layout qualifier must be
less than GL_MAX_VERTEX_ATTRIBS to link successfully. We can check for
this during shader compilation to not rely on other layers to handle
pathological cases.

While strictly speaking only 'active' attributes are considered during
shader linking, this is merely intended to allow for 'uber' shaders to
declare more inputs than GL_MAX_VERTEX_ATTRIBS but only use a subset of
them. There is no known reasonable use case for a manually specified
location to exceed the valid range.

Note that according to http://opengl.gpuinfo.org, the highest
GL_MAX_VERTEX_ATTRIBS value at the time of writing is 32. Also,
D3D12_VS_INPUT_REGISTER_COUNT = 32. Hence the unit test's value of 1000
should be sufficiently future proof.

Also address the case where the uniform location might be close to
INT_MAX and not be detected as out-of-range due to numeric overflow.

Bug: chromium:1110800
Change-Id: I9985c8eab3bb8a2a59b8f985e8f5b6884756383c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405368Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Nicolas Capens <capn@chromium.org>

These were messing up the test runner when used in combination
with the test runner's specific args.

Make it an error if the arguments are used together.

Bug: angleproject:3162
Change-Id: I6fa1c0fb346a8c376ca455f7f4bf0492cfc0198a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414931Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

For consistency with the rest of the backend.  Level index variables
were using the VK suffix while color index variables used Vk.

Bug: angleproject:4881
Change-Id: I0c2799da34cdfe19cb04adbebba042ac8876af96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413155
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

This moves the bit mask of attached color buffer to front end. No
function change is expected.

Bug: b/167301719
Change-Id: I4eec3a419560b91875260b812a036ceaaeb6b5bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410790Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

This matches the types used by GL and stored in the state.  setStorage
and setStorageMultisampled calls were using size_t instead with a number
of unnecessary casts in places which are now removed.

Bug: angleproject:4836
Change-Id: Ibb570f0c088a6f29abe10f513de27c30ba4dd098
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411697Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Just showing the line and function isn't as useful.

Bug: angleproject:3162
Change-Id: Ic8c2425a7a7e9992d2a569abd8ea0b7731fa69c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407834
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Test: angle_end2end_tests
Bug: angleproject:5053
Change-Id: I7aef6b5babe8f582e7500464f53e65721eaf0520
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414733Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

These tests fail on the Windows NVIDIA bots

Bug: angleproject:5044
Bug: chromium:1128064
Change-Id: Idad4cc33d8e49b0b468b8e560b44f9a9c6a2f37f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414932Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Bug: angleproject:3943
Change-Id: I88c2ec8a9f49746f6ce9838b0d1c8e8ea0a8ae9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405806
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Enable BlendIntegerTest
Add DrawBuffersTest.BlendWithGaps test
Add BlendPackedTest

Bug: angleproject:4548
Bug: angleproject:4571
Bug: angleproject:4583
Change-Id: I139183099b26f0fe1ac9e43f96d18b8ccb134a2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407772
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e59713d4edda..f105898a102f

2020-09-15 s.fricke@samsung.com layers: label VUID 04151 and 04152
2020-09-15 s.fricke@samsung.com layers: label VUID 04441
2020-09-15 tony@lunarg.com gpu: Handle KHR version of CmdDispatchBase
2020-09-14 s.fricke@samsung.com layers: Improve WSI related error messages
2020-09-14 s.fricke@samsung.com layers: label VUID 04448
2020-09-14 jzulauf@lunarg.com syncval: DRY/clean MakeRange computation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I13d028a7007a98f5db0fd4f78b32f8c0aa5c5843
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413555Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/726af6f78f80..e8ce4355ae1c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I9b2f0c42cb0a6bf162fc99dd72e91498c002a1bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413556Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/dc552fcef1fe..b33e0b36a08c

2020-09-15 natsu@google.com Support Gralloc4 in SwiftShader
2020-09-15 swiftshader.regress@gmail.com Regres: Update test lists @ dc552fce
2020-09-14 amaiorano@google.com CMake: normalize FOLDER property for third_party targets
2020-09-14 bclayton@google.com SpirvShaderDebugger: Add PRINT_EACH_DEFINED_DBG_INSTRUCTION
2020-09-14 bclayton@google.com SpirvShaderDebugger: Implement DebugValue
2020-09-14 bclayton@google.com SpirvShaderDebugger: Reduce lock contention

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I460dfa92d1606e2877a47b293a009a17d09b32dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413557Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/1960f3b23408..e4cbd27e4a55

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc90e7d103..42cbd32cfb
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a90362b4fc..3ff4f5027b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/598b9bd5a4..1d2f486547
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9967a97317..e73d966652
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bf815f1a74..e075ddd622
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8d1fa6cbe8..552c4cfa71
No update to Clang.

Bug: angleproject:3162
Tbr: jmadill@google.com
Change-Id: I0391f5aa9f047264315f7f7da056bef0f1eeeaef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413478Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

These tables are used by both the GL and D3D11 back-ends. Also moves
them to renderer_utils to be in a shared place.

Bug: angleproject:3943
Change-Id: I1f5d79842396a87e795547fa03c6855d6f9c5e9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405805
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The input types are string, not integer.

Bug: angleproject:3162
Change-Id: Ib4cac4cc0d4556d607e10fd9b79e36dbed68a39d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411340Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This was breaking the Skia roller.

Bug: angleproject:3943
Change-Id: I5b54feb2e4abc8a6bf157e35f69aa12c7334dda2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411474Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Can be useful when doing captures to make the replay more portable.

Bug: angleproject:5040
Change-Id: I3a045c636bc2638d601aff2536eed3d0e49c3643
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408714
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f8a5602c5560..9eaa69c21c45

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Ie7f53efaf59bac3060ce54bb413682b91871b7f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411963Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

The current roll_aosp.sh is generating an invalid Android.bp by
including the local repo's .git file:

cc_genrule {
    name: "angle_commit_id",
    tool_files: [
        "src/commit_id.py",
    ],
    cmd: "$(location) gen $(location commit.h)",
    srcs: [
        ".git/refs/heads/rollAngle",
    ],
    sdk_version: "28",
    out: [
        "commit.h",
    ],
}

This is fixed by enabling the GN arg 'angle_enable_commit_id=false' in
the script:

cc_genrule {
    name: "angle_commit_id",
    tool_files: [
        "src/commit_id.py",
    ],
    cmd: "$(location) gen $(location commit.h)",
    sdk_version: "28",
    out: [
        "commit.h",
    ],
}

Bug: angleproject:5050
Test: Manual verification in AOSP checkout
Change-Id: I08a08084c4c25411b29b22544c2ed8c06f6f54d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412790Reviewed-by: Geoff Lang <geofflang@chromium.org>

Implement supporting the array of array of image
type in uniform. Add a new end2end test for it.

Bug: angleproject:3881
Change-Id: Idd757ae1d0ed34d585ae1ca5e0b6577459a0acb7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2379335
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

glRenderbufferStorageMultisampleEXT has different semantics from
glRenderbufferStorageMultisample.  This change makes this
differentiation in the front-end and passes a flag to the backends.
This extension is currently only supported on Vulkan and D3D backends.
Support for the former will be done in a follow up.  Support for the
latter is not planned.

Bug: angleproject:4836
Change-Id: I75bc3d7990a4b1ce06264280a386d5e467983b7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405396
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ANGLE packs FBO attachments from OpenGL and uses packed attachments to
create VkFramebuffer and renderpass. When we use attachment index into
the attachment array, we must be very careful to use packed index for
vulkan objects. It is easy to make mistakes here and introduce hard to
debug bugs. This CL defines a PackedAttachmentIndex class that uses that
to index into vulkan attachments and pass around APIs so that compiler
would catch the error when wrong index is used. This also introduces
PackedClearValuesArray that stores clear value in packed attachment
index so that it is impossible to mix it with ClearValuesArray that
stores clear value in GL attachment index.

Bug: b/167301719
Change-Id: I68680522c60beeb5096e5211eaef89da28c7097e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410366
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This will allow us to speed up test execution by using multiple
processes on non-Windows platforms. Because of the process isolation
of "bot mode" we don't run into display re-use bugs like we do when
running in a single process.

Bug: angleproject:3162
Change-Id: I25370d4a07236e34f87e1c1efef8684f9891ecf8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407835Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Manhattan is calling glFlush in middle of a renderpass. This CL defers
the flush that issued in the middle of renderpass to the end of
renderpass.

Bug: b/166475273
Change-Id: I6baa3898d5efc456e2205c44e13c64f3d79d1464
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381942
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Also has a few other tweaks to test spin-up.

Bug: angleproject:3162
Change-Id: I8753f1afedbcc5c4b5ae257965ce68dc4a02ae06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407836
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This moves more build configuration out of libGLESv2.gni.

Bug: angleproject:3943
Change-Id: I58293f98c917e785cdf3bb1beb706f02ee8a3801
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405800Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

These tools are used by scripts/trigger.py and by the src-side testing.
Also adds .vpython and .vpython3 spec files which can't be easily
auto-rolled from the Chromium src/ repo.

Bug: angleproject:5040
Change-Id: Ie6384c176b391dae4fe19582ec59c2c1d6ec22d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408717
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

ANGLE needs to set the attribute forceQueryable="true" to the
AndroidManifest.xml to allow the Android framework to find the ANGLE
package.

Bug: angleproject:5035
Test: Manual verification
Change-Id: I5ac1c18a584b72d3384978592065853f0a9456de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2406131Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

Bug: angleproject:5040
Change-Id: I64f762b4eb5734f0768054a330a36e20ff9ba93e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408713
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

When draw buffers set to GL_NONE, instead of remove the attachment from
renderpass which breaks renderpass, we force vulkan's per buffer color
mask to false while keep the disabled draw buffer attached. This CL also
always create FrameBuffer with all color attachments regardless it is
enabled or not.

Bug: b/167301719
Change-Id: Ice9fca9aacf774a47d13b749f822b222cc050174
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389007Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

glRenderbufferStorageMultisampleEXT is special in that it doesn't have
the same semantics as glRenderbufferStorageMultisample, but is aliased
in gl.xml for the sake of desktop GL (where it does have the same
semantics).  This change special-cases this function so
multisampled-render-to-texture renderbuffers can be supported.

Bug: angleproject:4881
Change-Id: Iaa321dd0671dd82ea802df22a1ae935942789c21
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405395Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:2634
Change-Id: I36e5a6a4cb11d82f666c410b33fdb39ad35a5e80
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336557Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>