Commits · 0ee5eb6dbf1b450b8afc0653da4b71f4ef922dcd · Chen Yisong / angle

26 Mar, 2020 3 commits

Roll third_party/SwiftShader 540bdf92531d..77090261dabc (10 commits) · 0ee5eb6d

authored Mar 26, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/540bdf92531d..77090261dabc

git log 540bdf92531d..77090261dabc --date=short --first-parent --format='%ad %ae %s'
2020-03-25 capn@google.com Identify image views based on their state
2020-03-25 capn@google.com Provide packed VkFormat to uint8_t mapping
2020-03-25 capn@google.com Uniquely identify sampler state
2020-03-25 capn@google.com Split vk::Sampler state off into a structure
2020-03-25 capn@google.com Fix handling Memset<> assignment and comparison
2020-03-25 bclayton@google.com Add script for updating llvm 10
2020-03-25 amaiorano@google.com regres: add daily run against SwiftShader/Subzero
2020-03-25 bclayton@google.com CMake: Don't export LLVM_INCLUDE_DIR to PARENT_SCOPE
2020-03-25 bclayton@google.com CMake: Move LLVM rules out to third_party/llvm-7.0
2020-03-25 bclayton@google.com Add missing copyright header to CMakeLists.txt

Created with:
gclient setdep -r third_party/SwiftShader@77090261dabc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie880cfbad88061a571bedcf2b41a2876275fdd81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119882Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0ee5eb6d

Roll third_party/spirv-tools/src 1346dd5de119..fd773eb50d62 (4 commits) · 7a58e5b7

authored Mar 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1346dd5de119..fd773eb50d62


Created with:
  gclient setdep -r third_party/spirv-tools/src@fd773eb50d62

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6349d641ed962bb159f0659054055896eaa3b9c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119883Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7a58e5b7

Update Vulkan header and related repos · 6719f54a

authored Mar 24, 2020

Vulkan header was updated with non-backward compatible change so need
to update all dependencies simultaneously.

Bug: b:152298150
Bug: angleproject:4510
Change-Id: I46ac9a3a0ccb52184fd183df617804c866b63453
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118151Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

6719f54a

25 Mar, 2020 6 commits

Capture/Replay: Update CaptureReplay sample for compression · b69c4e14

authored Mar 24, 2020

* Move DecompressBinaryData to a shared helper
* Start using it in CaptureReplay sample
* Error out if decompress callback isn't set correctly

Test: AngryBirds and CandyCrush captures replay on desktop
Test: angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4484
Change-Id: I0432004fdb0cfb0fd61f9a66f792591c9aa40d9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118790
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b69c4e14

Perf: Add a single Manhattan trace · 78c77361

authored Mar 20, 2020

Now that TRex is up and working and Manhattan runs cleanly:
* Add a single compressed Manhattan trace.
* Allow errors from tests to fail the test
* Restore the working directory between each trace test

Test: angle_perftest --gtest_filter=TracePerfTest*
Bug: b:151349786
Bug: angleproject:3630
Bug: angleproject:4496
Change-Id: I9e9d9342efb23431380f484befb9a19915c4bd0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113230
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

78c77361

Re-enable angle_end2end_tests on 32-bit Windows SwiftShader · a7510f06

authored Mar 04, 2020

In order to add angle_end2end_tests on Win 32-bit SwANGLE bots.

Bug: angleproject:4421, angleproject:4092
Change-Id: I6923ca461492469f05503aebf2256763ea7061aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2088654Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

a7510f06

No-op draw calls with rendering feedback loops. · c77cb596

authored Mar 24, 2020

This is quite within spec and protects our various back-ends from FB
loops. Also makes the check more cached for optimization purposes.

Bug: angleproject:4490
Change-Id: Ia82ec88244d07670d68ce53495b5893b8a75ac42
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118153
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

c77cb596

Roll third_party/SwiftShader 6c11cf2ad9ca..540bdf92531d (2 commits) · 38152bda

authored Mar 25, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/6c11cf2ad9ca..540bdf92531d

git log 6c11cf2ad9ca..540bdf92531d --date=short --first-parent --format='%ad %ae %s'
2020-03-24 bclayton@google.com Regres: Add new run_testlist flags
2020-03-24 bclayton@google.com Merge changes I9862d8e2,Ie1024655

Created with:
  gclient setdep -r third_party/SwiftShader@540bdf92531d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I9c4fb01c33c816001c65959bf14c33c09d1e3070
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119920Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

38152bda

Lift SwANGLE dEQP-GLES3.functional.fbo.blit.conversion.* suppression · 107e4e98

authored Mar 24, 2020

Fixed by
https://swiftshader-review.googlesource.com/c/SwiftShader/+/42548/

Bug: angleproject:4416
Change-Id: I703608d7d3fa15f2428a832896a68893efbb35ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119234Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

107e4e98

24 Mar, 2020 6 commits

Vulkan: Fix crashes/failures in array-of-struct uniforms · d0800d29

authored Mar 24, 2020

When array-of-struct support was added to ANGLE, it was not added to
the shader cache serialize/deserialize functions.

This affects many GLES 2/3/3.1 dEQP tests, such as:

  dEQP-GLES2.functional.uniform_api.value.assigned.by_value.render.struct_in_array.sampler2D_samplerCube_vertex

Bug: angleproject:4475
Bug: b:151387995
Change-Id: I159f6340db255ec50c16b59fec23a61ed05aa8f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118152
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d0800d29

Speculative fix for assertion failure with samplers. · b91d2630

authored Mar 24, 2020

This was crashing for example here:

https://chromium-swarm.appspot.com/task?id=4b174a9710848410
https://chromium-swarm.appspot.com/task?id=4b214baec2ee7e10

With this stack:

libglesv2!gl::TextureState::isBoundAsSamplerTexture
libglesv2!gl::Texture::onUnbindAsSamplerTexture
libglesv2!gl::State::unsetActiveTexture+0x9
libglesv2!gl::State::updateActiveTextureState+0x2d2
libglesv2!gl::State::updateActiveTexture+0x3aa
libglesv2!gl::State::setSamplerTexture+0x4a1
libglesv2!gl::Context::bindTexture+0x1ab
libglesv2!gl::BindTexture+0x99
chrome!GrGLFunction+0x1f
chrome!GrGLGpu::bindTexture+0x1a0
chrome!GrGLProgram::bindTextures+0x1b9
chrome!GrGLOpsRenderPass::onBindTextures+0x50
chrome!GrOpsRenderPass::bindTextures+0x106
chrome!GrOpFlushState::bindTextures+0xf
chrome!`anonymous namespace'::FillRectOp::onExecute+0xd3

It's unclear how we could end up with a Texture bound that doesn't go
through the normal setter functions. I did see a potential hole where
textures might not get an unbind call when a Context is torn down. This
could lead to bugs in multi-context situations.

This protects the set/unset functions in a helper class to ensure we
always call onBind/onUnbind and forces the destructor to call unbind.

Bug: angleproject:4490
Change-Id: Ied64e02bbe3a37efcab6cbdd4bf2d1b6dcb8b3ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118254
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

b91d2630

Fix robust resource initialization with clipped CopyTexSubImage2D. · e39d055d

authored Mar 23, 2020

When CopyTexSubImage2D calls were clipped against the bounds of the
read framebuffer by the underlying renderer backends, the robust
resource initialization code assumed that the original destination
area would be overwritten by the renderer, which was not the case.

Add new tests which were previously failing on macOS with the
ES2_OpenGL and ES3_OpenGL backends. The Metal backend is still failing
and a follow-on bug has been filed.

Bug: angleproject:4504
Change-Id: I34821dd90597f31b3cbf0921b94756556e485c91
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2116873Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

e39d055d

Supress test failing with new Intel driver. · ed0e932c

authored Mar 23, 2020

EGLDirectCompositionTest.RenderSolidColor/ES2_D3D11_NoFixture failing
with the 26.20.100.7870 driver.

Bug: chromium:1063962
Change-Id: I48ef5915c67e05cc86a568c28115dae26dc78db2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2116871
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ed0e932c

Roll third_party/spirv-tools/src 60104cd97446..1346dd5de119 (4 commits) · 954f3d83

authored Mar 24, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/60104cd97446..1346dd5de119


Created with:
  gclient setdep -r third_party/spirv-tools/src@1346dd5de119

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ic133e60c657d4f9b2eaf8f28dfa26a3527bffe37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2117477Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

954f3d83

Roll third_party/SwiftShader 22d73d15e778..6c11cf2ad9ca (5 commits) · 20983e35

authored Mar 24, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/22d73d15e778..6c11cf2ad9ca

git log 22d73d15e778..6c11cf2ad9ca --date=short --first-parent --format='%ad %ae %s'
2020-03-24 capn@google.com Remove unused sampler parameter
2020-03-24 capn@google.com Specialize sampling routine for immutable sampler data
2020-03-23 amaiorano@google.com CMake: make SWIFTSHADER_DCHECK_ALWAYS_ON work on Windows
2020-03-23 chrisforbes@google.com Refactor vertex fetch to use VkFormat more aggressively
2020-03-23 bclayton@google.com Merge changes I2b7adc3c,I5873dfa8

Created with:
gclient setdep -r third_party/SwiftShader@6c11cf2ad9ca

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I301e41b5044c90f43228d8b01fb6d26ae249fee6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2117476Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

20983e35

23 Mar, 2020 3 commits

Vulkan: No-op redundant FB state changes. · 6fead375

authored Mar 21, 2020

This uses a trick by comparing the prior to the updated FB description
to filter out rendundant changes. Will allow the front-end syncState to
sometimes noisily report state changes when there aren't any in the
back-end. Ideally we wouldn't generate any updates when there aren't
real changes. However because Manhattan often transitons between a few
zero states it gets a bit difficult to determine in the front-end.

Also adds a no-op for redundant samples changes in the front-end.

Fixes a regression in the number of RenderPasses in Manhattan from work
to support rendering feedback loops.

Bug: angleproject:4490
Change-Id: Ibf83d584107a4561da7ad47a2d3fb543e63e31f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112935Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6fead375

Reland "Refactor BitCount" · 31e36a63

authored Mar 14, 2020

This is a reland of baecb7d5

Directly use NEON instructions on ARM/ARM64 on MSVC.

Original change's description:
> Refactor BitCount
>
> POPCNT intrinsics cannot be used without hardware support, so a CPUID
> check and polyfills are required for some CPUs when using MSVC to
> avoid runtime failure.
>
> Other changes include:
> - Clang: use builtins on all platforms to provide exact intent to the
> compiler;
> - MSVC on ARM: use dedicated intrinsics;
> - x86/x64 fallback is now branchless and works in constant time.
>
> Bug: angleproject:4462
> Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:4462
Change-Id: Ia58ae00fa4230f77d981d4ba393fa3481806c5b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113570Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

31e36a63

Roll third_party/SwiftShader 1c9f24263e6c..22d73d15e778 (1 commits) · 4c7460ac

authored Mar 23, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/1c9f24263e6c..22d73d15e778

git log 1c9f24263e6c..22d73d15e778 --date=short --first-parent --format='%ad %ae %s'
2020-03-20 amaiorano@google.com Subzero: fix CoroutineBegin generation

Created with:
  gclient setdep -r third_party/SwiftShader@22d73d15e778

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4482
Tbr: courtneygo@google.com
Change-Id: I0336b02843d138a16749a5ad76dd44e666b66e83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2114840Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4c7460ac

21 Mar, 2020 1 commit

Remove 32-bit Subzero GLES31 SwANGLE suppressions · cb7e7387

authored Mar 20, 2020

Remaining Windows crashes fixed by
https://swiftshader-review.googlesource.com/c/SwiftShader/+/42608

Bug: angleproject:4482
Change-Id: If1d6b6c4bd172c36108d31e01f561e001f49683f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113716Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

cb7e7387

20 Mar, 2020 20 commits

Skip flaky SwANGLE end2end tests. · 6b462120

authored Mar 20, 2020

AttributeLayoutNonIndexed.Test
AttributeLayoutBufferIndexed.Test
EGLSurfaceTest.ResizeWindowWithDraw

Bug: angleproject:4453, angleproject:4502
Change-Id: I6dbd333e428d61d84bb17bf0c4112fa66cff9846
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113711Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

6b462120

Skip ExternalWrapTest on Ozone. · c0b267cc

authored Mar 20, 2020

Ozone only supports external target for images created with
EGL_EXT_image_dma_buf_import.

BUG=angleproject:4443
BUG=chromium:1063462

Change-Id: Ia62fdd92198bdcc2d9840765305b4cc613fd3f7c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113450Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

c0b267cc

Vulkan: Implement EXT_shader_non_constant_global_initializers · ca2b6e1f

authored Mar 19, 2020

Enables the translator to handle non-constant global initializers in
all essl versions iff the shader enables the extension to do so.

Bug: angleproject:4468
Test: angle_end2end_tests --gtest_filter=ShaderNonConstGlobalInitializerTest.*
Change-Id: I8f138c12fc83d2f38ff8f45ca9133222b01e4087
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102959Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

ca2b6e1f

Implement gl[Get]MemoryObjectParameterivEXT · 13ea5b7f

authored Mar 19, 2020

These functions are required to tell the driver that the memory object
is dedicated memory. This is required for AMD drivers on Linux.

Bug: chromium:1049218
Change-Id: I17d69cde5e6308791dc90784f4d6e348503a6ed6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2110051Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

13ea5b7f

Update conditions for exposing ASTC extensions. · dd4e09ef

authored Mar 20, 2020

Add commenents to explain the Vulkan ASTC situation.

Expose GL_KHR_texture_compression_astc_sliced_3d when the HDR profile
exists.

Bug: angleproject:4447
Change-Id: I00a86cb3c44873a28397aab33a47fb363d4ecfe9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112283Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

dd4e09ef

Remove GL_CHROMIUM_path_rendering · 07467b4a

authored Mar 20, 2020

Bug: chromium:1063193
Bug: angleproject:4270
Change-Id: I35b24b7d8d892181955e49dd2495655bc57cb0df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112275Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

07467b4a

Android.bp: Ignore unknown warning flags. · 95a4ded5

authored Mar 20, 2020

Clang and Chrome build with different versions of clang which support
different warning flags.  Ignore unknown warning flags when building in
Android.

Bug: b:142320172
Change-Id: I35eb424aa5a146fec7dabf9f3aa71bd6dd9d8f50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112282Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

95a4ded5

ASTC: LDR support doesn't imply HDR support · 91f44a9a

authored Mar 20, 2020

There are SwiftShader related failures related to enabling the
textureCompressionASTCHDRKHR feature without properly checking if the
VK_EXT_texture_compression_astc_hdr extension is available, so HDR support
shouldn't be enabled only based on the LDR support being enabled.

Bug: angleproject:4447
Change-Id: Icde34892c9e2efff4b71e8c4e960c2fcff786700
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080594
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

91f44a9a

Suppress two -Wunreachable-code warnings on Fuchsia in Angle. · cd6028de

authored Mar 20, 2020

Bug: chromium:346399
Change-Id: Ibf9cefdee52e487d9e73b9dff98a12267ac82af6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112281
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cd6028de

Vulkan: Fix Framebuffer cache depth/stencil issue. · 4fb3c28f

authored Mar 19, 2020

The DrawBuffers resetting logic didn't update the depth/stencil serial.
Fix this and add a regression test that would crash in this situation.
Note that the Manhattan benchmark could trigger this under some cases.

Bug: angleproject:4322
Bug: angleproject:4490
Change-Id: Ie4b24efeb5991ecaa85bf8f964f77476bd6f167d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111333
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

4fb3c28f

Add optimized rendering feedback loop tracking. · 1c88cf27

authored Mar 18, 2020

This can be used both for WebGL and the Vulkan back-end workaround for
Manhattan. Uses the recently added tracking for Textures being bound as
samplers. Then caches this information in the Framebuffer using the
Subject/Observer pattern.

Bug: angleproject:4490
Change-Id: I08bef0a1b95c4333da19c2dae1f02a993e5835e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109335
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

1c88cf27

Perf: Limit TracePerfTest to single compressed TRex · a4337121

authored Mar 19, 2020

Update the TRex trace to:
* Incorporate recent fixes for compressed textures
* Incorporate support for compressing the trace
* Simplify the tag on the trace (drop the end frame)

Update TracePerfTest to:
* Temporarily support only a single trace (TRex200).

Test: angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4484
Bug: angleproject:4488
Bug: angleproject:4496
Change-Id: Ice0c4ee9de3ad9ae4596305a93c51c6eac842123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112629
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a4337121

Add support for EXT_EGL_image_external_wrap_modes · 62b72552

authored Mar 20, 2020

Allows for more wrap modes to TEXTURE_EXTERNAL_OES textures

Test: angle_end2end_tests --gtest_filter=ExternalWrapTest.*
Bug: angleproject:4443
Change-Id: I37bde091b166d7471c13c14fd6b0174136b52ecf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103433
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

62b72552

Remove util.gni. · 32c1bf54

authored Mar 19, 2020

This file was no longer referenced and is dead code.

Bug: None
Change-Id: Id4469b9575a14e31c6f715c2d290f2f8945cd25b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2110331Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

32c1bf54

Revert "Refactor BitCount" · 26f8f1a9

authored Mar 20, 2020

This reverts commit baecb7d5.

Reason for revert: Broke Skia Win/ARM builder. See issue for details.

Original change's description:
> Refactor BitCount
> 
> POPCNT intrinsics cannot be used without hardware support, so a CPUID
> check and polyfills are required for some CPUs when using MSVC to
> avoid runtime failure.
> 
> Other changes include:
> - Clang: use builtins on all platforms to provide exact intent to the
> compiler;
> - MSVC on ARM: use dedicated intrinsics;
> - x86/x64 fallback is now branchless and works in constant time.
> 
> Bug: angleproject:4462
> Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,lexa.knyazev@gmail.com

Change-Id: Ia1756abdf7da2aa9574149eb388915f97758bba0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4462
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112276Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

26f8f1a9

Skip updating viewport and scissor info if the same · 2709f40f

authored Mar 17, 2020

If glViewport() or glScissor() is called with same
info, skip updating viewport or scissor info and
related dirty bits.

Bug: angleproject:4487
Change-Id: I9a0f3eb0df789beb99447ebc98383f502fbc763d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105528
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2709f40f

Roll third_party/spirv-tools/src 18d3896a15fc..60104cd97446 (2 commits) · 12a1c373

authored Mar 20, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/18d3896a15fc..60104cd97446


Created with:
  gclient setdep -r third_party/spirv-tools/src@60104cd97446

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I3dcd66069fea3caf8aca5e10bc0dad5eb9d661dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111884Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

12a1c373

Roll third_party/SwiftShader bc98fbeec99b..1c9f24263e6c (2 commits) · 92941f2c

authored Mar 20, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/bc98fbeec99b..1c9f24263e6c

git log bc98fbeec99b..1c9f24263e6c --date=short --first-parent --format='%ad %ae %s'
2020-03-19 sugoi@google.com Fix float to r11g11b10 conversion
2020-03-19 amaiorano@google.com marl: manually apply partial patch to fix x86 crashes

Created with:
  gclient setdep -r third_party/SwiftShader@1c9f24263e6c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4482
Tbr: courtneygo@google.com
Change-Id: I6c49a595ffe084fbf6d80f57638011c96384384e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111883Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

92941f2c

Skip SwANGLE GLES31 tests which crash with 32-bit Subzero only on Windows · 0e069b42

authored Mar 19, 2020

Linux 32-bit crashes were fixed.

Bug: angleproject:4482
Change-Id: I3efd7c760dfec1f8b909eee2ed84f5f9ebc33c3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111970Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

0e069b42

Skip flaky TransformFeedbackTest.MultiContext on Win Intel Vulkan · ca45852d

authored Mar 19, 2020

Bug: angleproject:4497
Change-Id: I92e7ad9f0c34fe0b5f67318271ececc218c20757
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111781Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

ca45852d

19 Mar, 2020 1 commit

Track if a Texture is bound as a sampler. · b1eb44bf

authored Mar 18, 2020

This will more easily allow us to detect rendering feedback loops.
We'll need to support feedback loops to enable Manhattan.

Bug: angleproject:4490
Change-Id: I442deebd89dcf0139411688eaa204c5e5b2c2799
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109334
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

b1eb44bf