Commits · 0faa4a3d2e56ba0965af3bd39f220752ecd7196d · Chen Yisong / angle

06 Oct, 2020 17 commits

authored Sep 19, 2020

Bug: angleproject:5071
Bug: angleproject:5125
Bug: angleproject:5126
Change-Id: I58539ae721efa6bcaff04c52cb8137b303d3db1e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418716Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

0faa4a3d

Rename ui/ozone/ozone.gni to build/config/ozone.gni · 82683093

authored Oct 02, 2020

This CL depends on:
https://chromium-review.googlesource.com/c/chromium/src/+/2427423

Bug: chromium:1129223
Change-Id: I16d845772d13541153ee4775dbe6ba75f8485d7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447030
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

82683093

Roll SPIRV-Tools from f15133788010 to 63cc22d645ba (4 revisions) · deb785d9

authored Oct 06, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f15133788010..63cc22d645ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: If0844b308e147e473744d36aacb45859a3d0ecaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451650Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

deb785d9

Roll Vulkan-ValidationLayers from b588cd4df419 to c7d7610581df (4 revisions) · 3453f745

authored Oct 06, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b588cd4df419..c7d7610581df

2020-10-05 coki04@gmail.com tracker: Retire work when checking Timeline Semaphore Value
2020-10-05 btolsch@gmail.com layers: Reorder conditions to avoid uninitialized values
2020-10-05 bethau@microsoft.com layers: Fix false positives when importing AHardwareBuffers
2020-10-05 btolsch@gmail.com layers: Fix validation object leaks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Idecbb504caea21663eb64372b90a8fec89f227ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2452220Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3453f745

Roll SwiftShader from b3c1e71eb1cb to afe6ca45b6da (4 revisions) · 12be895d

authored Oct 06, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/b3c1e71eb1cb..afe6ca45b6da

2020-10-05 bclayton@google.com Merge changes I48e99f11,I1a914ff6
2020-10-05 capn@google.com Regres: limit the number of GL tests opening X connections
2020-10-05 bclayton@google.com CMake: Add flag for controlling the logging level
2020-10-05 bclayton@google.com third_party/cppdap: Roll forward to 1fd23dda

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Id48e7906ac1d6c9711082bdf0c11aa2e557587e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2452219Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

12be895d

Roll Vulkan-Loader from 7c07085ad1cc to 3610ce9fa2d8 (1 revision) · e4eb9c05

authored Oct 06, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/7c07085ad1cc..3610ce9fa2d8

2020-10-06 lenny@lunarg.com docs: Remove outdated references to WDK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I149bc8870af2c455647114fc4932f700d0911e03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451950Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e4eb9c05

Roll Chromium from 78d150eb2790 to edbb6564c87b (486 revisions) · f6e983b8

authored Oct 06, 2020

https://chromium.googlesource.com/chromium/src.git/+log/78d150eb2790..edbb6564c87b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4317485981..6186e428fc
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ddb20d82f3..1c37217884
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f513a0bef6..c5290b5af7
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/ee1e244813..f685c086bd
No update to Clang.

Bug: angleproject:5124
Tbr: timvp@google.com
Change-Id: I853a2ef9421337c2d345a082c053aff24d23fdaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451603Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f6e983b8

Work-around test runner & DebugAnnotator · 08142700

authored Oct 01, 2020

Note: This precedes another CL that needs this change.

DebugAnnotator uses a global variable.  The test runner doesn't change
state between testing different back-ends.  This works-around the
problem by setting the global variable when the context is switched.

Because the GL back-end doesn't have its own DebugAnnotator sub-class,
add a Display* to DisplayImpl::makeCurrent(), so that
DisplayGL::makeCurrent() can install the front-end-Display's
DebugAnnotator.

Note: the Vulkan back-end gets this fix even though the new
DebugAnnotatorVk class will be added in a follow-on CL.

Bug: b/162068318
Bug: b/169243237
Bug: angleproject:5121
Change-Id: If08626a5310f9b4e3210e1a897a6886248e4d8ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451423Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

08142700

Test Runner: More docs. · 23624c53

authored Oct 05, 2020

Bug: angleproject:3162
Change-Id: I5b282d7815973cef9f7e029bc3c65cf42729e009
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451596
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

23624c53

Vulkan: Defer the depthStencil buffer layout change to endRenderPass · 77e3d0ae

authored Sep 25, 2020

Depth stencil layout may change while we build the render pass,
depending on the read/write access been made. Right now we are always
inserting a layout change barrier at the start of render pass.  Later on
when the read/write property changes, we insert another layout change
barrier. Similarly, we maintain the attachmentOps and
RenderPassDesc::mPackedColorAttachmentRangeAndDSAccess as we changes
read/write access. This makes code quite commplicated. This CL moves
mReadOnlyDepthStencilMode from FramebufferVK to CommandBufferHelper
object and we only maintain that boolean while we updating the
read/write access. Then at the end of render pass or when depthStencil
image is deleted, we update attachmentOps and mRenderPassDesc and layout
transition all at once and only done once. This simplifies the read only
depth stencil mode implementation a lot.

Bug: b/168953278
Change-Id: Ie263b4526c82a9858e5d1f141ea58f499187a3ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2432075
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

77e3d0ae

Plumb EntryPoint & Context to DebugAnnotator/EVENT() · f074d61a

authored Sep 28, 2020

This makes it easier to plumb debug labels to a future
DebugAnnotatorVk class.

Bug: b/162068318
Bug: b/169243237
Change-Id: I01e3779569c27c91252dc2874f6deaec526afd6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451516
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f074d61a

Vulkan: Add plumbing to render pass when ImageHelper gets deleted · 86ca5d2b

authored Oct 01, 2020

ImageHelper object is not refcounted and garbage collected and
endRenderPass call is deferred until next render pass starts. This
caused a situation that an ImageHelper object gets deleted while still
referenced in the open render pass. This CL make sure that we call into
all shared context's open renderpass when an image goes away so that
they can take appropriate action for this.

Bug: b/169618408
Change-Id: I5075e805980084db82ca3e699462272eee5d2d59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2443571Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

86ca5d2b

Revert "Work-around test runner & DebugAnnotator" · da61c40e

authored Oct 06, 2020

This reverts commit e44c94d9.

Reason for revert: Breaks build of DisplayGbm on ChromeOS:
src/libANGLE/renderer/gl/egl/gbm/DisplayGbm.{h,cpp}
First failing builds:
https://ci.chromium.org/p/chromium/builders/ci/ChromeOS%20FYI%20Release%20%28amd64-generic%29/1608
https://ci.chromium.org/p/chromium/builders/ci/ChromeOS%20FYI%20Release%20%28kevin%29/2212

Original change's description:
> Work-around test runner & DebugAnnotator
>
> Note: This precedes another CL that needs this change.
>
> DebugAnnotator uses a global variable.  The test runner doesn't change
> state between testing different back-ends.  This works-around the
> problem by setting the global variable when the context is switched.
>
> Because the GL back-end doesn't have its own DebugAnnotator sub-class,
> add a Display* to DisplayImpl::makeCurrent(), so that
> DisplayGL::makeCurrent() can install the front-end-Display's
> DebugAnnotator.
>
> Note: the Vulkan back-end gets this fix even though the new
> DebugAnnotatorVk class will be added in a follow-on CL.
>
> Bug: b/162068318
> Bug: b/169243237
> Bug: angleproject:5121
> Change-Id: I748e8a1fd09b72e07242ac7fb39154537dcce534
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444095
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Commit-Queue: Ian Elliott <ianelliott@google.com>

TBR=courtneygo@google.com,ianelliott@google.com,jmadill@chromium.org

Change-Id: I99df2716951726ead24961dc3d27a7ec63aeda80
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/162068318
Bug: b/169243237
Bug: angleproject:5121
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451420Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>

da61c40e

Change shader compile failures into an info message. · a8d4457c

authored Oct 02, 2020

This reduces spam in our unit tests. Speeds up test execution.

Bug: angleproject:3162
Change-Id: I286a18b3ce862c4e4155076b2ee3f93c9db2eb33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447041
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

a8d4457c

Test Runner: Pass dEQP args to child processes. · d3aa1e9c

authored Oct 03, 2020

This fixes the sharding to use the specified back-end. With
the bug ANGLE would start the platform default back-end instead.

Bug: angleproject:3162
Change-Id: Ib2453dd3c58ea40fb36619301865ae0818038d15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447043
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

d3aa1e9c

Test Runner: More misc improvements. · f0d9471c

authored Oct 02, 2020

- reduces default batch size from 1000 -> 256
- reduces default max processes to a max of 16
- stripes tests when in bot mode
- prints less spam when waiting for child processes

The striping and smaller batch size can help with slow tests.
The max process limit seemed to prevent errors on Linux.

Bug: angleproject:3162
Change-Id: Ibed89ca35db54c62ec8ed63b32bc5aed916faec9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447037
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

f0d9471c

Work-around test runner & DebugAnnotator · e44c94d9

authored Oct 01, 2020

Note: This precedes another CL that needs this change.

DebugAnnotator uses a global variable.  The test runner doesn't change
state between testing different back-ends.  This works-around the
problem by setting the global variable when the context is switched.

Because the GL back-end doesn't have its own DebugAnnotator sub-class,
add a Display* to DisplayImpl::makeCurrent(), so that
DisplayGL::makeCurrent() can install the front-end-Display's
DebugAnnotator.

Note: the Vulkan back-end gets this fix even though the new
DebugAnnotatorVk class will be added in a follow-on CL.

Bug: b/162068318
Bug: b/169243237
Bug: angleproject:5121
Change-Id: I748e8a1fd09b72e07242ac7fb39154537dcce534
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444095Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

e44c94d9

05 Oct, 2020 14 commits

KHR_debug: Fix off-by-one message length. · 7004523a

authored Oct 02, 2020

The dEQP tests were timing out due to the "get message" call skipping
messages. The get call had a bufSize that ANGLE was rejecting as too
small because it didn't include the null terminator. The dEQP test
would pass but would always take ten seconds. I noticed this when
debugging the ANGLE test launcher and seeing batch timeouts.

Bug: angleproject:5130
Change-Id: Ie9f949218590b98a11f6c10b1f86074e90dbca17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447039
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

7004523a

Suppress failing Mac GL dEQP-GLES3 tests. · 9214fc18

authored Oct 05, 2020

dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.stencil_index8
dEQP-GLES3.functional.fbo.completeness.renderable.texture.stencil.stencil_index8
dEQP-GLES3.functional.fbo.completeness.renderable.texture.depth.stencil_index8

Bug: angleproject:5136
Change-Id: I3e534df7312f173716952adc7ef24ac052914308
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451317Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9214fc18

Replaced allow_list with files_to_check · f69aaf60

authored Oct 05, 2020

Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code

Bug: b/162834212
Change-Id: I2bb65ca7ae73109dc858c93f3a9f973ebfe9d4cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451318Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f69aaf60

Improve capture replay tests. · be73728d

authored Oct 03, 2020

Removes the custom logger class and uses the python logging class.
Moves the argument descriptions into argparse help.
Keep build directories around by default. Essential for normal use.
Print more debug messages.

Bug: angleproject:5133
Change-Id: Ida48828512abe60ee7d16873cbdb87c58529a60a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446898
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

be73728d

Capture/Replay: Don't capture XFB 0 in MEC. · 8608b402

authored Oct 04, 2020

This will only add an extra unused XFB object. Noticed when capturing
from the T-Rex replay.

Bug: angleproject:5134
Change-Id: Ia368f9e9f59f9ea7473ac88928a413001fa99496
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449157
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

8608b402

Suppress failing Mac GL dEQP tests. · 0ff24ae0

authored Oct 05, 2020

dEQP-GLES2.functional.fbo.completeness.renderable.texture.color0.stencil_index8
dEQP-GLES2.functional.fbo.completeness.renderable.texture.stencil.stencil_index8
dEQP-GLES2.functional.fbo.completeness.renderable.texture.depth.stencil_index8

Bug: angleproject:5136
Change-Id: I787bf4505a5c10d47fa669423df8a7510e28bcab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2450916Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

0ff24ae0

Tests: Update two traces, remove one · 61b13f8f

authored Sep 30, 2020

* Update candy_crush and temple_run to use more recent
  capture headers.

* Remove subway_surfer because the app no longer uses
  GLES. Its Unity backend now runs Vulkan, so we can't
  re-record it.

Test: angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4845
Change-Id: I9d219f2be05813c50b31287a65bfc099787d114c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441851
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

61b13f8f

Capture/Replay: Split very large replay function. · 505a8d05

authored Sep 26, 2020

This allows a replay of the T-Rex offscreen benchmark.

Bug: angleproject:5133
Change-Id: I9998c4785e61a6410863a1cd8a8a569b1e08098a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446897
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

505a8d05

Capture/Replay: Generalize function splitting. · c15d1e2d

authored Sep 26, 2020

We can use this to split up the replay function as well as very large
setup functions. This will let us replay the gfxbench offscreen
benchmarks directly.

Bug: angleproject:5133
Change-Id: Ic24f25f2ab6821e68356a28a698cb84301e99be2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446896
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

c15d1e2d

FrameCapture: More fixes for app updates · 34445b29

authored Oct 02, 2020

* Disable GL_EXT_map_buffer_range during capture, several
  native GLES drivers do not support it.

* Unmap buffers before updating them during Reset. Some native
  drivers require it.

Test: Temple Run on multiple systems
Bug: angleproject:4845
Change-Id: I9aea9c220320095aee87da107320b8fcad6c0a2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447029Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

34445b29

Roll SwiftShader from 375fee944c76 to b3c1e71eb1cb (2 revisions) · ef897a9c

authored Oct 05, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/375fee944c76..b3c1e71eb1cb

2020-10-02 nicolascapens@google.com Regres: List regressions before summary
2020-10-02 vantablack@google.com Added support for AndroidHardwareBuffer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I6765670fbd22e6c37290c1ef51823b9148eb765a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2448992Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ef897a9c

Roll SPIRV-Tools from d91afd8de27a to f15133788010 (3 revisions) · b33da9ae

authored Oct 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d91afd8de27a..f15133788010

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I9509dbb7a234dfd00d9457d522dcdd0068dd2ea8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2448213Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b33da9ae

Roll Vulkan-Headers from e1ba543c6789 to 94ff600cc862 (1 revision) · d8b31486

authored Oct 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1ba543c6789..94ff600cc862

2020-10-05 oddhack@sonic.net Update for Vulkan-Docs 1.2.156

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Iefb59064e9acccd309eaaef2993f60c70de73dd9
Bug: None
Tbr: timvp@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2448959Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d8b31486

Roll Chromium from 7b91afe96128 to 78d150eb2790 (541 revisions) · e56466d4

authored Oct 05, 2020

https://chromium.googlesource.com/chromium/src.git/+log/7b91afe96128..78d150eb2790

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9cc0704ecc..4317485981
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/5538030635..ddb20d82f3
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3187b54c0c..54a9cb2f54
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/921f371807..f513a0bef6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/410285a57e..5e26fff7a7
No update to Clang.

Bug: angleproject:5124
Tbr: jonahr@google.com
Change-Id: I51018170b29a3c03e59c856db57d4f0d780c20d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449150Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e56466d4

03 Oct, 2020 2 commits

Vulkan: Render pass creation cleanup · 50070481

authored Oct 02, 2020

Bug: angleproject:4836
Change-Id: If7b0beef4b32149bebb0f63558ac34d0c3cd79c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444098
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

50070481

Vulkan: Free up 2 bits in PackedAttachmentOpsDesc · c5494728

authored Oct 02, 2020

These bits will be used to aid in invalidation of
multisampled-render-to-texture attachments.

Bug: angleproject:4836
Change-Id: Ib2b438386f8cd8c057bc0ef16144b9d2ddbc1594
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444097
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c5494728

02 Oct, 2020 7 commits

Test Runner: Set interrupted to 'false' normally. · 23825b12

authored Oct 02, 2020

The bug here was to output 'interrupted: true' when running
in --bot-mode. Instead in normal execution we will output
that we were not interrupted.

Bug: angleproject:3162
Bug: chromium:1134619
Change-Id: I3842e90466473ff05b0b90bc4660f88606a3c9f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446851Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

23825b12

Suppress flaky test on Win/Intel/GL. · c488f0c9

authored Oct 02, 2020

CopyTextureTestES3.ES3UnormFormats/ES3_OpenGL

Bug: angleproject:5127
Change-Id: I93628beb92b8d9b4d8c6f70b32d15ed9add54667
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446595Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c488f0c9

First pass at increasing inclusivity · e815afbf

authored Sep 07, 2020

Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code

Bug: b/162834212
Bug: chromium:1097198
Change-Id: Ied5a9e3879d72bff3f77ea6fcda9b82f30c32c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396737
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>

e815afbf

Implement GL_OES_texture_stencil8 · 7a92d958

authored Jul 21, 2020

Add extension to Caps and code gen files.
Add to Validation of TexImage
Add all the autogen for new extension
Fix swizzle for stencil only
Add LoadFunction
Fix formatutils
Add validation
Test: angle_deqp_egl_tests
--deqp-case=GLES31.functional.stencil_texturing.format.stencil_index8_2d

Bug: angleproject:3231
Change-Id: Id59c7d183ea1658732887e99637d9c8faab938e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404327Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

7a92d958

Disable AMD OpenGL testing on Windows ANGLE tests. · 513095e9

authored Oct 02, 2020

Our current CI testing for AMD is quite out-of-date and unsupported.
If necessary we could skip based on a GPU device ID.

Bug: angleproject:5123
Change-Id: Idf919a330aa9903ad80aba38f745d4a35d1b501e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446092Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

513095e9

Vulkan: Add a test and fix the bug with draw/invalidate/clear · c6dc9d73

authored Sep 19, 2020

This adds a test that does draw with depth enabled, then disable depth
test but with depth mask still enabled. Then invalidate framebuffer and
followed by a clear. That clear  will go down clearWithCommand path and
should still work and data stored.

Bug: b/169590459
Change-Id: I6dd30d6a1e12ad7820d98fe79445c336cfa3a643
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422081Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

c6dc9d73

Skip ResizeWindowWithDraw test on all Linux. · e9a82849

authored Oct 02, 2020

Flakes on NVIDIA Linux as well when run in certain orders.

Bug: angleproject:4453
Change-Id: I7565b7868518d01d5e928ce95d0edb8abd651e28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446091
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

e9a82849