- 15 May, 2018 5 commits
-
-
Geoff Lang authored
Some dEQP tests call eglTerminate twice on the same display and cause crashes. BUG=angleproject:2546 Change-Id: I8a13d00fd03692b3b24dee4813c245d83ea00862 Reviewed-on: https://chromium-review.googlesource.com/1060335Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Geoff Lang authored
BUG=angleproject:2546 Change-Id: I3ffc33649bad26f9d12580e398777b8b6c8ad542 Reviewed-on: https://chromium-review.googlesource.com/1059711Reviewed-by:
-
Luc Ferron authored
- Add vkCmdCopyImageToBuffer support in CommandBuffer - Add a new function in the PixelBuffer to support staging changes coming from an image. Bug: angleproject:2500 Bug: angleproject:2501 Change-Id: Ic29101391edc6f25a71dcd318bc8a72b2ae1a054 Reviewed-on: https://chromium-review.googlesource.com/1054104 Commit-Queue: Luc Ferron <lucferron@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2546 Change-Id: I9ece2b5b38217afa43ba7f120ef311c2cf3ca4cb Reviewed-on: https://chromium-review.googlesource.com/1059700Reviewed-by:
-
Jamie Madill authored
Bug: angleproject:2557 Change-Id: Ica29c686ad3a71da3f8564f8a78bbe4f57ce304f Reviewed-on: https://chromium-review.googlesource.com/1058251Reviewed-by:
Luc Ferron <lucferron@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
- 14 May, 2018 11 commits
-
-
Geoff Lang authored
BUG=angleproject:2546 Change-Id: I911842753e8065de8e86f0af1f6cdf2a388fec63 Reviewed-on: https://chromium-review.googlesource.com/1058280Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2546 Change-Id: I9b62ef6331c03d185feaa91ad4f21f9a1380186f Reviewed-on: https://chromium-review.googlesource.com/1058147Reviewed-by:
-
Corentin Wallez authored
BUG=chromium:834269 Change-Id: Ia49f80f4c057ad467428a13e8cd4ca54ad48d5c4 Reviewed-on: https://chromium-review.googlesource.com/1058084Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2546 Change-Id: I996c1344c93be7618ffbedd3e34e9aaa4855e25e Reviewed-on: https://chromium-review.googlesource.com/1057989 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2546 Change-Id: I74b376c07f94d77abe28129ff5e97bd19a26d0d0 Reviewed-on: https://chromium-review.googlesource.com/1057831Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2546 Change-Id: I81c9786eccf50962b2928333272cee3eb556e707 Reviewed-on: https://chromium-review.googlesource.com/1057869Reviewed-by:
-
Jamie Madill authored
This fixes an edge case when the app clears both color and depth at the same time when a color mask is set. It also handles stencil clear, but does not handle stencil masks. Includes test suppressions for a few platforms that may have driver bugs. Bug: angleproject:2455 Bug: angleproject:2547 Bug: angleproject:2548 Change-Id: I5ac0a461a075328e5fc4e5e262c4d21f68f93434 Reviewed-on: https://chromium-review.googlesource.com/1052072Reviewed-by:
-
Jamie Madill authored
The GN was including both libGLESv2.def and _autogen. This fixes the GN to only include _autogen, and removes the .def include from the static build target. Bug: angleproject:2476 Change-Id: I2e856e3bbe875bdadd1add4517cef60a11227047 Reviewed-on: https://chromium-review.googlesource.com/1057451Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brandon1 Jones <brandon1.jones@intel.com> Reviewed-by:
-
Jamie Madill authored
These casts could result in overflow. Bug: chromium:842028 Change-Id: I998b638c58333a29f6bc9136ae3e81b90683cb72 Reviewed-on: https://chromium-review.googlesource.com/1057415Reviewed-by:
-
Lingfeng Yang authored
This is the renderer code for GLES1 that delivers basic vertex attributes, matrices, and allows texturing for unit 0 only (more units mean implementing the multitexturing pipeline). + Sample + Update test expectations for GLES1 conformance tests BUG=angleproject:2554 BUG=angleproject:2306 Change-Id: I398edc764f982fbfc4c5e0f9d6bfef1e91aec47c Reviewed-on: https://chromium-review.googlesource.com/1057356Reviewed-by:
-
Hans Wennborg authored
Bug: chromium:842408 Change-Id: I8793e3bb9ed4661e49eceb55c7253d7ada06488a Reviewed-on: https://chromium-review.googlesource.com/1057231Reviewed-by:
-
- 12 May, 2018 2 commits
-
-
Frank Henigman authored
This reverts commit a6909921. Reason for revert: New tests failing on gpu fyi bot. anglebug.com/2554 Original change's description: > GLES1: Renderer (minimal) > > This is the renderer code for GLES1 that delivers basic vertex > attributes, matrices, and allows texturing for unit 0 only (more units > mean implementing the multitexturing pipeline). > > + Sample > + Update test expectations for GLES1 conformance tests > > BUG=angleproject:2306 > > Change-Id: Id5d5603c967e577290085e5946f2cb7a03d7e017 > Reviewed-on: https://chromium-review.googlesource.com/1023988 > Commit-Queue: Lingfeng Yang <lfy@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org,lfy@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:2306 Change-Id: Ib6fd9db433cd1a13589d5a9e82cb2c40f3cf71ff Reviewed-on: https://chromium-review.googlesource.com/1056229Reviewed-by:
Frank Henigman <fjhenigman@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
-
Jamie Madill authored
When using a vertex buffer with DYNAMIC usage, with robust buffer access enabled, we would sometimes read out-of-bounds when using very large values for the index range. An unchecked signed addition would overflow and lead to reading a negative offset. Fix this problem by keeping the value size_t whenever possible. Also do clamped casts when converting to a smaller values. Also adds a regression test. Bug: chromium:842028 Change-Id: Ie630ac857c6acfc0bace849a03eebfbaa2fbe89a Reviewed-on: https://chromium-review.googlesource.com/1055928 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
- 11 May, 2018 8 commits
-
-
Geoff Lang authored
BUG=angleproject:2464 Change-Id: I243c010e30d62e233411b1dab1d13a69b44e4b38 Reviewed-on: https://chromium-review.googlesource.com/1054214Reviewed-by:
-
Geoff Lang authored
This caused the backends to fail native context creation and skip tests on these configs. BUG=angleproject:2464 Change-Id: I04922853a33c4bd8b38c87145f65431d8eb3db10 Reviewed-on: https://chromium-review.googlesource.com/1054482Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Lingfeng Yang authored
This is the renderer code for GLES1 that delivers basic vertex attributes, matrices, and allows texturing for unit 0 only (more units mean implementing the multitexturing pipeline). + Sample + Update test expectations for GLES1 conformance tests BUG=angleproject:2306 Change-Id: Id5d5603c967e577290085e5946f2cb7a03d7e017 Reviewed-on: https://chromium-review.googlesource.com/1023988 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by:
-
Yuly Novikov authored
Bug: 839893, angleproject:2549, angleproject:2550 Change-Id: Id51ad7df2dc225eb6d4e8d4a8668e7e2295d2fa3 Reviewed-on: https://chromium-review.googlesource.com/1054581 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Luc Ferron authored
2D multisample is out of scope since its ES 3 only. Bug: angleproject:2499 Change-Id: Id5f81d713a2882ba2a91b7d3f281d71a3e9289f4 Reviewed-on: https://chromium-review.googlesource.com/1046786 Commit-Queue: Luc Ferron <lucferron@chromium.org> Reviewed-by:
-
Geoff Lang authored
Also add a destroy method. BUG=angleproject:2464 Change-Id: I7346b799af4e7d64ed5cc3d5eca8e108ce2cf699 Reviewed-on: https://chromium-review.googlesource.com/1054213Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2464 Change-Id: I24b07557d90988369bc8b7e4b2fe3a500ab7bc36 Reviewed-on: https://chromium-review.googlesource.com/1048115Reviewed-by:
-
Olli Etuaho authored
Virtual functions are removed from TSymbol, so the warning for non-virtual destructor found in a class with virtual functions can be enabled. BUG=angleproject:2417 TEST=angle_unittests Change-Id: Icd0ea2c77ce826739fbe954137f8ee78e6ef5386 Reviewed-on: https://chromium-review.googlesource.com/1051830 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by:
-
- 10 May, 2018 3 commits
-
-
Jamie Madill authored
This CL is adapted from work by matavenrath@nvidia.com. It does the following small optimizations: * inlines a bunch of accessors. * reorders checks to hit the cache more often Also some small style updates. Bug: angleproject:1671 Change-Id: I8f21318e6644dcfe1f99c98f7f377742fcad78d3 Reviewed-on: https://chromium-review.googlesource.com/1054367 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Luc Ferron authored
The implementation of DynamicBuffer before my changes could have some issues in the following use case: - Allocate buffer 1 for Texture 1 (with size as big as the full buffer size) - Allocate buffer 2 for Texture 2 (triggers creation of a new underlying BufferVk and releases the buffer 1 to the Renderer) - Render with Texture 2 (texture 1 hasn't been flushed yet) - swap buffers (causes garbage in the renderer to be cleaned up) - Try rendering with Texture 1, and you'll get an error stating that the buffer we're trying to copy is not valid (because its already been freed). This set of changes: - Add a new test that specifically triggers this case. - enables the texture.filtering.cube* tests in dEQP. - Fixes the issue by adding a manual releasing pattern of the buffers in DynamicBuffer. Bug: angleproject:2505 Change-Id: I207ce4a694016766f008cca67d82b252f460e0df Reviewed-on: https://chromium-review.googlesource.com/1052551Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2464 Change-Id: I20aabeef3de6cf1fc13a29b6220e040aa83184d7 Reviewed-on: https://chromium-review.googlesource.com/1039986 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
- 09 May, 2018 7 commits
-
-
Luc Ferron authored
-Enables more dEQP tests in functional.texture.filtering -texture.filtering.cube.* tests don't work yet, another CL will be targeted at fixing that after this one. Bug: angleproject:2505 Change-Id: Ic634e0deafa54e8e8ebd0efbdae14263ffdbcef0 Reviewed-on: https://chromium-review.googlesource.com/1037183Reviewed-by:
-
Jamie Madill authored
This is a reland of c009255c Re-landing after crbug.com/840825 was updated. Original change's description: > Update cq.cfg with new builders. > > These builders are replacing the old standalone builders and the old > compile-only builders. They should be much faster. They also can be > extended in the future when we support running tests from ANGLE > standalone. > > Bug: chromium:833999 > Change-Id: Ice44c0fb8cb32d8be573f81d5df858509b00a107 > Reviewed-on: https://chromium-review.googlesource.com/1049959 > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: chromium:833999 Bug: chromium:840825 Change-Id: Ie08ebbef6b5802f0bb57053e082fac2e0f9aae34 Reviewed-on: https://chromium-review.googlesource.com/1052747Reviewed-by:
-
Geoff Lang authored
Pass the proxy context to the onDestroyDefault call. BUG=angleproject:2464 Change-Id: I47f869d623e238ca3680c962387ba9359e7d3844 Reviewed-on: https://chromium-review.googlesource.com/1052220Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2464 Change-Id: Icd260db9bbd11699b2d0f6152e898c38baa4844d Reviewed-on: https://chromium-review.googlesource.com/1052219Reviewed-by:
-
Luc Ferron authored
This is a problem when we emulate RGB8 with RGBA8. Bug: angleproject:2536 Change-Id: I5665e513ef0138bc56f52ba35342378d8392989f Reviewed-on: https://chromium-review.googlesource.com/1051687 Commit-Queue: Luc Ferron <lucferron@chromium.org> Reviewed-by:
-
Luc Ferron authored
This is a prerequisite to support incomplete textures. Bug: angleproject:2536 Change-Id: Ica40bbd185a67253f457148007b08f6735da788c Reviewed-on: https://chromium-review.googlesource.com/1050308Reviewed-by:
-
Olli Etuaho authored
This also adds unit tests for negative modulus operands. BUG=chromium:839468 TEST=angle_unittests Change-Id: I6ab5959ba4f7045d2bde71d246695ef0983c5608 Reviewed-on: https://chromium-review.googlesource.com/1046055Reviewed-by:
-
- 08 May, 2018 4 commits
-
-
Jamie Madill authored
BUG=angleproject:2464 Change-Id: Ib2a43bc8e2da467f49e8938c386a5e867c80d5bc Reviewed-on: https://chromium-review.googlesource.com/361921Reviewed-by:
-
Frank Henigman authored
This reverts commit fad918f8. Reason for revert: attempt to fix anglebug.com/2537 Original change's description: > ANGLETest: Reuse test windows per-renderer > > When running angle_end2end_tests unfiltered with the OpenGL and Vulkan > backends enabled, the test window was recreated all the time and grabbed > focus every-time it was created. This made it impossible to do anything > with the machine running the tests. > > Fix this by having one OSWindow per renderer group that's lazily created: > this solves most of the issue since only a couple windows end up being > created, and at the beginning of the test suite. > > BUG= > > Change-Id: I7a51300f0d59d8b6bb79e54d20b3acbf01068002 > Reviewed-on: https://chromium-review.googlesource.com/1038433 > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I93bdfa38757cbe2a6ce939c0c3e3da806307e7dd Reviewed-on: https://chromium-review.googlesource.com/1050326Reviewed-by:
-
Jamie Madill authored
This reverts commit c009255c. Reason for revert: Seems to be some kind of infra or goma error with the mac configs that wasn't showing up last night. Original change's description: > Update cq.cfg with new builders. > > These builders are replacing the old standalone builders and the old > compile-only builders. They should be much faster. They also can be > extended in the future when we support running tests from ANGLE > standalone. > > Bug: chromium:833999 > Change-Id: Ice44c0fb8cb32d8be573f81d5df858509b00a107 > Reviewed-on: https://chromium-review.googlesource.com/1049959 > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=fjhenigman@chromium.org,geofflang@chromium.org,jmadill@chromium.org Change-Id: I8bf895d7473da7fe44a3bb866a2026b59a374868 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:833999 Reviewed-on: https://chromium-review.googlesource.com/1050325Reviewed-by:
-
Jamie Madill authored
These builders are replacing the old standalone builders and the old compile-only builders. They should be much faster. They also can be extended in the future when we support running tests from ANGLE standalone. Bug: chromium:833999 Change-Id: Ice44c0fb8cb32d8be573f81d5df858509b00a107 Reviewed-on: https://chromium-review.googlesource.com/1049959Reviewed-by:
-
