Commits · 13ac4dfba8bd091d67dc8666b2838aa2d047f0ff · Chen Yisong / angle

23 Jun, 2021 8 commits

gl_tests:DrawArraysThenDrawElements: glFinish instead of swap · 13ac4dfb

authored Jun 23, 2021

Later in the test we read from the backbuffer to confirm that the
triangles were drawn correctly, but without EGL_BUFFER_PRESERVED
the content of the backbuffer is undefined.

Since glReadBuffer is not supported in GLES2 don't swap, instead to
a glFinish to force the drawing in each iteration.

Bug: angleproject:6088
Change-Id: Iac485cc6ec92626a74a4428bcdb32cc535a2691f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982112Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>

13ac4dfb

Test Runner: Omit results files when too many failures. · 15623ada

authored Jun 23, 2021

This will cause the test shards to be re-tried due to an invalid
result. The goal is to retry flaky configs where whole shards fail.

Bug: angleproject:6075
Change-Id: I76d0f08da29ffc4bcad7f282f7be38618c384bce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982500Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

15623ada

Capture: Serialize only the content of initialized attachments · 41f86f35

authored Jun 22, 2021

If a resource is marked MayNeedInit, then we don't serialize it but
mark the data as not initialized.

Bug: angleproject:6041
Change-Id: If3d3431a58848f7835692fe10b30fab68c901d8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2976657Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>

41f86f35

Disable warning on invalid feature name. · ac795859

authored Jun 23, 2021

Because we don't have a centralized feature list, we would fire
this warning every time we use a feature override. Disable it
until we have a centralized list we can check.

Bug: angleproject:6085
Change-Id: Ia5c3f2ae8337141e963e67e1d71243a3d0a01c9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982505Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

ac795859

Finish switch to angle_version.h. · 1b104dd9

authored May 26, 2021

Bug: b/168736059
Change-Id: I1232c8284f37aadb374840aca8f40e4569382c7b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920490Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1b104dd9

Roll vulkan-deps from 85e758a22b7a to 5fbfa253f282 (2 revisions) · b59db448

authored Jun 23, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/85e758a22b7a..5fbfa253f282

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f8eafd4d83..0c21e50922
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f12691a7fc..71916f15bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I18951d42d671c30a68ad1107780829fdd733f8c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2981695
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b59db448

Roll Chromium from 685eab2b2e45 to bbc918ca9021 (471 revisions) · 95603a5e

authored Jun 23, 2021

https://chromium.googlesource.com/chromium/src.git/+log/685eab2b2e45..bbc918ca9021

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/38ed2cb517..e589a8307b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2150962daf..eaddc52d2a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a2a4ced865
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b714c17658..2dd15401da
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2d4e9fd266..8dd9dda226
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c98879461d..573b694c3e
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e2f6c49548..cf75b77f7f
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: If4160acefe414e040b73abf01f9661fb5852d1c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2981691
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

95603a5e

Vulkan: Use pipeline statistics query to emulate primitives generated · b6adeb2f

authored Jun 21, 2021

The VK_QUERY_PIPELINE_STATISTIC_CLIPPING_INVOCATIONS_BIT query produces
the same result as the GL primitives generated query.  One caveat is
that in combination with rasterizer discard this query may not work.
This is emulated by disabling rasterizer discard when this query is
active and applying an empty scissor instead.

When VK_EXT_primitives_generated_query is released and supported, a
similar issue with rasterizer discard persists so this change will
facilitate using that extension as well.

Bug: angleproject:5430
Change-Id: Id45b6f058c5cb6837e04aa64b1efde28c104e4cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2976181
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b6adeb2f

22 Jun, 2021 15 commits

Test runner: Capture test stderr · 09bd5578

authored Jun 21, 2021

With this change, stderr is also output when a test fails, including
logs such as those originating from UNIMPLEMENTED().

Bug: angleproject:6077
Change-Id: Ice1e1f9aff26acfb630aef99865503643f0a9658
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2976184
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

09bd5578

Allow capturing process stdout and stderr interleaved · 72d2bd0c

authored Jun 21, 2021

The test utils are enhanced to allow redirecting stderr to stdout. This
is in preparation for a change that makes the test runner capture stderr
together with stdout. Currently, on failure logs originating from
UNIMPLEMENTED() and other such macros are not captured.

Bug: angleproject:6077
Change-Id: I7a3c6c4732a59dac3ff0cc20a7835d5ed6f0f22e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2976183Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

72d2bd0c

Fix overflow in gl::ValidateES2TexImageParametersBase · dbfc119a

authored Jun 22, 2021

Bug: chromium:1222516
Change-Id: I532dc6e1c80c442af2c35d1facc262c48222def3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2978251Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>

dbfc119a

Vulkan: SPIR-V Gen: Support most non-texture/image built-ins · 64ce506d

authored Jun 18, 2021

Most GLSL built-ins map directly to some SPIR-V operation.  texture*()
and image*() built-ins are not implemented as well as a handful of other
built-ins that require special-handling.

Bug: angleproject:4889
Change-Id: I72abfb4692c3d66a3c8be43ce44ba6808efe6255
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971646
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

64ce506d

Trace Tests: Print serialization diff on failure. · b80f1377

authored Jun 22, 2021

Instead of only printing this with the "verbose" flag, print the
diff of the serialization as an "info" message. This will make the
diff show up on the bots.

Bug: angleproject:5715
Change-Id: Ic9684b43cdf2d6ae248b5beab4317b0e939567c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2979854
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

b80f1377

Test Runner: Add maximum failure count. · 4194d400

authored Jun 21, 2021

This will make the test runner early exit after a certain count
of failures. This will prevent the bots from running tens of
thousands of tests when the whole test run is corrupt.

Bug: angleproject:6075
Change-Id: I8f5c19ea694a5ad3a5d5df1429d2ba4b1fe868e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2976179
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

4194d400

Better stack traces on Linux. · 3f99e4d3

authored Jun 18, 2021

Checks the memory information for the process to compute a more
accurate address for each function.

Bug: angleproject:6070
Change-Id: I57f927f3641298af7921522da0ece683f8fd8faf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971838Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

3f99e4d3

Add regression test for GL bug w.r.t cached programs · 3d37a374

authored Jun 22, 2021

Bug: angleproject:6073
Change-Id: I22ffabea8a686e2ae615e99607cb557324c23c78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2976185Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

3d37a374

Add simple UBSAN ignorelist. · db3b4ee6

authored Jun 22, 2021

Bug: angleproject:5795
Change-Id: Ic2aa1124ac88a5d0fe87df3d524a10fe62b00732
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2977174Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

db3b4ee6

Update glColorspace(EGL_KHR_gl_colorspace) enable logic · 96dd515a

authored Mar 31, 2021

1. Enable glColorspace if VK_EXT_swapchain_colorspace is
supported, remove dependency on VK_KHR_image_format_list.
2. Enable VK_KHR_image_format_list support on Mali GPU.
3. Fix PbufferTest.ClearAndBindTexImageSrgbSkipDecode
   test tolerance issue.

Bug: angleproject:2514
Bug: angleproject:5281
Change-Id: I2ed54a14afc7c3aee5a5980bd300ab052ebab3d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2793852
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

96dd515a

Roll vulkan-deps from 6cbd7212ad42 to 85e758a22b7a (4 revisions) · 9adf692c

authored Jun 22, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/6cbd7212ad42..85e758a22b7a

Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/2e1b5fb39e..9cdeefb5e3
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5dd2f76918..f8eafd4d83
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a680671d95..dbd221b2bc
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/16db450293..f12691a7fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I0a66f3693fdbf795b1ca8a346671f91978f1f055
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2978754
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9adf692c

Roll SwiftShader from 4a304244dd86 to f0a9f88dd5cb (1 revision) · eb69362b

authored Jun 22, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/4a304244dd86..f0a9f88dd5cb

2021-06-21 swiftshader.regress@gmail.com Regres: Update test lists @ 4a304244

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Ie8c19418ee314ddcf4bb87651598024d37c91c31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2978753
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eb69362b

Roll Chromium from 637b4cdf0c64 to 685eab2b2e45 (109 revisions) · 4c7e159c

authored Jun 22, 2021

https://chromium.googlesource.com/chromium/src.git/+log/637b4cdf0c64..685eab2b2e45

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e4e59f8437..38ed2cb517
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/466954eda3..9c143ace75
* buildtools/linux64: git_revision:170c2dba1e0c0299fe8c6a441caf2f2352a42ae0..git_revision:e9b8433248ae2c117644b4e40b33203e7d3da192
* buildtools/mac: git_revision:170c2dba1e0c0299fe8c6a441caf2f2352a42ae0..git_revision:e9b8433248ae2c117644b4e40b33203e7d3da192
* buildtools/win: git_revision:170c2dba1e0c0299fe8c6a441caf2f2352a42ae0..git_revision:e9b8433248ae2c117644b4e40b33203e7d3da192
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/05f219c87f..2150962daf
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ada99637c0
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/70dcfe26e2..b714c17658
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b4326be4ac..e2f6c49548
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: I7377d246831b15d8572fd086be00a39811639586
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2978451
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4c7e159c

Tests: Add support for --renderdoc · 7df7fc7f

authored Jun 20, 2021

This change adds support for a new flag namely `--renderdoc` to end2end
and deqp tests.  With this flag, each test automatically starts and ends
a frame capture in renderdoc, working around an issue where renderdoc
refuses to capture a test frame that doesn't start or end with a swap.

With end2end tests, the capture starts before test set up, and ends
after test tear down.  With deqp tests, it starts before init, ends and
restarts after each test iteration and ends after deinit.

Bug: angleproject:6072
Change-Id: Ib41b816aff121bf922d9147044cc363c33a62181
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971835
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7df7fc7f

Roll Chromium from 414f62ab7363 to 637b4cdf0c64 (416 revisions) · 9412ac9c

authored Jun 21, 2021

https://chromium.googlesource.com/chromium/src.git/+log/414f62ab7363..637b4cdf0c64

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d6115b16f5..e4e59f8437
* buildtools/linux64: git_revision:7d803996740ccd587c54062750cbe04dfbc3c423..git_revision:170c2dba1e0c0299fe8c6a441caf2f2352a42ae0
* buildtools/mac: git_revision:7d803996740ccd587c54062750cbe04dfbc3c423..git_revision:170c2dba1e0c0299fe8c6a441caf2f2352a42ae0
* buildtools/win: git_revision:7d803996740ccd587c54062750cbe04dfbc3c423..git_revision:170c2dba1e0c0299fe8c6a441caf2f2352a42ae0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/eda471dbf5..05f219c87f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..986f4bb45c
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/473499ba26..70dcfe26e2
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0e774456f5..2d4e9fd266
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f76c710738..c98879461d
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/02d48e7535..b4326be4ac
Clang version changed llvmorg-13-init-12881-g4017d033:llvmorg-13-init-13305-g1605fce6
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/0e774456f51950adbd2309ebc176eb5e0d74ed41..2d4e9fd266c166d0a29769bbbce71fdd5cdc6fb5/scripts/update.py

Bug: None
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: Ide59a0c30d9ba58a55a0e2abea2c0051aa7c79f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2977578
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9412ac9c

21 Jun, 2021 4 commits

CL: Make CL front end and back end thread-safe · 44a5c913

authored Jun 17, 2021

Add locking to all mutable variables of the CL objects in the
front end and pass-through back end to make them thread-safe.
This fixes a crash in a multi-threaded CTS test.

Bug: angleproject:6015
Change-Id: I1d6471c851217639411c434c82acd32d14035291
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2967468
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

44a5c913

Fix roll_aosp.sh 'gn gen' failure · 7753c837

authored Jun 18, 2021

The 'gn gen' step in roll_aosp.sh is failing due to trying to access
third_party/rapidjson/BUILD.gn, which isn't in AOSP. The rapidJSON
library is required to build the ANGLE libraries with frame capture
enabled, which isn't necessary for AOSP builds.

This CL adds the GN arg 'angle_has_rapidjson' which roll_aosp.sh will
set to 'false' to prevent 'gn gen' from attempting to access
third_party/rapidjson/BUILD.gn.

Bug: b/187342779
Change-Id: I6fcc0e94b6325be7523e35f966b8e4dbc708e3b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2973338Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

7753c837

CL: Refactor TRY macro and fix more conformance bugs · 1891af05

authored Jun 16, 2021

Bug: angleproject:6015
Change-Id: Id54be19822fec2ac5584ffe1d1cf5bb8f00c9094
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2967467Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

1891af05

Roll vulkan-deps from 65149e19efd9 to 6cbd7212ad42 (2 revisions) · b239790f

authored Jun 21, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/65149e19efd9..6cbd7212ad42

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bcef913745..5dd2f76918
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9d10a96f2d..37164a5726

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ie09f3b90e8b9c3221c0d227c558d10d80d2090df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2975479
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b239790f

19 Jun, 2021 1 commit

Roll Chromium from 4c77f83b612d to 414f62ab7363 (319 revisions) · f0d8cd40

authored Jun 19, 2021

https://chromium.googlesource.com/chromium/src.git/+log/4c77f83b612d..414f62ab7363

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/11f1e3d2cd..d6115b16f5
* buildtools/linux64: git_revision:d2dce7523036ed7c55fbb8d2f272ab3720d5cf34..git_revision:7d803996740ccd587c54062750cbe04dfbc3c423
* buildtools/mac: git_revision:d2dce7523036ed7c55fbb8d2f272ab3720d5cf34..git_revision:7d803996740ccd587c54062750cbe04dfbc3c423
* buildtools/win: git_revision:d2dce7523036ed7c55fbb8d2f272ab3720d5cf34..git_revision:7d803996740ccd587c54062750cbe04dfbc3c423
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/965c815e32..eda471dbf5
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8f8817d6f6..1478deef28
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/9f92effa4e..d4f10da1b8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..893c99ae71
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59140d436a..473499ba26
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/27f119ee39..f76c710738
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a61c45df6b..02d48e7535
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: I7f3b1fce35f2053d9008517a7459829acd862daa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2973636
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f0d8cd40

18 Jun, 2021 9 commits

Vulkan: Fix AGI hierarchy crash for noop'd clears/queries · 3706f9eb

authored Jun 10, 2021

The ASSERT in ContextVk::endEventLogForClearOrQuery() was wrong.
Certain glClear*, glBeginQuery*, and glEndQuery* commands may exit
early (e.g. noop).  When this happens, mQueryEventType will be set to
NotInQueryCmd.  In such cases, return without trying to finish a
non-started debug-util-marker hierarchy.

Bug: b/191489405
Change-Id: If40ed00fdc6e420ae6a11c2aeaced19e5aa45a5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2973342Reviewed-by: Trevor David Black <vantablack@google.com>
Reviewed-by: Mark Lobodzinski <mark@lunarg.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

3706f9eb

Test for missing index dirty bit bug · c51c59c7

authored Jun 15, 2021

Bug fixed in
https://chromium-review.googlesource.com/c/angle/angle/+/2961690
triggers only in the following situation:

- Context 1: draw indexed -> clears index dirty bit
- Context 1: change state in such a way that closing the render pass is
             deferred to dirty bit handling (for example, change FBO)
- Context 1: issue a non-indexed draw call.  This closes the render pass
             and starts a new one -> bug was that the index dirty bit
             was not set
- Context 2: flush the command buffer, which submits the previous render
             pass of context 1 (which contained vkCmdBindIndexBuffer).
             The primary command buffer is now reset.
- Context 1: issue an indexed draw call.  Since the index dirty bit was
             not set, this was missing the vkCmdBindIndexBuffer call.

This change implements a regression test based on the above scenario.

Bug: chromium:1183068
Bug: chromium:1190493
Change-Id: I729bd48cd6df2621ca763f6231023a52ac08b0fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2963836Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c51c59c7

infra: Add symbol_level=1 in Release. · ce22ad10

authored Jun 18, 2021

This should enable better crash file/line information.

Bug: angleproject:6070
Change-Id: I54280461160f2ac6404dbd4b88abdcfd31f3814e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971956Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

ce22ad10

Vulkan: Switch viewport and scissor to dynamic state · 851fbedb

authored Jun 10, 2021

Heavily based on http://crrev/c/1316888

Some apps are creating a large number of viewport combinations and
are running out of graphics memory. This CL drops their graphics
pipeline use from tens of thousands to tens.

Performance testing shows little impact to application traces.

Bug: b/190026813
Bug: angleproject:3143
Change-Id: Ib7415be1128f8fedae4a7ca72e067b2815201223
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954925Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

851fbedb

Ensure GLES1 state is cleared on context switch. · 4e1fd371

authored Jun 17, 2021

GLES1 support in multi-context D3D mode is broken prior to this
change as state in the GLES1Renderer is not being properly
dirtied on context switch. The immediate result is a crash on
draw commands due to a null program.

Introduce a new dirty bit to specify that the program is dirty
and should be re-initialized.

Test: GLES1 applications work with the D3D11 backend in multi-context
mode.

Bug: b/191158936
Change-Id: Ib53c1471514ff2cf36ef9fc0d6bfb99a8bb7cf66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2969789Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Doug Horn <doughorn@google.com>

4e1fd371

Roll SwiftShader from 84bc198202e5 to 4a304244dd86 (4 revisions) · d5e86bb0

authored Jun 18, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/84bc198202e5..4a304244dd86

2021-06-18 mikko.tiusanen@siru.fi Skip wait on already signalled timeline semaphore
2021-06-18 jari.komppa@siru.fi Remove assert to enable indexless access chains
2021-06-17 sugoi@google.com Increase maximum framebuffer size
2021-06-17 pkasting@chromium.org Fix -Wdeprecated-copy.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Id4f71546f99ca3633a7f9a6c02354a25d6cb148d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2970673
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d5e86bb0

Roll vulkan-deps from 7304bd043edc to 65149e19efd9 (8 revisions) · 910fce1a

authored Jun 18, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/7304bd043edc..65149e19efd9

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/71612a7e5d..b38100f6bc
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/bcf55210f1..07f259e68a
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4d22f58a81..bcef913745
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ec76459d6f..a680671d95
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ae3d0c3217..16db450293

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Idae09b2ee1e3a631391cdcf813cccc131fc54d60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2970618
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

910fce1a

Roll Chromium from 681ec5b77d1d to 4c77f83b612d (360 revisions) · f6efb013

authored Jun 18, 2021

https://chromium.googlesource.com/chromium/src.git/+log/681ec5b77d1d..4c77f83b612d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8a2885963d..11f1e3d2cd
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/b97bee9f24..965c815e32
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/816daa2545..ea5c2c2838
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2573cff725
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/74ef838a40..59140d436a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/66b4484319..0e774456f5
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/657824459c..a61c45df6b
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ic1e6b2b37b1fa47508d8623e276bdeb3395602a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2970925
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f6efb013

Vulkan: Free DynamicBuffer buffers after dip in allocation size · 24155b13

authored Jun 17, 2021

In a pattern like this:

- allocate 100 bytes
- allocate 200 bytes
- allocate 50 bytes
- allocate 100000000 bytes
- allocate 100 bytes
- allocate 200 bytes
- allocate 50 bytes

The DynamicBuffer class switches to making 100MB allocations even if
that allocation was a one-off.  A small future allocation would then tie
up 100MB in memory for future allocations.  Another 100MB is also left
tied up in the free list.

With this change, if an allocation is made that's less than a quarter of
the DynamicBuffer's current allocation size, it's taken as a sign that
the previous large allocation was a one-off and the size is moved back
to the DynamicBuffer's original initial size.

Bug: b/187757166
Change-Id: I0c6f00eec7c81298f9dc41a41cc308510ce76623
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971004Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

24155b13

17 Jun, 2021 3 commits

CL: Refactor info structs and fix conformance bug · 69562546

authored Jun 11, 2021

- Remove variable name prefix from Info structs to be more consistent
  with other ANGLE structs.
- Fix CL object validation check with magics, since the Mesa solution
  doesn't work without RTTI.
- Add support for some extensions required by OpenCL 1.1 and for some
  optional extensions.
- Fix more conformance bugs.

Bug: angleproject:6015
Change-Id: I41b1c45d95059a9994f5dc78bf9b74476cc6f2d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2956349
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

69562546

Disable ANGLE's VK backend on official Chrome Android builds. · dc334829

authored Jun 17, 2021

ANGLE's VK backend induces a memory and binary size regression due to
global initializers in glslang/spirvtools. Disable it on Android Chrome
official builds.

Bug: chromium:1172451
Change-Id: I08d77cf11e20b393c0faf7c85d08c92061e5a09b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2969385Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

dc334829

Roll vulkan-deps from 734228fd0093 to 7304bd043edc (5 revisions) · 97fca0c6

authored Jun 17, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/734228fd0093..7304bd043edc

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a23e143636..71612a7e5d
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/f1f5bdbd1b..ec76459d6f
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/adb3eb0e78..ae3d0c3217

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I2f4effc6a35486f3eaa7440486ba0ee4ea08bc51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2967886
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

97fca0c6