Assign new bug ID for clean-up work. It appears that the
UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset
error was already fixed.

Bug: b/166641492
Change-Id: I536017e0386cf5f57bb53bcba32d5df048050343
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380510Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

These tests were recently added, and fail on the Metal backend.

Bug: angleproject:4996
Change-Id: Iadffa25ab5b6c1372874c82f8356f7f19c76d1e0
TBR=jmadill@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380244Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Utility function roundUpPow2 is more optimal than roundUp so use it.

Bug: b/166462979
Change-Id: I616fa9f487b818137b1b496d93e292c3bd1f428c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377119Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

The nested_array.*sampler2D_* tests can pass on Mali with disabled
forceOldRewriteStructSamplers.

Test: dEQP-GLES31.functional.uniform_location.nested_array.*sampler2D_*
Bug: angleproject:2703
Change-Id: I34368d6ce14b81e873e2a3d60a73da4a8a866884
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377627
Commit-Queue: Amy Liu <Amy.Liu@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7a71abb602a2..cac2574c240a

2020-08-26 locke@lunarg.com layers: Get imageview from imageless framebuffer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I0e78a36cfff84f883219601b62f516970bbbdd97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377077Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/834673eaa34a..ced848d699b5

2020-08-26 oddhack@sonic.net Update for Vulkan-Docs 1.2.152

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Id9950d584ada693a8a1a12699345706b725bbc2a
Bug: None
Tbr: courtneygo@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2379233Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/94ee680cab4c..11fcbbf5d7cc

2020-08-27 alexander.galazin@arm.com Merge pull request #223 from jpark37/colorspace-common-instance

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC courtneygo@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com,angle-bots+autoroll-info@google.com
Change-Id: I27f7fba863ee772efa2edb143d10a99099a853c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2379234Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e1c7eaa74142..0654095b63fb

2020-08-26 lenny@lunarg.com repo: Prevent cmake name mismatch warning
2020-08-26 rharrison@google.com Fix formatting
2020-08-26 rharrison@google.com Move variables into scope they are referenced within

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I9549c05967e687f230258c06e91bb70f2a0cfb02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377081Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2205254cfb50..bceab9fab4bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I7ea2bad1481eafeb1a06963680015c310c8fa165
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377079Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/983698bb34ec..517f39eee46f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I27a71506052a5cd1eca7ad48d4f13a3692976008
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377080Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/dda8dabe9eb3..c472fa2f0330

2020-08-26 nathbappai@gmail.com cube: satisfy clang-format
2020-08-26 nathbappai@gmail.com vulkaninfo: Check if NOMINMAX is already defined
2020-08-26 nathbappai@gmail.com cube: Check _MSC_VER instead of _WIN32 for pragma directive
2020-08-26 nathbappai@gmail.com CMake: Check MSVC while deciding MSVC_VERSION

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I42b2ba08ec405a0857ce7939f19e90ecb81a4b88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377076Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/622558b02e1a..1f48854dae26

2020-08-26 capn@google.com Refactor image extent retrieval
2020-08-26 capn@google.com Refactor image view extent retrieval
2020-08-26 capn@google.com Refactor image query instructions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ib1dbbab2d4cabe177b7330c0b0edee5370546c5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377078Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This reverts commit 3c2454b8.

Reason for revert:
Causes rendering issues in Manhattan 3.1.

Original change's description:
> Vulkan: Only count descriptor set resources once
> 
> The descriptor set resource counts for monolithic programs already have
> all of the counts combined for all shader stages, rather than needing to
> loop through and combine them all like program pipeline objects.
> 
> Bug: angleproject:3570
> Test: CQ
> Change-Id: Ib8a2fe7af991a8d9d5edcef346352c7bac0703fd
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375869
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Tim Van Patten <timvp@google.com>

TBR=courtneygo@google.com,timvp@google.com,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3570
Change-Id: I4150d5adf65ace293cb08876e4a62ae3216096b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378564Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

Perf warnings added in the CPU path for unpack buffers, as well as CPU
readback of images.

Bug: angleproject:3461
Bug: angleproject:4900
Change-Id: I0f716a1ea6110ba8e779903a7d5913d5f6df0ce9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376905Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Add test coverage of multi-plane IOSurfaces.

Bug: chromium:1115621
Change-Id: Ib2150c4221a3e49f01ab016cebba4830194ab2b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376174Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Bug: skia:7647
Change-Id: I6bb33a98d69400c9d95fb9d028d29a3e470067e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377291Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: skia:7647
Change-Id: I3664355d183c1aec87ffd35ab23f594cdd1766c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376716Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Suppressions were missing for several texture formats. This slipped
through  because angle_end2end_tests are not run on SwANGLE on Mac.

Bug: angleproject:4369
Change-Id: I0cbafe5daab591da15f86f2658c4edc724ae2561
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364190Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

TRex invalidates depth but doesn't disable depth before the render
pass ends.  The render pass isn't ended, but a storeOp of STORE was
used instead of DONT_CARE, which causes a performance regression.

Bug: b/163854287
Change-Id: Iebd9999ef66c11ff334db3eef2943f58eb2d5053
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377105Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fb86cfb19849..94ee680cab4c

2020-08-21 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4
2020-08-20 alexander.galazin@arm.com Allow Vulkan CTS 1.2.4.0
2020-08-20 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-08-20 chrgau01@arm.com Fix incorrect buffer type in some protected memory tests
2020-08-20 tzlatinski@nvidia.com Fix Image layout transitions for diff_attachments_*
2020-08-20 venni.ihanakangas@siru.fi Fix creation of signaled fences in swapchain tests
2020-08-18 peter.quayle@imgtec.com Disable interval watchdog during long shader compiles
2020-08-14 anholt@google.com gles2: Add temporary constant-data shader indexing tests.
2020-08-14 vkushwaha@nvidia.com Add tests for floating-point atomic operations
2020-08-13 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC courtneygo@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com,angle-bots+autoroll-info@google.com
Change-Id: I9cf79e76d876ad0359c0d37923a664154d1fe9b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377407Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/431d6e57284a..065e739079d9

$ git log 431d6e572..065e73907 --date=short --no-merges --format='%ad %ae %s'
2020-08-26 jmadill Suppress two override suggestion warnings.
2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK.
2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them.
2020-06-25 thakis Fix argument order for aligned_alloc on mac.
2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK.

Created with:
  roll-dep third_party/vulkan_memory_allocator

Bug: skia:7647
Change-Id: Ia87c1c2d47547c170ab1f9a3bc84825b1716337d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376892Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12df3cafeee0..2205254cfb50

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I8ce381fe7b7d11c15aa9fbcae7da4ecc977e5ed4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377647Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e798df982b1b..7a71abb602a2

2020-08-26 locke@lunarg.com tests: Check shader feature enable
2020-08-26 locke@lunarg.com layers: Add has_atomic_descriptors
2020-08-25 s.fricke@samsung.com tests: Add ProtectedSubmitInfo VUs
2020-08-25 s.fricke@samsung.com layers: Add ProtectedSubmitInfo VUs
2020-08-25 s.fricke@samsung.com layers: Label bind2 protected VUs
2020-08-25 s.fricke@samsung.com layers: Label import fence VUs
2020-08-25 s.fricke@samsung.com layers: Label ValidateFenceForSubmit VUs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: If9d99d2e6d56e1983168a1e6b1d1442312c3dd97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2377509Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

gfxbench clears the depth buffer right before the swap. Even though the
last draw call that presents the frame didn't ever read or write to
depth, the tracking we added thought this depth write meant we had to
keep the LOAD_OP as CLEAR. Instead we can refine our check to treat
clears specially when enabling the depth-stencil read-only mode instead
of changing how the tracking works for clears. This way the tracking
can not affect other apps that don't use depth-stencil read-only loops.

Also adds a regression test that counts the clears after a swap.

Bug: angleproject:4959
Bug: angleproject:4979
Change-Id: I12ece6474019f7519a467f827110ad817f7d4df7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2370364
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

The descriptor set resource counts for monolithic programs already have
all of the counts combined for all shader stages, rather than needing to
loop through and combine them all like program pipeline objects.

Bug: angleproject:3570
Test: CQ
Change-Id: Ib8a2fe7af991a8d9d5edcef346352c7bac0703fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375869Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

ResourceUseList::add is called repeatedly when we need to
track a resource's usage in a context. Instead of a
potential memory operation on each add we reserve memory
upfront for about 4k SharedResourceUse objects. If the
vector grows larger, it will be automatically handled by
std::vector's allocator.

Bug: angleproject:4950
Change-Id: Ic85ed44a6662819621ee9a47f43dd2542b73114d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375801Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

- Metal's built-in blit based mipmap generator doesn't use box
  filtering. Hence manual generation using compute is needed.

- Compute based mipmap gen can generate up to 4 mips per pass if the
  base level is power of 2.

- This approach can be extended to 2D/cube texture's mipmap generation
  in future.

Bug: angleproject:4921
Bug: angleproject:2634
Change-Id: I7f997669fe39afef075b2bca2406e9424cbb3016
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336120Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>

This regressed in "Vulkan: Preserve RPs on XFB changes when possible."

The bug manifested as incorrect fire rendering in Manhattan. The fix is
to ensure we dirty the correct buffer state when we call endXFB. Also
adds a regression test.

Bug: b/161744596
Bug: angleproject:4622
Change-Id: If16cc22b149526950f300e74c0cc82c0fefae5bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368016Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Fix is now upstreamed, we can remove the workaround.

This reverts commit 2ba626dc.

Original CL message:

> dEQP was inadvertendly requiring the presence of these extensions to
> even run the tests. There's a WIP fix to the dEQP tests and this CL
> implements that fix as a temporary workaround until we can update dEQP.

> Fixes several tests in KHR-GLES31.core.constant_expressions and
> KHR-GLES31.core.shader_macros. They now correctly return unsupported.

Bug: angleproject:4143
Change-Id: I4001b30ab609ac4c9be2ce06c2d3c0dca75b64e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375965
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

Currently ProgramExecutableVk::mDescriptorSets is a vector, but it's
size is bound so it can be a std::array (DescriptorSetLayoutArray).

To ensure the size grows correctly in the future, the various descriptor
set indexes are also being converted from independent constexpr
uint32_ts into the enum DescriptorSetIndex.

Bug: angleproject:4898
Test: CQ
Change-Id: I7ae8ff3455bcfb61e24b73bd16cc3f8cf9873087
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372664Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

This CL refines the feedback loop check to allow rendering to non-
sampled levels of currently bound textures. This is a technique
sometimes used to initialize a mip chain of a texture.

Also adds a regression test that fails on Vulkan.

Bug: angleproject:4500
Bug: angleproject:4690
Change-Id: I5fd370e36a2919c82170abcbd2b0897c075bdcc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2367314
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

CommandBufferHelper will keep a pointer to the depth-stencil
RenderTargetVk, and use this to set RenderTargetVk::mContentDefined to
true at the end of a render pass.

Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.InvalidatingAndUsingDepthDoesNotBreakRenderPass/*
Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkan
Bug: b/163854287
Change-Id: I891381825ee01e141dfa4f9099d07d9ffc943f77
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368194Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Using KHR_debug features, this change creates a
performance-warning-generation macro and employs it in a handful of
locations to provide useful feedback to application developers.

The warnings added in this change are not exhaustive.

Bug: angleproject:3461
Bug: angleproject:4900
Change-Id: Id62435d170d90c5be9c1c5cab2d6779ccb58345e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372628Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

ASAN bot caught bug in FastIntegerMap.BasicUsage test.
The end() iterator points past the end of the list, accessing
end()->first is invalid. rbegin() points at the last element of the
list which is what this test intended.

Bug: b/166255370
Change-Id: I06e098143d3de9658088cda6f10761d41b17a520
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375305Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

Just like invalidate, this should attempt to sync the framebuffer after
nooping incomplete framebuffers.

Bug: chromium:1119669
Change-Id: Ie4bc6211bbeb1765674f7e0aef884faf7ceb8cc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375565Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

These tests are frequently cloned to make new tests, and so it's good
to do a more-global refactor so that these and future tests will use
RAII.

Bug: angleproject:4947
Change-Id: I2973e70ee075629965b18c685793975537e96b6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372627Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

vkQueueSubmit already performs this operation, so this barrier was
unnecessary.

The only place this is necessary is when the GPU is expected to receive
updates from the CPU post-submit.  ContextVk::synchronizeCpuGpuTime is
the only such use-case in ANGLE.

Bug: angleproject:4897
Change-Id: I7297fbd65d3faabd949dddb6bcaa181053a83193
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372631Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This was only used for one ASSERT, which is changed to use a correlated
variable.

Bug: angleproject:4959
Change-Id: I0eccd2c06c52fcfbff4c533e661735bf1213125d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2371222
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

USE_X11 && USE_OZONE build is a new config for
Chromium/Linux that is going to be enabled soon.
However, it breaks angle tests for Linux bots that
run these tests. Atm, we don't support Wayland
in angle anyway, and always falling back to X11
is the right thing to do.

However, it's a bit strange to return false in
IsOzone for USE_X11 && USE_OZONE case, but it's
something we can do now to unblock switching
Chromium to use_x11 && use_ozone config for
Linux and resolve the problem later.

Bug: angleproject:4977
Bug: chromium:1085700
Change-Id: Id223110cc504d8a4faa38608a96338a297a8cfc3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2367856Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This was featurized as a workaround for Intel/Windows drivers that did
not render flipped in comparison to GL per Vulkan spec.  This issue has
long since been fixed, and due to missing parentheses the feature was
accidentally unconditionally true for a long time already.

Bug: angleproject:4896
Change-Id: I1db55d298bd47df649ff1f03d287d0cfa7453ea7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372632Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>