Commits · 166dd0c75cbf82c8565904693efe1aee56767e44 · Chen Yisong / angle

10 Jun, 2021 11 commits

Roll chromium_revision 6c5859c895..399855f4bb (890175:891326) · 166dd0c7

authored Jun 10, 2021

Manual changes:
1. Fix generate_test_spec_json.py to correctly handle ADDITIONAL_MIXINS
   Needed after angle_skia_gold_test mixin removed from Chromium in
   crrev.com/890333
2. Copy third_party/logdog from Chromium
   Needed after crrev.com/890539 in order to create isolates on Android
   and for tools/perf/process_perf_results.py

Change log: https://chromium.googlesource.com/chromium/src/+log/6c5859c895..399855f4bb
Full diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8870cb4120..2192a63c23
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c793cca886..9d8449e380
* buildtools/linux64: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa
* buildtools/mac: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7e3b76855b..2c53623d59
* buildtools/win: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a62f8260df..ab567bcc84
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7949d87093..bd17c406ba
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/887e8d9009..fa47598982
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/1cfc90728e..816daa2545
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17cf72ca75
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b508ecd932..6d099d543d
* third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/19f3fad68d..e9be5fd6d7
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/82f8803671..f4241bd0f2
* third_party/turbine: _iPtB_ThhxlMOt2TsYqVppwriEEn0mp-NUNRwDwYLUAC..Om6yIEXgJxuqghErK29h9RcMH6VaymMbxwScwXmcN6EC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/09481f56be..fd14318cc9
* tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968
* tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968
* tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/94630dfc19..12c8fa872b
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5c84710692..2e6477d751
DEPS diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb/DEPS

Clang version changed llvmorg-13-init-11999-g50c0aaed:llvmorg-13-init-12491-g055770d5
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/09481f56be7b1bbaf5a466be5d81691902825fcf..fd14318cc948b67e5ec8a0f2f7563142ccd6dac2/scripts/update.py

Bug: angleproject:4483, angleproject:6037
Change-Id: I9035126bce55642d4dfce54eeace85093bdd1782
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954241Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

166dd0c7

Roll VK-GL-CTS from d17a353c6cd4 to 7f2ec8531b64 (15 revisions) · ac704c80

authored Jun 10, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d17a353c6cd4..7f2ec8531b64

2021-06-10 siglesias@igalia.com Check resource limits properly
2021-06-10 rgarcia@igalia.com Capture early errors on instance creation
2021-06-10 ilkka.saarelainen@siru.fi Add depth execution mode tests
2021-06-10 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-06-09 rgarcia@igalia.com Test instance matrix update after command recording
2021-06-09 rgarcia@igalia.com Test null miss shader group handles work
2021-06-09 rgarcia@igalia.com Test tracing rays from inside AABBs
2021-06-09 siglesias@igalia.com Fix wait semaphore count value
2021-06-09 marcin.kantoch@amd.com Fix internal error for fragment stage in RT tests
2021-06-09 alexander.galazin@arm.com Add GL_ARB_separate_shader_objects requirement
2021-06-09 alexander.galazin@arm.com Raise glsl version to 420 for compute shaders
2021-06-09 alexander.galazin@arm.com Raise glsl version to 410 core for shaders with GL_ARB_shader_atomic_counters
2021-06-09 alexander.galazin@arm.com Remove shaders.switch from the Khronos mustpasses
2021-06-07 zzyiwei@google.com Add a test for VK_EXT_global_priority_query
2021-06-07 alexander.galazin@arm.com Update Vulkan headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com,angle-bots+autoroll-info@google.com
Change-Id: Iac5faae807430cb114617f77543768ea6047f3a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953060Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ac704c80

Declare specialization constants in the AST · 31641b8e

authored Jun 05, 2021

A new qualifier (EvqSpecConst) is added so that specialization constants
can be declared in tree.

This enables TVariable references to specialization constants to be
validated, which were in fact invalid as every reference declared a new
variable.  That is fixed.

Bug: angleproject:4889
Change-Id: I1711e41cbc5a1260843d2d004d3568bdae11e963
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2941451Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

31641b8e

CL: Add program build commands · 82654e5d

authored Jun 06, 2021

Add program build commands to front end and pass-through back end.

Bug: angleproject:6015
Change-Id: I1175646d35ff050796b718d7f0e269520292b319
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940839
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

82654e5d

Use Chromium mirror of tools/perf. · 5fd72bd3

authored Jun 10, 2021

This will keep ANGLE in sync with Chromium changes and reduce the
maintenance burden.

Bug: angleproject:6037
Change-Id: Ibed4031d8cb3468e6be6501bda21404c42fb2be6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953043Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

5fd72bd3

CL: Add image enqueue commands · 2e772e04

authored Jun 04, 2021

Add image enqueue commands to front end and pass-through back end.

Bug: angleproject:6015
Change-Id: I133e84020975679fafd29432c965cd19f086d2b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940837Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

2e772e04

[Fuchsia] Cleanup vulkan_fuchsia_ext.h · c670917c

authored Jun 02, 2021

Removed defintions of fuchsia-specific vulkan types from
vulkan_fuchsia_ext.h . Instead, the types provided by vulkan_fuchsia.h
are used now.
Also re-enabled vulkan validation on Fuchsia.

Bug: chromium:1215736
Change-Id: I795347b7fb61d90033749533cefd42cf180730fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2934718Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c670917c

Roll vulkan-deps from 4d0e65d25f37 to d19e20ee6d7d (4 revisions) · 9b142b64

authored Jun 10, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/4d0e65d25f37..d19e20ee6d7d

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3d935ea224..fe15158676
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d07505c761..bbc660edab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ic216efdfdd40d3bafd3f74c3494400592aa3abb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950831
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9b142b64

Roll SwiftShader from 5ecc95a00e2b to 81ba5f47b66c (1 revision) · 2a42e869

authored Jun 10, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/5ecc95a00e2b..81ba5f47b66c

2021-06-10 srisser@google.com Prevent BC6h decoder from using global constructor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ie5c73bca485ecc3809c0b1f9a7d73082f400b86f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2952621
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2a42e869

test/ImageTest: Clear back buffer when test cleanup · eb882040

authored Jun 08, 2021

Many tests don't actually use the back buffer, so uninitialized data
is used when capturing leading to failure. Hence, clear the back buffer
when the test ends and before swap is called triggering the capture.

Bug: angleproject:6035
Change-Id: I0a500ae9f5203feaf0b492dc18e84c5a92ee1497
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944953Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>

eb882040

Vulkan: SPIR-V Gen: Default uniforms · d769742c

authored Jun 03, 2021

Default uniforms are gathered in a uniform block, so treat them like
other nameless uniform block fields.

Bug: angleproject:4889
Change-Id: If340040ab4c59f3243c40de7daba530b2289e147
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939333Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d769742c

09 Jun, 2021 4 commits

Roll Chromium from 3bcc8fd7c291 to 6c5859c895f5 (510 revisions) · 7108e069

authored Jun 08, 2021

https://chromium.googlesource.com/chromium/src.git/+log/3bcc8fd7c291..6c5859c895f5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e353b02625..8870cb4120
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0b443d31ef..c793cca886
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a45949a818..a62f8260df
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/42884eb2ac..887e8d9009
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d598390f02
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5b6b2f8b7..b508ecd932
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/9523daa51d..82f8803671
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0c64e8349d..09481f56be
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5d794a9f5..94630dfc19
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/71214b910d..84ad259424
No update to Clang.

Manually added tools/android/modularization/convenience/lookup_dep.py
from crrev.com/889754
And updated .gn to use python3 in GN build by default

Bug: angleproject:6042
Tbr: syoussefi@google.com
Change-Id: I00384f4d38d14b54778d334aec9c633f54d619bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946825Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

7108e069

Capture: Add a specialization for TGLeglImageOES · cb4f8a79

authored Jun 08, 2021

When writing out the parameter TGLeglImageOES an additional cast is
needed.

Bug: angleproject:6036
Change-Id: I7470a58a6ae17b0185d0c2e3fe1184b698f3efaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944952Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>

cb4f8a79

Fix -Wc++11-narrowing in ANGLE. · 19209666

authored Jun 09, 2021

This adds a few explicit casts where necessary and changes some double
constants to floats to avoid truncation.

Bug: chromium:1216696
Change-Id: Ie1a3ad94284185fb20a6feff75290cabb7ee09e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950320Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

19209666

Roll vulkan-deps from 11d5b8e51262 to 4d0e65d25f37 (13 revisions) · 87b8d32a

authored Jun 09, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/11d5b8e51262..4d0e65d25f37

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1fa21491bc..3d935ea224
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/87a2867976..d07505c761
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3ae088978f..1021540dc2
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/46de0cdb74..b82d4bc692

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I96591b5d42b648f807d185d07ae4d1da825d3fea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2948447
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

87b8d32a

08 Jun, 2021 19 commits

Vulkan: Expose OES_geometry_shader extension · 69f2fb00

authored Mar 08, 2021

Modify the symbol table generation script to accept a list
of supported extensions. This allows for the EXT and
OES versions of the geometry shader extension to be exposed.

Test: angle_deqp_khr_gles31_tests --deqp-case=*geometry_shader*
Bug: angleproject:3571
Change-Id: Ia7127a03dbd3fce78957f0505d3ce0c9bab6cb15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765011
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

69f2fb00

infra: Reduce sharding on GLES3 GL/Metal tests. · c778f93f

authored Jun 07, 2021

Bug: None
Change-Id: I56593374d027db20a5ed0ebf09ca2210e219f244
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945431
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

c778f93f

Vulkan: SPIR-V Gen: Support function forward declaration · ac2fc259

authored Jun 03, 2021

The generation of function-related ids is moved to
visitFunctionPrototype to support forward declarations.  The
DeferGlobalInitializers AST transformation produces such code.

Bug: angleproject:4889
Change-Id: Iefee534575092ca25ff86e416e35703d7022bc07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939332
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ac2fc259

Translator: Allow invariant on I/O block members · 013613ea

authored Jun 08, 2021

The GLSL ES 3.2 spec says:

> Only variables output from a shader can be candidates for invariance.

And:

> All uses of invariant must be at global scope or on block members, and
> before any use of the variables being declared as invariant.

As a result, it's possible to specify `invariant` on a member of an
output I/O block.

Bug: angleproject:4889
Change-Id: I8822ed214813db8424d6a67dfef7f069a448b19d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946115Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

013613ea

Vulkan: Fix AGI hierarchy for clear commands · 4bafc503

authored Jun 01, 2021

Treat mid-render-pass glClear* commands the same as glDraw*
commands, generating a hierarchy.  This results in
vkCmdClearAttachment commands being nested under glClear, instead of
being a peer of glDraw* commands.

Bug: b/183547523
Change-Id: Ibc6900b0485fd174d79c8fe6c94ea17dbefa520b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2941364Reviewed-by: Mark Lobodzinski <mark@lunarg.com>
Reviewed-by: Mike Schuchardt <mikes@lunarg.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

4bafc503

D3D11 additional context-loss logging · 7c253fca

authored Jun 02, 2021

This makes logging more consistent when we encounter context loss.

In Renderer11::testDeviceLost, note DXGI_ERROR_INVALID_CALL is a
valid GetDeviceRemovedReason, but was not detected prior.

SwapChain11::resize and SwapChain11::reset added more logging,
likewise with Context11::handleResult.

This covers everywhere d3d11::isDeviceLostError is invoked, though that
might not be exhaustive of all cases we detect device loss.

Bug: b/188291915
Test: Manually trigger conditions to test logging.
Change-Id: Idd57363101b53bc2d3c4c306ee78a42012a1a320
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2935696Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Doug Horn <doughorn@google.com>
Commit-Queue: Michael Yu <warty@google.com>

7c253fca

Translator: Validate global qualifier declaration's symbol · df977aaf

authored Jun 08, 2021

Global qualifier declarations (invariant, precise) apply to
already-declared variables.  This is now validated.

Bug: angleproject:4889
Change-Id: I9889f2d68dcd6a2fc0de2b20a1291899397982d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946114Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

df977aaf

Docs: Update CONTRIBUTORS with LunarG info · 1b2000f5

authored Jun 07, 2021

Add LunarG, Inc. and Mark Lobodzinski to the CONTRIBUTORS file
and LunarG, Inc. to the AUTHORS file.

Bug: None
Change-Id: Id3f9ff2075498532280d4a652a5fffa85dd77f45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945696Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

1b2000f5

Vulkan: SPIR-V Gen: Support initializers in declarations · 0c26ff11

authored Jun 03, 2021

If the initializer is a constant, it's specified directly in the
OpVariable instruction.  Otherwise an OpStore is generated where the
declaration is visited.

Bug: angleproject:4889
Change-Id: I79291552ecc50c0878f921aff9f6d8618be34116
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939331
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0c26ff11

Use float clamp unconditionally for indirect index clamping · c3e397c6

authored Jun 07, 2021

Suspecting a Qualcomm driver bug with integer clamp affecting WebGL2
tests.

Bug: chromium:1217167
Change-Id: I6b323a9de5828b3a11cbe2650d66c7627b90a9f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946111Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c3e397c6

Roll SwiftShader from 3da42a3a2cd6 to 5ecc95a00e2b (1 revision) · d6f344c2

authored Jun 08, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/3da42a3a2cd6..5ecc95a00e2b

2021-06-08 swiftshader.regress@gmail.com Regres: Update test lists @ 3da42a3a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I8f127154cac665383aa2d776709b801c20b3b22e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946992
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d6f344c2

Vulkan: SPIR-V Gen: Basic support for compute shaders · 6746e5dd

authored Jun 01, 2021

This change enables direct SPIR-V generation for compute shaders and
enables a few tests.  A handful of built-in functions are translated to
support said tests.

Bug: angleproject:4889
Change-Id: I8fd6dc50ff31559a738ba680a993fb197e29fcf9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939330
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

6746e5dd

Capture: Create group variable for BlockMemberInfo · 1ab6d214

authored Jun 07, 2021

Also declare GroupScope as NO_DISCARD.

Bug: angleproject:6016
Change-Id: I738f137727d52a0930cd8c400fbc05f1cc8cfdad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2943927
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1ab6d214

Vulkan: SPIR-V Gen: Function calls · ee4a5266

authored Jun 01, 2021

This change implements function calls.  As a result, transform feedback
tests are enabled as well as support for transform feedback emulation
(which contains functions and if blocks).

`const` and opaque uniform function arguments take intermediate values,
while the rest take memory objects.  If the argument being passed is an
unindexed lvalue, it can be directly given to the function.  Otherwise a
temporary variable is made which is initialized by the parameter if
necessary (in and inout parameters) and later overwrites the parameter
if necessary (out and inout parameters).

Bug: angleproject:4889
Change-Id: I8976cdd17870c35d5a2daeed3c38de57ada931d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2930363
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ee4a5266

Serializer: Print FBO attachment name instead of a number · c1932fb5

authored Jun 07, 2021

Bug: None
Change-Id: I419a0ca6d1c2e3c47dc84b106baf40dc0abb85cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2943930
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c1932fb5

infra: Add flaky retries to Metal GLES 3 tests. · 3bc28a27

authored Jun 07, 2021

These have been somewhat flaky on the waterfall.

Bug: angleproject:6019
Change-Id: I4d76411ab54ad5fbfb9c49775c44a12b99def846
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945430
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

3bc28a27

Gold Tests: Fix flaky test handling. · d99864c0

authored Jun 07, 2021

Indead of just retrying the batch, retry individual tests.
This should correctly handle the Intel flake pattern.

Bug: angleproject:5415
Change-Id: I029c2514ff8e7a45184c5c105bf2d0350171da29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940049
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

d99864c0

infra: Don't run trace tests in perf smoke tests. · f03f7bdb

authored Jun 07, 2021

These test were already being run more safely in the gold tests step.

Bug: angleproject:5977
Change-Id: I4fb1062926fcda19384835723555d0fab0b42aae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939469Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f03f7bdb

infra: Override Gold mixin. · 2917ab34

authored Jun 07, 2021

This mixin is being removed from the Chromium version of the mixins.
Therefore we have to move it into the additional mixins option of the
generator.

Bug: angleproject:6037
Change-Id: I605b7cbf35d6282754bf5fb26246e32b2edcea10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939466Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2917ab34

07 Jun, 2021 6 commits

Vulkan: Submit Dispatch commands outside renderpass · 0a6c6c00

authored Jun 01, 2021

Compute dispatch commands must be submitted outside a renderpass,
but their associated debug event markers were being submitted
on the renderpass commandbuffer. The dispatch debug event markers are
now handled separately from those for draw calls and are now submitted
on the correct commandbuffer.

Failure manifested in malformed AGI traces for Ragnarok M:
Eternal Love

Bug: b/181611786
Change-Id: I768eeccd76be38818fc99d6d56f5899290c8fc5b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2930818Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

0a6c6c00

Lift OpenGL Win/Intel test expectation. · 052713da

authored Jun 07, 2021

This was fixed in a prior patch.

Bug: angleproject:5444
Change-Id: I6df4b71b8dabd66eb151d94d757f89d88a864dab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939468
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

052713da

Tests: Skip genshin_impact on Intel Linux · 7231c705

authored Jun 07, 2021

Bug: angleproject:6029
Change-Id: I2f25dcedf36d9f341d134baeb9752fb3e3aada6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944621Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

7231c705

Roll vulkan-deps from 95b967c506f6 to 11d5b8e51262 (5 revisions) · bb6e12a3

authored Jun 07, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/95b967c506f6..11d5b8e51262

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6d5c5677e1..87a2867976
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/7fe877c90a..07c4a37bcf
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/34ee418b3a..46de0cdb74

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ib38948aad433ec022a3d551bfc85f5d4c89dd5d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944220
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bb6e12a3

Roll vulkan-deps from 7fd6569e6ad3 to 95b967c506f6 (3 revisions) · b20581b9

authored Jun 07, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/7fd6569e6ad3..95b967c506f6

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6bdcb4be34..1fa21491bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I75895dc7986e207cd69522e8a0fb182a5e9db66a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2942471
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b20581b9

Roll SwiftShader from efe254de5d88 to 3da42a3a2cd6 (1 revision) · 2d72c99f

authored Jun 07, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/efe254de5d88..3da42a3a2cd6

2021-06-07 swiftshader.regress@gmail.com Regres: Update test lists @ efe254de

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I9bf9af0182722b3b065222f55eaf410bb44ff8ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944667
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2d72c99f