Fix is now upstreamed, we can remove the workaround.

This reverts commit 2ba626dc.

Original CL message:

> dEQP was inadvertendly requiring the presence of these extensions to
> even run the tests. There's a WIP fix to the dEQP tests and this CL
> implements that fix as a temporary workaround until we can update dEQP.

> Fixes several tests in KHR-GLES31.core.constant_expressions and
> KHR-GLES31.core.shader_macros. They now correctly return unsupported.

Bug: angleproject:4143
Change-Id: I4001b30ab609ac4c9be2ce06c2d3c0dca75b64e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375965
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

Currently ProgramExecutableVk::mDescriptorSets is a vector, but it's
size is bound so it can be a std::array (DescriptorSetLayoutArray).

To ensure the size grows correctly in the future, the various descriptor
set indexes are also being converted from independent constexpr
uint32_ts into the enum DescriptorSetIndex.

Bug: angleproject:4898
Test: CQ
Change-Id: I7ae8ff3455bcfb61e24b73bd16cc3f8cf9873087
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372664Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

This CL refines the feedback loop check to allow rendering to non-
sampled levels of currently bound textures. This is a technique
sometimes used to initialize a mip chain of a texture.

Also adds a regression test that fails on Vulkan.

Bug: angleproject:4500
Bug: angleproject:4690
Change-Id: I5fd370e36a2919c82170abcbd2b0897c075bdcc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2367314
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

CommandBufferHelper will keep a pointer to the depth-stencil
RenderTargetVk, and use this to set RenderTargetVk::mContentDefined to
true at the end of a render pass.

Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.InvalidatingAndUsingDepthDoesNotBreakRenderPass/*
Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkan
Bug: b/163854287
Change-Id: I891381825ee01e141dfa4f9099d07d9ffc943f77
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368194Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Using KHR_debug features, this change creates a
performance-warning-generation macro and employs it in a handful of
locations to provide useful feedback to application developers.

The warnings added in this change are not exhaustive.

Bug: angleproject:3461
Bug: angleproject:4900
Change-Id: Id62435d170d90c5be9c1c5cab2d6779ccb58345e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372628Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

ASAN bot caught bug in FastIntegerMap.BasicUsage test.
The end() iterator points past the end of the list, accessing
end()->first is invalid. rbegin() points at the last element of the
list which is what this test intended.

Bug: b/166255370
Change-Id: I06e098143d3de9658088cda6f10761d41b17a520
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375305Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

Just like invalidate, this should attempt to sync the framebuffer after
nooping incomplete framebuffers.

Bug: chromium:1119669
Change-Id: Ie4bc6211bbeb1765674f7e0aef884faf7ceb8cc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375565Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

These tests are frequently cloned to make new tests, and so it's good
to do a more-global refactor so that these and future tests will use
RAII.

Bug: angleproject:4947
Change-Id: I2973e70ee075629965b18c685793975537e96b6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372627Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

vkQueueSubmit already performs this operation, so this barrier was
unnecessary.

The only place this is necessary is when the GPU is expected to receive
updates from the CPU post-submit.  ContextVk::synchronizeCpuGpuTime is
the only such use-case in ANGLE.

Bug: angleproject:4897
Change-Id: I7297fbd65d3faabd949dddb6bcaa181053a83193
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372631Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This was only used for one ASSERT, which is changed to use a correlated
variable.

Bug: angleproject:4959
Change-Id: I0eccd2c06c52fcfbff4c533e661735bf1213125d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2371222
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

USE_X11 && USE_OZONE build is a new config for
Chromium/Linux that is going to be enabled soon.
However, it breaks angle tests for Linux bots that
run these tests. Atm, we don't support Wayland
in angle anyway, and always falling back to X11
is the right thing to do.

However, it's a bit strange to return false in
IsOzone for USE_X11 && USE_OZONE case, but it's
something we can do now to unblock switching
Chromium to use_x11 && use_ozone config for
Linux and resolve the problem later.

Bug: angleproject:4977
Bug: chromium:1085700
Change-Id: Id223110cc504d8a4faa38608a96338a297a8cfc3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2367856Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This was featurized as a workaround for Intel/Windows drivers that did
not render flipped in comparison to GL per Vulkan spec.  This issue has
long since been fixed, and due to missing parentheses the feature was
accidentally unconditionally true for a long time already.

Bug: angleproject:4896
Change-Id: I1db55d298bd47df649ff1f03d287d0cfa7453ea7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2372632Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4dd122392f3a..12df3cafeee0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ie63aa9a5c776770ac43cdcf798eec7faf6722b2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2374226Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/76e8dee41452..e798df982b1b

2020-08-25 locke@lunarg.com layers: Check NULL
2020-08-25 locke@lunarg.com tests: Test overlap and not overlap
2020-08-25 locke@lunarg.com layers: Fix wrong overlap check
2020-08-24 mark@lunarg.com tests: Add test for version-checked pNext structs
2020-08-24 mark@lunarg.com tests: Add TessDomainOrigin pnext version check
2020-08-24 mark@lunarg.com stateless: Version check pNext sTypes
2020-08-24 mark@lunarg.com tests: Fix FramebufferCreateErrors test
2020-08-24 mark@lunarg.com tests: Fix AndroidHwBufferDepthStencil test
2020-08-24 mark@lunarg.com tests: Fix error types for InvalidPipelineSamplePNext test
2020-08-24 mark@lunarg.com tests: Fix error types in message limit tests
2020-08-24 mark@lunarg.com tests: Fix error types for InvalidStructPnext tests
2020-08-24 mark@lunarg.com tests: Fix InvalidGetDeviceQueue invalid struct
2020-08-24 mark@lunarg.com tests: Fix TessDomainOrigin positive test
2020-08-24 mark@lunarg.com stateless: Fix sType check string comparison
2020-08-24 mark@lunarg.com stateless: Fix valid sType list for pMultisampleState pNext ptr
2020-08-24 s.fricke@samsung.com layers: Remove 03269 todo
2020-08-24 s.fricke@samsung.com tests: Add Depth/Stencil BufferImageCopy VU
2020-08-24 s.fricke@samsung.com layers: Add Depth/Stencil BufferImageCopy VU
2020-08-24 s.fricke@samsung.com layers: Add VkCommandPool to COMMAND_POOL_STATE
2020-08-24 s.fricke@samsung.com layers: Fix Descriptor ImageLayout check

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I388405c9186a540933c8d25c57a5bcd8073298f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2374348Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/eceb318c06a2..dda8dabe9eb3

2020-08-24 jmadill@chromium.org Bump mock ICD surface max extents.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I35ddd35aeedb4e33a155ceefe359ed37a5e5d172
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2374347Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

RAW hazards were being tested for if the layouts were identical, but
that's impossible.

Bug: angleproject:4911
Change-Id: I73f568b1df2cbffe943217e19b115561e48a56c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2370862
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

Add FastIntegerSet container to enable fast contains operation
for a set of integer keys. The class uses a BitSet vector to
achieve performance.

Add FastIntegerMap container to improve buffer serial
tracking performance. FastIntegerMap uses FastIntegerSet container
to track buffer serial keys. It also provides an ensureCapacity
method to reserve space, for the expected buffer count, upfront.

CommandBufferHelper::mUsedBuffers and ContextVk::descriptorSetCache
are now FastIntegerMap
CommandBufferHelper::mRenderPassUsedImages is now a FastIntegerSet

Based on a CL by Jamie

Bug: angleproject:4950
Test: angle_unittests.exe --gtest_filter=FastInteger*
Change-Id: Ib58be20143f588baab99acadac796f2435f72d54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2369466Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

Bug: angleproject:4921
Bug: angleproject:2634
Change-Id: I5c379d750114e2ca1c5dd0203e94bb63dac1e0bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336125
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0d6b4440549b..76e8dee41452

2020-08-22 locke@lunarg.com tests: Binding and index are different
2020-08-22 locke@lunarg.com layers: Fix wrong index
2020-08-21 mark@lunarg.com layers: Fixed multiview handling in RenderPass code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ibc6ec188f3decea8a02d1127acfba41c27aa4b5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2371318Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b79773a35d52..4dd122392f3a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ibb81d2cffb4bf310a344c23e49b3a36a0871ee22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2371280Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/44e1791f100c..622558b02e1a

2020-08-21 srisser@google.com Revert "Add getPhysicalDeviceFeatures2"
2020-08-21 msisov@igalia.com X11 and Ozone: Try to check for display type when creating framebuf
2020-08-21 capn@google.com Perform independent blend state optimization

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ia64a7480274de87da5b21f28e1198637edb3d37c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2371319Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f257e0ea6b9a..983698bb34ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Id88987775255ab33cfa7e4704ddc5bcdddfacbc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2371281Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Checking sampler completeness after every sampler related
state change is inefficient. Defer sampler completeness
check to draw time.

Based on a CL by hckim.kim@samsung.com.

Bug: angleproject:4765
Tests: angle_perftests.exe --gtest_filter=TexturesBenchmark.*
Change-Id: I7e971371e40b3044ca3d5ca39bfe7fc600620c3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2268577
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The GN test() template now generates bin/run_ wrappers for
targets; this CL ensures that they'll properly declare when
the wrappers need to use Xvfb on Linux.

Bug: chromium:816629
Change-Id: I4f227eab3306f737f77bbe3341039d710184db96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2370337Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2634
Change-Id: I8c46493ac28fe1bbfdb29ee3a60b23076bbc4c0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336119
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

GL_OES_texture_3D requires support for 3D textures at both API and GLSL
levels.

D3D11 back-end doesn't handle GLSL's added functions (texture3D*)
properly. See TextureFunctionHLSL::useTextureFunction()
(TextureFunctionHLSL.cpp:1475)

Bug: angleproject:4926
Change-Id: Icd669b070c68ec04f5de790d5a531912f5b42d98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336132
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2634
Change-Id: I769ca7e113e660870e9b31dafb706c313db8ac24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332146
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

ImageHelper::copyImageDataToBuffer() is called from glCopyTexture*. It
allocate staging buffer and write the copy command into command buffer
right away. This uses context staging buffer instead of ImageHelper's
staging buffer. This has the benefit of able to share staging buffer
with other objects (including buffers etc).

Bug: b/164511310
Change-Id: I3f680b1cd95df172a442aac573a8cc8d48972b1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364717
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This CL does the following:
* Skip calls from KHR_debug and EXT_debug_marker
* Update an assert in setDeletedBuffer
* Warn when capturing an invalid call

Test: Capture first 2000 frames of PUBG:Mobile
Bug: b/165824228
Bug: angleproject:4048
Change-Id: Ib7fa616a1b5c8ed7c83daaaf0779b41acd31a7f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2366828
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

We now we detect feedback loops by tracking the Framebuffers that the
Texture is bound to. We still have the old tracking method that counts
sampler and image bindings in the code as well.

This CL removes the old front-end tracking for feedback loops. It's no
longer used by any back-ends. This removal should reduce CPU overhead
around Texture and Program binding changes. Reverts the image binding
tracking to the simpler scheme that tracks if a Texture has ever been
bound as an Image. This should practically have little or no perf
effect and we can reinstate some simpler tracking in the future if
required.

Bug: angleproject:4500
Bug: angleproject:4959
Change-Id: Idc625d6e4c519919f97a4dc72dd9c35d262706fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2363210
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Two commits conflicted and the bots didn't catch it somehow

Bug: b/163854287
Change-Id: Idb4d7802eec71b2112b11e4553e609b532cee070
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2369261Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Initially, FramebufferVk::invalidateImpl() was very conservative and
always ended a render pass (if the framebuffer is part of the current
render pass).  This adversely affects PUBG Mobile, which invalidates
the depth buffer every frame, causing the render pass to be split.

Test: PUBG MOBILE on Android
Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.InvalidatingAndUsingDepthDoesNotBreakRenderPass/*
Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkan
Bug: b/163854287
Change-Id: I343dee1db3ebaf039ff92557f9ef25b24bcdcc93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2352627Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Front-end detection still in place and will be removed in a follow-up.
Removes the Vulkan feature and the special clear handling.

Bug: angleproject:4959
Change-Id: I5d44c3f7dbdb49d8aa0375f54b7148df09732ba2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2363208Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2979391e5b0c..e1c7eaa74142

2020-08-20 lenny@lunarg.com loader: Fix invalid cleanup on allocation error

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I1c202b3b886499dd4b33ae1bb8e02f861c5174a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368912Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a711c594b8cc..b79773a35d52

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Iab1da2816a46c4cb658c1560e54b49ab86b21b26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368817Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/cbfd396756c6..44e1791f100c

2020-08-20 srisser@google.com Add getPhysicalDeviceFeatures2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie0cfc798345d8a176168f16fd6c7189611e0769a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368816Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Rename only to keep it consistency.

Bug: b/164511310
Change-Id: I7b00c48010b76bff0b292e6e75b9aff154cdecc0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364727
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

We can combine an initial RenderPass with a read-only RP if the first
RP never writes to depth. We can check the depth-write tracking in
CommandBufferHelper and substitute in a new Framebuffer/RP Desc in this
case as well as issue new layout barriers. We need to disable barrier
merging in this special case.

This reduces the RenderPass count in the Manhattan trace from 15->13.
The performance on the Pixel 4 benchmark goes to ~82% of native for
the on-screen version and ~88% for off-screen. There's also a ~5% bump
in speed for the desktop trace.

Bug: angleproject:4959
Change-Id: I70241824f75eaa1e11b50370f826abc36e91686e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358772
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>

This uses context's staging buffer for immutable texture
TextureVk::setSubImageImpl call and flushes update right away.

Bug: b/164511310
Change-Id: I04fee0a9afe0e84617a461fb6cd7137e853adf8b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2357971
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Instead of always switching the Framebuffer to mask out depth/stencil
loops we now switch the RenderPass to a "read-only" depth/stencil mode.

Reduces the RenderPass count in Manhattan from 18->15. There are still
a couple extra RenderPasses inserted that we can get rid. We can merge
a few RenderPasses by retroactively changing a started RenderPass to
"read-only" when there are no prior recorded depth writes or clears.

Also adds a test to count the number of RenderPasses ANGLE generates in
DS feedback loop situaions.

Bug: angleproject:4959
Change-Id: I1855a45959655fc27ccd47a3469c1c672fc8fd9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2357973
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>