This patch intends to clean up the link validations on interface
blocks for better implementing program linking with geoemtry shader.
1. Move three interface block validation functions to the anonymous
   namespace of Program.cpp instead of the member function of class
   Program.
2. Use IsActiveInterfaceBlock everywhere we need to know if an
   interface block is active or not.

BUG=angleproject:1941

Change-Id: Ic868d015e45f04d57ba382a2b447be00952fa4fc
Reviewed-on: https://chromium-review.googlesource.com/965395
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:2395
TEST=angle_end2end_tests

Change-Id: Ife833a6573c49fc453c120ebc66765064d807b16
Reviewed-on: https://chromium-review.googlesource.com/954991Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Parameter nodes are not needed - it's simpler to just create a
TVariable object for each parameter when the TFunction is initialized.

With this change we also store only one object per each parameter type
used in built-in functions, instead of one array of TConstParameter
entries for each unique parameter sequence.

This simplifies code and reduces binary size and compiler memory use.
Compiler perf does not seem to be significantly affected.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I2b82400dd594731074309f92a705e75135a4c82c
Reviewed-on: https://chromium-review.googlesource.com/955589
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Fixes bug where mVertexAttribsNeedsTranslation was not being set when
vertex attribute changes internally from DIRECT to DYNAMIC. This changes
mVertexAttribsNeedTranslation to be set during any change in vertex
attribute type.

BUG=angleproject:2381

Change-Id: I91ae86624f0cb68bd8c41c3bcbdeb31fa1ccd9ed
Reviewed-on: https://chromium-review.googlesource.com/951894
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug:angleproject:2358

Change-Id: I4dc19f9e4cc7b51f215b57d440a108cdf17aec24
Reviewed-on: https://chromium-review.googlesource.com/960573Reviewed-by: Geoff Lang <geofflang@chromium.org>

The translator already prunes no-ops and unreferenced variables, and
this may result in case statements that are followed by nothing.

Since the last case statement in as switch statement must always
contain a statement to be valid GLSL, the translator must not leave
empty case statements in place. They're now being pruned by the
PruneEmptyCases AST transformation. This improves on the earlier
RemoveEmptySwitchStatements AST transformation that did address
empty switch statements but could not remove them if they had a
case statement inside.

BUG=angleproject:2402
TEST=angle_unittests

Change-Id: Ieb9598a744078e45226d8fb7266d877f7835cf0c
Reviewed-on: https://chromium-review.googlesource.com/962181
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Currently changing uniform values will not always be seen.

Bug: angleproject:2392
Bug: angleproject:2403
Change-Id: Ie315a64ad6094f2c23e48e901de2e03e4d98516a
Reviewed-on: https://chromium-review.googlesource.com/963296
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>

Bug:angleproject:2392

Change-Id: I97efea83e604d19b1745d9db4ab8f02997a1b7fc
Reviewed-on: https://chromium-review.googlesource.com/962666
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:2404

Change-Id: I2667ddc92d5c9ef6e0ef115f2fdf0c3d3643d945
Reviewed-on: https://chromium-review.googlesource.com/962702Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This simple perf test already in the source does a great job at this.

Bug: angleproject:2389
Change-Id: I94ff14e0eab1cb49a8d19725056ad8f7f008ac05
Reviewed-on: https://chromium-review.googlesource.com/962962Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This patch implements all the program queries on the geometry
shader stage of a program by glGetProgramiv(), including the
queries on geometry shader input/output primitives, invocations
and maximum output vertices

BUG=angleproject:1941
TEST=dEQP-GLES31.functional.geometry_shading.query.geometry_linked_*
     dEQP-GLES31.functional.geometry_shading.query.geometry_shader_invocations
     dEQP-GLES31.functional.state_query.program.geometry_shader_state_get_programiv

Change-Id: Ibfa630c64dba5baf52ff84ce7e0bf4c567eef8c4
Reviewed-on: https://chromium-review.googlesource.com/961397
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Bug:angleproject:2392

Change-Id: I2110ecde653a85a28b515dc9d8473a1b37a73eb6
Reviewed-on: https://chromium-review.googlesource.com/962718Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Luc Ferron <lucferron@chromium.org>

This is moving all ANGLE Linux tryservers to run on LUCI only.

BUG=chromium:815092

Change-Id: I66cd2908706243a54a406fa6aa297c0d18a0127b
Reviewed-on: https://chromium-review.googlesource.com/962930Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

The code in gl::Texture would only check whether the first cube map face
is correctly initialized but not for the others.

BUG=angleproject:2169

Change-Id: Ib565579a4570e731da785b5c74c8d1a6511ebcd4
Reviewed-on: https://chromium-review.googlesource.com/960571
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Previously called DrawCallVertexParams. This params helper will be
passed into the VertexArray state sync method so we can handle
vertex attribute updates directly in the VertexArray implementation
instead of deferring the updates to the draw call, where the draw
call implementation method would have access to the draw call params.

Also includes the full range of draw parameters to DrawCallParams so
we can use it in more places.

Refactoring change only, subsequent work will contain more refactoring
and lead to code cleanups and easier dependent state updates for the
VertexArray implementation classes.

Bug: angleproject:2389
Change-Id: Ia84f8af54ae51eca94d8fb6f5b8adc88b8d981a7
Reviewed-on: https://chromium-review.googlesource.com/948787
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The 'firstVertexDefinitelyZero' argument didn't actually have any
behavioural change to the code, so remove it. Also add an explicit
call to resolve the index range, instead of doing it implicitly when
certain values were queried.

Bug: angleproject:2389

Change-Id: I377c79006bfa541183fe94d0ed199fbaa1132afc
Reviewed-on: https://chromium-review.googlesource.com/948786
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This implements basic depth/stencil states and clearing.

This also implements "fallback" texture formats in the texture
generation. Fallback formats are those that are chosen at runtime for
replacements for main formats which lack driver support. They are
different from override formats, which are always used because we
assume there is no driver support.

The Vulkan spec only asserts that one of the two of D32 or D24 has
mandatory support. In the case of AMD, D24 is not supported fully, and
we need the fallback format support emulation.

Bug: angleproject:2357
Change-Id: Ic86cede3c69ff9893a06b3a55c3b5d2d897fa55f
Reviewed-on: https://chromium-review.googlesource.com/916701
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

Bug:angleproject:2358

Change-Id: I8e5baa53239ab0509683114645fed0e769f43764
Reviewed-on: https://chromium-review.googlesource.com/962321
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This way we can do numeric comparisons instead of string comparisons.

The effect on compiler perf test scores is fairly marginal, but
this reduces binary size by a few kilobytes, and there may be a larger
effect on shaders calling a lot of texture functions.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I077db97b16b16b70b7e18ee037e06d7450d08dc9
Reviewed-on: https://chromium-review.googlesource.com/947952
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This patch implements adjacency primitive types as new draw modes
on OpenGL back-ends.

This patch also implements validations on the compatibilities among
draw modes and geometry shader input primitive types.

BUG=angleproject:1941
TEST=dEQP-GLES31.functional.geometry_shading.input.*
     dEQP-GLES31.functional.geometry_shading.negative.*

Change-Id: I373ebfe88d7f50da3cc81adaf2d1b7f586b0932a
Reviewed-on: https://chromium-review.googlesource.com/954715
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Since querying the internal format of an attachment might need ot look
at the RenderTarget for some back-ends, or otherwise flush attachment
changes, we should call syncState internally. This means that we can't
mark these queries as const.

Bug: angleproject:2372
Change-Id: I9bfb43a472bcd7dfdd6ea7fab4751d494e1126bb
Reviewed-on: https://chromium-review.googlesource.com/948784Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This improves angle_perftests
bindings_gl_100_objects_allocated_every_iteration by over 30%.

Bug: 820723
Change-Id: Icfaa0f54f7c61db6475948e3a95296f37ab4f7dc
Reviewed-on: https://chromium-review.googlesource.com/961302Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1944

Change-Id: I37d6f22c18e65bd53b75702f0f13ec818b83c34d
Reviewed-on: https://chromium-review.googlesource.com/959224
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug:angleproject:2358

Change-Id: I93bdbbe65ac8109a5a506d88202715c51918613b
Reviewed-on: https://chromium-review.googlesource.com/960574Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This enables 21 tests in the texture department (including luminance
texture format tests except mimap related tests).

Bug:angleproject:2364

Change-Id: Ib609f0457833b34ecdb9d8f8b4479ece9ef6c1a6
Reviewed-on: https://chromium-review.googlesource.com/959233
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The new mangled name format is as follows:

The first character is a hex digit from 0 to F that encodes vector or
matrix size. For scalars, structs etc. the character is 0.

Then, if it's a struct, the mangled name continues with "{s", followed
by mangled names of fields, and ends with "}".

If it's an interface block, the mangled name continues with "{i",
followed by mangled names of fields, and ends with "}".

If it's anything else, the second alphabetic character encodes the
basic type. Characters are assigned to basic types in the enumeration
order.

If it's an array, the mangled name has a suffix [array_size].

This saves a few kilobytes from the binary size. The effect on symbol
lookup speed seems mostly marginal.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I26e65dcb48c3478df9a719ffff9c15f2fd12e293
Reviewed-on: https://chromium-review.googlesource.com/945910
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Vulkan does not support receiving out of bounds numbers for the scissor
region but no validation errors are sent. This change clips the region
received to fit the current viewport and it fixes
many dEQP tests.

Bug:angleproject:2356
Change-Id: I5dcf739366ba1f62b56593eaaccedf5f14d0c200
Reviewed-on: https://chromium-review.googlesource.com/957758Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Luc Ferron <lucferron@chromium.org>

Contains definitions of GLES1-specific states such as material /
lighting.

Tweaked the Color class for easier copying to uniforms / reading as a
float array.

This CL also adds the GLES1-specific state in GLES1State, which is then
part of the State class and is initialized to the spec's values if the
context major version is ES 1.

+ Some clang-format

BUG=angleproject:2306

Change-Id: I7fc3bd9a22ebf0ffcd98d931d0176f21e17b1c5c
Reviewed-on: https://chromium-review.googlesource.com/936424
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This change enables the following tests:
dEQP-GLES2.functional.rasterization.culling.* 18/18
dEQP-GLES2.functional.rasterization.interpolation.* 12/12
dEQP-GLES2.functional.rasterization.fill_rules.* 5/5

Bug:angleproject:2352

Change-Id: I5a8869751ea0d787cc266ae12422633106e39983
Reviewed-on: https://chromium-review.googlesource.com/959118
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This enables 17 additional tests, including the line_loop tests.

Bug:angleproject:2335

Change-Id: I5d441dde08e6018d089749e102070886ccef3a08
Reviewed-on: https://chromium-review.googlesource.com/957448
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2306

Change-Id: I1c5a2dd40fb7d9b51cbf3fd37720a172578d76e8
Reviewed-on: https://chromium-review.googlesource.com/959105
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This set of expectations modifications effectively enables exactly these tests:
dEQP-GLES2.functional.fragment_ops.scissor.* -> 16/16 tests passed.

Bug:angleproject:2338
Change-Id: Icb971e0e7b253e7df390de1196cc4bc4401f9631
Reviewed-on: https://chromium-review.googlesource.com/957269
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This set of expectations modifications effectively enables exactly these tests:
dEQP-GLES2.functional.fragment_ops.blend.* -> 1046 / 1046 tests passed.

Bug:angleproject:2346

Change-Id: I3acf903db9be05180df41fed10c2803c59cfc838
Reviewed-on: https://chromium-review.googlesource.com/957312
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This pipes a lot more errors around in the Validation, where
they now will be caught.

Bug: angleproject:2372
Change-Id: Ibb4e47ddc932995a02dd92e10578b7a4097182a9
Reviewed-on: https://chromium-review.googlesource.com/954406Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug:angleproject:2396
Change-Id: I8069847f1389308c7c4d4e4786360dfc5a7eb1f4
Reviewed-on: https://chromium-review.googlesource.com/959047Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Luc Ferron <lucferron@chromium.org>

BUG=angleproject:1941
TEST=dEQP-GLES31.functional.shaders.builtin_constants.*
     dEQP-GLES31.functional.shaders.builtin_functions.*_geometry
     dEQP-GLES31.functional.debug.negative_coverage.*.geometry_shader

Change-Id: I37b29e48f27ae31e3753efe00b849849879f848d
Reviewed-on: https://chromium-review.googlesource.com/954713
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This is a fix for a graphics problem we've been seeing for a while with WebRender+Angle on Nvidia/Windows. The sampler metadata doesn't get updated properly for some of the draw calls, since it's not invalidated on program change (this is what the CL is fixing). Extra entries get filled with garbage data because the constant buffer is updated with `MAP_WRITE_DISCARD`, and only those samplers are updated that the current program has. This may generally occur undetected, if not for our `textureSize` calls that appear to go the NV-specific Angle workaround path that ignores our `baseLevel = 0` and instead picks the one from the driver constants (which contains garbage), leading to either zeroes returned or even crashing the driver sometimes...

BUG=angleproject:2399

Change-Id: Ie2bef32184e2305c7255299933b899eb3fffb7ab
Reviewed-on: https://chromium-review.googlesource.com/949412Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

gen_builtin_symbols.py now generates code for initializing built-in
variable symbols as well. Some of the variable symbols are static, but
some of them also get initialized dynamically based on values in
ShBuiltInResources.

The static symbols have get functions in a header file so they can be
referenced from AST traversers as well without doing a lookup.

BUG=angleproject:2267
TEST=angle_unittests, angle_end2end_tests

Change-Id: Ida7f3aeb06d2bce0f737f1483b1bd5833aeddd2e
Reviewed-on: https://chromium-review.googlesource.com/911768Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This also fixes a missed VkResult error. In order to do this
we also return an error from ProgramImpl::destroy.

Bug: angleproject:2396
Change-Id: I649b19e64732785bb33eebadea7f361245137d0f
Reviewed-on: https://chromium-review.googlesource.com/958406Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We were missing the data definition for the standard validation layer.
This file was missing from the isolate, and the entire layer system
was not working.

Found this as a side-effect of working on depth stencil support.

Also fixes a missing definition in the white_box_tests BUILD.gn.

Also temporarily disables the ClearTest support for Vulkan because of
an implementation bug on AMD. Unfortunately because of the failure
mode it didn't work to just skip the test in the preamble.

Bug: angleproject:2357
Change-Id: I4d06c54191b09e09a4ba68c24613db6f148b17e3
Reviewed-on: https://chromium-review.googlesource.com/956759
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>