Skip to content

A
angle
Switch branch/tag
  1. 02 Oct, 2020 4 commits
    • Test Runner: Fix race in watchdog timeouts. · 1fd3e5d8
      Jamie Madill authored 
      This fixes a TSAN warning that popped up with the standalone test
runner. The watchdog timer actually was never started so timeouts
were not working as intended. It also switches the timeout mode
to call _Exit which skips all the atexit handlers and avoids some
races on teardown. This change also speeds up the TestSuiteTest.

Also a small fix to GetTempDir that was including an extra path
separator on Windows.

Bug: angleproject:3162
Bug: angleproject:5117
Change-Id: I0e7880a08b61bbb6e30c65665d5c0acec2d78db2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2442381Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
    • Vulkan: Fix UtilsVk clear in non-zero subpass · 01641c7a
      Shahbaz Youssefi authored 
      Mid-render-pass clears (through UtilsVk) run on the current subpass,
which in the presence of multisampled-render-to-texture unresolve
would be subpass 1.  The graphics pipeline for that draw call should
set the correct subpass index.

Bug: angleproject:4836
Change-Id: Iba4a03ea96a63b0f5d09c27e5283ff8a8b534e05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441509
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • Revert "Vulkan:Add debug labels for OpenGL calls" · 6534a6f8
      Jamie Madill authored 
      This reverts commit 3705fc41.

Reason for revert: Causes errors on Debug bots. See bug.

Bug: angleproject:5121

Original change's description:
> Vulkan:Add debug labels for OpenGL calls
>
> Implement the DebugAnnotatorVk class, and plumb the EVENT macro in the
> GL entrypoints to save a string of call info in the vector of all
> GL calls in ContextVk.
>
> Then add a vkCmdBeginDebugUtilsLabelEXT() call that includes the
> OpenGL draw/dispatch call prior to any Vulkan Draw or Dispatch calls.
> Also embedded under that label add a second
> vkCmdBeginDebugUtilsLabelEXT() call labeled "OpenGL Commands" that
> includes all of the OpenGL calls leading up to the draw/dispatch.
> Each individual OpenGL call is then given its own
> vkCmdBegin/EndDebugUtilsLabelEXT() pair so that the complete sequence
> of GL calls leading up to a draw call is visible for each Draw.
>
> Enable the OGL->VK mapping feature by setting
> "angle_enable_trace = true" in GN args.
>
> Note: This will create an ANGLE APK on Android that generally won't
> work with games, unless launched by AGI (which provides the debug
> utils extension).  A future version will disable these labels unless
> the debug utils extension is found.
>
> Bug: b/162068318
> Bug: b/169243237
> Change-Id: I09886f17fa9287528c12552698738ea1fe2a4b8c
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2427557
> Commit-Queue: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

TBR=courtneygo@google.com,ianelliott@google.com,timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/162068318
Bug: b/169243237
Change-Id: I772d549213e1ad64ae58a1937e5de0f7ea740084
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444094Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    • Add a standalone GN isolate map. · 7b25b643
      Jamie Madill authored 
      This will allow us to use trigger.py in a standalone checkout
to fire off swarming jobs.

Bug: angleproject:5114
Change-Id: I99302a4e8fdfc0f6d9996748a2d6c97dc5f03cde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2442079
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarDirk Pranke <dpranke@google.com>
Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
  3. 01 Oct, 2020 14 commits
  5. 30 Sep, 2020 15 commits
  7. 29 Sep, 2020 7 commits