Skip to content

A
angle
Switch branch/tag
  1. 20 Apr, 2021 10 commits
  3. 19 Apr, 2021 8 commits
  5. 17 Apr, 2021 5 commits
  7. 16 Apr, 2021 9 commits
  9. 15 Apr, 2021 8 commits
    • Vulkan: Implement shader buffers descriptor cache. · 0c77f3ad
      Jamie Madill authored 
      Implements a descriptor set cache for UBOs, SSBOs, and atomic counter
buffers. Storage Images and framebuffer fetch input attachments are
not yet included. Requires moving the buffer barrier handling into
ContextVk, similarly to how we handle the barriers for Textures.

The packed description key for the descriptors uses a "fast" vector
with a basic minimum size. For most cases of a few buffers this will
fit easily in stack memory, but for larger programs with many buffers
we fit this into heap memory. The key has a large upper bound due to
the high ES 3.2 requirements and the need to index several values such
as the offset and binding size.

We use dynamic offsets for uniform buffers when possible. This ensures
applications like Manhattan 3.1 that use sets of common buffers with
changing offsets hit the cache most of the time.

Because of resource limits we pick at compilation time whether to use
dynamic or static descriptor sets. Mostly this applies to tests that
use a large number of uniform buffers. A future implementation could
be smart and would recompile the program with heuristics to use a
minimal number of dynamic indices.

Reduces the number of descriptor set updates from ~300 -> ~30 per frame
in Manhattan 3.1 and in Asphalt 9 from 900+ to as low as 0 per frame.

Bug: angleproject:5736
Change-Id: I5c2a3881bec90d301dab15cc86c8a70e60674ad7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757515
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    • Generate CL enums in libGLESv2 · 8226dc23
      John Plate authored 
      Bug: angleproject:5869
Change-Id: Ie547d415bed37accef6cb62d28bc6b088a1eb810
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2829370Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>
    • Capture/Replay: Add PPO/glProgramUniform support · fbfecbe2
      Tim Van Patten authored 
      Command and Conquer: Rivals requires additional frame capture API
support:
- Program Pipeline Objects
- glProgramUniform*

Bug: angleproject:5830
Change-Id: I159086f92d2dfead0a513cd17fadeda7df92f408
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809891
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    • Remove suppression for fixed CTS tests · 4f68a4ee
      Shahbaz Youssefi authored 
      CTS bugs are fixed in [1] and [2].

[1]: https://gerrit.khronos.org/c/vk-gl-cts/+/7062
[2]: https://gerrit.khronos.org/c/vk-gl-cts/+/7049

Bug: angleproject:5673
Change-Id: I2d86f53a6a83bab143f89896d4d5dab3cc7b2334
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808053Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    • Vulkan: Consolidate mReadOnlyDepthStencilMode to mRenderPassUsageFlags · fb288312
      Charlie Lao authored 
      Since now ImageHelper object has a mRenderPassUsageFlags tracking how it
is been used by current RenderPassCommands, we can consolidate
mReadOnlyDepthStencilMode into a bit in the mRenderPassUsageFlags. The
read only mode is just a special attachment mode, so this makes code
more consistent and able to get rid of the extra dword for
mReadOnlyDepthStencilMode.

Bug: b/181797383
Change-Id: Ie9b7be1c18c392e5b2712bdae6ab6506de8d6d34
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821942
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    • Vulkan: Support sample/render to depth texture with different LOD · 5eac3169
      Charlie Lao authored 
      Previously we supported read only depth attachment that attachment and
sample are using the same texture. It was always assuming it will be
read only if the same texture is attached to FBO and same time bound to
texture unit. But we never supported if it actually writing to depth
texture, but at the different level with sampling. This is supported
OpenGL operation as long as the levels render to is outside [base_level,
max_level]. Later on, we added support of the above operation, but
limited to color buffers. This CL extends the same support of render and
sample to the same depth texture with non-overlapping levels. Android
game black desert mobile is running into this usage case.

Bug: b/181797383
Change-Id: I7ee1d52f27603f933102ad1b098684309449c406
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819487
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarIan Elliott <ianelliott@google.com>
    • Vulkan: Add test for render+sample depth texture with non-overlap LOD · e55462b9
      Charlie Lao authored 
      Render and sample from the same texture and then bind to another FBO
without trigger texture bind should still detect the condition that it
is render and sample same texture.

Render to depth texture and sample form the same depth texture but with
non-overlapping levels should work.

Bug: b/181797383
Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLODAndFBOSwitch
Test: FramebufferTest_ES3.RenderSampleImmutableDepthTextureWithExcludedLevel
Change-Id: I0d330d6f9530eb4fea417019a627890c4a5c1154
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819486
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarIan Elliott <ianelliott@google.com>
    • Roll VK-GL-CTS from c4e6dbe68e04 to ededa67cb12a (76 revisions) · 1a146f07
      Shahbaz Youssefi authored 
      https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c4e6dbe68e04..ededa67cb12a

2021-04-13 timvp@google.com Always include sys/system_properties.h for Android
2021-04-09 juha.heiskanen@siru.fi Add primitive topologies for XFB query tests
2021-04-09 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
2021-04-09 s.fricke@samsung.com Add OpImageQuerySamples with Storage Image test
2021-04-09 jdarpinian@chromium.org EXT_multisampled_render_to_texture test using ReadPixels
2021-04-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-04-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
2021-04-07 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-04-07 jajones@nvidia.com Add CMake detection logic for libdrm include files
2021-04-02 juha.heiskanen@siru.fi Add early fragment tests
2021-04-02 michal.jakubek@mobica.com Add tests for multisample resolve to level != 0
2021-04-02 boris.zanin@mobica.com Add coverage for 1D, 1D array and Cube array shadow images
2021-04-02 boris.zanin@mobica.com Add subgroup testing for ray tracing pipelines
2021-04-02 caio.oliveira@intel.com Test interaction between Workgroup explicit layout and zero initialization
2021-04-02 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master"
2021-04-02 cheryl.wei@arm.com Add waived tests support for cts tools
2021-04-01 rgarcia@igalia.com Remove duplicate dataSafe function from deSTLUtil
2021-04-01 boris.zanin@mobica.com Add keys deqp-log-decompiled-spirv and deqp-log-empty-loginfo
2021-04-01 apinheiro@igalia.com Check for drawIndirectFirstInstance should only affect indirect draw calls
2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the uniform location tests
2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the multisample texture tests
2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the EXT_texture_border_clamp tests
2021-03-30 alexander.galazin@arm.com Update Vulkan headers
2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the geometry shading tests
2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the tessellation tests
2021-03-30 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-30 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the copy image tests
2021-03-26 michal.jakubek@mobica.com Added tests for most-negative snorm values in images
2021-03-26 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.2.2.x
2021-03-25 timvp@google.com Include sys/system_properties.h in teglAndroidUtil.cpp
2021-03-25 afdx@google.com Add a batch of GraphicsFuzz tests
2021-03-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-25 rgarcia@igalia.com QPA image viewer updates
2021-03-25 boris.zanin@mobica.com Fulfill OpControlBarrier requirement
2021-03-25 slawomir.cygan@intel.com Add an option to terminate after first failure, update READMEs
2021-03-25 slawomir.cygan@intel.com Terminate with an error if unrecognized arguments are passed to dEQP executable
2021-03-25 venni.ihanakangas@siru.fi Ensure only Unix paths are added to deqp.apk
2021-03-19 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
2021-03-19 jbolz@nvidia.com Add tests to exercise 'readonly' SSBOs
2021-03-18 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-03-18 slawomir.cygan@intel.com Fix required features checks in shaderRecordExplicitScalarOffset_6 test case
2021-03-18 tom.cooper@arm.com Add VK_EXT_headless_surface surface tests
2021-03-18 Junda.Liu@amd.com Fix robust buffer access result checking for partially out of bound cases
2021-03-18 tapani.palli@intel.com Use linear tiling with external_memory_host tests
2021-03-18 ancheng.qiao@arm.com Fix precision issue in NearestEdgeTests shaders
2021-03-17 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-03-17 gleese@broadcom.com Enable shadow filtering tests for non-filterable formats
2021-03-17 rgarcia@igalia.com Add BGR and BGRA formats to image view tests
2021-03-17 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-17 jari.komppa@siru.fi Add tests for standard multisample positions
2021-03-17 rgarcia@igalia.com Push constant overwrite tests
2021-03-17 rgarcia@igalia.com Test large command buffers with many draw commands
2021-03-17 rgarcia@igalia.com Test barycentric coordinates in ray tracing hits
2021-03-17 rgarcia@igalia.com Add missing mandatory features
2021-03-17 venni.ihanakangas@siru.fi Ensure WSI colorspace has no effect on image contents
2021-03-17 tapani.palli@intel.com reset minSampleShading only with OpenGL Core 4.0+
2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
2021-03-15 rgarcia@igalia.com Enable validation for all custom devices
2021-03-15 rgarcia@igalia.com Remove multiview requirement in extended dyn state tests
2021-03-15 boris.zanin@mobica.com Fix recursion depth requirement in complexcontrolflow
2021-03-15 rgarcia@igalia.com Check image extent support in watertightness tests
2021-03-15 boris.zanin@mobica.com Read deserealization size from stream
2021-03-15 gleese@broadcom.com Fix flush/invalidate in mismatched_write_op tests
2021-03-15 gleese@broadcom.com Fix sync validation for mismatched_write_op tests
2021-03-15 tapani.palli@intel.com Check if image sample count supported by VkSampleCountFlags
2021-03-15 rgarcia@igalia.com Always accumulate errors in desc set random tests
2021-03-15 syoussefi@google.com Fix missing barrier in compute test
2021-03-15 syoussefi@google.com Fix missing barrier in texture buffer test
2021-03-15 ari.suonpaa@siru.fi Replace libUI with native Android AHB API
2021-03-10 gleese@broadcom.com Add a waiver for depth bias on some Broadcom GPUs
2021-03-10 alexander.galazin@arm.com Update Vulkan/GL Readme
2021-03-10 ari.suonpaa@siru.fi Update Amber
2021-03-08 toni.salmivalli@siru.fi Add a batch of Graphicsfuzz tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:5816
Change-Id: I324ce9596a62771726dc4504b2341e049818f7de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807533Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>