Commits · 22e1f3e2c22ebf2b3907f1691130f2ebf95ef99f · Chen Yisong / angle

16 Jul, 2020 11 commits

Vulkan: Let all shader stages share one buffer for default uniform · 22e1f3e2

authored Jun 26, 2020

Right now each shader stage has its own vk::DynamicBuffer for default
uniform storage. This is less efficient than just share one buffer. This
CL moves the storage from per shader stage into its ProgramVk object.

Bug: b/159457348
Change-Id: If47248ea23c4e48407d3b211583ae2b048d4d10f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2265281
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

22e1f3e2

Perf Tests: Fix trace test calibration. · 4e7a6a69

authored Jul 15, 2020

The trace tests were including the startup time in their calibration
calculations. Then was forcing them to always render one step. This
fixes the calibration to attempt to get a more consistent measurement.
The trace tests now render many more steps than they did before. It
should increase the stability and decrease variance in our measurements
as they will be runnnig many more frames than before.

Also adds a verbose logging flag to help debugging.

Noticed this bug when working on the trace test offscreen mode.

Bug: angleproject:4845
Change-Id: Iff0c987008a935e7051fca34ef12f4433eb46092
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300205Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4e7a6a69

Vulkan: Fix capturing arrays using VK_EXT_transform_feedback · 45f54928

authored Jun 17, 2020

Vulkan is able to capture the whole array when using
transform feedback extension. Add a new end2end test
for it.
Due to the outdated nv bots, khr_gles31 tests are
faild. Add these suppressions in the khr_gles31
expectations file in order to unblock the commit.

Bug: angleproject:4723
Change-Id: I929f99544a01cf5fc781dc31c2c041c851976676
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2247952
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

45f54928

Metal: fix max point size and RGB565 renderbuffer bug. · 349b661d

authored Jul 08, 2020

- Max point size is set to 64, since this is the max size observed. It
  is not 511 as
  https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf claims.
- RGB565 is emulated on macOS by RGBA, needs to disable alpha write for
  this format. This was already done for TextureMtl, but wasn't for
  RenderBufferMtl.
- Also enable true non-power-of-two textures support (OES_texture_npot).
  This was technically already supported, just that the extension wasn't
  advertised yet.

- New Test: FramebufferFormatsTest.RGB565Renderbuffer

Bug: angleproject:4816
Bug: angleproject:2634
Change-Id: Ie7e3efb4cb29bb9a3fd706c26e2b50b42ff3f6be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281797
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

349b661d

Metal: Prevent vertex shader's inactive varying from being removed · 08b9ad57

authored Jul 08, 2020

If vertex shader declares a varying but doesn't use it, and this varying
is being used in fragment shader, linking will fail because the varying
would be removed by spirv-cross.

Fix: initilize the unused varying with zero(s).

New test: GLSLTest.InactiveVaryingInVertexActiveInFragment.

Bug: angleproject:2634
Change-Id: Ia37acd8eea85d5da4ddbca6457d6cddb1b41662c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281796
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

08b9ad57

Roll SPIRV-Tools from 4c33fb0d3dba to 7221ccf85e26 (5 revisions) · 82359f92

authored Jul 16, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4c33fb0d3dba..7221ccf85e26

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I2a8920fc337b444d2036d7410be3fa6066f16239
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301353Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

82359f92

Roll SwiftShader from 1de497cc50ab to 0a8f44c514ce (1 revision) · 2361c593

authored Jul 16, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/1de497cc50ab..0a8f44c514ce

2020-07-15 bclayton@google.com Regres: Collate and add new documentation for Regres

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Icc753a1ac3871ebfaf3a30c6aa999b3fb24c49f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301354Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2361c593

Roll glslang from b481744aea1e to 4f72970ed3e0 (1 revision) · 0f55d55a

authored Jul 16, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b481744aea1e..4f72970ed3e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: If2f1140131bd5ce6052491dbff763935502a44bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301350Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0f55d55a

Roll Vulkan-Tools from 521eaacef67a to d093d9723b7c (2 revisions) · b7c81133

authored Jul 16, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/521eaacef67a..d093d9723b7c

2020-07-16 bob@lunarg.com scripts: fix update_deps retry clone
2020-07-15 shannon@lunarg.com build: Update known-good files for 1.2.147 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I9ca9134800e9ad27340fd43348f6ca389be2b187
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301352Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b7c81133

Roll Vulkan-Loader from d8f34456c819 to dd3511549b18 (1 revision) · eb3d8ee6

authored Jul 16, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d8f34456c819..dd3511549b18

2020-07-16 bob@lunarg.com scripts: fix update_deps retry clone

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Idc84db0de207a83f25c798899bc4e5a66958529a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301351Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eb3d8ee6

Roll Vulkan-ValidationLayers from 04c82ec6f36f to 7548cbeabfa7 (100 revisions) · 452ab092

authored Jul 16, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/04c82ec6f36f..7548cbeabfa7

2020-07-15 bob@lunarg.com scripts: fix update_deps retry clone
2020-07-15 tony@lunarg.com tests: Add ShieldTV rev b to skiplist
2020-07-15 tony@lunarg.com gpu: Report errors when shader instrumentation fails
2020-07-15 shannon@lunarg.com build: Address VUID inconsistencies for 1.2.147
2020-07-15 shannon@lunarg.com build: Update known-good files for 1.2.147 header
2020-07-14 jzulauf@lunarg.com tests: Add test for attachment final layout tran
2020-07-14 8729214+jonahryandavis@users.noreply.github.com Fix -Wrange-loop-construct range var copy warning
2020-07-14 jzulauf@lunarg.com syval: Correct assert during final layout record
2020-07-14 tksuoran@gmail.com lifetimes: Fix GetPhysDeviceDisplayProp2 null derefs
2020-07-13 pdaniell@nvidia.com tests: Add VK_EXT_extended_dynamic_state tests
2020-07-13 pdaniell@nvidia.com layers: Add VK_EXT_extended_dynamic_state validation
2020-07-13 bob@lunarg.com scripts: update copyright notice for update_deps
2020-07-13 bob@lunarg.com scripts: update_deps retry on clone or fetch failure
2020-07-13 jzulauf@lunarg.com docs: Add synchronization design doc
2020-07-13 locke@lunarg.com tests: Layout Transition error test
2020-07-13 jzulauf@lunarg.com syncval: Add stage/access info to hazard messages
2020-07-13 jzulauf@lunarg.com syncval: Add input attachment state tracking
2020-07-13 jzulauf@lunarg.com syncval: Fixes for attachment detection/update
2020-07-13 locke@lunarg.com layers: Fix sub extents
2020-07-13 locke@lunarg.com syncval: Add Prior access
2020-07-13 locke@lunarg.com syncval: Fix for 3D image
2020-07-13 jzulauf@lunarg.com syncval: Correct order for syval end rendpass calls
2020-07-13 locke@lunarg.com syncval: Fix wrong mip count in encoder
2020-07-13 jzulauf@lunarg.com syncval: Bound access resolve to range.
2020-07-13 locke@lunarg.com syncval: Check for no current renderpass
2020-07-13 locke@lunarg.com syncval: Fix blitImage offset and extent error
2020-07-13 jzulauf@lunarg.com syncval: Add command name to harzard reports
2020-07-13 jzulauf@lunarg.com layers: Refactor Command name lookup to function
2020-07-13 jzulauf@lunarg.com syncval: Add tag information to hazard log messages
2020-07-13 locke@lunarg.com syncval: Record in StateTracker
2020-07-13 locke@lunarg.com tests: Test syval depth/stencil speparately
2020-07-13 locke@lunarg.com syncval: Test depth/stencil separately
2020-07-13 locke@lunarg.com syncval: Skip FS validation w/rasterizerDiscardEnable
2020-07-13 locke@lunarg.com syncval: Check fs writable output
2020-07-13 locke@lunarg.com syncval: Remove dupl. input attachment validation
2020-07-13 locke@lunarg.com syncval: Refactor detect/update for draw/dispatch
2020-07-13 locke@lunarg.com layers: Catch if shader use store function
2020-07-13 locke@lunarg.com syncval: Check every shader stages
2020-07-13 locke@lunarg.com scripts: Add shader stage map
2020-07-13 locke@lunarg.com tests: More syval test in Cmd
2020-07-13 locke@lunarg.com syncval: Refactor get pipeline
2020-07-13 locke@lunarg.com syncval: More syval in cmd
2020-07-13 locke@lunarg.com syncval: Detect/Update Subpass attachments
2020-07-13 locke@lunarg.com syncval: shared_ptr renderpass/framebuffer
2020-07-13 locke@lunarg.com syncval: Syval vertex and index
2020-07-13 locke@lunarg.com syncval: Syval more cmd
2020-07-13 locke@lunarg.com tests: Fix fail
2020-07-13 locke@lunarg.com tests: Syval CmdDispatch
2020-07-13 locke@lunarg.com syncval: Syval descriptorSets in CmdDispatch
2020-07-13 jzulauf@lunarg.com syncval: Add renderpass store sync validation
2020-07-13 locke@lunarg.com layers: D24 depth pixel size is 3, not 4
2020-07-13 locke@lunarg.com scripts: Deal with MEMORY_READ/WRITE_BIT
2020-07-13 jzulauf@lunarg.com syncval: Add additional resolve att. val/update
2020-07-13 jzulauf@lunarg.com syncval: Add resolve validations NextSubpass only
2020-07-13 jzulauf@lunarg.com syncval: Add hazard detection with ordering checks
2020-07-13 jzulauf@lunarg.com syncval: Add loadOp validation to renderpass
2020-07-13 jzulauf@lunarg.com syncval: Synch Val bugfixes from design review
2020-07-13 locke@lunarg.com syncval: Deal with whole size and remaining
2020-07-13 jzulauf@lunarg.com tests: Add begin renderpass hazard test
2020-07-13 jzulauf@lunarg.com syncval: Convert all sync tagging to new style
2020-07-13 jzulauf@lunarg.com syncval: Add renderpass image layout sync checks
2020-07-13 jzulauf@lunarg.com layers: Add additional attachment info
2020-07-13 jzulauf@lunarg.com layers: Add hinted invalidation to parallel iter
2020-07-13 jzulauf@lunarg.com tests: Fix access mask logic for SetLayout
2020-07-13 locke@lunarg.com syncval: Merge contiguous ranges during encode
2020-07-13 locke@lunarg.com syncval: Fix texel size in ImageRangeEncoder
2020-07-13 locke@lunarg.com syncval: Encode linear image as optimal in MockICD
2020-07-13 locke@lunarg.com syncval: Move image encoder init to BindMemory
2020-07-13 jzulauf@lunarg.com syncval: Add FreeCommandBuffer callback support
2020-07-13 locke@lunarg.com scripts: Sort syncval output for consistency
2020-07-13 jzulauf@lunarg.com syncval: Remove per-handle maps for AccessState
2020-07-13 jzulauf@lunarg.com layers: Add support for fake device memory address
2020-07-13 locke@lunarg.com syncval: Refactor Image encoder/generator
2020-07-13 jzulauf@lunarg.com syncval: Cleanup/Refactor AccessContext
2020-07-13 jzulauf@lunarg.com layers: Add range operator + and copy constructor
2020-07-13 jzulauf@lunarg.com layers: Add subpass transition info to RP state
2020-07-13 jzulauf@lunarg.com syncval: Clean up and bugfix Access state resolve
2020-07-13 locke@lunarg.com syncval: Change offset generator to image generator
2020-07-13 locke@lunarg.com syncval: Add default constructors for Encoders
2020-07-13 jzulauf@lunarg.com syncval: Clean attachment first/last for RP creation
2020-07-13 jzulauf@lunarg.com syncval: Add end renderpass access context resolve
2020-07-13 jzulauf@lunarg.com syncval: Change hazard check to use resolved map.
2020-07-13 locke@lunarg.com syncval: Add function name to hazard log messages
2020-07-13 locke@lunarg.com tests: Test copy buffer image and blit hazards
2020-07-13 locke@lunarg.com syncval: Add copy buffer image and blit entry points
2020-07-13 locke@lunarg.com syncval: Use new generator in synchronization
2020-07-13 locke@lunarg.com tests: Fix test synchronization errors
2020-07-13 locke@lunarg.com syncval: Add dest image adjustment for compressed
2020-07-13 locke@lunarg.com syncval: Add new RangeEncoder and RangeGenerator
2020-07-13 jzulauf@lunarg.com syncval: Add context interface for detect/update
2020-07-13 jzulauf@lunarg.com layers: Enhance Subpass DAG tree information
2020-07-13 jzulauf@lunarg.com syncval: Adding race hazard support
2020-07-13 jzulauf@lunarg.com syncval: Add logical stage extension to exec scope
2020-07-13 jzulauf@lunarg.com sync: Add earlier/later stage maps to codegen
2020-07-13 jzulauf@lunarg.com syncval: Add image layout transition hazard checks
2020-07-13 jzulauf@lunarg.com tests: Add first image sync tests
2020-07-13 jzulauf@lunarg.com syncval: Add image sync validation for CopyImage
2020-07-13 jzulauf@lunarg.com tests: Add more flexible interface to VkImageObj
2020-07-13 jzulauf@lunarg.com tests: Add testcases for buffer region copies
2020-07-13 jzulauf@lunarg.com syncval: Init Sync Val Resource Hazard

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Ib945290815d94bdff93297daa0f3f700772e90fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301349Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

452ab092

15 Jul, 2020 14 commits

Tests: Change screen orientation for traces on Android · 6fe87f4a

authored Jul 10, 2020

This CL adds a reverse JNI call to our Android Native Activity that
sets the orientation of the screen based on width and height.

To achieve this we:
* Attach to the java thread once at the beginning to grab JNI env.
* Detach from the thread once when platform sends APP_CMD_DESTROY
* Set the orientation during test init

Bug: angleproject:4327
Change-Id: Ifbe31a6a84dd60a0dfe7d7032962c99b290d8b81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289054Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

6fe87f4a

Add buffer serialization capability · dc9743fb

authored Jul 14, 2020

Serializes buffers' states stored on CPU.
Gets buffers contents on GPU by mapping buffers to CPU's address space,
then copy their data. Unmap buffers after finish. Since this feature is
for tests only, it is only implemented for the Vulkan backend.

Adds buffer serialization to serializeContext method so that capture
replay regresssion testing now compares the states of buffers too.

Bug: angleproject:4817
Change-Id: Ic9b529701014d5ba8420023a021cd5ea381bd9a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2295950
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dc9743fb

GL: Fix issue with EXTBlendFuncExtendedES3DrawTest · a3ed8e19

authored Jul 09, 2020

The call to glBindFragDataLocationIndexedEXT was not being properly
forwarded through ANGLE because we assumed that if its location was
set, then its index was set, which is not always the case.
Fixed this, and also added a link status check after linking so the
error will properly propagate in the future.

Bug: chromium:1099763
Change-Id: I28981c04a3f2d6a59c239b35b3f7eb0c7f586804
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289653Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

a3ed8e19

Test Runner: Accept Chromium args. · debe4683

authored Jul 15, 2020

This change lets the test runner accept the same isolated script
parameter syntax as Chromium. It keeps the old parameter names so
the tests accept both. This will let us more easily integrate with
the Chromium Android test_runner.py script.

Also update the README which was missing a few flags.

Bug: angleproject:3162
Change-Id: Ic22b289a095418ffdaa19a04caa1b45c6c657872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300530Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

debe4683

Revise documentation on adding EGL extensions. · 5927706b

authored Jul 14, 2020

Provided more links and steps per earlier advice from geofflang@.

Bug: angleproject:4842
No-Try: true
Change-Id: I9c9361b4b71a63fd36f79a87d45e0f4b04c4140c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2297528
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5927706b

Capture/Replay: More ES 3.1 support · dd4723e3

authored Jun 23, 2020

This CL adds the following changes:
* Support variable block sizes for ASTC
* Support glMapBuffer
* Additional param captures

Test: Capture from beginning of Asphalt 8 and Aztec Ruins
Bug: b/150484427
Bug: b/160808198
Change-Id: Ic1041011c3f51c32dbf7bf7105f41dffb9460b87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2264832
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dd4723e3

Fix ANGLE_base_vertex_base_instance baseInstances type · 7ce16cda

authored Jul 14, 2020

First two appearances of baseInstances should have type
GLuint instead of GLint. It should be a typo.

Bug: angleproject:4838
Change-Id: I3df0dd9deb90a18bb2527ba24fe2ddd2766dd7f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298200Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>

7ce16cda

Metal: Compile default shader source files separately. · 3e0b61a9

authored Jul 06, 2020

- Previously all default shader files were included in one file named
  master_source.metal.
- Now they will be compiled separately and link together to generate
  binary shader.
- Also generate a debug binary variant that will be used in debug build.

Bug: angleproject:2634
Change-Id: Ic040835c4a729666e73afeba52f5be839b632396
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281784
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3e0b61a9

Metal: Implement MSAA default framebuffer. · 9277ee74

authored Jul 06, 2020

GL_SAMPLE_COVERAGE_VALUE is implemented by inserting gl_SampleMask
writing logic to fragment shader.

New test added: MultisampleTest.ContentPresevedAfterInterruption.
- Skip on D3D11 (Bug: angleproject:4609)

Bug: angleproject:2634
Change-Id: Ib44daf0baccc36ea320596d81713156047da059c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281783
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9277ee74

Fix stale validation cache on buffer deletion. · f9e01f12

authored Jul 14, 2020

When we would delete the currently bound element array buffer we
would neglect to invalidate a specific validation cache variable.
This incorrectly would let us skip buffer size validation and lead
to internal invalid memory accesses.

Bug: chromium:1105202
Change-Id: I23ab28ccd3ac6b5d461cb8745b930f4d42d53b35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298145Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f9e01f12

Roll glslang from fe24a54808c2 to b481744aea1e (5 revisions) · c44b2b25

authored Jul 15, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fe24a54808c2..b481744aea1e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I5a2aeacad2b865374b48a795ab0549e769beae68
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2299302Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c44b2b25

Roll SPIRV-Tools from 94667fbf66ee to 4c33fb0d3dba (12 revisions) · 1d498161

authored Jul 15, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/94667fbf66ee..4c33fb0d3dba

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I950abbbb6bf0533afa3f6be83e5e1c5505c97689
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2299301Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1d498161

Roll SwiftShader from cd0af6456eb1 to 1de497cc50ab (3 revisions) · 1647225f

authored Jul 15, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/cd0af6456eb1..1de497cc50ab

2020-07-14 natsu@google.com Support Gralloc3 in SwiftShader
2020-07-14 swiftshader.regress@gmail.com Regres: Update test lists @ cd0af645
2020-07-14 capn@google.com Undefine Bool after the headers that define them

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I45aa331794a5a6a2e6d0ab2b71259e7ab7b976ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2299300Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1647225f

Roll Vulkan-Loader from 0bc4c2ae7012 to d8f34456c819 (2 revisions) · c08b0ace

authored Jul 15, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0bc4c2ae7012..d8f34456c819

2020-07-14 shannon@lunarg.com build: Update known-good files for 1.2.147 header
2020-07-14 lenny@lunarg.com loader: Remove RTLD_DEEPBIND flag

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I1d439d5f01752b34969037731d19db95acb6fcba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2299303Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c08b0ace

14 Jul, 2020 9 commits

Revert "Vulkan: Enable VK_KHR_get_memory_requirements2 extension" · 4ad0f250

authored Jul 14, 2020

This reverts commit d98afb78.

Reason for revert: Suspected for angle_perftests failure. See issue.

Bug: chromium:1105609

Original change's description:
> Vulkan: Enable VK_KHR_get_memory_requirements2 extension
> 
> 1. Don't assume support for VK_KHR_get_memory_requirements2.
>    Enable the extension, if supported, during device creation.
> 2. Also let VMA fill in the function pointers for these commands
>    based on Vulkan API version -
>    1. vkGetBufferMemoryRequirements2KHR
>    2. vkGetImageMemoryRequirements2KHR
> 
> Bug: angleproject:4830
> Change-Id: Icd0b3baf56732b5f5f49f320c1feb996204169ed
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2293633
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

TBR=syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com

Change-Id: Ida9a333f897d87e7608d4fafe9da9f1fad0221e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4830
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298146Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4ad0f250

Update README.md to indicate GLES 3.1 conformance · 97d54a0e

authored Jul 09, 2020

This CL updates the README.md to indicate that ANGLE became OpenGL ES
3.1 conformant on July, 2020.

Bug: angleproject:3520
Change-Id: I5e93560ab7927a81b55bd6ed89abb5d78b704993
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289949Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

97d54a0e

Metal: Create a dedicated class for Window Surface. · 5e7b1c41

authored Jul 06, 2020

To distinguish it from PBuffer class in future.

Bug: angleproject:2634
Change-Id: I1e256a74584fb001158465cd3068925847231984
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281795
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

5e7b1c41

Roll Vulkan-Headers from 2a164e9680a5 to 858b13a1220a (1 revision) · 249db6da

authored Jul 14, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/2a164e9680a5..858b13a1220a

2020-07-13 oddhack@sonic.net Update for Vulkan-Docs 1.2.147

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I63fdb76434d1dc6091c69032687bf28ca098c95c
Bug: None
Tbr: jonahr@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296843Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

249db6da

Roll Vulkan-Loader from d704d1bc0e11 to 0bc4c2ae7012 (1 revision) · 8690a7d5

authored Jul 14, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d704d1bc0e11..0bc4c2ae7012

2020-07-13 bob@lunarg.com scripts: udpate_deps retry on clone or fetch failure

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I609edfa843eb5578c0db8e9b0f396f913e31f267
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296967Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8690a7d5

Roll SwiftShader from ad65826a2ab1 to cd0af6456eb1 (5 revisions) · 41ec1f4e

authored Jul 14, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/ad65826a2ab1..cd0af6456eb1

2020-07-13 capn@google.com Remove dead ASTC code for GLES
2020-07-13 capn@google.com Rename command classes to match API calls
2020-07-13 srisser@google.com Add decoder for BC6h
2020-07-13 sugoi@google.com Image dirtiness
2020-07-13 amaiorano@google.com Android: build against llvm-10 instead of llvm-7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I91433b218e1fff6994877f868445e252ca11e7c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296964Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

41ec1f4e

Roll glslang from 4e13c90944e9 to fe24a54808c2 (3 revisions) · 200f2b4a

authored Jul 14, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4e13c90944e9..fe24a54808c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Ib923f55a3c55925017480d0523695e3ac9aea668
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296966Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

200f2b4a

Roll Vulkan-Tools from 68bfbc219497 to 521eaacef67a (1 revision) · e1caaf54

authored Jul 14, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/68bfbc219497..521eaacef67a

2020-07-13 bob@lunarg.com scripts: udpate_deps retry on clone or fetch failure

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Ie1398e884c0c377738bb65bbdf6ca8cfa0c152d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296963Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e1caaf54

Vulkan: Fix resolve draw path · 95bfb3e5

authored Jul 08, 2020

If the draw path is taken for resolve, the internal shader previously
calculated (1+sum(sample.a))/sampleCount instead of
sum(sample.a)/sampleCount.  Additionally, due to a typo, the result was
rounded.

This change also fixes a number of off-by-one errors when calculating
src/dst offsets in blit/resolve path.

Tests are added to resolve from default to FBO and vice versa to
exercise the draw path which was otherwise never invoked for color
buffers.

Bug: angleproject:4746
BUg: angleproject:4092
Change-Id: I4b9c181339b89af44b27d61d27a6b3d88cde2eea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288224
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

95bfb3e5

13 Jul, 2020 6 commits

Vulkan: Enable VK_KHR_get_memory_requirements2 extension · d98afb78

authored Jul 10, 2020

1. Don't assume support for VK_KHR_get_memory_requirements2.
   Enable the extension, if supported, during device creation.
2. Also let VMA fill in the function pointers for these commands
   based on Vulkan API version -
   1. vkGetBufferMemoryRequirements2KHR
   2. vkGetImageMemoryRequirements2KHR

Bug: angleproject:4830
Change-Id: Icd0b3baf56732b5f5f49f320c1feb996204169ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2293633Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

d98afb78

Revert "Refactor DisplayGbm::generateConfigs" · 66d85686

authored Jul 13, 2020

This reverts commit 7d82d293.

Reason for revert: Suspect CL failing on Linux FYI Ozone

Original change's description:
> Refactor DisplayGbm::generateConfigs
>
> Bug: angleproject:4809
> Change-Id: I5f352f737bbd53c78d9e01055c17eabd17d5fb8a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278667
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

TBR=geofflang@chromium.org,jiajia.qin@intel.com,jmadill@chromium.org

Change-Id: I62c8a6a78d1ccfe8aa63bea7a9409229cd0059ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4809, chromium:1105208
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296041
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

66d85686

Multi-frames serialization + comparision for capture replay test · e5c18475

authored Jul 06, 2020

Changes how context states are serialized during capture run. Now,
context states are serialized after each frame until the end frame
is reached, or context is destroyed.

Adds an api to the trace files to query serialization results of
multiple frames. Makes change to CaptureReplayTest to serialize
multiple frames then compares the serialization results with the ones
retrieved from said api.

Adds to capture replay the ability to produce working, compilable trace
files even when end frame is not reached.

Adds to the generated trace files config information and makes
CaptureReplayTest utilize said config information to reproduce the exact
environment of the captured application.

Bug: angleproject:4817
Change-Id: Ie3d487af2bacf349dc3ff6f6b1b5f89e1169dc84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2282885
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e5c18475

Vulkan: Disable GL_EXT_robustness extension on Mali · 92ffd40e

authored Jul 08, 2020

Vulkan doesn't have a mapping extension to
GL_EXT_robustness, so we need to disable it.

Bug: angleproject:4823
Change-Id: If7b66c0eb7ba14b9349925af64ec2efcec9985a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287092
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

92ffd40e

Roll VK-GL-CTS from 44ef9e08c459 to 8726fda3f865 (8 revisions) · 5263d5e1

authored Jul 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/44ef9e08c459..8726fda3f865

2020-07-13 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-07-12 ilkka.saarelainen@siru.fi Add support for comments in amber index files
2020-07-12 ari.suonpaa@siru.fi Test texelfetch on uniform texel buffer with packed format
2020-07-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master
2020-07-06 piotr.byszewski@mobica.com Test transitions between command buffer states
2020-07-04 alexander.galazin@arm.com Update SPIR-V Tools/Headers and glslang
2020-07-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-07-04 alexander.galazin@arm.com Update Vulkan headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com
Change-Id: I48bc03267af2f66bb3794f31b060d74f4d4e1343
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294915Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5263d5e1

Roll Vulkan-ValidationLayers from 94f1ce331e85 to 04c82ec6f36f (9 revisions) · f3f891c5

authored Jul 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/94f1ce331e85..04c82ec6f36f

2020-07-13 s.fricke@samsung.com tests: Add Protected Resource VUIDs
2020-07-13 s.fricke@samsung.com layers: Add Protected Resource VUIDs
2020-07-10 timvp@google.com build: Add a virtual dtor to AspectParameters
2020-07-10 jan-harald.fredriksen@arm.com tests: Add VUID 04059
2020-07-10 jan-harald.fredriksen@arm.com layers: Add VUID 04059
2020-07-10 s.fricke@samsung.com tests: Add YCbCr Swizzle VUIDs
2020-07-10 s.fricke@samsung.com layers: Add YCbCr Swizzle VUIDs
2020-07-10 tony@lunarg.com layers: Remove leftover enum
2020-07-10 liyl@google.com chassis: Fix memory leaks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia30720d58d1b8f3c9cc5030da5c95576ec82519d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294696Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f3f891c5