- 16 Sep, 2020 16 commits
-
-
Jamie Madill authored
These were messing up the test runner when used in combination with the test runner's specific args. Make it an error if the arguments are used together. Bug: angleproject:3162 Change-Id: I6fa1c0fb346a8c376ca455f7f4bf0492cfc0198a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414931Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
For consistency with the rest of the backend. Level index variables were using the VK suffix while color index variables used Vk. Bug: angleproject:4881 Change-Id: I0c2799da34cdfe19cb04adbebba042ac8876af96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413155 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Charlie Lao authored
This moves the bit mask of attached color buffer to front end. No function change is expected. Bug: b/167301719 Change-Id: I4eec3a419560b91875260b812a036ceaaeb6b5bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410790Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
This matches the types used by GL and stored in the state. setStorage and setStorageMultisampled calls were using size_t instead with a number of unnecessary casts in places which are now removed. Bug: angleproject:4836 Change-Id: Ibb570f0c088a6f29abe10f513de27c30ba4dd098 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411697Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
Just showing the line and function isn't as useful. Bug: angleproject:3162 Change-Id: Ic8c2425a7a7e9992d2a569abd8ea0b7731fa69c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407834 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Cody Northrop authored
Test: angle_end2end_tests Bug: angleproject:5053 Change-Id: I7aef6b5babe8f582e7500464f53e65721eaf0520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414733Reviewed-by:
-
Ian Elliott authored
These tests fail on the Windows NVIDIA bots Bug: angleproject:5044 Bug: chromium:1128064 Change-Id: Idad4cc33d8e49b0b468b8e560b44f9a9c6a2f37f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414932Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Jamie Madill authored
Bug: angleproject:3943 Change-Id: I88c2ec8a9f49746f6ce9838b0d1c8e8ea0a8ae9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405806 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Alexey Knyazev authored
Enable BlendIntegerTest Add DrawBuffersTest.BlendWithGaps test Add BlendPackedTest Bug: angleproject:4548 Bug: angleproject:4571 Bug: angleproject:4583 Change-Id: I139183099b26f0fe1ac9e43f96d18b8ccb134a2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407772 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e59713d4edda..f105898a102f 2020-09-15 s.fricke@samsung.com layers: label VUID 04151 and 04152 2020-09-15 s.fricke@samsung.com layers: label VUID 04441 2020-09-15 tony@lunarg.com gpu: Handle KHR version of CmdDispatchBase 2020-09-14 s.fricke@samsung.com layers: Improve WSI related error messages 2020-09-14 s.fricke@samsung.com layers: label VUID 04448 2020-09-14 jzulauf@lunarg.com syncval: DRY/clean MakeRange computation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I13d028a7007a98f5db0fd4f78b32f8c0aa5c5843 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413555Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/726af6f78f80..e8ce4355ae1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I9b2f0c42cb0a6bf162fc99dd72e91498c002a1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413556Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc552fcef1fe..b33e0b36a08c 2020-09-15 natsu@google.com Support Gralloc4 in SwiftShader 2020-09-15 swiftshader.regress@gmail.com Regres: Update test lists @ dc552fce 2020-09-14 amaiorano@google.com CMake: normalize FOLDER property for third_party targets 2020-09-14 bclayton@google.com SpirvShaderDebugger: Add PRINT_EACH_DEFINED_DBG_INSTRUCTION 2020-09-14 bclayton@google.com SpirvShaderDebugger: Implement DebugValue 2020-09-14 bclayton@google.com SpirvShaderDebugger: Reduce lock contention If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I460dfa92d1606e2877a47b293a009a17d09b32dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413557Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/1960f3b23408..e4cbd27e4a55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc90e7d103..42cbd32cfb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a90362b4fc..3ff4f5027b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/598b9bd5a4..1d2f486547 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9967a97317..e73d966652 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bf815f1a74..e075ddd622 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8d1fa6cbe8..552c4cfa71 No update to Clang. Bug: angleproject:3162 Tbr: jmadill@google.com Change-Id: I0391f5aa9f047264315f7f7da056bef0f1eeeaef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2413478Reviewed-by:
-
Jamie Madill authored
These tables are used by both the GL and D3D11 back-ends. Also moves them to renderer_utils to be in a shared place. Bug: angleproject:3943 Change-Id: I1f5d79842396a87e795547fa03c6855d6f9c5e9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405805 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
The input types are string, not integer. Bug: angleproject:3162 Change-Id: Ib4cac4cc0d4556d607e10fd9b79e36dbed68a39d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411340Reviewed-by:
-
Jamie Madill authored
This was breaking the Skia roller. Bug: angleproject:3943 Change-Id: I5b54feb2e4abc8a6bf157e35f69aa12c7334dda2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411474Reviewed-by:
-
- 15 Sep, 2020 7 commits
-
-
Jamie Madill authored
Can be useful when doing captures to make the replay more portable. Bug: angleproject:5040 Change-Id: I3a045c636bc2638d601aff2536eed3d0e49c3643 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408714 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f8a5602c5560..9eaa69c21c45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ie7f53efaf59bac3060ce54bb413682b91871b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411963Reviewed-by:
-
Tim Van Patten authored
The current roll_aosp.sh is generating an invalid Android.bp by including the local repo's .git file: cc_genrule { name: "angle_commit_id", tool_files: [ "src/commit_id.py", ], cmd: "$(location) gen $(location commit.h)", srcs: [ ".git/refs/heads/rollAngle", ], sdk_version: "28", out: [ "commit.h", ], } This is fixed by enabling the GN arg 'angle_enable_commit_id=false' in the script: cc_genrule { name: "angle_commit_id", tool_files: [ "src/commit_id.py", ], cmd: "$(location) gen $(location commit.h)", sdk_version: "28", out: [ "commit.h", ], } Bug: angleproject:5050 Test: Manual verification in AOSP checkout Change-Id: I08a08084c4c25411b29b22544c2ed8c06f6f54d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412790Reviewed-by: -
Xinyi He authored
Implement supporting the array of array of image type in uniform. Add a new end2end test for it. Bug: angleproject:3881 Change-Id: Idd757ae1d0ed34d585ae1ca5e0b6577459a0acb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2379335 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
glRenderbufferStorageMultisampleEXT has different semantics from glRenderbufferStorageMultisample. This change makes this differentiation in the front-end and passes a flag to the backends. This extension is currently only supported on Vulkan and D3D backends. Support for the former will be done in a follow up. Support for the latter is not planned. Bug: angleproject:4836 Change-Id: I75bc3d7990a4b1ce06264280a386d5e467983b7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405396 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Charlie Lao authored
ANGLE packs FBO attachments from OpenGL and uses packed attachments to create VkFramebuffer and renderpass. When we use attachment index into the attachment array, we must be very careful to use packed index for vulkan objects. It is easy to make mistakes here and introduce hard to debug bugs. This CL defines a PackedAttachmentIndex class that uses that to index into vulkan attachments and pass around APIs so that compiler would catch the error when wrong index is used. This also introduces PackedClearValuesArray that stores clear value in packed attachment index so that it is impossible to mix it with ClearValuesArray that stores clear value in GL attachment index. Bug: b/167301719 Change-Id: I68680522c60beeb5096e5211eaef89da28c7097e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2410366 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
-
Jamie Madill authored
This will allow us to speed up test execution by using multiple processes on non-Windows platforms. Because of the process isolation of "bot mode" we don't run into display re-use bugs like we do when running in a single process. Bug: angleproject:3162 Change-Id: I25370d4a07236e34f87e1c1efef8684f9891ecf8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407835Reviewed-by:
-
- 14 Sep, 2020 17 commits
-
-
Charlie Lao authored
Manhattan is calling glFlush in middle of a renderpass. This CL defers the flush that issued in the middle of renderpass to the end of renderpass. Bug: b/166475273 Change-Id: I6baa3898d5efc456e2205c44e13c64f3d79d1464 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381942 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
-
Jamie Madill authored
Also has a few other tweaks to test spin-up. Bug: angleproject:3162 Change-Id: I8753f1afedbcc5c4b5ae257965ce68dc4a02ae06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407836 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
-
Jamie Madill authored
This moves more build configuration out of libGLESv2.gni. Bug: angleproject:3943 Change-Id: I58293f98c917e785cdf3bb1beb706f02ee8a3801 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405800Reviewed-by:
-
Jamie Madill authored
These tools are used by scripts/trigger.py and by the src-side testing. Also adds .vpython and .vpython3 spec files which can't be easily auto-rolled from the Chromium src/ repo. Bug: angleproject:5040 Change-Id: Ie6384c176b391dae4fe19582ec59c2c1d6ec22d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408717 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Tim Van Patten authored
ANGLE needs to set the attribute forceQueryable="true" to the AndroidManifest.xml to allow the Android framework to find the ANGLE package. Bug: angleproject:5035 Test: Manual verification Change-Id: I5ac1c18a584b72d3384978592065853f0a9456de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2406131Reviewed-by:
-
Jamie Madill authored
Bug: angleproject:5040 Change-Id: I64f762b4eb5734f0768054a330a36e20ff9ba93e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408713 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Charlie Lao authored
When draw buffers set to GL_NONE, instead of remove the attachment from renderpass which breaks renderpass, we force vulkan's per buffer color mask to false while keep the disabled draw buffer attached. This CL also always create FrameBuffer with all color attachments regardless it is enabled or not. Bug: b/167301719 Change-Id: Ice9fca9aacf774a47d13b749f822b222cc050174 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389007Reviewed-by:
-
Shahbaz Youssefi authored
glRenderbufferStorageMultisampleEXT is special in that it doesn't have the same semantics as glRenderbufferStorageMultisample, but is aliased in gl.xml for the sake of desktop GL (where it does have the same semantics). This change special-cases this function so multisampled-render-to-texture renderbuffers can be supported. Bug: angleproject:4881 Change-Id: Iaa321dd0671dd82ea802df22a1ae935942789c21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405395Reviewed-by:
-
Le Hoang Quyen authored
Bug: angleproject:2634 Change-Id: I36e5a6a4cb11d82f666c410b33fdb39ad35a5e80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336557Reviewed-by:
-
Jamie Madill authored
This will allow the isolation scripts to correctly package the trace data GZ file. Bug: angleproject:5040 Change-Id: I9e0229701eb10ea5e46b79304c8da47a42ba552d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408718 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This allows us to use the sample for benchmarking. Bug: angleproject:5040 Change-Id: I9177d04b270a0588dc5f261918eb27b0bc734256 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408716 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This moves the debug callback code into a common location. For ease of access it's in shader_utils since that file has access to the GL API. Bug: angleproject:5040 Change-Id: Iab9de47c2d520a5618ea6825852f8afa63565c8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408715 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Amy Liu authored
The input coordinates of blitResolveStencil compute shader start from 0,we need to align the sample position to start from 0 if x/y is flipped. Test: dEQP-GLES3.functional.fbo.invalidate.*.unbind_blit_msaa_* Bug: b/159995959 Change-Id: If0c9f5b7cacddbe1a2d7062469a757a63bcc1378 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392162 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41974f57973e..dc552fcef1fe 2020-09-11 capn@google.com Drop the float literal suffix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I30a1c103cea3d1b53a3af8d03ab611c545bbf0e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409384Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/45f2f18a69eb..399f7fd741f7 2020-09-11 pdaniell@nvidia.com loader Fix issues with physical device sorting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I6e7d4257242966479d0b36beecc8432f8086bc4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409383Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3114c91b037b..e59713d4edda 2020-09-12 mark@lunarg.com corechecks: Remove memory shadow copies 2020-09-11 jzulauf@lunarg.com syncval: Add missing WAW suppression 2020-09-11 tony@lunarg.com gpu: Pass-through driver-returned PipelineFeedback data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I80145595ddb4f398a7621598aad0155c743f7bce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409381Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2de7d3af0c0e..726af6f78f80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I26842b1895871dd0922bd8be0a1f9c81d2cac537 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409382Reviewed-by:
-
