Commits · 243d0f899e443cd931c78aba7489382dff79edbb · Chen Yisong / angle

10 Oct, 2020 7 commits

Vulkan: Avoid content restore by detecting no-op stencil · 243d0f89

authored Oct 08, 2020

Previously, as long as stencil was enabled, it was considered that it is
also being modified. This caused stencil invalidate to be undone in a
number of situations, such as:

- glEnable(GL_STENCIL_TEST); // with func/ops default
- glDrawArrays();
- glInvalidateFramebuffer([GL_STENCIL_ATTACHMENT]);
- glClear(GL_DEPTH_BUFFER_BIT);
- Close render pass

In the above scenario, invalidation of stencil was undone at the end of
render pass.

In this change, the following cases are considered read-only stencil:

- Func = GL_NEVER, stencilFail = GL_KEEP
- Func = GL_ALWAYS, stencilPassDepth* = GL_KEEP
- stencilFail = GL_KEEP, stencilPassDepth* = GL_KEEP

Note that while the above scenario is fixed for no-op stencil, a similar
issue persists if stencil was not no-op.  The reason stencil invalidate
is undone in that case is due to the fact that it's assumed any command
after the invalidate call will be a draw call that outputs to stencil,
but that is not the case with the glClear call in this example.

Bug: angleproject:4836
Change-Id: Ie2ea2d52b7c8ee2394f5456773a7ef434e2b2b16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461465
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

243d0f89

Vulkan: Clear depth by shader if depthClamp not supported · 6c1c3bd9

authored Oct 09, 2020

This will avoid breaking the render pass when clearing depth through
clearWithDraw if the depthClamp Vulkan feature is not present.

Bug: angleproject:4836
Change-Id: I845fd5074dd95f6896da89f9e119ebc5000a5688
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462719
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

6c1c3bd9

Vulkan: Restore at the end of RP if write-after-invalidate · e5d52ac3

authored Oct 08, 2020

If a depth/stencil attachment is invalidated, but subsequently drawn to
in the same render pass, undo the invalidate when the render pass is
closed.  Adapted from
https://chromium-review.googlesource.com/c/angle/angle/+/2386478.

Bug: b/167275320
Bug: angleproject:4836
Change-Id: I17a35bfd692ddc403ceaa6ec44b5c4f16ff9eed6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461464
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

e5d52ac3

Vulkan: Use depthClamp to clear depth where available · f8070feb

authored Oct 09, 2020

This will avoid breaking render pass if clearing depth in clearWithDraw.

Bug: angleproject:4836
Change-Id: I50242d1115efc91059923143f6ae5fd25fb3d36f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462717
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f8070feb

Vulkan: Boilerplace for vkCmdSetScissor · dd4b6445

authored Oct 09, 2020

Bug: angleproject:4836
Change-Id: I4fa5355fc3e7fcf3ecd091d299c5c0c8d3a74732
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463984
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dd4b6445

Vulkan: Invalidate/restore depth/stencil separately. · 61fa0878

authored Oct 08, 2020

Depth/stencil content defined is already tracked separately in the
ImageHelper.  This change exposes this tracking from RenderTargetVk.

Bug: b/167275320
Bug: angleproject:4836
Change-Id: Ie6520e7a4ab557eb233c60c6ab0d4a8f8f098bf6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462039
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

61fa0878

Metal: Disable fence sync extension on Nvidia · 87f3f4b5

authored Oct 09, 2020

The following tests are flaky on Mac FYI Retina Release (NVIDIA), so the
Metal fence sync extension is being disabled for Nvidia.

Bug: chromium:1136673
Change-Id: I7e99f558950c6e867318e27f27bb526b4c209fcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463516
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

87f3f4b5

09 Oct, 2020 16 commits

Vulkan: Support invalidate of MSRTT attachments · 5081f89b

authored Oct 02, 2020

Invalidate was previously affecting only the storeOp of the color and
depth/stencil attachments.  With multisampled-render-to-texture
attachments, the storeOp of the resolve attachments were not being
affected.

This change implements the latter, attempting to remove the attachment
altogether if possible.  With MSRTT depth/stencil buffers, this makes
possible the ability to never write depth/stencil data to memory.

Bug: angleproject:4836
Change-Id: I53599e2f4ed6c390dfd03bf226274f6f53f438bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2437506
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5081f89b

Vulkan: Call onColorDraw in resolveColorWithSubpass · a3d5a6e3

authored Oct 07, 2020

We are currently calling onImageRenderPassWrite() on the read render
target within resolveColorWithSubpass(). We need to instead call
onColorDraw() on the draw render target, since that's what's actually
being written.

Bug: b/159903491
Test: CQ
Change-Id: I577381d91228e132950455d2e872fbb9b066d0c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458850Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

a3d5a6e3

trigger.py: Append user tag. · a1477bef

authored Oct 09, 2020

This puts the output of 'whoami' into the user tag. This is useful for
finding your triggered swarming tasks.

Implemented while working on triggering standalone dEQP test runs.

Bug: angleproject:5157
Change-Id: Ic850726485a96408c8f2ded36195268eabb275f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463370Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a1477bef

Add perf-alert monitoring instruction to docs · 75de9ef2

authored Oct 02, 2020

Bug: angleproject:1944
Change-Id: Idee9a3b749b7f618c221f85be54e1331259a8dce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446852
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

75de9ef2

Vulkan: DepthStencil layout should use both early and late stages · 848ab12d

authored Oct 08, 2020

Vulkan spec 6.1.2 says "Including a particular pipeline stage in the
first synchronization scope of a command implicitly includes logically
earlier pipeline stages in the synchronization scope. Similarly, the
second synchronization scope includes logically later pipeline stages.
However, note that access scopes are not affected in this way - only the
precise stages specified are considered part of each access scope." For
depth stencil layout, both early and late fragment test stages could
access it, thus we should include both in the src and dst stage mask.

Bug: b/169498230
Change-Id: Ifd2f6f7e9947c95248ae400353ae6570912be560
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461631
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

848ab12d

Declare ozone_platform_gbm when angle doesn't have build · 450209c3

authored Oct 09, 2020

Otherwise, it causes build breakages to other projects that depend on
it, such as Skia project.

Bug: angleproject:5146
Change-Id: I09d8e175fa76fb098a0836c2542986609fae7757
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462721Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

450209c3

Remove gaps in Framebuffer::DirtyBits · efc0aaf4

authored Oct 06, 2020

Bug: angleproject:4836
Change-Id: Ia36563eefaa7f6a84ad70db27e0abc5f9fcba703
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453465Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

efc0aaf4

Vulkan: Move content-defined tracking to ImageHelper · 2392e6b3

authored Oct 07, 2020

Content-defined tracking was done in render targets prior to this
change.  This had multiple drawbacks:

- When a framebuffer attachment is changed (including the first time
  it's set), it's unknown whether the contents of the attachment is
  defined.
- Invalidate takes effect at the end of render pass, at which point the
  render target objects may be gone.  Attachment ImageHelpers are
  however correctly tracked.

This change moves content-defined tracking to the ImageHelper itself,
and tracks it per subresource.  ImageHelper::onWrite() now receives the
subresource that is being written, and marks it as having defined
content.

A future optimization can make use of this change to
ImageHelper::onWrite to track "dirty" subresources.  This can lead to
the removal of unnecessary barriers when same-kind writes are done on
different subresources of the image.  See http://anglebug.com/3347#c15

Bug: b/167275320
Bug: angleproject:4836
Change-Id: Iabd1dace4eae9eb379453a9eb7ec6eafc9db1aef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462036
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

2392e6b3

Suppress Mac/GL test failures with standalone runner. · b2ff69f8

authored Oct 09, 2020

These tests fail when run in certain orders with display reusei
on the bots. See issues for list of suppressed tests.

Bug: angleproject:5154
Bug: angleproject:5153
Change-Id: I1b4a523ba000785f4f8c26eeb236c518481ed7af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462715
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b2ff69f8

fix an instance of bugprone-unused-return-value · c759206c

authored Oct 07, 2020

This new clang-tidy check fires when the result of a function like
`unique_ptr.release()` is unused. Sometimes this is intentional, other
times, it's not (e.g., the dev intended to `.reset()`).

Bug: chromium:1134714
Change-Id: I9b6bc9e847e5c27d68707a4f33d37b225ded34fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458188
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

c759206c

Roll SPIRV-Tools from fc8264854c53 to c2553a315f5c (5 revisions) · 5291cbad

authored Oct 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc8264854c53..c2553a315f5c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: If001c4eb01adfdc349719f9aab8bb77722a1d123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463245Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5291cbad

Roll SwiftShader from 952149303d06 to 51b03d58fb17 (2 revisions) · 1cf632e0

authored Oct 09, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/952149303d06..51b03d58fb17

2020-10-09 bclayton@google.com SpirvShaderDebugger: Fix store() of arrays
2020-10-09 bclayton@google.com SpirvShaderDebugger: Improve ASSERT() messages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I58214fff9f6b91f592033e07e50aa40a6afe9a83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463244Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1cf632e0

Roll Vulkan-ValidationLayers from 24184fe81c6f to 0046c31f2f96 (2 revisions) · 500eeff4

authored Oct 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/24184fe81c6f..0046c31f2f96

2020-10-08 nathaniel@lunarg.com layers: Fix ImageView format compatibility error
2020-10-07 shannon@lunarg.com build: Update known-good files for 1.2.156 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ieec1da74d36bd07a4c1eaa114e44986a5e4de10b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463243Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

500eeff4

Roll Vulkan-Loader from dc8a96d60b6b to 14ad927e679a (2 revisions) · f30ae360

authored Oct 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dc8a96d60b6b..14ad927e679a

2020-10-08 dorian.apanel@gmail.com Handling also zero size override paths.
2020-10-08 dorian.apanel@gmail.com loader: Override layer load when custom allocator used.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ib7634589744013e845ae600dffa3fe6f853a3f32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463242Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f30ae360

Roll Chromium from 090102a7065c to 77bfcdcde874 (466 revisions) · fc8f5e0a

authored Oct 09, 2020

https://chromium.googlesource.com/chromium/src.git/+log/090102a7065c..77bfcdcde874

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d058068a4b..f12b0ac8bf
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/17295a5c35..26fd14f32d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7054864146..ed409570c0
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: Ib54c76f7997a6cac606d68532fd67cd98ad7a59c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462165Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

fc8f5e0a

Suppress gl_test failures on Mac ARM64 (Apple DTK) · e0780931

authored Oct 08, 2020

BuiltinVariableFragDepthClampingFloatRBOTest.Below1/ES3_OpenGL
CopyTexImageTest.DeleteAfterCopyingToTextures/ES2_OpenGL
GLSLTest.MaxVaryingVec2Arrays/ES2_Metal
GLSLTest.MaxVaryingVec3ArrayAndOneFloatArray/ES2_Metal
GLSLTest.MoreNestedCompoundStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedCompoundStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedStructsWithSamplersAsFunctionArg/ES3_OpenGL
MipmapTestES3.BaseLevelTextureBug/ES3_OpenGL
MipmapTestES3.GenerateMipmapBaseLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapCubeBaseLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapMaxLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapPreservesOutOfRangeMips/ES3_OpenGL
OcclusionQueriesTest.MultiQueries/ES2_Metal
Texture2DBaseMaxTestES3.GenerateMipmapAfterRedefineAndRebase/ES3_OpenGL
Texture2DFloatTestES2.TextureFloatLinearLegacyTest/ES2_Metal
Texture2DFloatTestES2.TextureFloatLinearLegacyTest/ES2_OpenGL
Texture2DFloatTestES2.TextureFloatLinearTest/ES2_Metal
Texture2DFloatTestES2.TextureFloatLinearTest/ES2_OpenGL
Texture2DFloatTestES3.TextureFloatLinearLegacyTest/ES3_OpenGL
Texture2DFloatTestES3.TextureFloatLinearTest/ES3_OpenGL
TimerQueriesTest.TimeElapsed/ES3_OpenGL
TimerQueriesTest.TimeElapsedMulticontextTest/ES3_OpenGL
WebGLCompatibilityTest.TextureCopyingFeedbackLoops/ES2_OpenGL
WebGLCompatibilityTest.TextureCopyingFeedbackLoops/ES3_OpenGL

Bug: chromium:1132295
Change-Id: If64dc67275063c8046dbc941d92de273fbc226e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461674
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e0780931

08 Oct, 2020 16 commits

GL: Work around Mac glBindBufferRange issue. · cd8eb564

authored Oct 08, 2020

Mac GL drivers generat errors when binding transform feedback buffers
with glBindBufferBase/glBindBufferRange when the buffer has not been
bound to any binding point before. Work around this by simply binding
the buffer first.

Bug: angleproject:5140
Change-Id: I1895f8367412135c100a5072117c929be8a8e90b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461826
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cd8eb564

Target the "absl" component for component builds. · 36f0464a

authored Oct 08, 2020

When performing a component build, we need to make sure our targets are
accessing abseil from the component when is_component_build=true.

Bug: chromium:1134776
Change-Id: Iaf5ee7176b4b8d84b3bafeaa259e476062a1e1dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461454Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

36f0464a

Suppress TransformFeedbackTest.RecordAndDrawWithScissorTest · f8117992

authored Oct 08, 2020

TransformFeedbackTest.RecordAndDrawWithScissorTest is flaky on
"Mac Pro FYI Release (AMD)", so suppressing for now.

Bug: chromium:1135841
Test: TransformFeedbackTest.RecordAndDrawWithScissorTest
Change-Id: If610d7868950d1e2663c52b5194f6065a5900525
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461455Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f8117992

Support RGB -> BGRX copies in copySubImage. · 57f86257

authored Oct 08, 2020

This was showing up in the following test for me on OSX:

IOSurfaceClientBufferTest.CopySubImageToBGRX8888IOSurface/ES2_Vulkan_SwiftShader

Test: angle_end2end_tests on OSX 10.15
Bug: angleproject:5147
Change-Id: I666dc832e8be33cde1617c849990c6092f4e2240
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462041Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

57f86257

Vulkan: Disable vkCreateDevice-physical-device-features-not-retrieved · 4dae43d8

authored Oct 08, 2020

Disable
UNASSIGNED-BestPractices-vkCreateDevice-physical-device-features-not-retrieved
while the Khronos issue is investigated.

Bug: angleproject:5149
Change-Id: I680cf264d6356cf219826902d7fdf2304e27ebab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461475
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

4dae43d8

Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount · a5db7d6e

authored Oct 08, 2020

Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount while the
Khronos issue is investigated.

Bug: angleproject:5148
Change-Id: If3cd4b028182a06411b928417e7c778ea02189d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462075Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

a5db7d6e

Document how to revert/reland a CL · a2491911

authored Oct 07, 2020

Bug: angleproject:5141
Change-Id: I9a0a2ae18dc298250f8fc6fba2eb0042a31dc369
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458846
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

a2491911

Vulkan: Add resolve/unresolve counters · 887b1346

authored Oct 02, 2020

With this change, render-pass-related counters are calculated at render
pass creation time and stored alongside the render pass handle (and
serial) in the render pass cache.  On every use, the render pass'
counters are accumulated over the global counters.

Additionally, this change adds MSRTT resolve and unresolve counters to
render pass counters.

Bug: angleproject:4836
Change-Id: If15a789e5a7d66c7ea5a2315bc76fe045ce57491
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444099
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

887b1346

Pass in Command::Clear to framebuffer syncState · 102074d1

authored Oct 06, 2020

In preparation for some clear-related optimizations.

Bug: angleproject:4836
Change-Id: I32ceb2b8a690ed13dac81e1ffe073436d6e24421
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453464
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

102074d1

Metal: Implement fence sync · 6dfd855a

authored Mar 25, 2020

Bug: angleproject:2634
Change-Id: If1f7bb12c0e661c8e4b5677798a92440995819e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433325
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6dfd855a

Roll Vulkan-ValidationLayers from e171d8431cfa to 24184fe81c6f (3 revisions) · 0c046aff

authored Oct 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e171d8431cfa..24184fe81c6f

2020-10-07 nathaniel@lunarg.com refactor: Move CALL_STATE into best_practices
2020-10-07 mark@lunarg.com readme: Update contact info
2020-10-07 lionel.g.landwerlin@intel.com tests: Keep QueryPerfIncompletePasses from triggering VU00817

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I3e13c7764bb430c93f48a97a7395d5f2f3f27f68
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461388Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c046aff

Roll glslang from bacaef3237c5 to 2067d1a93e6e (8 revisions) · a8bb3df7

authored Oct 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bacaef3237c5..2067d1a93e6e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I95e50c1daf8e032cdd70dfe9126c8d58d82ac610
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461387Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a8bb3df7

Roll Vulkan-Loader from a638f3acae94 to dc8a96d60b6b (2 revisions) · 5f00d6bc

authored Oct 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a638f3acae94..dc8a96d60b6b

2020-10-07 pdaniell@nvidia.com Fix formatting issue.
2020-10-07 pdaniell@nvidia.com Fix some issues when EnumerateAdapterPhysicalDevices is available

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ief8353ba32e633b83f4135bd5dc2d00bb6349e13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461406Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5f00d6bc

Roll SwiftShader from 635de036d766 to 952149303d06 (2 revisions) · cfd451ed

authored Oct 08, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/635de036d766..952149303d06

2020-10-08 bclayton@google.com SpirvShaderDebugger: Have Function inherit LexicalBlock
2020-10-07 capn@google.com Remove float division-by-zero prevention

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I46e38b5ec92086f750ce42ae4423fcf8e19700c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461407Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cfd451ed

Roll Chromium from a5a8696e5087 to 090102a7065c (466 revisions) · 6a09a9d4

authored Oct 08, 2020

https://chromium.googlesource.com/chromium/src.git/+log/a5a8696e5087..090102a7065c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/854fdb73c8..d058068a4b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0fa2c0deee..17295a5c35
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/54a9cb2f54..c89bad5e6d
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cc0ee19df9..7054864146
* tools/skia_goldctl/linux: dMvix4BkhDJmKBK1tudaxlOMub1Dif3ZPcqzSY72-ZAC..ehm_yIO4CdwsvaJZJPQ2xBXAFv3KXEgrDpTY3AaK7EYC
* tools/skia_goldctl/mac: xJncEfNMb0HaDG9EglMx2YNbKAxqk6qJbckhfn0BXb8C..wIHfWG-DQOw0ISbpkWZrm2f2GoKa3H1Z4I2w8MxhlVIC
* tools/skia_goldctl/win: cLgS219WFD65Hr6NfoCQYA5KEE2FfO3FBl30KYhpTFoC..ixP2POw1dVLvzG-YPiGAJdFrTLwpr--nwyQr_S5FoRkC
No update to Clang.

Bug: angleproject:5038,angleproject:5124
Tbr: timvp@google.com
Change-Id: Ic1b5300ae727a297ac0628c46d37c994eeb6c6fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458792Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6a09a9d4

Add a test for deferred clears and 0-sized scissor clears · 1a87f1f0

authored Oct 06, 2020

The Vulkan backend no-ops such clears before flushing deferred clears.
Deferred clears are actually not gathered when doing a scissored clear,
so this is not an issue.  An ASSERT is added along with a regression
test.

Bug: angleproject:4836
Change-Id: I5ea5bab499ced41e13023ffb6b821e3caefb9ab2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453466
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

1a87f1f0

07 Oct, 2020 1 commit

Ensure a CGL context is current for WindowSurfaceCGL. · 36ccb695

authored Oct 07, 2020

WindowSurfaceCGL does quite a bit of emulation using GL textures and
renderbuffers but some of these operations need to happen during EGL
functions when there may be no native context current.

Add a helper that ensures a context is current for operations that
manipulate GL objects.

Bug: angleproject:5138
Change-Id: Ic9f87aa26fd178a40510836c3aca8814382f92e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2456051Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

36ccb695