This enables implementing specialized variants of TIntermTraverser.
Intermediate subclasses of TIntermTraverser are expected to maintain
contextual information in their traverse* functions, which is then used
by the visit* functions in the actual traversers.

This approach is better than adding a flag to TIntermTraverser, since
it will make the code cleaner and easier to understand.

Traverse() functions in TIntermNode subclasses are still kept around to
redirect calls to TIntermTraverser traversal functions. This is less
hacky than choosing the function with switch/case in TIntermTraverser
would be, and if new TIntermNode subclasses get added, it's not as likely
that adding the traversal support would be forgotten.

TEST=angle_unittests
BUG=angleproject:1116

Change-Id: Ie6889be1d7e955518f13cd3390dce17871ba49b5
Reviewed-on: https://chromium-review.googlesource.com/292720Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:890

Change-Id: Id55d941a95cf38f825b9a52fc8043e0e129f7a82
Reviewed-on: https://chromium-review.googlesource.com/292631Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1119

Change-Id: Ie3de5a776b5860b1ca502cee9e2b19c41cd3bfb2
Reviewed-on: https://chromium-review.googlesource.com/292051Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Cooper Partin <coopp@microsoft.com>

BUG=angleproject:1119

Change-Id: I99572711ceeae94fb920d197c86e741945d3b60b
Reviewed-on: https://chromium-review.googlesource.com/292279Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1119

Change-Id: I2c879193dc122e6c45d0462abc91f39f5d332506
Reviewed-on: https://chromium-review.googlesource.com/292156Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1119

Change-Id: Ibc7cfdea72abe402cbfa1c10e0ada7576fa1cfa2
Reviewed-on: https://chromium-review.googlesource.com/292052Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1040
TEST=angle_end2end_tests,angle_perftests,WebGL

Change-Id: If471cfb9676795d5cc985eea52ad7144d4544ed1
Reviewed-on: https://chromium-review.googlesource.com/289559Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Under certain situations an integer overflow could lead to ANGLE
writing to places where it shouldn't.

BUG=518206

Change-Id: I9217685daecb160a4072fbf79c26e5bee9f4621e
Reviewed-on: https://chromium-review.googlesource.com/292391Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

f8dd7b10 fixed unnecessary shader compiles, but introduced a draw
call perf regression. Fix the regression robustly by storing a
minimal set of input layout elements/vertex attribute info,
but also handle the case where the vector sizes mismatch between
a cached and new vertex layout.

Reland with fix for comparison warning.

BUG=510151

Change-Id: I578ddbb5b5bb12e7c1a901f23c7b5fcbd64b5d23
Reviewed-on: https://chromium-review.googlesource.com/292460Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=504872

Change-Id: Ib69830a556fe06c111f41d78811c7115b0d8314c
Reviewed-on: https://chromium-review.googlesource.com/292450
Tryjob-Request: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

size_t comparison warning in Win32.

src\libangle\renderer\d3d\programd3d.cpp(2084) : warning C4018: '<' : signed/unsigned mismatch

BUG=510151
This reverts commit bf3f780c.

Change-Id: I5565b697ca29270375049f3e855437fa19157de9
Reviewed-on: https://chromium-review.googlesource.com/292331Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

f8dd7b10 fixed unnecessary shader compiles, but introduced a draw
call perf regression. Fix the regression robustly by storing a
minimal set of input layout elements/vertex attribute info,
but also handle the case where the vector sizes mismatch between
a cached and new vertex layout.

BUG=510151

Change-Id: If5e9ea4a4c9edaa7a78c8daa44bbe7d9927dc4e4
Reviewed-on: https://chromium-review.googlesource.com/292390Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

This fixes a bot compilation failure that started happening after
unittest started using Display stuff that use X11. Because
angle_unittests was linking against libANGLE and not libGLESv2, it
didn't get linked to X11, which produced a link error.

BUG=

Change-Id: I8f1f0dbcb13bb7c9897f235b72c4d4896a7b8a6c
Reviewed-on: https://chromium-review.googlesource.com/292380Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

The code is from http://smhasher.googlecode.com/svn/trunk/
revision 152.

Fixes error:
../../src/third_party/murmurhash/MurmurHash3.cpp:57:41: error: inlining failed in call to always_inline ‘uint32_t getblock(const uint32_t*, int)’: function body can be overwritten at link time
 FORCE_INLINE uint32_t getblock ( const uint32_t * p, int i )

The error was previously fixed by adding a pragma to ignore the warning.

The problem the compiler is complaining is that the function is visible
to outside of the compilation unit. This can be fixed by making the
function inline (as in the new version of the MurmurHash3.cpp) or
static.

Change-Id: I7a1262964489d72de8b4707ca2284363c8b46e20
Reviewed-on: https://chromium-review.googlesource.com/291620Tested-by: Kimmo Kinnunen <kkinnunen@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Tested-by: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

In an expression like a[ind]++, a[ind] is required to be an l-value but
ind is not. Reset the l-value required flags before traversing the index
of an indexing operation, so that this is accurately tracked. After the
index has been traversed, the previous state of the l-value required
flags is restored.

New tests are added to angle_unittests cover this functionality.

TEST=angle_unittests
BUG=angleproject:1116

Change-Id: I8929ec01e85e672c83ef7d385e455b7df8682f4b
Reviewed-on: https://chromium-review.googlesource.com/290561Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

This functionality is refactored out of EmulatePrecision to be a common
feature of TIntermTraverser. This is done since tracking where l-values
are required will be useful for other traversers. For example, it will
be needed for converting dynamic indexing of matrices and vectors to
function calls. This change adds some overhead to all tree traversers,
but the overhead is expected to be small for typical shaders which don't
contain too many user-defined functions.

BUG=angleproject:1116
TEST=angle_unittests

Change-Id: I54d34c2b5093ef028f2b24d854c11c0195dc1dbb
Reviewed-on: https://chromium-review.googlesource.com/290514Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

BUG=angleproject:890

Change-Id: If10ea7e1cb670bb3cd6fdcf40344d1c1e0acd862
Reviewed-on: https://chromium-review.googlesource.com/291650Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1040
TEST=angle_end2end_tests,angle_perftests,WebGL

Change-Id: I72beaf7e178e042440337fbb8b9669638c5ad016
Reviewed-on: https://chromium-review.googlesource.com/289558Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Pull over the more recent changes from Chromium which include the
graphics API, which we can use for specific API suppressions for
the dEQP tests.

Also update the docs with detailed steps for updating from Chrome.

BUG=None

Change-Id: I0cb7d8268fbb2778c0160a58f1a10ef4a92c9c61
Reviewed-on: https://chromium-review.googlesource.com/287810Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Exposes gl_SecondaryFragColor, glSecondaryFragData[] and
gl_MaxDualSourceDrawBuffers to GLES SL 1.0.

Relaxes rules for undefined output locations for GLES SL 3.0
and exposes gl_MaxDualSourceDrawBuffers.

If the output GL context is GL ES 2.0 or 3.0:
The emulation layer is expected to turn on EXT_blend_func_extended
if the output GL context supports it.

If the output GL context is GL:
The emulation layer is expected to turn on EXT_blend_func_extended
if the output GL context supports ARB_blend_func_extended or if GL
context is 3.2 or later.

If the source shader spec is GLES SL 2.0: The emulation layer is
expected to inspect the shader compilation output variables upon
linking. If output target is GL SL, the emulation layer should bind
color location 0, index 1 to "angle_SecondaryFragColor" if variable
"gl_SecondaryFragColorEXT" is used. Alternatively, emulation layer
should bind "angle_SecondaryFragData" to locations 0,1,2,3,..., all
color index 1, if "gl_SecondaryFragData" array is used.
(The caller can not bind the locations or specify output variables.)

If the source shader spec is GLES SL 3.0:
The emulation layer is expected to do location auto-resolve of the
the output variables that have undefined output locations that have
not been bound by the caller.
(The caller can not use gl_ built-ins, so nothing to do with those.)

BUG=angleproject:1085
TEST=angle_unittest

Change-Id: I5cafe205b0c29478b0dcd24aa89a7b0000f5d046
Reviewed-on: https://chromium-review.googlesource.com/287580Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Kimmo Kinnunen <kkinnunen@nvidia.com>

When mocking functions gmock uses the keyword virtual instead of
override and this conflicted with our usage of override for the
destructor (there is a warning for using all one or the other).

BUG=

Change-Id: I9dd9204d5755dd3a588a32d438de3c1018ba07cd
Reviewed-on: https://chromium-review.googlesource.com/291630Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This avoids a flickering of the window at the start of every test.

Reland with a speculative fix for ViewportTest

BUG=angleproject:1105

Change-Id: I83e89881de5b6f58cfb3e14cbe324fd9547f2836
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/288533Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Previously ViewportTest would rely on the scissor being set to the
size of the window by default, which is a fragile assumption as the
scissor is set to the size of the window only on the first makeCurrent.

BUG=angleproject:1105

Change-Id: I088565c7032fe817eb5c48a5351cc678fe42b376
Reviewed-on: https://chromium-review.googlesource.com/291310Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Always size input layouts to gl::MAX_VERTEX_ATTRIBS, and use '1' bits
to signal where we have a GPU conversion. The simplification allows us
to more cleanly match the vertex executable signatures and makes our
default VertexExecutable hit much more often.

BUG=510151
TEST=angle_end2end_tests,Canary WebGL, manual testing with Chromium

Change-Id: I5009323c4e7e208e7a2595be46658c344517a4ff
Reviewed-on: https://chromium-review.googlesource.com/290740Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Add end2end tests and unittests.

BUG=angleproject:970

Change-Id: Ie8306971730a793f08dfd09ead1bfd6ff3e4623d
Reviewed-on: https://chromium-review.googlesource.com/291260Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

This reverts commit 22a4f38c.

Change-Id: I07acbfe28d11675236de2ea7f6b050c25f80579a
Reviewed-on: https://chromium-review.googlesource.com/290960Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

This reverts commit 52ff4ac9.

Change-Id: I11ec6e7e343dd6579f7aa13106facc65b05eb795
Reviewed-on: https://chromium-review.googlesource.com/290940Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:970

Change-Id: Ic7f451fb4c2378c7574ede7c513a5bb9d903c908
Reviewed-on: https://chromium-review.googlesource.com/290920Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Add end2end tests and unittests.

BUG=angleproject:970

Change-Id: I13fc501b24c3f11bfedc810c1ff80fcf1318877c
Reviewed-on: https://chromium-review.googlesource.com/287343Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

This helper allows us to quickly iterate state bits from the
Impl/Renderer layers.

Re-land with no C++11 usage.

BUG=angleproject:1040
TEST=angle_unittests (Mac/Win/Linux)

Change-Id: I3b6d5beb2bcff7fa3d45c9220d7c026c64c45d2e
Reviewed-on: https://chromium-review.googlesource.com/290153Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This enables inserting helper functions as an AST transformation.

BUG=angleproject:1116
TEST=angle_unittests

Change-Id: I169d4d3a726d0e389cb3444fe9dfb4c6c5d80155
Reviewed-on: https://chromium-review.googlesource.com/290513Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

This is very tiny code cleanup and is a noop behavior change.

BUG=

Change-Id: Ib850ff88eafa0bd45bb389de1b74b1e9fe4c6d8b
Reviewed-on: https://chromium-review.googlesource.com/290146Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

On CGL, the default framebuffer will have a name different than 0 and
without this change it wouldn't get special-cased as on the other
platforms. It is assumed that the default framebuffer will get
initialized directly by the driver or other parts of the code.

BUG=angleproject:891

Change-Id: Ifbe4ada58f27ad9ddb5b43697c234cb17e7504f0
Reviewed-on: https://chromium-review.googlesource.com/290147Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=504872

Change-Id: I44b619f15e46cb3a6a3d95fd81c999d612d60184
Reviewed-on: https://chromium-review.googlesource.com/290090Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ESSL 3.00 allows a wider variety of types of input/output variables
than ESSL 1.00, but there are still specific restrictions on structs,
matrices and arrays.

Some of the checks need to be implemented twice: once for array syntax
where the brackets are after the type, and another time for array syntax
where the brackets are after the variable name.

This requires fixes to constant folding unit tests which were previously
incorrectly using matrix outputs in fragment shaders.

New unit tests are added for several of the rules introduced, but some
cases are also covered by dEQP.

TEST=angle_unittests, dEQP-GLES.functional.shaders.linkage.varying.rules.*
BUG=angleproject:1061

Change-Id: I655b054cfe56d376db775b96a2bb41b3ac5740b0
Reviewed-on: https://chromium-review.googlesource.com/285482Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

All the previously implemented surfaces used to preserve the content of
the surface on a swap but this is no longer the case with CGL.

BUG=angleproject:891

Change-Id: I264c579bcbbd22b4eeb09e78aa95751d223694fc
Reviewed-on: https://chromium-review.googlesource.com/289871Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=516027

Change-Id: Ibbf45c863570581ea79e198604cd4c5cc1836620
Reviewed-on: https://chromium-review.googlesource.com/289996Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

These macros replace a lot of repeated timing code, and mirror how
Chromium operates.

BUG=516027

Change-Id: Ib03e35d0f3b8638b9b0e8785c397c8381f16b041
Reviewed-on: https://chromium-review.googlesource.com/289995Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

The previous skeleton was name NSGL because it seemed the easier route
to go, however Chrome uses CGL internally, which we want to match.

BUG=angleproject:891

Change-Id: I00eb597080c8b735545750dfcd6ad80dcea79300
Reviewed-on: https://chromium-review.googlesource.com/289870Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

std::to_ullong is c++11, failing on Mac.

BUG=angleproject:1040

This reverts commit 37a9e712.

Change-Id: I5cecd1fe95b889feffb556f67d082cec585256f4
Reviewed-on: https://chromium-review.googlesource.com/290211Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>