- 02 Oct, 2020 6 commits
-
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/615fbe6cbc78..d91afd8de27a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id07d30f214dafc716c2b41aa2297021e7405df1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2445059Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/5efa84e265f7..7b91afe96128 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/83b9c33a0b..9cc0704ecc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/66ad7ae099..5538030635 No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I5f39cb814435589c2cec8c37efa277c40a904306 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444100Reviewed-by:
-
Jamie Madill authored
This fixes a TSAN warning that popped up with the standalone test runner. The watchdog timer actually was never started so timeouts were not working as intended. It also switches the timeout mode to call _Exit which skips all the atexit handlers and avoids some races on teardown. This change also speeds up the TestSuiteTest. Also a small fix to GetTempDir that was including an extra path separator on Windows. Bug: angleproject:3162 Bug: angleproject:5117 Change-Id: I0e7880a08b61bbb6e30c65665d5c0acec2d78db2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2442381Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
Mid-render-pass clears (through UtilsVk) run on the current subpass, which in the presence of multisampled-render-to-texture unresolve would be subpass 1. The graphics pipeline for that draw call should set the correct subpass index. Bug: angleproject:4836 Change-Id: Iba4a03ea96a63b0f5d09c27e5283ff8a8b534e05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441509 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
This reverts commit 3705fc41. Reason for revert: Causes errors on Debug bots. See bug. Bug: angleproject:5121 Original change's description: > Vulkan:Add debug labels for OpenGL calls > > Implement the DebugAnnotatorVk class, and plumb the EVENT macro in the > GL entrypoints to save a string of call info in the vector of all > GL calls in ContextVk. > > Then add a vkCmdBeginDebugUtilsLabelEXT() call that includes the > OpenGL draw/dispatch call prior to any Vulkan Draw or Dispatch calls. > Also embedded under that label add a second > vkCmdBeginDebugUtilsLabelEXT() call labeled "OpenGL Commands" that > includes all of the OpenGL calls leading up to the draw/dispatch. > Each individual OpenGL call is then given its own > vkCmdBegin/EndDebugUtilsLabelEXT() pair so that the complete sequence > of GL calls leading up to a draw call is visible for each Draw. > > Enable the OGL->VK mapping feature by setting > "angle_enable_trace = true" in GN args. > > Note: This will create an ANGLE APK on Android that generally won't > work with games, unless launched by AGI (which provides the debug > utils extension). A future version will disable these labels unless > the debug utils extension is found. > > Bug: b/162068318 > Bug: b/169243237 > Change-Id: I09886f17fa9287528c12552698738ea1fe2a4b8c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2427557 > Commit-Queue: Ian Elliott <ianelliott@google.com> > Reviewed-by: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> TBR=courtneygo@google.com,ianelliott@google.com,timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/162068318 Bug: b/169243237 Change-Id: I772d549213e1ad64ae58a1937e5de0f7ea740084 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444094Reviewed-by:
-
Jamie Madill authored
This will allow us to use trigger.py in a standalone checkout to fire off swarming jobs. Bug: angleproject:5114 Change-Id: I99302a4e8fdfc0f6d9996748a2d6c97dc5f03cde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2442079 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
-
- 01 Oct, 2020 14 commits
-
-
Jonah Ryan-Davis authored
This test started failing, but we don't care about performance on GLES so we can suppress it for now. Bug: angleproject:5120 Change-Id: If5eb865956ee5fb6f798d110d42e3493294bc18e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2443590 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
These bots don't have VK_EXT_depth_stencil_resolve. Bug: chromium:1134286 Change-Id: I4cc5a627996139bf03dc3cc334435d08876a0a8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2443584Reviewed-by:
-
Brandon Schade authored
When emulating the sample coverage to a mask, truncate the value. Test: dEQP-GLES3.functional.multisample.fbo*sample_coverage* Bug: angleproject:4568 Change-Id: Ie0f9fee7dc7cf08e2289ff24f0fa69f9929c4ae3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433069 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
Le Hoang Quyen authored
- XFB is currently emulated by writing to storage buffers. - Metal doesn't allow vertex shader to both write to storage buffers and to stage output (i.e clip position). So if GL_RASTERIZER_DISCARD is NOT enabled, the draw with XFB enabled will have 2 passes: + First pass: vertex shader writes to XFB buffers + not write to stage output + disable rasterizer. + Second pass: vertex shader writes to stage output (i.e. [[position]]) + enable rasterizer. If GL_RASTERIZER_DISCARD is enabled, the second pass is omitted. + This effectively executes the same vertex shader twice. TODO: possible improvement is writing vertex outputs to buffer in first pass then re-use that buffer as input for second pass which has a passthrough vertex shader. - If GL_RASTERIZER_DISCARD is enabled, and XFB is enabled: + Only first pass above will be executed, and the render pass will use an empty 1x1 texture attachment since rasterization is not needed. - If GL_RASTERIZER_DISCARD is enabled, but XFB is NOT enabled: + we still enable Metal rasterizer. + but vertex shader must emulate the discard by writing gl_Position = (-3, -3, -3, 1). This effectively moves the vertex out of clip space's visible area. + This is because GLSL still allows vertex shader to write to stage output when rasterizer is disabled. However, Metal doesn't allow that. In Metal, if rasterizer is disabled, then vertex shader must not write to stage output. - See src/libANGLE/renderer/metal/doc/TransformFeedback.md for more details. Bug: angleproject:2634 Change-Id: I6c700e031052560326b7f660ee7597202d38e6aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408594Reviewed-by:Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
Jamie Madill authored
Bug: angleproject:5118 Change-Id: I92f4932b9d0c0413703177d13ae526307327a710 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2442382Reviewed-by:
-
Cody Northrop authored
Detected when recapturing Temple Run and Candy Crush. Each of these apps has updated recently. Test: angle_perftests --gtest_filter="*Trace*" Bug: angleproject:4845 Change-Id: Id0e8d362661d97d7b8e60b3afb0a3a989b6a6771 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441850Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fcb22ecf0f7e..615fbe6cbc78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ie48755f1b9097f2c54609c6d4ac3d81b4cee25bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441348Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b042f4e70879..5e947adaf26e 2020-10-01 capn@google.com Fix clamping cube face coordinates to [0.0, 1.0) range 2020-09-30 nicolascapens@google.com Fix delegating eglCreateWindowSurface to CreatePlatformWindowSurface 2020-09-30 amaiorano@google.com Fix GN build 2020-09-30 amaiorano@google.com Optimize transcendentals for Subzero If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I729937d96941832d2330eac96ec00b4e08939bca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441986Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e2b329a75b6a..7a78cc629cca 2020-09-30 shannon@lunarg.com build: Update Android known-good for 1.2.154 SDK 2020-09-30 tony@lunarg.com tests: Add test for sampler with null image view 2020-09-30 tony@lunarg.com layers: Allow for sampler with null image view If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I7b3d6184abeda68c76acba190a15d320abc26070 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441987Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/18cdc3179c58..5efa84e265f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3ede10128b..83b9c33a0b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe12eb7d0a..66ad7ae099 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bd8e096f1d..921f371807 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6c5b056475..410285a57e No update to Clang. Bug: angleproject:5038 Tbr: jonahr@google.com Change-Id: I6d685864226e263081fe146ff3e7d04cfed4d336 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441981Reviewed-by:
-
Jamie Madill authored
The implementation is based heavily on the Chromium Skia Gold Python classes in //build/skia_gold_common . Results will be visible here: https://angle-gold.skia.org/ Currently results are not visible until this CL lands. Bug: angleproject:4090 Bug: b/168049670 Change-Id: I7a5d64fe35583ad7ea6360804a0f6b72cd9f6d8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2430179Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
This argument isn't used and is in the process of being removed. We need to remove it partially to unblock landing ANGLE tests in Chrome. We can follow up later to remove it from the argument set. Bug: angleproject:3162 Change-Id: I3f80eb1bc14fd93a2b6d9732e51f49873fabb27e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441512 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Tim Van Patten authored
We need to always call reset() during createPipelineLayout(), particularly to reset the descriptor pools to handle the new descriptor set layouts that are generated by new immutable samplers. Otherwise, DynamicDescriptorPool::init() will detect that a pool is attempting to be created with a mis-matching descriptor set layout handle. Bug: angleproject:4307 Test: Manually verify Cut the Rope doesn't crash Change-Id: I0993bc37170e3ddf45c50abdfefda1d7f782b801 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441127Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Ian Elliott authored
Implement the DebugAnnotatorVk class, and plumb the EVENT macro in the GL entrypoints to save a string of call info in the vector of all GL calls in ContextVk. Then add a vkCmdBeginDebugUtilsLabelEXT() call that includes the OpenGL draw/dispatch call prior to any Vulkan Draw or Dispatch calls. Also embedded under that label add a second vkCmdBeginDebugUtilsLabelEXT() call labeled "OpenGL Commands" that includes all of the OpenGL calls leading up to the draw/dispatch. Each individual OpenGL call is then given its own vkCmdBegin/EndDebugUtilsLabelEXT() pair so that the complete sequence of GL calls leading up to a draw call is visible for each Draw. Enable the OGL->VK mapping feature by setting "angle_enable_trace = true" in GN args. Note: This will create an ANGLE APK on Android that generally won't work with games, unless launched by AGI (which provides the debug utils extension). A future version will disable these labels unless the debug utils extension is found. Bug: b/162068318 Bug: b/169243237 Change-Id: I09886f17fa9287528c12552698738ea1fe2a4b8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2427557 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
-
- 30 Sep, 2020 15 commits
-
-
Courtney Goeltzenleuchter authored
Testing with TSN found a race condition with RefCounted objects (DescriptorSetLayout and PipelineLayout). Rather than add more lock calls to protect accesses to mRefCount and mObject recommendation was to put these caches in the ShareGroup (basically part of the context). Locking at the GL level will ensure that two threads that share the same context will not access the ShareGroup at the same time. The ShareGroup also works because these layouts are not destroyed until the context is destroyed so don't have to worry about other threads (e.g. command processor thread) accessing them. Bug: b/168744561 Change-Id: Icc0aa07bf4787a69572d6ec62da2f21d286232c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2437509 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Charlie Lao authored
It appears this optimization causing Manhattan performance regression on pixel4 with QualComm GPU. It does have a measurable performance improvement on S20+ that has ARM GPU. This disables this optimization for QualComm but still leaves it enabled on other GPUs. Bug: b/166475273 Change-Id: I9c9cd55ab169463fc8cc16d7d917be660cb2f363 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441667Reviewed-by:
Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
Jamie Madill authored
Allows Vulkan info collection even if Vk is not enabled in ANGLE. Also removes the system_utils error message so that the Android test runner can parse the standard output without conflicts. Bug: chromium:1133459 Bug: angleproject:5109 Change-Id: I7d7bff0f1c3e456342f27538812b33ee6cd1054b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2436657Reviewed-by:
-
Jamie Madill authored
Adds several new command line arguments and documents all args in the README. Changes the trace tests to output milliseconds. Bug: b/169600938 Change-Id: Ie8c7840a6a8958951992c806979dde6dc7d8a709 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2438194 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Courtney Goeltzenleuchter authored
It can be hard to tell sometimes when the mRenderPassCommands or mOutSideRenderPassCommands command buffers have changed and there have been some issues with code that locally caches a pointer to a commandBuffer that then becomes invalid. This change adds checking so that if a command is being added to a commandBuffer that's been closed (e.g. submitted for processing) then we hit an assert. Bug: b/168144059 Change-Id: If5d37c462e3bcb51f6ec2ca44c27a2fad4e57c19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405812Reviewed-by:
-
Shahbaz Youssefi authored
kClearValueDepth/StencilIndex is renamed and repurposed in other places where depth and stencil are placed at indices MAX_DRAW_BUFFERS and MAX_DRAW_BUFFERS+1. Bug: angleproject:4836 Change-Id: Idaeff5017d944d786a5f388c4f1ce3a4e3fe9b7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2437505 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6ca885c0b4a..fcb22ecf0f7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ice3b01847559d28504fbdb31fce4bd4e2445cfd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2438321Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/db992e60cc7a..e2b329a75b6a 2020-09-29 jmadill@chromium.org layers: Fix duplicate header in GN build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I59148be2f0530db904394c864c8fd264f47166c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2438319Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/44be0942f9a8..b042f4e70879 2020-09-29 caramelli.devel@gmail.com EGL_KHR_platform_x11: wrong implementation in CreatePlatformWindowSurface() 2020-09-29 caramelli.devel@gmail.com Add DirectFB support for Vulkan WSI 2020-09-29 srisser@google.com Add VK_KHR_imageless_framebuffer 2020-09-29 bclayton@google.com SpirvShaderDebugger: Mark II 2020-09-29 bclayton@google.com Vulkan/Debug: Support Locations as hashmap keys 2020-09-29 bclayton@google.com System/Types: Add support for vec3 2020-09-29 bclayton@google.com Pipeline: Remove hack to disable spirv-opt when debugging 2020-09-29 bclayton@google.com Vulkan/Debug: Add Context::Lock::findFile() 2020-09-29 bclayton@google.com src/Pipeline: Misc fixes 2020-09-29 bclayton@google.com Vulkan/Debug: Various fixes / improvements to Thread 2020-09-29 bclayton@google.com Vulkan/Debug: Don't accumulate function breakpoints 2020-09-29 bclayton@google.com Vulkan/Debug: Overhaul Values / Variables 2020-09-29 bclayton@google.com Vulkan/Debug: Assert on locking context twice on same thread 2020-09-29 bclayton@google.com Vulkan/Debug: Add File::getBreakpoints() 2020-09-29 bclayton@google.com Vulkan/Debug: Split EventListener If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I1ed77dc24226c95be3dcb458b2ea705703ec56c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2439100Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2bfd6a752dc6..c5c6265c026e 2020-09-29 nathaniel@lunarg.com build: Fix linux/windows build in single directory 2020-09-29 richard@lunarg.com Update known_good.json for MoltenVK 2020-09-29 richard@lunarg.com Fixed paths for MoltenVK changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ia046082a56d0d9a5ed0095f75ab8cf35793ec1d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2438320Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8fdc21e4078d..0c0ac2c6c458 2020-09-29 charles@lunarg.com docs: Update static linking info If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ia0290adf8de0751eaada3f97963b9b5b0f0f986d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2439101Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/3049a95d28fb..18cdc3179c58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/00ed20cfb8..3ede10128b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3ff4f5027b..4be464e050 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/31ad7f13e1..fe12eb7d0a * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4668feaaa4..26211a5a8e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3017edade6..bd8e096f1d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dec9a2365d..6c5b056475 No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I4a39180b2dbd382967aea77fe9121ce439b8dea1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2439767Reviewed-by:
-
Shahbaz Youssefi authored
Using the same shader that unresolves color, this change allows depth/stencil to be unresolved as well. In turn, this allows the depth and stencil loadOp/storeOp of the implicit multisampled image associated with a multisampled-render-to-texture renderbuffer to be set to DONT_CARE. Stencil unresolve depends on VK_EXT_shader_stencil_export. In the absence of this extension, the stencil aspect is not unresolved and must continue to use loadOp=LOAD and storeOp=STORE. This is not ideal, but the expected use-case of depth/stencil MSRTT renderbuffers is that they get invalidated, so that load and store wouldn't happen in practice. Bug: angleproject:4836 Change-Id: I9939d1e15e10fa8ed285acdd6fe6edb42c59054f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2427049Reviewed-by:
-
James Darpinian authored
EXT_color_buffer_half_float was recently updated to be valid for WebGL 2 contexts because iOS can't support EXT_color_buffer_float. Bug: angleproject:5038 Change-Id: Ib0d35c6b26a6cd215ff6725e92c47d1efd64e048 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2415187 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
Jamie Madill authored
This adds new conditonal arguments --device-type and --device-os (shortened as -t and -o) that specify an Android device type/OS. In practice only -t is usually necessary. Also makes the GPU dimension optional (-g or --gpu). Bug: angleproject:5109 Bug: chromium:1133459 Change-Id: Id975c676db40e9eb104b73a4ed5858e6083cbd70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2439481Reviewed-by:
-
- 29 Sep, 2020 5 commits
-
-
Tim Van Patten authored
We're currently looking for any deferred clears before disabling read-only depth/stencil mode in FramebufferVk::syncState(). This CL removes that checking, since read-only D/S mode is configured at the start of a render pass, so it doesn't need to be updated again as part of changing framebuffers. Bug: b/168953278 Test: CQ Change-Id: I386114640f2b763c964d5ef0c18b1d31449a6f1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2435497Reviewed-by:
-
Mohan Maiya authored
Add Samsung's PCI-SIG vendor ID to ANGLE's list of known vendors. Bug: angleproject:5111 Change-Id: I0ec7b6b0dd057fc02828ccb3bfd597591cd7a9ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2438930Reviewed-by:
-
Tim Van Patten authored
The contents of the group angle_abseil and config angle_abseil_config needs to be underneath a check of angle_enable_abseil, so we don't erroneously attempt to access Abseil files when Abseil is disabled (like when building ANGLE in Skia). Bug: angleproject:4873 Bug: skia:7647 Test: CQ Test: Manual verification of Skia 'gn gen' on Windows Change-Id: I587da0edb66be8c422ae4e7f9d7ed0461749179a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2435898 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
Bug: angleproject:5084 Change-Id: Iafff2adbd8bfc2844c43ca31329f3f8be1250631 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2438193Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b94db86cf9b3..44be0942f9a8 2020-09-28 bclayton@google.com Pipeline: Fix return type of SIMD::Pointer::limit() 2020-09-28 bclayton@google.com Pipeline: Assign to SpirvRoutine::pointCoord If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ie8783795d53a8c576e4f362ce97a749586b828d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2438152Reviewed-by:
-
