Commits · 2f71802b4404331ecb8f86d6691097479e6b29ae · Chen Yisong / angle

28 Oct, 2019 5 commits

GN: Don't expose glslang when unused. · 2f71802b

authored Oct 28, 2019

The ninja generation step could get confused if we try to build the
glslang wrapper project on platforms that don't support glslang. Turn
it off if the Metal / Vulkan back-ends are not enabled.

Bug: angleproject:4053
Change-Id: If4dd2856681f18f4f45e952bf88e33371b9a1e3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884010Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2f71802b

Don't cc angle-team on Chromium DEPS rolls. · a12b3032

authored Oct 28, 2019

Leave a TODO to use the wrangler email alias when Chrome's rota-ng
tool is updated.

Bug: angleproject:4059
Change-Id: Ide7538b4762ea3ec0f21237e1f2af7dba5023301
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884012Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a12b3032

Fixups to ANGLE_get_image boilerplate. · 0964988b

authored Oct 26, 2019

- Remove level parameter from GetRenderbufferImage.
- Add packed enum handling to GetTexImage.
- Fix ext spec reference to table 8.4.

Bug: angleproject:3944
Change-Id: I8f67608396217aaddb789dd95d0f3e2378ce918d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879960Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

0964988b

Roll third_party/SwiftShader f44f7c066a67..1737a30e3e34 (1 commits) · 225301d6

authored Oct 28, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/f44f7c066a67..1737a30e3e34

git log f44f7c066a67..1737a30e3e34 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 sugoi@google.com Removed stencil reference from PixelProcessor::States

Created with:
  gclient setdep -r third_party/SwiftShader@1737a30e3e34

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: I74de5492bf7d771d4d70f2ee91e8579b22b4cddd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1883390Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

225301d6

Roll third_party/spirv-tools/src b34fa731931b..ec12de913124 (2 commits) · 076f869c

authored Oct 28, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b34fa731931b..ec12de913124


Created with:
  gclient setdep -r third_party/spirv-tools/src@ec12de913124

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: I26ac305c6099059c7f1d5671fdd2b0aa419e8881
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1883391Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

076f869c

26 Oct, 2019 2 commits

Reland "Add more test_utils functions." · 95a736bd

authored Oct 09, 2019

This is a reland of 5fcfcea4

Re-land uses static linking with angle_util. The root cause
of the CFI error wasn't solved. Static linking works around
the problem by not using any export rules.

Second re-land fixes missing imports for libEGL and libGLESv2
static varieties.

Original change's description:
> Add more test_utils functions.
>
> Includes methods for creating temporary files, deleting files, and
> reading files into a string. Also renames GetPathSeparator to mention
> it's only used for environment variables. Includes a new virtual type
> angle::Process that will be used to implement cross-platform async
> Process launching for tests. Also includes a way to specify a custom
> crash handler callback.
>
> Also adds a few unit tests for the new functionality. They are disabled
> on Android because the functions are not needed by the new test runner.
>
> Bug: angleproject:3162
> Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Bug: chromium:1015810
Bug: angleproject:3162
Change-Id: I2a18b819b0f91df610ad12ffedea2b38349fe7cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879859
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

95a736bd

Roll chromium_revision 60074bf9e0..5fe256ab5e (709436:709762) · e7c8e80d

authored Oct 26, 2019

Change log: https://chromium.googlesource.com/chromium/src/+log/60074bf9e0..5fe256ab5e
Full diff: https://chromium.googlesource.com/chromium/src/+/60074bf9e0..5fe256ab5e

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a193dcc697..258e22bc61
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f712af4fd9..85152663b9
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/571788934b..1cfec065ed
* third_party/yasm: https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/cc10bc0f1d..02a8d2167f
DEPS diff: https://chromium.googlesource.com/chromium/src/+/60074bf9e0..5fe256ab5e/DEPS

No update to Clang.

Also includes new DEPS for jsoncpp and yasm.

TBR=jmadill@chromium.org,
BUG=1017514

Change-Id: I0f1998407f74521251d920d269ad2787e79fb57d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1882273Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e7c8e80d

25 Oct, 2019 21 commits

SwiftShader: Update the expectations file according to latest testing · 76763cb9

authored Oct 25, 2019

Some tests fixed.  Others only fail on Android.

Bug: angleproject:4016
Bug: angleproject:4019
Bug: angleproject:4045
Change-Id: If3b915fdd1c54cefa17589f025ea8a93935377c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880165Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

76763cb9

Capture/Replay: Add ANGLE_get_image extension. · 04ee27ef

authored Oct 24, 2019

Will be used for mid-execution capture. Only has a
stubbed-out implementation right now.

Bug: angleproject:3944
Change-Id: I6ddae07907ecbdbd3be9a5d2d3fcafeb425445e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1878888
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

04ee27ef

Roll third_party/SwiftShader 883e817b14bf..f44f7c066a67 (4 commits) · 003629a5

authored Oct 25, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/883e817b14bf..f44f7c066a67

git log 883e817b14bf..f44f7c066a67 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 amaiorano@google.com Fix LLVM7 partially initialized ManagedStatic
2019-10-24 sugoi@google.com Fixed using an offset in Blitter::blitFromBuffer()
2019-10-24 sugoi@google.com Fix stencil+MSAA
2019-10-24 paulthomson@google.com Add LESS_DEBUG_INFO CMake option

Created with:
  gclient setdep -r third_party/SwiftShader@f44f7c066a67

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4037,angleproject:4013,angleproject:4044
TBR=jonahr@google.com,jmadill@google.com
Change-Id: If8150d05ff1e222c24c1f8dc09b99cbb42bffa10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880455
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

003629a5

Capture/Replay: Fix capture build on Android. · 02c89327

authored Oct 25, 2019

A compile error slipped in due to lack of test coverage.

Bug: angleproject:3611
Change-Id: Id34ce239f3913efb0ed1abab77321981419cab44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880160Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

02c89327

Update wrangling docs to link to SwiftShader roller. · adcda20c

authored Oct 25, 2019

Bug: angleproject:1944
Change-Id: I8eabf5e8ec5cd7bfeab4db9b7bd5422f5168744e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880159Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

adcda20c

GN: Explicitly add several Windows libs. · e55374f7

authored Oct 24, 2019

These were not implicitly added in the Skia build.

Bug: angleproject:4046
Change-Id: I0acdb4056e4598ea372b650dbd8044fe680187b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877483Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e55374f7

Fix warnings in xxhash. · 8ab0bf1f

authored Oct 24, 2019

Again these were showing up in Skia.

Bug: angleproject:4046
Change-Id: Ia295ac02b1e1d7bd4186243fc2bf38dffce43c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877482Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8ab0bf1f

Roll third_party/spirv-tools/src feb154921397..b34fa731931b (23 commits) · 4bad5355

authored Oct 25, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/feb154921397..b34fa731931b


Also rolling transitive DEPS:
  third_party/spirv-headers/src 842ec9067462..af64a9e826bf

Created with:
  gclient setdep -r third_party/spirv-tools/src@b34fa731931b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: I19a2870cef1000757fa7767ef45b5fbac8a3a4a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880801Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4bad5355

Capture/Replay: Fix docs link. · 664be3f8

authored Oct 25, 2019

Should be samples/capture_replay not samples/capture_and_replay.

Bug: angleproject:3611
Change-Id: I5de4849c875add39df36f7875482e4dc91ca0ca6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880158Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

664be3f8

Use googletest nested DEPS file. · 07035681

authored Oct 25, 2019

This will fix the issue where gclient didn't support checking
out DEPS-inside-DEPS. We pass a 'googletest_revision' variable
to third_party/googletest via recursedeps.

Bug: chromium:1017514
Change-Id: I4ef3785e385775910f24e13e60e284b8ab2996d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881023Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

07035681

Roll chromium_revision 9325340209..60074bf9e0 (704874:709436) · 7d51cc98

authored Oct 25, 2019

Change log: https://chromium.googlesource.com/chromium/src/+log/9325340209..60074bf9e0
Full diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/592281c03c..a193dcc697
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/6752fa027a..f712af4fd9
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c721b68dde..60616473f7
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/48246a0995..571788934b
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9d3bf3e968..bc13578529
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ddebad26cf..403ca5ad3a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6bc727d9d8..662cbb8d60
DEPS diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0/DEPS

No update to Clang.

TBR=jmadill@chromium.org,
BUG=None

Change-Id: I429a0179f2941ebe04a41a1e25068c2bc41e66c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881022Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

7d51cc98

Enable "-Wconditional-uninitialized". · 155947fc

authored Oct 24, 2019

This is a final warning used by Skia.

Bug: angleproject:4046
Change-Id: I3970e30e4bd2aef07cddadd7322ef120ac857493
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877481Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

155947fc

Enable "-Winconsistent-missing-destructor-override". · 16370a65

authored Oct 24, 2019

This is purely a code style and consistency warning. Enabled to
support building in Skia.

Bug: angleproject:4046
Change-Id: Ibdcd06ded0195123e52c693851c43d0864e54ad1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877480Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

16370a65

Roll third_party/glslang/src 7662586844f4..b131630e7c74 (1 commits) · ec14fd5a

authored Oct 25, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7662586844f4..b131630e7c74


Created with:
  gclient setdep -r third_party/glslang/src@b131630e7c74

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: Ia4ef9eeef7404245de43d5adf1636e395c4e61f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880657Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ec14fd5a

Enable "-Wundefined-reinterpret-cast". · c017cee9

authored Oct 24, 2019

A couple cases popped up where we were using an undefined cast.
Fix them by rearranging assignment macros to use decltype.

Another warning that is enabled in Skia.

Bug: angleproject:4046
Change-Id: Ibdbae0b2a96909b101a259ff805b8b2d43a5174b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877479
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c017cee9

Fix improper vertex array assignment in ANGLE test. · 77fba58c

authored Oct 24, 2019

Test: StateChangeTestES3.VertexArrayObjectAndDisabledAttributes
Bug: angleproject:4049
Change-Id: Ibda86585e9117686283081a76df213b2b2db0b6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879582Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

77fba58c

GL: Temporarily disable emulatePrimitiveRestartFixedIndex. · 4db96149

authored Oct 24, 2019

This workaround appears to cause problems on Mac ASAN builds.
Disabling it while investigating the root cause.

BUG=1017337
BUG=angleproject:3997

Change-Id: I16a2f07f8fc69ec4d5ab40a5bf521c43f6854a49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879873Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

4db96149

Enable "-Wredundant-parens". · 68945f1c

authored Oct 24, 2019

This one is also required by Skia. It's purely for consistency and
code readability.

Bug: angleproject:4046
Change-Id: I9ed418a0bf6c7661f0970fef6da7088ca6ae6204
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877478Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

68945f1c

Enable "-Wmissing-field-initializers". · a6206854

authored Oct 24, 2019

This is another warning required by Skia. This one didn't find
anything that surprising. Enabling the warning does help enforce
code consistency and avoids a bit of possible undefined behaviour.

Bug: angleproject:4046
Change-Id: Ifec7f4afad49cd820bf3c0a79df3f46559473ee2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877477
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a6206854

Enable "-Wshadow-field". · 859ca039

authored Oct 24, 2019

This warning verifies we don't give variables names that shadow
fields. This is another good warning to enable that Skia requires.
This CL also fixes a small number of points in code that used this
bad pattern. We have to disable the warning for Glslang for now.

Bug: angleproject:4046
Change-Id: I072a686e3023b60cfafa778525fe712ce1fb5a50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877476Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

859ca039

Enable "-Wtautological-type-limit-compare". · fd58d22c

authored Oct 24, 2019

This is used by Skia. It seems like a good this to enable in any case.
It verifies that we don't do pointless comparisons like "int < INTMAX".

Fix the one instance by using the base checked numeric helpers.

Bug: angleproject:4046
Change-Id: Ie14a9cb2754df52929591281062d92ef70df8f97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877474Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

fd58d22c

24 Oct, 2019 10 commits

Use "full" git cl format by default. · 3db80f93

authored Oct 24, 2019

This uses the new setting added to depot_tools. The diff
lines of context setting was removed.

Bug: angleproject:4003
Change-Id: I6f7d471d3cce066cd3a6caa200828d09ccfca5ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879577Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

3db80f93

Capture/Replay: Write capture index file. · f251995d

authored Oct 24, 2019

This file will be used with multi-frame captures to share common code.
Common code is global state, resource maps, and a list of frame replay
functions. This should make converting a CPP replay into a functional
test quite a bit simpler. The replay files will now be something like:

angle_capture_context1.cpp
angle_capture_context1.h
angle_capture_context1_frame000.cpp
angle_capture_context1_frame001.cpp
... etc

Also adds a template for adding a capture/replay sample. Instructions
are located in samples/BUILD.gn and docs in doc/CaptureAndReplay.md.

Bug: angleproject:3611
Change-Id: I437b338fd84689d670a7d9e3e219d9334de25fd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869543
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

f251995d

Fix TextureAttachment support for unsized DS formats · 7af2676b

authored Oct 23, 2019

Unsized DS formats should not pick up support from ES3 automatically.
Also unsized DEPTH COMPONENT textures should not be allowed as texture
attachments without also having support for GL_ANGLE_depth_texture or
GL_OES_depth_texture extensions.
This change modifies some unsized formats to require extension support
for TextureAttachment use.

There are a couple of tests bugs that were exposed by this change so
updated those tests as well.

This CL only changes TextureAttachment support, but it's quite possible
that renderbuffer (and texture) support may also need to be updated.
Will attempt that in a follow-on.

Bug: angleproject:3952
Change-Id: I75d15330dc418c421cd2855135e1e8100a89b2e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877135Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

7af2676b

Capture/Replay: Introduce environment options and docs. · a2e66a5e

authored Oct 24, 2019

Introduces a few ways of controlling capture via:

 * `ANGLE_CAPTURE_ENABLED`:
   Can be set to "0" to disable capture entirely.
 * `ANGLE_CAPTURE_OUT_DIR`:
   Can specify an alternate directory than the CWD.
 * `ANGLE_CAPTURE_FRAME_END`:
   This variable can override the default of 10 frame to capture.

Also adds a simple usage guide document.

Bug: angleproject:3611
Change-Id: I49d32d5bae2c490dcbeb0f1ce3c6038e433adfaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869542Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a2e66a5e

Vulkan: Update expectations for SwiftShader sRGB fix · 6b652b33

authored Oct 24, 2019

Issue 4011 had 2 root causes, one of which was fixed and the other split out into 4037.

Bug: angleproject:4011
Bug: angleproject:4037
Change-Id: I460588d7667429751416c1904863a5117a8a4b1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1878889Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

6b652b33

Vulkan: Enable multithreading tests. · c139250c

authored Oct 13, 2019

These now pass with all the prior work.

One test case is left disabled on Linux due to timeouts.

Bug: angleproject:2464
Change-Id: If41f59f44f78160cf1b26dc05f560afd286996bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1832526Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c139250c

GN: Fix one missing check for 'angle_has_build'. · 299b1baf

authored Oct 24, 2019

This was blocking using our GN files in Skia.

Bug: angleproject:4046
Change-Id: I12887a53c5f92b0e00206f8d391a8d03433b5e6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877475Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

299b1baf

GL: Follow-up primitive restart emulation fixes. · 3a8b8908

authored Oct 23, 2019

 - Use the existing utility function for computing the primitive
   restart index.
 - Fix bad merge that removed the unfoldShortCircuits feature.

BUG=1017337
BUG=angleproject:3997

Change-Id: I4ba5ada9816731bdd29a0e518ce225bdd69a762e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1876453Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

3a8b8908

Roll third_party/SwiftShader 7738ed713e7b..883e817b14bf (1 commits) · 56d4da05

authored Oct 24, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/7738ed713e7b..883e817b14bf

git log 7738ed713e7b..883e817b14bf --date=short --no-merges --format='%ad %ae %s'
2019-10-23 webmaster@saschawillems.de Added vkGetPhysicalDeviceWin32PresentationSupportKHR to Vulkan ICD

Created with:
  gclient setdep -r third_party/SwiftShader@883e817b14bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: If101eb655a556a70884b6b65d8f628d98901e73a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877852Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

56d4da05

Roll third_party/glslang/src 5e634c8999e6..7662586844f4 (3 commits) · 806747e0

authored Oct 24, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5e634c8999e6..7662586844f4


Created with:
  gclient setdep -r third_party/glslang/src@7662586844f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: Ibaa281c82997e29b0d27a1e67c828a8f693c79d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877851Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

806747e0

23 Oct, 2019 2 commits

Vulkan:Enable UpdateBufferInUse test on AMD · b2885bc4

authored Oct 23, 2019

Re-tested this and it's now passing so turning it on.

Bug: angleproject:3255
Change-Id: Iccf63cfaa4386dfda5628e189362631e655953f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1876081Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

b2885bc4

Vulkan: Mipmap is unconditionally enabled in ANGLE · 052167bc

authored Aug 13, 2019

ANGLE always enables the Mipmap. The fix does redefining
the image with mipmaps and replace the origin one only
when it is necessary.

Bug: angleproject:3737
Change-Id: Ia33a16fd7feae303fb114988059c4eec58c4232d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1750627
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

052167bc