- 27 Aug, 2018 5 commits
-
-
Jamie Madill authored
This test covers several validation edge cases with detecting feedback loops and buffers bound to multiple types of binding. Bug: angleproject:2747 Change-Id: I612a4fcf1870667a821ebcba2d3948695b3cabd5 Reviewed-on: https://chromium-review.googlesource.com/1174094Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Frank Henigman <fjhenigman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
This splits checkObjectAllocation into the inline part and the slow part. It uses ANGLE_INLINE to force the former to be inlined. Also inlines and optimizes a few other buffer binding related checks. Improves performance in a bindings performance test by about 20%. Includes contributions from matavenrath@nvidia.com. Test: Bindings_gl_100_objects_allocated_at_initialization Bug: angleproject:2777 Change-Id: I71b07d72a8e81db7a90140ef84eca599a29239ed Reviewed-on: https://chromium-review.googlesource.com/1190442Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Bryan Bernhart authored
Add validation that disallows GL_UNIFORM_NAME_LENGTH from being used. BUG=angleproject:1523 TEST=angle_end2end_tests Change-Id: Id70e25ab79fd93ae4eb8b8343819458a4a0e4a71 Reviewed-on: https://chromium-review.googlesource.com/1187511Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Bryan Bernhart <bryan.bernhart@intel.com> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
The frontend was not taking into account the fact that some drivers do not support program binaries. The fix is that now glGetProgramiv(GL_PROGRAM_BINARY_LENGTH) returns 0 under such circumstances. Bug: angleproject:2780 Change-Id: I4ea2cda6bb4612e69dbd7e00b3d43b97ee3b3c3d Reviewed-on: https://chromium-review.googlesource.com/1188768Reviewed-by: -
Olli Etuaho authored
This adds the entry point but does not implement it yet. The entry point and enums are also added to the gl2ext_angle.h header file. BUG=angleproject:2775 TEST=angle_end2end_tests Change-Id: I24c231c52e7cbb13637880b21044e655935b51e8 Reviewed-on: https://chromium-review.googlesource.com/1188575Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
- 24 Aug, 2018 6 commits
-
-
Shahbaz Youssefi authored
Bug: angleproject:2138 Change-Id: Ia5331845d34f60a31280e6da041d13dc3da29232 Reviewed-on: https://chromium-review.googlesource.com/1187364 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
Even if explicitly enabled. Bug: angleproject:2138 Change-Id: I598d21296bb6843e05cdeab146c1ff3da3a1174b Reviewed-on: https://chromium-review.googlesource.com/1185743Reviewed-by:
-
Shahbaz Youssefi authored
The test no longer fails on any platform Bug=angleproject:2779 Change-Id: I1b184b41be23a25fb01a54587eda88fac470b7de Reviewed-on: https://chromium-review.googlesource.com/1188604 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Olli Etuaho authored
This also places textureSize(gsampler2DMS) correctly in the ESSL 3.10 builtins instead of ESSL 3.00 builtins. BUG=angleproject:2775 TEST=angle_unittests Change-Id: Ieb0f7a7424a5558a5569af6d4fcbcc9b12ec9840 Reviewed-on: https://chromium-review.googlesource.com/1186466 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by:
-
Olli Etuaho authored
This is needed for antialiased multiview rendering. The extension is written against OpenGL ES 3.1. To add support for it in OpenGL ES 3.0, an extension for exposing non-array multisample textures will also be required (ANGLE_texture_multisample). This has been previously proposed though not yet submitted to ANGLE. The extension spec provides robustness guarantees for sampling multisample textures. It still needs to be tested whether native implementations follow these guarantees or if the spec needs to be adjusted to allow for clamping coordinates. The native KHR_robust_buffer_access_behavior is not very explicit about whether the texel fetch robustness applies also to multisample textures. BUG=angleproject:2775 Change-Id: I1bd721008a10bee29f8e2e06edca19370a9932a7 Reviewed-on: https://chromium-review.googlesource.com/1186336Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
-
jchen10 authored
Add an option for "compie_only" and "compile_and_link". Bug: chromium:849576 Change-Id: Id796ebb85ad5aff1a5272173f11ce2ff42685dce Reviewed-on: https://chromium-review.googlesource.com/1186159 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
-
- 23 Aug, 2018 5 commits
-
-
Shahbaz Youssefi authored
Accidentally disabled in 26581113, which intended to disable tests requiring GL_ANGLE_framebuffer_blit, but also disabled glBlitFramebuffer tests. glBlitFramebuffer is core, but was conditioned to EXT_framebuffer_blit. Bug: angleproject:2773 Change-Id: I0468af8874dc8676a4eb6214b111c08aadc0e2fc Reviewed-on: https://chromium-review.googlesource.com/1186543Reviewed-by:
-
Frank Henigman authored
Roll to get versions of build and tools/clang don't require gyp in our DEPS, so we can to remove gyp from our DEPS. BUG=angleproject:1569 Change-Id: I2d1639bb5d576e62aff2a8aa993542b0ac777be6 Reviewed-on: https://chromium-review.googlesource.com/1185756 Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Reviewed-by:
-
Jamie Madill authored
Apparently returning a small struct was slow enough to make a 2-3% difference in benchmark scores. Very visible on the MSVC sampling profiler. Bug: angleproject:2747 Change-Id: I459a127f3f2a0fc3a08db15c37257a67f63f20ce Reviewed-on: https://chromium-review.googlesource.com/1181465Reviewed-by:
-
Jamie Madill authored
This test covers feedback loops and invalid component types. Bug: angleproject:2747 Change-Id: I3e3c762c5457afef59311f7c5843e464fa386cd6 Reviewed-on: https://chromium-review.googlesource.com/1174093 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:2740 Change-Id: I44fd2a1daf3dca764e2eef73e437feb32b36dbaa Reviewed-on: https://chromium-review.googlesource.com/1185234 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
- 22 Aug, 2018 9 commits
-
-
Olli Etuaho authored
Use helper to create multiview backing textures in NoLeakingFragments test instead of doing FBO attachments twice. The test seems to pass on Windows after the recent fixes that have been done to the tests, or possibly due to other earlier fixes. BUG=angleproject:2687 TEST=angle_end2end_tests Change-Id: I6015a5b44fdd06faf7b9375bad501355be8d7732 Reviewed-on: https://chromium-review.googlesource.com/1184713Reviewed-by:
-
Olli Etuaho authored
Multiview tests now use common helpers to create textures for multiview framebuffers and often also to attach the textures to the framebuffers. The tests now rely on uploaded texture data to initialize the buffers instead of clearing the framebuffers with glClear. BUG=angleproject:2765 TEST=angle_end2end_tests Change-Id: I7d6d63add5943cab610ab888045d5b0f8ba29215 Reviewed-on: https://chromium-review.googlesource.com/1184712Reviewed-by:
-
Jamie Madill authored
Bug: angleproject:2747 Change-Id: Ia808e26a48ecf432cc29ebd8514f265ff3e15ce8 Reviewed-on: https://chromium-review.googlesource.com/1169825 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Olli Etuaho authored
This is better than skipping the tests entirely. The debug layer messages appear incorrect and may be specific to Windows 7 and Windows Server 2008. BUG=angleproject:2778 TEST=angle_end2end_tests on Windows Server 2008 Change-Id: Ief81fbe22f518c393a37a0969c8987ed9500fbed Reviewed-on: https://chromium-review.googlesource.com/1184918Reviewed-by:
-
Corentin Wallez authored
BUG= Change-Id: Iffcbace5f2165718c1db617b83692eb82c48d057 Reviewed-on: https://chromium-review.googlesource.com/1184907Reviewed-by:
-
Corentin Wallez authored
On example of the debug layer warnings: [ RUN ] MultiviewRenderTest.ProgramRelinkUpdatesAttribDivisor/ES3_D3D11_force_geom_shader_side_by_side Message 0: ID3D11DeviceContext::DrawInstanced: Vertex Buffer at the input vertex slot 1 is not big enough for what the Draw*() call expects to traverse. This is OK, as reading off the end of the Buffer is defined to return 0. However the developer probably did not intend to make use of this behavior. BUG=angleproject:2765 Change-Id: Ic7f45d7965162640d41d27c4b746e1048de59e15 Reviewed-on: https://chromium-review.googlesource.com/1184906Reviewed-by:
-
Olli Etuaho authored
This calls TearDown functions properly in MultiviewDrawTest test classes. GL RAII objects can't be used as test class members since the GL objects need to be deleted before the test class TearDown is called. Since now the tests call ANGLETestTearDown, this causes D3D debug layer messages to be checked. It turns out that there are some seemingly incorrect debug layer messages generated on AMD bots, so the failing tests are now disabled on AMD/Windows. BUG=angleproject:2765 TEST=angle_end2end_tests Change-Id: Ifa0fe4d19b76aa84bb3b6b18c8f66a8ab6bd893e Reviewed-on: https://chromium-review.googlesource.com/1179839Reviewed-by:
-
jchen10 authored
These methods are very hot in the DrawCall/gl_null bechmark. With this CL applied, the score can improve about 10% on Linux. This also removes a few unnecessary resolveLink calls. Bug: chromium:873724 Change-Id: I6034f29eeeebe8341dae3988c38196123687a44f Reviewed-on: https://chromium-review.googlesource.com/1183522 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
-
Jamie Madill authored
This will allow us to react to state change notifications for validation caching. It also cleans up some of the logic in the D3D11 State Manager. Bug: angleproject:2747 Change-Id: I85ed6404206c2b9bf504d552cf5751be56e62146 Reviewed-on: https://chromium-review.googlesource.com/1172086Reviewed-by:
-
- 21 Aug, 2018 9 commits
-
-
Jamie Madill authored
Currently this handles uniform block bindings. Cleans up some logic in D3D. Bug: angleproject:2747 Change-Id: I8c2989738d50a77d6f6d90a9ff11dceab6d3129c Reviewed-on: https://chromium-review.googlesource.com/1172085Reviewed-by:
-
Jamie Madill authored
This inlines some methods and code that was regressing binding performance. Improves the score of a bindings benchmark by 15%. Based on contributions by matavenrath@nvidia.com. Test: bindings_gl_100_objects_allocated_at_initialization Bug: angleproject:2777 Change-Id: Ied5fdbc67ced862a36c5145fff5ac94f93b40c21 Reviewed-on: https://chromium-review.googlesource.com/1181865Reviewed-by:
-
Tobin Ehlis authored
This reverts commit d710fee3. Reason for revert: pointcoord test still failing on Pixel 2 bot Original change's description: > Expect pass on pointcoord test on Pixel 2 > > Just ran this locally and it passed so re-enabling. > > Bug: angleproject:2727 > Change-Id: I10368664dc68f360474dda8534e1fd28875ff4e8 > Reviewed-on: https://chromium-review.googlesource.com/1183528 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Tobin Ehlis <tobine@google.com> TBR=ynovikov@chromium.org,jmadill@chromium.org,tobine@google.com Change-Id: If7a3e5dfb12c7b392ae91c477ad9fd9169912f90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:2727 Reviewed-on: https://chromium-review.googlesource.com/1183503Reviewed-by:
Tobin Ehlis <tobine@google.com> Reviewed-by:
-
Jamie Madill authored
Also add links from other pages. Bug: angleproject:1944 Change-Id: I344ce075973bd45942d52b819385cb74a5a073ca Reviewed-on: https://chromium-review.googlesource.com/1183629Reviewed-by:
-
Jamie Madill authored
Fix contributed by matavenrath@nvidia.com. This fixes BindingsBenchmark::drawBenchmark to take only 3% instead of 15% of the time spent in BindingsBenchmark.Run/gl_100_objects_allocated_at_initialization. Bug: angleproject:2777 Change-Id: I5b5b6f167289b947767b40e7761d90cf06c49816 Reviewed-on: https://chromium-review.googlesource.com/1181868Reviewed-by:
-
Tobin Ehlis authored
Just ran this locally and it passed so re-enabling. Bug: angleproject:2727 Change-Id: I10368664dc68f360474dda8534e1fd28875ff4e8 Reviewed-on: https://chromium-review.googlesource.com/1183528Reviewed-by:
-
Olli Etuaho authored
It doesn't need to inherit from MultiviewRenderTest since it doesn't need a framebuffer. BUG=angleproject:2765 TEST=angle_end2end_tests Change-Id: I77b232a907afcae7f2f93cbf9da47ca7bd93c959 Reviewed-on: https://chromium-review.googlesource.com/1179881Reviewed-by:
-
Olli Etuaho authored
GL RAII classes can't be used as test class members since the GL objects need to be deleted before the test class TearDown is called. BUG=angleproject:2765 TEST=angle_end2end_tests Change-Id: If19d33bd044c9e74e46f35183e8ca1bc6a96d6cf Reviewed-on: https://chromium-review.googlesource.com/1179159Reviewed-by:
-
Olli Etuaho authored
MultiviewRenderTestBase is renamed to MultiviewFramebufferTestBase since the functionality it has is mostly to set up a framebuffer. This cleans up the test class without including functional changes to ease diagnosis of issues with resource init/teardown. BUG=angleproject:2765 TEST=angle_end2end_tests Change-Id: I0debd6a7a53a2e6bff7100d07b29313d66a79cb5 Reviewed-on: https://chromium-review.googlesource.com/1181052Reviewed-by:
-
- 20 Aug, 2018 2 commits
-
-
Tobin Ehlis authored
Added separate Validate* functions for CopyBuffers(), BindTexImage(), ReleaseTexImage(), SwapInterval(), and BindAPI(). For ValidateBindTexImage() the textureObject is set by validation when appropriate and then used in the core function to prevent replicating the textureObject look-up code. Bug: angleproject:798 Change-Id: Ia32076a10aa0b044c2bdc8e2e24dd36d002c5022 Reviewed-on: https://chromium-review.googlesource.com/1180090Reviewed-by:
-
Olli Etuaho authored
This prepares for fixing multiview test resource init/teardown order. BUG=angleproject:2765 TEST=angle_end2end_tests Change-Id: I841327416fa76ac682310ef1b2309f5bb4e9fbac Reviewed-on: https://chromium-review.googlesource.com/1179155 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by:
-
- 17 Aug, 2018 4 commits
-
-
jchen10 authored
The method has to be extremely fast as it's very frequently called. It contributes about 2% cpu time in the DrawCall/gl_null benchmark. With this optimization it can be decreased to less than 1%. Bug: chromium:873724 Change-Id: I7fb376db73452dbdf6cb44c92815848e860867c9 Reviewed-on: https://chromium-review.googlesource.com/1179369Reviewed-by:
-
jchen10 authored
Bug: angleproject:2306 Change-Id: Ic63de75d12b76395450517c99b742b8a5807cf9b Reviewed-on: https://chromium-review.googlesource.com/1179373Reviewed-by:
Lingfeng Yang <lfy@google.com> Reviewed-by:
-
Frank Henigman authored
Update pipeline description with depth offset state. Enable test. BUG=angleproject:2353 Change-Id: Ib087bbff8e145b0e6e862eb6616a4943a989a7b2 Reviewed-on: https://chromium-review.googlesource.com/1173447 Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Reviewed-by:
-
Tobin Ehlis authored
Migrating much of EGL validation to use existing macros. Added new Validate* functions for eglDestroySurface(), eglDestroyContext(), eglWaitNative() functions. This continues the EGL validation refactor begun with SwapBuffers. Following similar pattern used there, but putting this out as an intermediate change to verify that code looks good and is going in the desired direction. Bug: angleproject:798 Change-Id: Id7309b9686543c20b20e273b35df1f8b9010fcd3 Reviewed-on: https://chromium-review.googlesource.com/1178750 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by:
-
