Commits · 37c400146e59f718b516eb58e16fa53c8a88bf21 · Chen Yisong / angle

16 Oct, 2020 18 commits

Revert "Vulkan: Fold deferred clears into current clears" · 37c40014

authored Oct 16, 2020

This reverts commit e416c92a.

Reason for revert: Reverted parent:
https://chromium-review.googlesource.com/c/angle/angle/+/2481612

Original change's description:
> Vulkan: Fold deferred clears into current clears
>
> If there are clears prior to a glClear() call, those clears were
> flushed (starting a new render pass) and then the clear call's clears
> would be applied (essentially modifying the loadOps of said render
> pass).
>
> The main downside of the above is that the current glClear() clears
> don't get a chance to be deferred.  This was observed in Chrome which
> clears an attachment with an emulated format, then switches
> framebuffers.
>
> Additionally, if the render pass had already been started, the deferred
> clears could have become inlined instead of breaking the render pass.
> Although, it's unlikely for there to be deferred clears when the render
> pass is already open.
>
> This change first identifies which clears need to go through the draw
> path (scissored, masked or as workaround for driver bug).  It merges the
> rest of the clears (that don't need the draw path) with the deferred
> clears.  It then checks deferred clears and applies them by either:
>
> - vkCmdClearAttachments if mid RP
> - Start a new render pass and use loadOps, if any draw-based clear needs
>   to follow.
> - Modify current RP loadOps / defer the clear
>
> Afterwards, the draw-based clears are applied.
>
> Bug: angleproject:4836
> Change-Id: Id4992c78983b199734508c9d4bb18ed3195c91ec
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455167
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Charlie Lao <cclao@google.com>

TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

Change-Id: I85733b3594409df9b96e3d5b34933522c97c42cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4836
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2481613Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

37c40014

FrameCapture: Move shader and program source to shared cache · 5a9827d2

authored Oct 08, 2020

These are local copies of source seen earlier in the trace.
Centralize them so they can be tracked across contexts.

Test: PUBG MEC
Bug: b/165824228
Bug: angleproject:4048
Change-Id: If414826b0280c61507812c2fd92706b7f095cc4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462162
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5a9827d2

Trace Tests: Add vsync-limited mode with a GPU timer. · 51ff0d05

authored Oct 16, 2020

Local testing on Linux shows that ANGLE and native have
the same wall-time, and ANGLE has a 10 ms vs native 6 ms
GPU time.

Bug: angleproject:5183
Change-Id: I26da678b984af916bfb40e1db6416f5df4f85c08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2480782
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

51ff0d05

Perf Tests: Add offscreen mode. · ecbac31c

authored Oct 16, 2020

This lets the trace perf tests run configurable number of frames
within a single swap. The offscreen config is similar to how
gfxbench works. It renders to a user FBO (by overriding calls to
BindFramebuffer) and then composits multiple frames into the real
backbuffer. This allows us to get a perf measurement with less
overhead from composition and display.

Adds emulation for some APIs that operate on Framebuffers like
BindFramebuffer, Invalidate, DrawBuffers and ReadBuffer.

Bug: angleproject:4845
Change-Id: I1044c1d52c82f1c215a68a6c46d74c52ed0f3d2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300207
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

ecbac31c

Roll Vulkan-Loader from 14ad927e679a to 970c132746b1 (1 revision) · 50348a8a

authored Oct 16, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/14ad927e679a..970c132746b1

2020-10-12 shannon@lunarg.com build: Update known-good files for 1.2.157 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Idc4988d80af175c57d8e4708235fb3a042adb19f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2479382Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

50348a8a

Roll Vulkan-Tools from 1abaced34b84 to ee0de094ddff (1 revision) · e1d8dab2

authored Oct 16, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1abaced34b84..ee0de094ddff

2020-10-15 shannon@lunarg.com build: Update known-good files for 1.2.157 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I6708380b01fadca63cf95379ca583350de59df92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2479224
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e1d8dab2

Suppress Mac/AMD/GL dEQP failures with standalone mode. · 2402c336

authored Oct 16, 2020

These tests appear to flake based on different batch sizes. Disable them
for now until we have time to investigate. See issue for more details.

Bug: angleproject:5172
Change-Id: I90fff3b3400cbd5a5aa0d5e9a23364320fba7e4d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2480785Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2402c336

Remove flaky check in TimerQueriesTest. · 5025d781

authored Oct 16, 2020

We cannot guarantee that a shader with more instructions will
always take more time than a smaller shader.

Bug: angleproject:5178
Change-Id: Icf48a7b73ad482237cf3161667d75a25e36dd643
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2479682Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5025d781

Capture/Replay: Fix GL_HALF_FLOAT_OES vertex attrib type name · d83f6792

authored Oct 08, 2020

The string for VertexAttribType::HalfFloatOES was missing.  The output
would contain GL_INVALID_ENUM instead of GL_HALF_FLOAT_OES.

Detected when capturing Free Fire.

Test: Free Fire MEC
Bug: b/168049517
Bug: angleproject:4048
Change-Id: Ib9efbb8cee1ae9f679ff20f4182f7dd428000d5b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461349
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

d83f6792

Suppress fragment out int tests on Intel/Mac/GL. · b620ca9e

authored Oct 16, 2020

These tests started failing when run in larger batches. The test order
caused determimnistic failures. See the issue for more details.

Bug: angleproject:5172
Change-Id: If5be66b843c1e0fccba962ff55e5064cbee60859
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2480784Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

b620ca9e

Roll Chromium from 20073b8681d2 to 7e36b15b99a7 (145 revisions) · 09ac7d90

authored Oct 16, 2020

https://chromium.googlesource.com/chromium/src.git/+log/20073b8681d2..7e36b15b99a7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/53ad43e619..0a3d03b92f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/14abbc061e..16f793c6e0
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Idc9a99a2569a244b8e0305978f5ea96b7e33e65e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2480987Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

09ac7d90

Metal: autogen blit & clear shaders for integer textures · 119d867c

authored Sep 26, 2020

Bug: angleproject:2634
Change-Id: I20d0bf3fca354a7964ce5893a605ab72a8a9012d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433328
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

119d867c

Roll Chromium from 312a2b1c9d05 to 20073b8681d2 (419 revisions) · 46f8db4b

authored Oct 16, 2020

https://chromium.googlesource.com/chromium/src.git/+log/312a2b1c9d05..20073b8681d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d6e2fedeed..53ad43e619
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a990bf47a4..14abbc061e
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/66b870c3b1..9c0fc6713c
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/26211a5a8e..8cd0fc1ed5
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d4827bfe10..3a982adabb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d3ce77fdae..eef787ed93
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Icc812bec41ee938d95725e9763823526e83422ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2478071Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

46f8db4b

Metal: Support 2D array textures and base & max levels. · 27e7e446

authored Sep 27, 2020

Bug: angleproject:2634
Change-Id: If9e50cec46bdf5f472f1e58c6e82a67b524e2408
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433327
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

27e7e446

Test Runner: Print reproduction steps on a batch failure. · b4fb7cc9

authored Oct 15, 2020

This prints out a large gtest_filter of the tests in a batch. Makes
reproducing a particular failure much easier.

In the future we could potentially look at using an encoding to
reproduce a specific batch: e.g. a flag that acceps a batch / shard
number and runs those tests based on using the same internal counts.

Bug: angleproject:5172
Change-Id: Iefad8f5ca23761417ad1ceb11fd664c9cf23c8be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2475455
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

b4fb7cc9

Add priority to trigger.py jobs. · 78822603

authored Oct 14, 2020

Use a default priority of 30 to match CQ jobs and not starve.
The user can also carefully add a higher priotity for small tasks.

Bug: angleproject:5177
Change-Id: I8e8460f096102423429b19e2107673f58d73805a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2475454
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

78822603

Roll Vulkan-Headers from 94ff600cc862 to 04306fa5d673 (2 revisions) · 2aaa38e9

authored Oct 15, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/94ff600cc862..04306fa5d673

2020-10-12 oddhack@sonic.net Update for Vulkan-Docs 1.2.157
2020-10-12 oddhack@sonic.net Update for Vulkan-Docs 1.2.157

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I8efa0f86caea1b6cb1abfcfa93f9cb21b28c2639
Bug: None
Tbr: ynovikov@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477443Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2aaa38e9

Perf tests: remove redundant null naming. · 089eac22

authored Oct 11, 2020

Bug: None
Change-Id: I9e3e0d8b160a438c9001d9dbd4bb067355b9e562
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2475457Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

089eac22

15 Oct, 2020 11 commits

Vulkan: Fold deferred clears into current clears · e416c92a

authored Oct 06, 2020

If there are clears prior to a glClear() call, those clears were
flushed (starting a new render pass) and then the clear call's clears
would be applied (essentially modifying the loadOps of said render
pass).

The main downside of the above is that the current glClear() clears
don't get a chance to be deferred.  This was observed in Chrome which
clears an attachment with an emulated format, then switches
framebuffers.

Additionally, if the render pass had already been started, the deferred
clears could have become inlined instead of breaking the render pass.
Although, it's unlikely for there to be deferred clears when the render
pass is already open.

This change first identifies which clears need to go through the draw
path (scissored, masked or as workaround for driver bug).  It merges the
rest of the clears (that don't need the draw path) with the deferred
clears.  It then checks deferred clears and applies them by either:

- vkCmdClearAttachments if mid RP
- Start a new render pass and use loadOps, if any draw-based clear needs
  to follow.
- Modify current RP loadOps / defer the clear

Afterwards, the draw-based clears are applied.

Bug: angleproject:4836
Change-Id: Id4992c78983b199734508c9d4bb18ed3195c91ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455167
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

e416c92a

GLX, EGL: Support NV_robustness_video_memory_purge · 96a49a48

authored Oct 06, 2020

Chrome is showing rendering issues on Linux/Nvidia after returning from
the lock screen. This could be related to the fact that Nvidia drivers
are not able to guarantee conformance after certain events.
By exposing this extension, we can instruct Chrome to reinitialize
contexts after they are purged by the driver. If this is not explicitly
requested, we can still generate an UnknownContextReset to tell apps
to discard the invalid context anyway.

Bug: chromium:1113040
Change-Id: Ie99b6356cc27fea33643d61b1d74f4f68a271d70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453689Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

96a49a48

Roll Vulkan-ValidationLayers from 465acf564a41 to 7d11021098f2 (2 revisions) · c13ddc36

authored Oct 15, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/465acf564a41..7d11021098f2

2020-10-15 shannon@lunarg.com build: Update known-good files for 1.2.157 header
2020-10-15 lionel.g.landwerlin@intel.com tests: Fix QueryPerformanceIncompletePasses stride usage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ib1d53742c6b96d43734b5e275bd9a3065ef58340
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477281Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c13ddc36

Cache BlitGL initialization state with a single bool. · 266f4429

authored Oct 15, 2020

We used to cache initializatin per-resource and check each one for
every operation. This was slower and more error prone, the
mSRGBMipmapGenerationFormat was computed every time.

Found when diagnosing crbug.com/1136613

Bug: chromium:1136613
Change-Id: Ifd804fe1dc8e26e1a9b444cc1d0c6f73954da895
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477037Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

266f4429

EGL: Entrypoint and autogen for EGL_KHR_reusable_sync · 8eaf72a8

authored Oct 14, 2020

Add entry point eglSignalSync
Update autogen files

Test: angle_deqp_egl_tests
--deqp-case=dEQP-EGL.functional.reusable_sync.*

Bug: angleproject:5168
Change-Id: I47afa4010c533096b4c56e9b3ab6eddc1944b83e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472998
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jeff Vigil <j.vigil@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

8eaf72a8

Vulkan: Remove serial from RenderPassHelper · f51e99fb

authored Oct 13, 2020

We don't delete RenderPass's so no need to keep a serial.
This simplifies things for coming threading code.

Bug: b/169788986
Change-Id: I2577b17bc1f6af163725389589d7cd62d09eea13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2468538Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

f51e99fb

Metal: Use MipmapNativeLevel class to store native mip lvl · 0e5e6078

authored Sep 26, 2020

This is to avoid wrong native level in Metal, for example, not taking
into account the OpenGL base level.

Bug: angleproject:2634
Change-Id: I3a7a3ac41bdbd91a47755bb4ca11bd579c182e04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433326
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0e5e6078

GLES/GL/Win: Suppress all constancy samples tests. · c9206a08

authored Oct 15, 2020

These were all flaking. Use two simple wildcard patterns.

Bug: angleproject:5162
Change-Id: I37cd7db1234c5586bc7c61c7b8f379c878b2ae2b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2475458Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c9206a08

Roll SwiftShader from e72c6099f946 to 52c1a859d9eb (3 revisions) · 7a56d38b

authored Oct 15, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/e72c6099f946..52c1a859d9eb

2020-10-14 natsu@google.com Revert "Revert "Update virlg_hw path to reflect Minigbm""
2020-10-14 sugoi@google.com Fix CommandPool memory management
2020-10-14 bclayton@google.com SpirvShaderDebugger: Improve stepping for inlined functions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I1af93b04dd5f117d8b22786fb532fba816d61018
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2474635Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7a56d38b

Roll Vulkan-ValidationLayers from f121d1252b2a to 465acf564a41 (2 revisions) · b0248ea4

authored Oct 15, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f121d1252b2a..465acf564a41

2020-10-14 jleger@qti.qualcomm.com tests: Add tests for KHR_copy_commands2
2020-10-14 jleger@qti.qualcomm.com layers: Add support for KHR_copy_commands2

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I2c4a48baa125a723f8f4a49c9c7a51239c584fd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2474575Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b0248ea4

Roll Chromium from 20d60a8527d7 to 312a2b1c9d05 (473 revisions) · 481fb88f

authored Oct 15, 2020

https://chromium.googlesource.com/chromium/src.git/+log/20d60a8527d7..312a2b1c9d05

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4af5c075ce..d6e2fedeed
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a8c1307999..a990bf47a4
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1b83be28f4..d3ce77fdae
No update to Clang.

Bug: angleproject:4730,angleproject:5124
Tbr: ynovikov@google.com
Change-Id: I4d78c8c02ff414d3a8202b906c9e537f714c2acf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2473772Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

481fb88f

14 Oct, 2020 11 commits

Vulkan: fix undefined right shift in GetMask · a2ef8144

authored Oct 14, 2020

Bug: chromium:1137170
Change-Id: I95efdc7888e44f2b4227f9c0d892b9102cead0bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2469616Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a2ef8144

Revert "Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount" · 43b4fefd

authored Oct 14, 2020

This reverts commit a5db7d6e.

Reason for revert: VVL rolled with the fix.

Original change's description:
> Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount
>
> Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount while the
> Khronos issue is investigated.
>
> Bug: angleproject:5148
> Change-Id: If3cd4b028182a06411b928417e7c778ea02189d1
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462075
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Tim Van Patten <timvp@google.com>

TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:5148
Change-Id: Ibb66370334554773dda3e849d0bc9f3e8f8577fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472997Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

43b4fefd

Populate LevelInfoGL's format/internalFormat in eglBindTexImage. · 1ca0c2a9

authored Oct 14, 2020

Previously GL_NONE were being used, causing
nativegl::SupportsNativeRendering to think the bound texture wasn't
renderable, and TextureGL::copySubTextureHelper (called via
CopyTexSubImageCHROMIUM) to use CPU readback. This affected the WebGL
DrawingBuffer's premultiplyAlpha:false code path.

Thanks to geofflang@ for the patch.

Bug: chromium:1136613
Change-Id: Iee650156983f880fa802b3a17d3989f5a9322e91
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472535Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

1ca0c2a9

Vulkan: Support dumping VMA stats string · 1e435d07

authored Oct 14, 2020

This CL adds support for dumping the VMA stats string, which can be
given to VmaDumpVis.py to visualize the allocations that the VMA has
performed.

To enable dumping the string, set:
RendererVk.cpp
  rx::kOutputVmaStatsString = true

Copy the desired JSON output into a text file, and pass that to
VmaDumpVis.py:
python3 \
  third_party/vulkan_memory_allocator/tools/VmaDumpVis/VmaDumpVis.py \
  -o stats.png stats.txt

The legend for the visualization is available at:
https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/tree/master/tools/VmaDumpVis

Bug: angleproject:2162
Test: Manual verification
Change-Id: Ic8c1002805dd57e594df724bcf1cdbc1d1599a3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472525Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

1e435d07

Skip slow GLES 1 Win/Intel/Vulkan test. · 12462910

authored Oct 14, 2020

GLES1ConformanceTest.Blend/ES1_Vulkan

Bug: angleproject:5171
Change-Id: I2f3bb0d53676ed54e1fb74816e7c93a8e44042a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472536Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

12462910

Add GL_EXT_copy_image extension entry points · b22e437a

authored Oct 07, 2020

Bug: angleproject:3593
Change-Id: I6d3a55a3112f5f9b20ef33c859a60b2952bfbc2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444209
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

b22e437a

Disable more ARM-based Mac tests · 1075b47a

authored Oct 14, 2020

Disables the following tests due to them failing on the ARM-based Mac
DTKs:

* GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/ES3_OpenGL
* OcclusionQueriesTest.MultiQueries/ES2_Metal
* TransformFeedbackTest.TwoUnreferencedInFragShader/ES3_OpenGL
* WebGL2CompatibilityTest.CopyMip1ToMip0/ES3_OpenGL

Bug: chromium:1132295
Change-Id: I557e3c978d884e9beeafb4f43676271edcd36a87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472532Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1075b47a

Roll SPIRV-Tools from c2553a315f5c to 5c64374dd6cb (5 revisions) · aaef5869

authored Oct 14, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c2553a315f5c..5c64374dd6cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ia678f7bcac2750fc489f639e151f56b77468d8c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2470737Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

aaef5869

Revert "Vulkan: Disable vkCreateDevice-physical-device-features-not-retrieved" · fa47b9a4

authored Oct 14, 2020

This reverts commit 4dae43d8.

Reason for revert: VVL rolled with the fix.

Original change's description:
> Vulkan: Disable vkCreateDevice-physical-device-features-not-retrieved
>
> Disable
> UNASSIGNED-BestPractices-vkCreateDevice-physical-device-features-not-retrieved
> while the Khronos issue is investigated.
>
> Bug: angleproject:5149
> Change-Id: I680cf264d6356cf219826902d7fdf2304e27ebab
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461475
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:5149
Change-Id: I0a338983ac0804d5bb0e41e592f177372be66d5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2471556Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

fa47b9a4

Vulkan: refactor error info · 7d70a62f

authored Oct 13, 2020

Consolidate error info into a structure in preparation of threading
work. Also preserves the meaning of the data until it's rendered to a
string for consumption by GL.

Bug: b/154030730
Change-Id: I8cde7133c817d77fdb117efc1c11edc94f615da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2468537
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

7d70a62f

Skip slow EGL Vulkan Linux tests. · d4b35199

authored Oct 14, 2020

dEQP-EGL.functional.swap_buffers_with_damage.resize_after_swap.*
dEQP-EGL.functional.swap_buffers_with_damage.resize_before_swap.*

See issue for more details.

Bug: angleproject:5170
Change-Id: Id0376dcb26514dffc09a28e9ad7b2ade8d50b8c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472518Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d4b35199