Commits · 37f7316ecaafae630312304447e5a4d6f6758e5e · Chen Yisong / angle

18 Nov, 2019 1 commit

Roll third_party/SwiftShader 102fd19c65f4..aba1020d3914 (7 commits) · 37f7316e

authored Nov 18, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/102fd19c65f4..aba1020d3914

git log 102fd19c65f4..aba1020d3914 --date=short --no-merges --format='%ad %ae %s'
2019-11-15 bclayton@google.com Remove the now unused sw::Event.
2019-11-15 bclayton@google.com VkQueryPool: Migrate from sw sync to marl
2019-11-15 bclayton@google.com VkDevice: Migrate to using marl::Event::any()
2019-11-15 bclayton@google.com VkFence: Migrate to marl::Event
2019-11-15 bclayton@google.com Merge changes Ifb21caa2,Iaca5897d
2019-11-15 swiftshader.regress@gmail.com Regres: Update test lists @ cc221e83
2019-11-15 chrisforbes@google.com Update deqp to b64acc6c3371607583b3aa6d12c7290b4aaae747

Created with:
gclient setdep -r third_party/SwiftShader@aba1020d3914

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: Ie779409c1316d9b30cb91c6ad0df18a71ebfa634
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1921748Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

37f7316e

15 Nov, 2019 10 commits

Update dEQP 3.1 expectations · 51b5a322

authored Nov 15, 2019

Set bug 4110 for dEQP-GLES31.functional.shaders.helper_invocation.*

Bug: angleproject:4110
Bug: angleproject:1442
Change-Id: Ic1b62e5f1a1a47fd92420fb1aeab7f97dd9f75dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919549Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

51b5a322

Expose EGL_CHROMIUM_sync_control via GLX_OML_sync_control · a829c0b9

authored Nov 14, 2019

On GLX, we can expose the EGL_CHROMIUM_sync_control extension by
forwarding to GLX_OML_sync_control when it's available. This will help
with accurate vsync times for Chrome

Bug: 1020252
Change-Id: I9b1e8cf0f8b1a548cc7cc7202fac2d0cdb01d74d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918104
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

a829c0b9

Vulkan: Update Expectations with GLES 3.1 Conformance Failures · e4aa7235

authored Nov 13, 2019

Update the following expectations files with GLES 3.1 conformance
failures to help tracking:

deqp_gles31_test_expectations.txt
deqp_khr_gles31_test_expectations.txt

Bug: angleproject:4098
Bug: angleproject:4099
Bug: angleproject:4100
Bug: angleproject:4101
Bug: angleproject:4102
Bug: angleproject:4103
Bug: angleproject:4104
Bug: angleproject:4105
Bug: angleproject:3443
Bug: angleproject:4107
Bug: angleproject:4106
Bug: angleproject:4108
Test: None (test failures were collect with Khronos conformance run)
Change-Id: I9ea818f99c6b74602ea5321f393f0066bc115905
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914131Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

e4aa7235

Enable Metal backend. · deae1fce

authored Nov 09, 2019

Metal will be secondary default backend after OpenGL for now.

The tests will be enabled for metal in
CL http://crrev.com/c/1906607.

Bug: angleproject:2634
Change-Id: I109c641d749c2a207bbb7d500bc281ffb0b13848
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906612
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

deae1fce

Update GLES31 Expectations · 20f11f58

authored Nov 14, 2019

The following tests need to have their bugs corrected in
deqp_gles31_test_expectations.txt:

dEQP-GLES31.functional.separate_shader.*
dEQP-GLES31.functional.program_interface_query.program_input.resource_list.compute.empty
dEQP-GLES31.functional.program_interface_query.shader_storage_block.buffer_data_size.*

Bug: angleproject:3570
Bug: angleproject:3596
Test: None
Change-Id: I09807d86a2cec153fcb7d6b22407bdd0d84c44ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918045Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

20f11f58

Add a test to capture bug with LUMA blit workaround · 1c795d9e

authored Nov 12, 2019

This test captures a bug with state tracking in the BlitGL LUMA
texture workaround.

Bug: 1022080
Change-Id: I22d2eb0d653778be300ab4a1f6b27e67f8cf1cbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1912140Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

1c795d9e

Add android_ndk and catapult to .gitignore · 86f65119

authored Nov 15, 2019

BUG=angleproject:4026

Change-Id: I58ed4dea3c962c6a7c46deb69400b984d8a2ea30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918569
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

86f65119

Roll third_party/spirv-tools/src 3da910d55f20..c3f22f7cba60 (2 commits) · 4207870b

authored Nov 15, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3da910d55f20..c3f22f7cba60


Created with:
  gclient setdep -r third_party/spirv-tools/src@c3f22f7cba60

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: Ibf9f114a42ab052536d3106b07227bd3cd6c0651
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918960Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4207870b

Roll third_party/SwiftShader b2407dd746de..102fd19c65f4 (4 commits) · 36fbe602

authored Nov 15, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/b2407dd746de..102fd19c65f4

git log b2407dd746de..102fd19c65f4 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 amaiorano@google.com PixelRoutine: const-qualify reference parameters
2019-11-14 swiftshader.regress@gmail.com Regres: Update test lists @ b2407dd7
2019-11-14 capn@google.com Rasterize 'Bresenham' line segments as parallelograms
2019-11-14 sugoi@google.com Negative baseVertex support

Created with:
  gclient setdep -r third_party/SwiftShader@102fd19c65f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I624498c405221a12cfb1a6fbc5e62e5484457edf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918961Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

36fbe602

Fix performance issue with EXT_multisampled_render_to_texture · 5f4db6a7

authored Nov 11, 2019

Adding a dirty flag to the mMSTexInfo struct so that the multisampled
texture does not get unnecessarily resolved on each call.

Bug: chromium:1019199
Change-Id: Ia9b24cd0a7f2d82f83f20f7e60f9f2b23383ec6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910531Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5f4db6a7

14 Nov, 2019 9 commits

Manually copy dEQP data files to output directory · 11c487a8

authored Oct 25, 2019

dEQP has data files that live in several directories within dEQP's
source tree. For example, GLES3 has data files that live within:

data/gles3/data/
external/graphicsfuzz/data/gles3/

However, we can only tell dEQP about a single data directory during
initialization of dEQP. To get around this, we are manually copying all
of the necessary data files to the output generated files directory and
pointing dEQP to this single directory. This also helps us solve a
second problem related to the paths that dEQP uses when accessing
graphicsfuzz data files.

For the graphicsfuzz tests, dEQP will attempt to open the necessary
shaders by accessing them with the path:

data/gles3/graphicsfuzz/

However, those files would normally live at the path that matches their
location within the source tree:

external/graphicsfuzz/data/gles3/graphicsfuzz/

As part of the manual copy of these data files, we are also able to
strip the extra 'external/graphicsfuzz/' portion of the path.

Bug: angleproject:2322
Test: dEQP
Change-Id: Ibc96442c221485e2f246890fa8fe51f090c5e222
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881759
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

11c487a8

Refactor end2end test macros · 1a01b4b3

authored Nov 11, 2019

This is a foundational CL to enabling the end2end tests on swiftshader.

Refactored infrastructure with new ANGLE_INSTANTIATE_TEST_ES*
macros that will run tests over all various combinations of all
platforms for different ES versions.

Just skipping failing tests initially to get the refactor landed.

Bug: angleproject:4081
Bug: angleproject:4092
Change-Id: I017f6c3267179e49b6ae08cc7488096b423dcdb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1904635
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

1a01b4b3

Treat VK_TIMEOUT as an error · 968df09e

authored Nov 11, 2019

The fence wait time was increased to 120 seconds, so we don't expect
VK_TIMEOUT to be returned by a healty GPU. This change makes it so that
when VK_TIMEOUT is returned, we will treat this as an error and
propagate it to the GLES application as a GL_INVALID_OPERATION.

It is expected that the GL application will re-initialize ANGLE which
will also reinitialize the Vulkan device (and hopefully clean up the
error). This is not our final design for ANGLE's VK_TIMEOUT handling,
since we expect to expand our Vulkan device lost error handling when
implementing the GLES 3.2 robustness requirements. This will likely
improve ANGLE's VK_TIMEOUT handling as well.

Bug: angleproject:4043
Test: Manually force VK_TIMEOUT (lower kMaxFenceWaitTimeNs)
Change-Id: I2449ad214ada176014a1702a9b3417d4498d070f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910722
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

968df09e

Vulkan: Enable 3.0 as default context version · 0e5d019e

authored Nov 08, 2019

Now that 3.0 support is passing dEQP, always return that as the
context version to use (unless app asks for 1.0).

Test: angle_end2end --gtest_filter=EGLBackwardsCompatibleContextTest.BackwardsCompatibleEnabledES3/*
Bug: angleproject:3750
Change-Id: I0402ac015acfc22e84a985fe75346999bcc47188
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906202Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

0e5d019e

Vulkan: Add 565 and validate pixel formats: Windows · edc560fe

authored Oct 31, 2019

Add support for 565 to Windows. Also includes code that verifies
generated configs can actually be supported by Vulkan.
Test:
--use-angle=swiftshader --deqp-gl-config-name=rgb565d0s0ms0 --gtest_filter=dEQP.GLES3/functional_fragment_ops_interaction_basic_shader_80

Bug: angleproject:4016
Change-Id: Idcfd4dd368c4a30ef177aa89e1035d2f00570c99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1885378Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

edc560fe

Support standalone Android builds in ANGLE. · 6e687af2

authored Oct 17, 2019

By disabling apk generation, we can build all of our targets in a
standalone ANGLE checkout on Linux.

This allows tools like gn desc to give us useful information about
Android builds.

BUG=angleproject:4026,angleproject:2344

Change-Id: Ic46348fd06c5174ce5e5a4d89ceb391246c6ac6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1866080Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

6e687af2

Roll third_party/spirv-tools/src ab3cdcaef56e..3da910d55f20 (3 commits) · 515f9beb

authored Nov 14, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab3cdcaef56e..3da910d55f20


Created with:
  gclient setdep -r third_party/spirv-tools/src@3da910d55f20

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I8b6eea801806cefacb0db8f63f05609f5478029d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1915880Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

515f9beb

Roll third_party/SwiftShader 88632cac30e1..b2407dd746de (3 commits) · ae55a94f

authored Nov 14, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/88632cac30e1..b2407dd746de

git log 88632cac30e1..b2407dd746de --date=short --no-merges --format='%ad %ae %s'
2019-11-13 chrisforbes@google.com regres: Don't ignore abnormal exits
2019-11-13 swiftshader.regress@gmail.com Regres: Update test lists @ 88632cac
2019-11-13 digit@google.com [vulkan] Implement VK_KHR_external_memory_fd for Linux and Android.

Created with:
  gclient setdep -r third_party/SwiftShader@b2407dd746de

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: Ib24713050daecfc44bd0075f4896283e7232225f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1915881Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ae55a94f

Vulkan: Update bug numbers for GLES 3.1 "debug" expected failures · 1b52f058

authored Nov 13, 2019

I triaged these failures and put cross-backend failures in 2324, and
Vulkan-specific failures in 3590.

Bug: angleproject:2324
Bug: angleproject:3590
Change-Id: Iac806334f410d660c9af42a5c9101b26364911bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914928Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

1b52f058

13 Nov, 2019 7 commits

Roll third_party/vulkan-headers/src d287523f48db..d42d0747ee1b (6 commits) · f533355b

authored Nov 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d287523f48db..d42d0747ee1b

git log d287523f48db..d42d0747ee1b --date=short --no-merges --format='%ad %ae %s'
2019-11-06 jmadill@chromium.org GN: Add support for Google Games Platform.
2019-11-06 8729214+jonahryandavis@users.noreply.github.com build: BUILD.gn missing defines for MacOS
2019-11-04 oddhack@sonic.net Update for Vulkan-Docs 1.1.127
2019-10-28 shannon@lunarg.com vulkan: Fix typo for `operator==` in `vulkan.hpp`
2019-10-25 shannon@lunarg.com vulkan: Update `vulkan.hpp` for VS2015 VT fix
2019-10-21 oddhack@sonic.net Update for Vulkan-Docs 1.1.126

Created with:
gclient setdep -r third_party/vulkan-headers/src@d42d0747ee1b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I36b0e8d3141bf621fdee054cd45d0e98cd3b70c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914130Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f533355b

Vulkan: Fix glMemoryBarrier* implementation · b3c4dffd

authored Nov 12, 2019

The indirect bit handling is no longer necessary, as setup*Indirect
functions already add the barriers if necessary.  The framebuffer bit
is unnecessary as the image layout transition from storage image to
framebuffer attachment would already add the necessary barrier.  Image
access bit was indeed necessary, but so is shader storage bit which is
added.

Bug: angleproject:3574
Bug: angleproject:3879
Bug: angleproject:3934
Change-Id: I9da722e7a34941932731335af2313783295031ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1913080
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b3c4dffd

ES31: Update Vulkan skip list for SSBO · feb3fb1a

authored Nov 12, 2019

This test is passing on multiple implementations locally, including
SwiftShader on Android.  Suspect a driver bug, will follow up with
vendor.

dEQP-GLES31.functional.synchronization.in_invocation.ssbo_alias_overwrite

Bug: angleproject:3602
Bug: angleproject:4097
Change-Id: I363ca6fe150419f4338988cf88c7926c689914b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1911293Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

feb3fb1a

Desktop GLSL input + Vulkan GLSL output in shader_translator · 4b642a6d

authored Sep 04, 2019

This is a sample program that can be used to compile a shader and
inspect the intermediate tree or the output from the shader translator.
This change adds support for the recently added desktop GLSL inputs as
well as the ability to produce Vulkan GLSL output.

Bug: angleproject:3453
Change-Id: I1f378e8d84b74636d6a47ce1aaff5f1f55f5bbb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1784881Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4b642a6d

Roll third_party/spirv-tools/src 12e54dae167c..ab3cdcaef56e (2 commits) · d4b3120e

authored Nov 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12e54dae167c..ab3cdcaef56e


Created with:
  gclient setdep -r third_party/spirv-tools/src@ab3cdcaef56e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I2e643d6348ab9edf9084607666445988f1ab655c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914160Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d4b3120e

Roll third_party/glslang/src f34cdc70ca1b..37dcb894574e (1 commits) · 853e8544

authored Nov 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f34cdc70ca1b..37dcb894574e


Created with:
  gclient setdep -r third_party/glslang/src@37dcb894574e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I74bceafb6cedf58fe7c772c9fbf580d0b8efa7aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914161Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

853e8544

Roll third_party/SwiftShader 9da287fd0264..88632cac30e1 (6 commits) · 9ec5c78a

authored Nov 13, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/9da287fd0264..88632cac30e1

git log 9da287fd0264..88632cac30e1 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 bclayton@google.com Regres: Don't treat non-zero error codes as crashes.
2019-11-12 tobine@google.com Vulkan:maxPerStageDescriptorStorageBuffers = 16
2019-11-12 nicolascapens@google.com Revert "Suppress 32-bit MSVC warning."
2019-11-12 bclayton@google.com Regres: Add workaround for Khronos Gitlab issues
2019-11-12 swiftshader.regress@gmail.com Regres: Update test lists @ 9da287fd
2019-11-12 sugoi@google.com Blend mode fix for 565 format

Created with:
gclient setdep -r third_party/SwiftShader@88632cac30e1

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4016
TBR=cnorthrop@google.com
Change-Id: I39661778e6d1018568736bb499d0e0943b6031b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914162Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9ec5c78a

12 Nov, 2019 4 commits

Enable passing end2end test · 4f023f56

authored Nov 11, 2019

Bug: angleproject:3361
Change-Id: Ie488f77a7baa0ce66d192c651e826c2fee597af2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1912139Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4f023f56

Vulkan: Improve Bresenham line emulation. · 3f647b1b

authored Nov 09, 2019

Clamps the vertex position to the subpixel grid before interpolation.
This will give more correct results on systems that have less than
8 bits of subpixel accuracy.

Also uses a more accurate formulation for the emulation filter in the
fragment shader using dfdx and dfdy.

Fixes line raster CTS tests on SwiftShader. Still does not produce spec
conformant lines. Updates the public docs to indicate this.

Bug: angleproject:2830
Change-Id: Ib9a268df3e7d986bd2b1348be664389fe8fc0ef2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1826598
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

3f647b1b

Roll third_party/spirv-tools/src 3e4abc9ac382..12e54dae167c (1 commits) · b9b1bae4

authored Nov 12, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e4abc9ac382..12e54dae167c


Created with:
  gclient setdep -r third_party/spirv-tools/src@12e54dae167c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I25c0aa854a5d44c9f517de60603c3014a3b7a95f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910782Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b9b1bae4

Roll third_party/SwiftShader 31edef751a8d..9da287fd0264 (6 commits) · 867f8c92

authored Nov 12, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/31edef751a8d..9da287fd0264

git log 31edef751a8d..9da287fd0264 --date=short --no-merges --format='%ad %ae %s'
2019-11-11 timvp@google.com Output Swiftshader version to logcat
2019-11-11 chrisforbes@google.com Allow depth/stencil attachment to be VK_ATTACHMENT_UNUSED in clear
2019-11-11 swiftshader.regress@gmail.com Regres: Update test lists @ 414f99e0
2019-11-11 chrisforbes@google.com Relax descriptor set index assert at descriptor point of definition
2019-11-11 sugoi@google.com Avoid sync issues by removing global android swapchain map
2019-11-11 bclayton@google.com Regres: Check out the change before attempting to read files from it.

Created with:
gclient setdep -r third_party/SwiftShader@9da287fd0264

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I27defe08fe427a2fe8eec29bd49c35dcae411383
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910783Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

867f8c92

11 Nov, 2019 6 commits

Fix EXT_texture_norm16 · e33c1582

authored Nov 06, 2019

* Add norm16 format info for OpenGL backend
* Add validation for newly introduced norm16 formats
* Fix some logic of texture tests

Bug: chromium:1000354, angleproject:1365
Change-Id: Ie6d6e5e276da4df4b7c667be28d324d4976b35ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1902720Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>

e33c1582

Windows: Use Job handle in LaunchProcess. · 82fd2540

authored Nov 11, 2019

This forces all child processes to quit when the parent process is
unexpectedly terminated.

Disabled on Windows 7 because it seems to fail with assinging the
process to the job object. Possibly because of permission conflicts
with the Chromium base/test launcher.

Bug: angleproject:3162
Change-Id: I35f1c1ac5c802904b9b7220cab1bafce1ae0ea15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1862989Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

82fd2540

Minor tweaks to SampleApplication. · f18ff947

authored Nov 09, 2019

Removes an unreferenced function. Also adds the ability for samples to
respond to key up and down events. Only implemented on Windows.

Bug: angleproject:2830
Change-Id: I44c9f93f0ad07b92923ffc0efa580f97d9b98693
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1908448Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f18ff947

Add Metal progress to README · 1abb0dd1

authored Nov 11, 2019

Just to let users of ANGLE aware of

Bug: angleproject:2634
Change-Id: I241ed569a967e8c427cb5cc2e6d82c73c17e320c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906621
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

1abb0dd1

Roll third_party/SwiftShader d9ed1c2732ba..31edef751a8d (3 commits) · 1c7097b6

authored Nov 11, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ed1c2732ba..31edef751a8d

git log d9ed1c2732ba..31edef751a8d --date=short --no-merges --format='%ad %ae %s'
2019-11-09 chrisforbes@google.com Update deqp to vulkan-cts-1.1.6.1
2019-11-08 chrisforbes@google.com Fix PointCoord builtin
2019-11-08 bclayton@google.com Kokoro: Allow 'Fixes:' in bug check

Created with:
  gclient setdep -r third_party/SwiftShader@31edef751a8d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: Id5d4e11721e8d64f0434e6fd58c178419c31e327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1909434Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1c7097b6

Roll third_party/spirv-tools/src 041f0a02493d..3e4abc9ac382 (2 commits) · 02eeebf1

authored Nov 11, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/041f0a02493d..3e4abc9ac382


Created with:
  gclient setdep -r third_party/spirv-tools/src@3e4abc9ac382

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: Ic814942250eea97d3370bf18eb5947941e22188f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1909433Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

02eeebf1

09 Nov, 2019 1 commit

Stop using __has_include<Cocoa/Cocoa.h> · 012d1519

authored Oct 31, 2019

__has_include seems to cause problems with goma builds.
Instead, detect iOS vs MacOS using TargetConditionals.h. Also use
plain C++ instead of Objective-C++ when possible.

Bug: angleproject:3439
Bug: 1015591
Change-Id: I816624e0cdc54ad3a18d3891b4efecf6fe640574
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1894243Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

012d1519

08 Nov, 2019 2 commits

Capture/Replay: Implement more state for mid-execution replay. · 5c0e6e52

authored Nov 08, 2019

Includes much more state serialization. Notably Vertex Arrays were
missing as well as multiple GL render states. Also fixes many
serialization bugs. For example, we would not be using the correct
client array and pack/unpack state in the mid-execution capture. Also
depth/stencil attachments were missing from the capture.

Also fixes the replay sample to work with non-zero starting frames.

With these fixes we can run mid-execution replay of the T-Rex demo.

Bug: angleproject:3611
Change-Id: I6945eb9b30a5137be996956b43f074a0a750b333
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1895112
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

5c0e6e52

Metal: multiple bug fixes · 405d4cf3

authored Nov 09, 2019

- ContextMtl: triangle fan draws should call setupDraw() with original
parameters. Not the modified parameters.
- SurfaceMtl: should initialize metal layer's drawableSize after layer's
creation.
- TextureMtl & FrameBufferMtl: Fix texture copySubImage CPU path
incorrectly copied unflipped area.
- mtl_render_utils: Fix wrong variable name used for trifan compute
pipeline cache table.
- mtl_resources: Fix texture & buffer memory leaks due to missing
ANGLE_MTL_AUTORELEASE.
- mtl_utils: Fix viewport flipping error due to arithmetic between
unsigned & signed values.

These bugs were discovered during dEQP tests running.

Bug: angleproject:2634
Change-Id: Ie01380910ab68a2b876718d9dac0b5b4c41b607c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906608
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

405d4cf3