BUG=angleproject:892

Change-Id: I35288ff43fb7a50a327047eacb8f41ca91e2b441
Reviewed-on: https://chromium-review.googlesource.com/283471Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This will help port OSWindow to other platforms.

BUG=angleproject:892

Change-Id: If9884d310d80421e2fc09cffd03bcf01327b1eee
Reviewed-on: https://chromium-review.googlesource.com/283900Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Otherwise glGetString(GL_RENDERER) returns "ANGLE" and doesn't provide
information on the vendor.

BUG=angleproject:892

Change-Id: I01899ca78656aaa8db860829c78bf3c61c355eae
Reviewed-on: https://chromium-review.googlesource.com/284051Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Instead of storing a vertex format as a struct with the full info,
instead use an enum, and look up the info when we need it. This
saves a lot of constructor initialization time, operator comparison
time, and storage. It also will allow us to look up D3D format info
more quickly.

BUG=angleproject:959

Change-Id: I202fd1ea96981073bc1b5b232b1ec3efa91485cb
Reviewed-on: https://chromium-review.googlesource.com/277289Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

On some configs, this would use an RGBA4 16-bit backbuffer, which is
not enough resolution for the test. Fix this by requiring 32-bit
backbuffers. We might also want to figure out if we want to default
to 16-bit on Windows 8 desktop, which seems less than ideal.

BUG=angleproject:959

Change-Id: I53b3a9ef6cbecf76c7c764623e5eb1f454a6b72d
Reviewed-on: https://chromium-review.googlesource.com/283773Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Austin Kinross <austin.kinross@gmail.com>
Reviewed-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
which can be more simply written as:
STRUCT s = {};

BUG=505297

Change-Id: Ie9f9037a1ba4b6303daa30424cdc24c1ecf18896
Reviewed-on: https://chromium-review.googlesource.com/284160Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

This change splits TIntermConstantUnion::foldUnary into two
functions:
    - foldUnaryWithDifferentReturnType:
        - Handles constant folding of operations where the return
          type has a different number of components compared to the
          operand type.
    - foldUnaryWithSameReturnType:
        - Handles constant folding of unary operations where the
          return type is the same as operand type.

BUG=angleproject:913
TEST=angle_unittests, dEQP Tests
(dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.*)

Change-Id: I675891138d4e17fd2390c03e9f710e0be0b7c7b6
Reviewed-on: https://chromium-review.googlesource.com/283464Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This change adds constant folding support for following floating
point pack and unpack functions:
    - packSnorm2x16, unpackSnorm2x16, packUnorm2x16, unpackUnorm2x16,
      packHalf2x16, and unpackHalf2x16.

BUG=angleproject:913
TEST=angle_unittests(new: MathUtilTest.packAndUnpack*), dEQP Tests
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.float_pack_unpack.*
(all 10 tests started passing with this change)

Change-Id: I2b69faebee4127e5e13900b3a9485b7145950277
Reviewed-on: https://chromium-review.googlesource.com/282683Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

It should not be possible to use globals as l-values in global initializers.

This change was tested extensively with popular WebGL content, with no
regressions found.

TEST=angle_unittests
BUG=angleproject:988

Change-Id: I21ab731eb1d92aeae25795856ccae280792ad1f0
Reviewed-on: https://chromium-review.googlesource.com/283910Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

Verified the NVIDIA suppression locally; assuming the AMD suppression
will take effect on the bot. Thanks to geofflang@ and cwallez@ for the
suggestion on the approach to take.

BUG=angleproject:892

Change-Id: Ida4b6c1395185b0dfb0ea890395e35cb6db7ccd5
Reviewed-on: https://chromium-review.googlesource.com/283974Tested-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Lots of compile errors.

BUG=492725

This reverts commit 5377720a.

Change-Id: I64889b99b1f1f48d39b87ebb668f6a32a3abac45
Reviewed-on: https://chromium-review.googlesource.com/283945Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

This is to help with the FYI bot and pending a refactor to use
our test instantiation.

BUG=angleproject:892

Change-Id: I56e772d7988a2172ad2384bdf408a8eaeab7129a
Reviewed-on: https://chromium-review.googlesource.com/283971Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Cooper Partin <coopp@microsoft.com>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This change saves us ~70KiB per compiler with just ~3KiB of cache.

BUG=492725

Change-Id: I2ee748f7271b1afe0834083cbff6f0b84104aa53
Reviewed-on: https://chromium-review.googlesource.com/281411Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Dmitry Skiba <dskiba@google.com>

Fixes problem where the glBlitFramebufferANGLE symbol couldn't be
found because Mesa's libGLESv2.so was being picked up.

BUG=angleproject:892

Change-Id: Ia3c55bd8eb3f078350adf4cc504bbbed6d97cb0b
Reviewed-on: https://chromium-review.googlesource.com/283950Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

BUG=angleproject:892

Change-Id: I66690ba49789faa672f6ed58e9eb8a2482eb4f6d
Reviewed-on: https://chromium-review.googlesource.com/283472Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Change-Id: Iede6682306082346cf2a3a55fe58f732b7a453df
Reviewed-on: https://chromium-review.googlesource.com/277931Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Generate an error message when an user-defined function call is found in
a global variable initializer.

Even before this patch, the call graph already marked functions that were
only called from the global scope as unused.

This change was tested extensively with popular WebGL content, with no
regressions found.

TEST=angle_unittests
BUG=angleproject:988

Change-Id: Iec1b16d2af386f1e5c383f86926d80cef553b694
Reviewed-on: https://chromium-review.googlesource.com/283291Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

This allows Chromium to avoid initializing a whole bunch of resources
and a shader when it collects GPU information. This should speed up
startup.

BUG=angleproject:1014

Change-Id: Id1e777c6ea86d66ad812540f9d8494744cda64de
Reviewed-on: https://chromium-review.googlesource.com/282553Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

Again this saves on startup time and memory use.

BUG=angleproject:1014

Change-Id: I3890dc2ea50ff4e4f1ff9d7cb223e1ab57c330ce
Reviewed-on: https://chromium-review.googlesource.com/282552Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Lazily loading input layouts can also save memory and startup time.
There are several cases where we don't need these resources until
later, or sometimes, at all.

BUG=angleproject:1014

Change-Id: I4e0d45353b5d3969bd1ed86ad26f47d34e542ed5
Reviewed-on: https://chromium-review.googlesource.com/282551Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

*re-land with fix for cache overflowing*

Using a much more compact input layout structure allows us to save
quite a bit of time comparing input layouts, or computing hashes.
A subsequent patch shrinks the size of the structure further.

BUG=angleproject:959

Change-Id: If240bb7c84d78fc8c9fb6f9049bf71d8a81c97c6
Reviewed-on: https://chromium-review.googlesource.com/283227Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1051

Change-Id: I5f397e230f0e56b1e6832c3dae5ae5c0c9a8b7c4
Reviewed-on: https://chromium-review.googlesource.com/283226Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Variable shadowing and a few other non-bug warnings.

BUG=None

Change-Id: Ibf62d6e7fef91fc213a53a6902f494147ed30ebc
Reviewed-on: https://chromium-review.googlesource.com/283223Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Float16ToFloat32 is now required by constant folding of
float pack/unpack built-ins as well, moving it to commom
so that it is available in libangle_common instead of libANGLE.

BUG=angleproject:913
TEST=angle_unittests

Change-Id: I1e23bb98c1b725c79f933a66ddb9986133fec19c
Reviewed-on: https://chromium-review.googlesource.com/282961Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

BUG=505317

Change-Id: I731b6e5ae5d5eba50f556314eeeebc6a3d29fc7a
Reviewed-on: https://chromium-review.googlesource.com/282932Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1042

Change-Id: I7024bd47601a21b08cafbf6460d512151b53d035
Reviewed-on: https://chromium-review.googlesource.com/277002Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:892

Change-Id: I135e356e1ec78c95e69a260bd0576e5285e759b5
Reviewed-on: https://chromium-review.googlesource.com/283225Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This emulation is for renderers that do not support Geometry Shaders.

BUG=angleproject:949

Change-Id: I7acf003e83ea6661f10a703486e6d07eb28786f8
Reviewed-on: https://chromium-review.googlesource.com/274851Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Cooper Partin <coopp@microsoft.com>

Fixes the tests not running directly from the VS UI.

BUG=angleproject:1051

Change-Id: Ia299d8e7ad676330902725c114e8f5766db49d82
Reviewed-on: https://chromium-review.googlesource.com/283158Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1051

Change-Id: If10abaea31ad29af9f8d438403f67b9dfbfd7e45
Reviewed-on: https://chromium-review.googlesource.com/283167Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1051

Change-Id: I46c3a5651d36750558735eb626ed5c9424b250b4
Reviewed-on: https://chromium-review.googlesource.com/282596Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Seems to be failing maps_pixel_test on the bots.

BUG=angleproject:959

This reverts commit 53fd1552.

Change-Id: I1f2593caca58f701d284993d2ee313846806491b
Reviewed-on: https://chromium-review.googlesource.com/283157Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Using a much more compact input layout structure allows us to save
quite a bit of time comparing input layouts, or computing hashes.
A subsequent patch shrinks the size of the structure further.

BUG=angleproject:959

Change-Id: I7a0f10428cc7e96967e60cc085ff2e8779718978
Reviewed-on: https://chromium-review.googlesource.com/277288Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

We can reduce the amount of iterations we use by using std::vectors
for storing UBO indexes, and resizing them to the max active index.
This allows us to skip inactive ranges. Reduces draw call overhead.

BUG=angleproject:959

Change-Id: I2577e5dbdce0e5ab102ca916eb7f1f35cf03f9ad
Reviewed-on: https://chromium-review.googlesource.com/277287Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
which can be more simply written as:
STRUCT s = {};

BUG=505297

Change-Id: Ib4513ee195d43e7c4a4a2f46c328866f0023a2a5
Reviewed-on: https://chromium-review.googlesource.com/282921Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

On 32-bit Android this change saves ~30KiB per compiler instance.

BUG=492725

Change-Id: I8bea48d57ee7eac0a0ee417035085c0d335aea09
Reviewed-on: https://chromium-review.googlesource.com/281047Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Dmitry Skiba <dskiba@google.com>

Const types make it possible to implement caching and
other optimizations.

BUG=492725

Change-Id: I64398bb9effcc909dd052a038acbb5ec0ca730e8
Reviewed-on: https://chromium-review.googlesource.com/281046Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Dmitry Skiba <dskiba@google.com>

Deferred rendering is a shading technique, and "lazy" is the more
correct term. Also rename a few methods so we can use a shared
interface for other types of lazy D3D11 resources.

BUG=angleproject:1014

Change-Id: I2fd2c823291d414003690066eaec063f1cd0bc4c
Reviewed-on: https://chromium-review.googlesource.com/282550Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Brandon Jones <bajones@google.com>

BUG=angleproject:1051

Change-Id: I158e59ca581b580825848e831d05064cdcc30d96
Reviewed-on: https://chromium-review.googlesource.com/276202Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1052

Change-Id: I03883799ef334f39c9e855a0a4b7af1ab02d5da9
Reviewed-on: https://chromium-review.googlesource.com/282414Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Minmin Gong <mgong@microsoft.com>