The PVRTC format, as pointed out by Le Hoang Quyen and Geoff Lang,
uses 4x4 or 8x4 blocks, but due to sampling from adjacent blocks,
requires a minimum size of 2x2 blocks per the OpenGL extension:
https://www.khronos.org/registry/OpenGL/extensions/IMG/IMG_texture_compression_pvrtc.txt
. Thanks to Quyen and Geoff for pointing out the intricacies.

Add a helper function to formatutils.cpp which returns the minimum
number of blocks (width and height) for a given compressed texture
format, and incorporate this into the compressed texture size
computation.

This patch makes WebKit on ANGLE pass WebGL's PVRTC compressed texture
test on iOS hardware.

Bug: angleproject:4652
No-Presubmit: True
Change-Id: I1046a091321b7948d712d16686ee0cb8795b8c99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2213676
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Eliminate the potential for integer overflow when clippling a large
viewport rectangle by first limiting it to the Vulkan viewport size
limits.

BUG=chromium:1078378

Change-Id: I2648c6136d2d27d67a3fc5dae2de821279d70d81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2215308Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

These warnings were generated due to a validation layer bug, which is
presumably fixed now.

Bug: angleproject:4572
Bug: angleproject:4577
Bug: angleproject:4578
Bug: angleproject:4579
Bug: angleproject:4580
Bug: angleproject:4583
Change-Id: I8799c4e33bc38f83e0fdd364cf6e7eb607c39890
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227810Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3450
Change-Id: Ie88aedae6e4573b2c31e389f7d0ff5c8d1059647
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227856Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_shaders_derivate
Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest.OrientedWindow
Bug: b/157476241
Change-Id: I7b60b7a33313ba91731755d289792bd0968515c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2222825
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

1. The first sentence description should be one line <= 64 characters
2. The description body should be wrapped to <= 71 characters
3. Blank lines between the description and the body,
and the body and the meta-tags like Bugs

Bug: angleproject:4662
Change-Id: I966c79d96175da9eee92ef6da20db50d488137b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2218696Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/515b4041cc32..d43f5107400d

2020-06-02 s.fricke@samsung.com layers: Add function name prefix to more logs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Idc4deba8a183dd983de000b90a33fa240ceb9ed5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2228479Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2bc4fcd9eba5..322784a873be

2020-06-02 charles@lunarg.com vulkaninfo: fix indent with for present support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ic784b5999651d0fcb3bc3846321befb54a0bbd78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2228480Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/11dd7183c4d2..3ad285a60d82

2020-06-02 vantablack@google.com Added reference counting for PipelineLayout objects
2020-06-02 bclayton@google.com libVulkan: Use new marl::Scheduler::Config API.
2020-06-02 bclayton@google.com Kokoro: Test LLVM 10 backend for macos
2020-06-02 bclayton@google.com Merge changes I5eaceebc,I4d78c011,I7d01a3c8
2020-06-02 caio.oliveira@intel.com Update VkStringify for VK_EXT_subgroup_size_control
2020-06-02 caio.oliveira@intel.com Update Vulkan headers to version 1.2.141
2020-06-02 bclayton@google.com SpirvShaderDebugger: Implement Array types
2020-06-02 bclayton@google.com SpirvShaderDebugger: Replace 'builtins' / 'root' with a global scope
2020-06-02 bclayton@google.com SpirvShaderDebugger: Silence release only warning
2020-06-02 bclayton@google.com SpirvShaderDebugger: Handle None sizes for composite types
2020-06-02 bclayton@google.com SpirvShaderDebugger: Handle template types
2020-06-02 bclayton@google.com SpirvShaderDebugger: Don't display SSAs for array types
2020-06-02 bclayton@google.com SpirvShaderDebugger: Don't display SSA values with DebugInfo
2020-06-02 capn@google.com Make ManagedStatic registration thread-safe
2020-06-02 capn@google.com Regres: Test changes from external contributors if reviewed by Googler

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: If4c5997f3544590234efdd860f2b776dd9c276fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2228481Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f050cca7ec47..636f449e1529

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I139bc63fb64adef7de274245c9f82bcf78f6cf74
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2228478Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This uses the "null" buffer in the Renderer to bind an empty
buffer handle so ANGLE can maintain a consistent state.

Bug: chromium:1086532
Change-Id: I1912a1d1cb64433a285fcfced80a675619690a0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2219140
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

When copying via glTexSubImage2D to a non-renderable format, GL_RGB9_E5,
ANGLE's TextureVk::copySubTextureImpl will use the read-back and copy
method. This path was ignoring the source offset in the source area
computation.

Fixes the following WebGL tests:
conformance2/textures/canvas_sub_rectangle/tex-2d-rgb9_e5-rgb-float.html
conformance2/textures/canvas_sub_rectangle/tex-2d-rgb9_e5-rgb-half_float.html

Bug: b/157744725
Change-Id: I714f8d3b8f1490edab5e7578445e9623215ce229
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225611Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS/+log/60972ed7fa8f..80dc8399b063

$ git log 60972ed7f..80dc8399b --date=short --no-merges --format='%ad %ae %s'
2018-03-16 capn Add texture specification test for GL_OES_texture_half_float.
2020-06-01 alexander.galazin Update KC CTS
2020-05-15 rgarcia Add SampleMask write tests
2020-05-29 ynovikov Fix Windows build
2019-03-08 lionel.g.landwerlin Add drm format modifiers tests
2020-05-21 piotr.byszewski Correct few pipeline_barrier tests
2020-05-22 slawomir.cygan Do not use 2D array d/s attachment created from 3D texture
2019-04-03 mika.vainola Update Android API levels and grant permissions
2020-05-18 basni Fix overflow in VK_EXT_subgroup_size_control tests.
2019-11-21 courtneygo Fix uninitialized index array
2020-02-24 jdrouan Add conformance tests for new buffer offset rules
2020-03-03 tomek.bury Improve Wayland protocol version selection.
2020-04-30 tarceri Fix broken layout binding tests
2020-05-06 gleese Remove non-compute variants of common function tests
2020-04-17 Kyle.Griffiths Allow RTZ rounding in spv_assembly*writes_two_buffers* tests
2020-05-04 alexander.galazin Update glslang
2020-05-24 alexander.galazin Force Popen to text mode
2020-05-07 alexander.galazin Ensure alphabetical order of xml attributes
2020-05-24 alexander.galazin Force Popen to text mode
2020-05-06 james.glanville Limit dimensionality of arrays-of-arrays in random SSBO tests
2020-05-07 alexander.galazin Fix Fedora 32 gcc/clang warnings
2020-05-07 alexander.galazin Fix Fedora 32 gcc/clang warnings
2019-11-18 mike.byrne Split spirv_assembly tests workload
2020-05-12 rgarcia Add --deqp-print-validation-errors cmd line option
2020-04-29 rgarcia Test using ViewportIndex from frag shaders only
2020-05-07 ari.suonpaa Test OpArrayLength with stride larger than element size
2020-05-08 bwatling Add an Amber test which uses textureOffset()
2020-05-09 ari.suonpaa Test negative value conversion to b10g11r11 float format.
2020-05-03 tarceri Fix some egl robustness tests
2020-04-28 aleksy.sokolowski Fix epsilon calculation for RGB10_A2 pixel format
2020-05-14 piotr.byszewski Fix warnings found by compiling with MS VC++ 2019
2020-05-13 piotr.byszewski Correct few tests from indirect_dispatch group
2020-05-12 piotr.byszewski Correct sparse_image_format_properties2 tests
2020-05-12 piotr.byszewski Clarify integer formats conversions in blit_image tests
2020-05-11 piotr.byszewski Correct external_memory_host tests
2020-05-11 piotr.byszewski Correct opatomic_storage_buffer_volatile tests
2020-05-15 alexander.galazin Update Vulkan headers
2020-05-13 alexander.galazin Whitelist Vulkan CTS 1.2.2.1
2020-05-07 slawomir.cygan Add missing barrier to HOST in memory_barrier test
2020-05-04 quic_mnetsch Fix wide line rasterization tests
2019-12-04 courtneygo GLES 3.1 negative framebuffer texture2D test fails
2019-12-17 courtneygo OpenGL ES: Use shader storage alignment
2019-07-31 courtneygo Remove illegal parameter use in fbo.completeness
2019-09-11 courtneygo Fix use of invalid HALF_FLOAT enum
2018-08-28 james.hauxwell Fix invalid combinations for texture/copy on ES2 driver
2019-08-28 timvp Use unsized internal format in KHR-GLES2.texture_3d.[copy_sub_image|framebuffer_texture].rgba8
2019-07-30 courtneygo Fix invalid parameter for GLES 2.0
2018-07-13 james.hauxwell Fix invalid combinations for texture/copy on ES2 driver
2019-12-20 courtneygo Migrate deRoundUp32 to deInt32.h
2020-04-22 alex.walters Non-strict line interpolation and rasterization
2020-05-01 zzyiwei Suppress -Werror=array-bounds for latest GCC
2020-03-13 rosen.zhelev Extend Android Hardware Buffer external memory format tests
2020-05-07 alexander.galazin Ensure alphabetical order of xml attributes
2020-05-07 alexander.galazin Ensure alphabetical order of xml attributes
2020-05-04 cwabbott0 fix input dependency for renderpass depth/stencil format tests
2020-04-27 slawomir.cygan Avoid exceeding maxPerStageResources in descriptor_indexing tests
2020-04-27 ari.suonpaa Split subgroupBroadcast tests
2020-04-03 rgarcia Test variableMultisampleRate with non-empty framebuffer
2020-04-29 ari.suonpaa Added a fourth batch of coverage tests found by GraphicsFuzz
2020-04-17 joshua Make ImageSamplingInstance loop over pNexts
2020-02-26 yevhenii.kolesnikov Add tests for usage of pixel storage modes
2020-04-29 luwang Fix of a build failure on QNX
2020-05-05 alexander.galazin Update SPIR-V Tools
2019-08-28 quic_mnetsch Adds geometry shader check for test
2020-04-17 james.glanville Stop 10bit formats requiring GL_SRGB encoding
2017-12-21 mnetsch Fixes pixelformat utils for RGB10_A2
2018-08-31 yabin.zheng Add specific RGB10A2 data for BlendHSLHue and BlendHSLSaturation

Created with:
  roll-dep third_party/VK-GL-CTS/src

Bug: angleproject:4675
Change-Id: Id9b92e3ce400bf2c4669be845d3f6b5a12b5886f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227039Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

EGL_CreateSync was calling into ValidateCreateSyncKHR
instead of ValidateCreateSync. This ended up returning
the incorrect enum for a negative test in deqp.

Bug: angleproject:2466
Test: angle_deqp_egl_no_gtest.exe --deqp-case=dEQP-EGL.functional.fence_sync.invalid.create_invalid_type
Change-Id: I476d533049c2499705b783293cb6bde311f48a65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2226932
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The VK_IMAGE_USAGE_STORAGE_BIT has negative performance impact. Right
now we needed for overlay widgets. This CL will only add the bit if we
actually have widget enabled.

Bug: b/157774833
Change-Id: I3027df886c9b34ccfd667152fa4fb090dfadb45b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225810Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

Fixes Vulkan validation-layer errors.  Found by dEQP tests that
use small viewports and/or scissors (see Buganizer bugs for
details).

Bug: angleproject:4431
Bug: b/157933235
Bug: b/157933198
Change-Id: I83966906d70c30a4b50209cf1a33649bf69e3dd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225607
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

This is useful for later modifications where blit/clear could be further
categorized based on texture format type (float/integer).

Bug: angleproject:2634
Change-Id: I877abd21761af9e91657686a60e189a43a33e3f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2193195Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This test is failing because our out-of-date Windows 7 NV bots
can't create a GLES 3.0 context. Skip this test until the machines
are updated.

Also updates our wrapper classes to check for an empty handle
before calling delete. Prevents a crash trying to call null functions.

Bug: chromium:1090139
Change-Id: I0bb58f8bd167691cd241fb0df30cdf4b2f6adf5b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225447
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/471c120ac92a..11dd7183c4d2

2020-06-01 capn@google.com Remove generation of OpenCLDebugInfo100.h
2020-06-01 capn@google.com Fix deallocation of uninitialized pointer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I72b05c53434de57fc3110de155ec9cbf922809ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2226132Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/09531f27933b..db1a98c6cc43

2020-06-01 oddhack@sonic.net Update for Vulkan-Docs 1.2.142

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I2856b05ceecc2f233869621e243b4b11e72acccb
Bug: None
Tbr: ynovikov@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2226131Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d39b8afc47a1..78a3c915a1d7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I8acf30345c583a0512cf9c7016df8239559518cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2226130Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/500f77901f6d..515b4041cc32

2020-06-01 mark@lunarg.com chassis: Address non-const refs
2020-06-01 mark@lunarg.com chassis: Properly use vk_safe_struct.cpp without including it
2020-06-01 mark@lunarg.com chassis: Factor out some common parsing functions
2020-06-01 mark@lunarg.com chassis: Load default callbacks earlier in CreateInstance

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: If51ab028be0cf0b3da9f8917676a6800322589fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2226129Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

In crrev.com/c/1866080, catapult and android_ndk were added for
supporting standalone Android builds, which increased ANGLE's fresh
checkout time and disk occupation a lot. For ANGLE embedders, this can
be mitigated by putting them behind a condition, where checkout_android
is a builtin variable controlled by target_os in the .gclient file. For
standalone builds on Linux, Android will be added to target_os by
default for compatibility with previous behavior.

Bug: None
Change-Id: I0b258c6fc7f62ca65e705b8c31c9ace5dffd4030
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216709Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajie Hu <jiajie.hu@intel.com>

The mAcquireImageSemaphore is for achieving the maximum overlap between
display engine and rendering engine. We should only need to block when
we write to the swapchain image. Work that doesn't touch the visible
buffer can proceed.

Bug: b/157916459
Change-Id: Ic9a9a1f2a7648ef7f50f99578a0f0d674ae5e66c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2223826
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

These do not fail on SwiftShaderVK. Root problem was fixed at some point
so we can re-enable these.

Bug: angleproject:4092
Change-Id: I8a0e03eaf438b61d31a2c6461e581445d0378645
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2221424Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This will allow the TransformFeedback and other classes to share
the same buffer. Also should save a bit of memory.

Bug: chromium:1086532
Change-Id: I198170b4e09165a4770b68af6df9aa7b690e8d66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2219138
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Previously ProgramMtl could try to bind fixed slots to samplers based on
layout (set=..., binding=...). However, GLSL layout model is different
from Metal slots assignment. For example, The following is valid layout
in GLSL:
- array samplers A[2] is bound to index 0.
- array samplers B[2] is bound to index 1.
It is invalid to do so in Metal, since A occupies 2 slots, thus samplers
  B[2] must be bound to slots starting from 2.

New binding method: let spirv-cross auto assigns the texture slots and
  retrieve them after compilation.

Incomplete textures moved to ContextMtl using IncompleteTextureSet.

New test added: GLSLTest.ArrayOfStructContainingArrayOfSamplers.

Bug: angleproject:2634
Change-Id: Ib0edaaf8b20512e1272c37c1d4b16a88a5b35e75
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2193193
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Both DisplayOzone and DisplayGLX have SwapControlData declared and
defined. In the future, when both of them will be compiled
(DisplayGLX will be required for Ozone/X11), they will result
in a compilation error stating about multiple definitions of the
struct.

Thus, move that rendergl_utils.

Bug: chromium:1084458
Change-Id: Ib174d0e8de1ac4773c841fe286175358acb15d79
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2210702
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Had an incorrect label for the gl::Context and was missing a
few edges for new connections.

Bug: None
Change-Id: I037551f8f0a6559b9c522ae192b1cd93edf9bcf0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2223815Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Fixes an implied dependency cycle between translator and angle_common. This will also allow us to be more strict about declaring dependencies on GLSLANG headers.

Tested by building and running angle_unit_tests on Linux.

Bug: angleproject:4672
Change-Id: I331230d2cf179ccea140ee7a0d5a3c8768c58cb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2222682Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1. Request a GLES3.0 context
2. Create 2 uniform buffers to be used in the new test case
3. Increase the size of the viewport
4. Add a new test case where we issue draw and buffer
   copy commands. The expectation is that the draw to
   FBO and the copy between the 2 buffers happen in
   parallel.

Bug: angleproject:4633
Test: angle_perftest --gtest_filter=VulkanBarriersPerfBenchmark.Run/vulkan_buffer_copy
Change-Id: I3c5d287c05451f77053962371a96e2de6a8ea00d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2215139
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8dfdbeff84f3..f050cca7ec47

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I682a6e599541cc32ff7cbd7d6f509683fef0f598
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2224899Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3c5bad0911e3..500f77901f6d

2020-05-29 s.fricke@samsung.com tests: Add extra VK_EXT_sample_location test
2020-05-29 s.fricke@samsung.com layers: Fix VK_EXT_sample_locations bug
2020-05-29 mark@lunarg.com tests: Added test for VUID-VkFBCreateInfo-pAttachments-00891
2020-05-29 mark@lunarg.com corechecks: Add FB check for depth-stencil 3D image/imageviews
2020-05-29 s.fricke@samsung.com tests: Add VUID 02840
2020-05-29 s.fricke@samsung.com layers: Add VUID 02840
2020-05-29 mark@lunarg.com layers: Clean up some variable name formatting issues
2020-05-29 souravp@nvidia.com tests: Implement test for raytracing VUIDs
2020-05-29 souravp@nvidia.com layers: Raytracing VUIDs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I1fce9cae0dcf5c96713b70833dee2c02aab9ae47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2224610Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

TBR: jmadill@chromium.org,nguyenmh@google.com,tobine@google.com
Test: angle_perftest --gtest_filter="*candy*"
Bug: b/150458396
Change-Id: I79c86b8d111ef55528da2ec5f0ac3a39428a1667
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2223658Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

TBR: jmadill@chromium.org,nguyenmh@google.com,tobine@google.com
Test: angle_perftests --gtest_filter="*Trace*"
Bug: b/150458446
Change-Id: Ie47dfa7208db0fb1f2449b758df9d2b73bbfe974
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2220766Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Traces that populate data by reading from unaligned memory addresses can
crash. This CL ensures each offset is 16-byte aligned.

TBR: jmadill@chromium.org,nguyenmh@google.com
Test: angle_perftests --gtest_filter="*Trace*"
Bug: b/150458446
Change-Id: I721999426772fa2f94fe39600d330a15eacc2794
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2222847Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Make these more consistent with the rest of the wrapper classes.
Also handle some VkResult errors that were being ignored.

Will pave the way for better handling of buffer allocation error
conditions.

Bug: chromium:1086532
Change-Id: Idc5b3f0e2945b1f44f152d33e8cc572f83a6b658
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2219136
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>

This is necessary so we can initialize a "null" BufferHelper in
RendererVk which does not have access to the ContextVk. This in
turn will allow us to use a single global "null" Buffer instead
of instantiating them all over ANGLE.

Also removes a TODO that was sticking in the code.

Bug: angleproject:2162
Bug: chromium:1086532
Change-Id: Ica48d5b886e885ebfe0f8e3abfbe8169a8eaa5b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2219139
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Reference article in favour of one big triangle instead of 2:
https://michaldrobot.com/2014/04/01/gcn-execution-patterns-in-full-screen-passes/

According to this article, the performance could be increased by ~10% for fullscreen shaders.

Bug: angleproject:2634
Change-Id: Ia5b04c40f0587e3cb8680c0f30f7b68d9d7a3efe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2193192
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

It's undefined what happens if we run into OOM errors when allocating
new resources. To guard against fuzzer issues we can set the buffer
size internally to zero when an allocation fails. This should prevent
GL APIs from reading from the buffer when the contents are internally
inconsistent.

Bug: chromium:1086532
Change-Id: I9ac4becf977bf0521208b2220caba788c21c93f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2219137
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>