Commits · 3f4e004f7b3f3f308fa152d195e1aa4286e523ca · Chen Yisong / angle

22 Jan, 2021 4 commits

Roll vulkan-deps from f646afdb8929 to a0047c0f6ec8 (1 revision) · 3f4e004f

authored Jan 22, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/f646afdb8929..a0047c0f6ec8

2021-01-21 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9b4e82efb482 to 6abdde3ce511 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Iac0fb2ddd8cb81e7cec57df74062e83eca32c172
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643123Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3f4e004f

Roll Chromium from 67fb6a8435bb to 318dff1807ef (435 revisions) · c827ccbb

authored Jan 22, 2021

https://chromium.googlesource.com/chromium/src.git/+log/67fb6a8435bb..318dff1807ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/2f05905c0d..888f037dd4
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0c30db82f7..13547b97da
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/cd618b63bb..eeb08d20a6
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/947ea991af..63a2bc635d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..957dfeae29
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3c716375fd..786cae1ea0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7161349d95..07f759b55a
No update to Clang.

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6bc26ccad8ffc7a406c03c6726112212a492ed3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2643865Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c827ccbb

Properly fail upon program binary version mismatch · ff5f715e

authored Jan 19, 2021

Return angle::Result::Stop instead of Incomplete when
Program::deserialize detects version mismatch. This causes the caller,
Program::loadBinary, to stop trying to load it. At least with the
Vulkan backend, trying to load it results in a crash.

Added test case to ProgramBinariesAcrossPlatforms which exhibits the
old crash.

Bug: angleproject:5567
Change-Id: I2ebb27cee0aa895855504f758992b4dfec3f4aa3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639078Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Steven An <stevenan@google.com>

ff5f715e

Capture/Replay: Capture all indexed buffer bindings during MEC · 9ccd3536

authored Jan 20, 2021

"eFootball PES 2021" binds uniform buffers via glBindBufferRange()
before any frames haves been rendered and then uses those bound buffers
for all subsequent frames. A recent fix captured the UBOs that were also
bound as GL_UNIFORM_BUFFER, but failed to capture all indexed buffers
bound only with glBindBufferRange().

This CL captures all indexed uniform, atomic counter, and shader storage
buffers during MEC setup.

Bug: angleproject:5564
Change-Id: I0e638ec4407a091f943b9640e8fc6a7c9f4c4e08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640424Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

9ccd3536

21 Jan, 2021 11 commits

Tests: Add Subway Surfers trace · 70f493d6

authored Jan 20, 2021

Note this differs from the previous trace for the app,
"subway_surfer_500". The previous trace is no longer
compatible with the replay harness and could not be
re-recorded due to using Vulkan at the time.

Test: angle_perftests --gtest_filter="*subway_surfers*"
Bug: angleproject:5569
Change-Id: If941a3f0e88e3e1aee7fb7db736e623f66a65de6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641098Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

70f493d6

Vulkan: Flush if sync object is pending during SyncVk::getStatus() · 535d4783

authored Jan 20, 2021

When a glGetSynciv() is performed for GL_SYNC_STATUS, we should flush
any pending commands if a sync object is pending a flush, since the
caller is interested in the status of a fence. This will guarantee that
the work is submitted to the hardware and eventually completes.

This is accomplished by moving mSyncObjectPendingFlush from ContextVk to
ShareGroupVk, so that any sync objects used by any contexts within the
share group are submitted to hardware and the required work completes.

Bug: angleproject:5306
Bug: angleproject:5425
Test: FenceSyncTest.BasicOperations
Change-Id: I2e2681ad01fda429ba37f061c9bac5eb91f800fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641095Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

535d4783

Capture/Replay: Erase texture from mCachedTextureLevelData · 26e02593

authored Jan 15, 2021

When the caller issues a glCompressedTexImage call, we need to delete
the cached texture data, since the texture size/data are being
respecified and the old data is now stale.

This fixes MEC for "Klondike Adventures".

Bug: angleproject:5549
Change-Id: Ie788e2bf39f7a29ec6bc55f95d6f570f1d22d659
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633071
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

26e02593

Do not make context current during context deletion. · f5d56799

authored Jan 20, 2021

ANGLE will make a context current during deletion, so ANGLE can release
related resources, but for an external context, the API user should make
sure the native context is current during deleting the ANGLE external
context, so ANGLE doesn't need to make the context current.

Bug: angleproject:5509
Change-Id: Ia4cee4e3965e9e9e811e3f989f6f6d72bd940f41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640593
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f5d56799

Vulkan: Remove swiftshader workaround for missing gl_Position · 203154b5

authored Jan 18, 2021

The following line was added by the translator to work around a
swiftshader bug where no gl_PerVertex declaration (and hence no
gl_Position) would fail an assertion:

    gl_Position = gl_Position;

The swiftshader bug is fixed, so this line can be removed.

Bug: b/176161380
Change-Id: I68a8e0d9cd8b97e9d294a119c2daa4ab64ec863f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633729Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

203154b5

Roll vulkan-deps from 3180f85f9bcd to f646afdb8929 (2 revisions) · f28a06ba

authored Jan 21, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/3180f85f9bcd..f646afdb8929

2021-01-20 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1bd539b9bfc4 to f37547c73a98 (1 revision)
2021-01-20 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 56f8ed48efd5 to 1bd539b9bfc4 (1 revision)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I592dbdeccf1b7aeaa8bc36b0cafaf9363678b19e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641011Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f28a06ba

Roll Chromium from 132575638f37 to 67fb6a8435bb (480 revisions) · 0e37da9b

authored Jan 21, 2021

https://chromium.googlesource.com/chromium/src.git/+log/132575638f37..67fb6a8435bb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3fd2266640..2f05905c0d
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4dfabb3243..cd618b63bb
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..beb8370c49
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2e4e6e975a..3c716375fd
No update to Clang.

Bug: angleproject:3580
Tbr: cnorthrop@google.com
Change-Id: I5aeb58e86be883cbb5e03bbc910981deaede93c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2641008Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0e37da9b

Translator: Avoid vector copies with multi-replacement · 9f4b159b

authored Jan 19, 2021

Turns push_backs into emplace_backs and changes the TIntermSequence
constructor argument to &&.

Bug: angleproject:5535
Change-Id: I640ce879b6ade48a28dea6385ebb7a95cb8304ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636680
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

9f4b159b

Vulkan: Move Flush during SyncHelper::clientWait() earlier · bb766000

authored Jan 20, 2021

The checks and call to contextVk->flushImpl() needs to be moved before
the timeout check to ensure that the vkEvent is flushed to HW eventually
when the caller is waiting on it, even if they don't specify a timeout.

Bug: chromium:1060139
Test: CopyOutputScalingPixelTest.ScaledCopyOfDrawnFrame/48
Change-Id: I725ea492aaf21e291fe3e5b9ae11ea009e59e019
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640423
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>

bb766000

Translator: Stop allocating TIntermSequence · f0286e63

authored Jan 19, 2021

The functions that take a TIntermSequence always copy out / Swap the
contents away.  This change makes all TIntermSequences live on the stack
instead of being newed.

Bug: angleproject:5535
Change-Id: I942f1c5e57b00199d5308183f71bd9e18b0608bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636679Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

f0286e63

Support specifying array slice for D3D11 texture EGLImage · 137271ff

authored Jan 13, 2021

Client can specify array slice for creating the SRV/RTV with
EGL_D3D11_TEXTURE_ARRAY_SLICE_ANGLE.

Test: D3DTextureTest.TextureArrayImage*
Bug: angleproject:5538, chromium:1116101
Change-Id: I81cb2823df2145f1d05ad1526b0e36d6a0724d5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2628609Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>

137271ff

20 Jan, 2021 17 commits

Rename ShaderVariable::structName to structOrBlockName · bb3adfa4

authored Dec 01, 2020

Bug: angleproject:3580
Change-Id: Ic53a5267972f153dad2e20948e493e9767a45d16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568247
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bb3adfa4

EGL: Respect eglMakeCurrent with a null context. · df33d561

authored Jan 19, 2021

Our context virtualization code would try to optimize this case
and leave the current context bound when possible. This has the
side effect of leaving the current surface bound too, even if
it was deleted.

During Chrome's window resizing, it deletes the window, calls
eglMakeCurrent with null and then recreates the window. This
causes an error because the window still exists because it was
left current in ANGLE.

Bug: chromium:1167718
Change-Id: I857be88be48dfa9c0dd9173f235e155e727e3014
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637717Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

df33d561

Support switch surfaces for external context. · 2ebff7f2

authored Jan 20, 2021

WebView may change surfaces due to resizing. So we need to support
switching surfaces with the external context.

Bug: angleproject:5509
Change-Id: Id91eed092a63b3740fd796e0a3cb819ae18baaa9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639077Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

2ebff7f2

Capture/Replay tests: Use failure exit code. · 0ae61c25

authored Jan 20, 2021

This will allow the test step to fail when run in CI.

Bug: angleproject:5530
Change-Id: I7c156438ded82aa7191b8b597a9a52200c0efe57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2638989
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

0ae61c25

Vulkan: Emulate R32F images with R32UI · ea71c6b6

authored Jan 12, 2021

GL requires that imageAtomicExchange be supported for r32f formats.
However VK_FORMAT_FEATURE_STORAGE_*_ATOMIC_BIT is nearly unsupported
everywhere without some Vulkan extension that brings in unnecessary
support.

This GL feature is emulated by transforming the shader to use r32ui for
all images that originally specified r32f.  floatToUintBits and
uintBitsToFloat is used to maintain correct usage of the image* builtin
functions.

Bug: angleproject:5535
Change-Id: Ie607089935d3283b3ffa054f4b4385b81fb8f53d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2635453
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ea71c6b6

Capture/Replay: Don't serialize compile resources string. · a4d05638

authored Jan 18, 2021

The resources string gets changed dynamically during capture. This
breaks the regression tests because they were comparing for identity.

Bug: angleproject:5530
Change-Id: I0734f735577a5ff4c9083adb8f25a37aad3c0e37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634830
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

a4d05638

Make metal_shader_cache_file_hooking a data_deps · 80b45c33

authored Jan 20, 2021

After https://chromium-review.googlesource.com/c/angle/angle/+/2580918
angle_unittests will not run on OSX when it is non component build
and metal_shader_cache_file_hooking is a shared library:
dyld: Library not loaded: ./libmetal_shader_cache_file_hooking.dylib

Bug: angleproject:5565
Change-Id: I1ac43d928cfaff692aa233c2ba3504a73573ee3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2640173Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

80b45c33

Vulkan: Simplify RewriteCubeMapSamplersAs2DArray · 2b242f53

authored Jan 17, 2021

This change is mostly done to remove an unnecessary helper in
ReplaceVariable.cpp.

Tested locally, as the bots all support ES3.1+.  There are a few
failures, with or without this change.

Bug: angleproject:5556
Change-Id: I7bd2d4294c9dc164146d713db6b45cbc73e59c16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633437
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

2b242f53

Roll vulkan-deps from dd50a3bce3ca to 3180f85f9bcd (11 revisions) · bd8ca051

authored Jan 20, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/dd50a3bce3ca..3180f85f9bcd

2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from e25db023c47a to 56f8ed48efd5 (1 revision)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c7ffe6890160 to ab73ad637606 (2 revisions)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from efecc309816c to c7ffe6890160 (2 revisions)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from fb6e414f76dc to efecc309816c (1 revision)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 03e41cc0c2a8 to fb6e414f76dc (2 revisions)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6886c4b57f10 to 03e41cc0c2a8 (3 revisions)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 10651a9c0bc2 to 6886c4b57f10 (1 revision)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 5b7d68ca6b3f to 9b4e82efb482 (1 revision)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3de5cfe50ede to 5b7d68ca6b3f (1 revision)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 9efc4a631161 to 684390cedbff (1 revision)
2021-01-19 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8383bd5d6f26 to e25db023c47a (1 revision)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ic79a5b12d8132a7f322c507150d3a7aa62ca0d66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639815Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bd8ca051

Roll SwiftShader from 8da0f82baf35 to 22be66d40712 (2 revisions) · 15a3d28b

authored Jan 20, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/8da0f82baf35..22be66d40712

2021-01-20 capn@google.com Fix always performing early depth test when requested
2021-01-19 digit@google.com vulkan: Support VK_KHR_external_memory_fd on OS X.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Iddb4b62f284463aef7d7cdcc289b711668e0c545
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639923Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

15a3d28b

Roll Chromium from f3626a1bfa8f to 132575638f37 (396 revisions) · 2900a0f4

authored Jan 20, 2021

https://chromium.googlesource.com/chromium/src.git/+log/f3626a1bfa8f..132575638f37

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9766d96a51..3fd2266640
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c38b5ab1c6..0c30db82f7
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d6e501127c..4dfabb3243
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..05342ef131
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/819010a7e6..2e4e6e975a
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/860610b866..7161349d95
* tools/skia_goldctl/linux: fZ-8UCX4nVBdizWPWt4iEXoKw9052O2u8regRqax1zUC..ISnBOFRy8pK6MqHvQt1Dssi358v4KHM5zJuWVrsmL6cC
* tools/skia_goldctl/mac: tb5CVkUBpdIU8L9wnnDjjfFYcI6Xbq9-m8iZlEi5G-EC..-AmQt0We5dhSelcdGZjJtq6gbhQWATSagCOyH-JL0yIC
* tools/skia_goldctl/win: CY_g7u7URjjZnq4pgCohkA5JcSnWH4YE10bSECPnYewC..Dlf6e8GKMBiJAaFXTVte4LowGeiFs79erbrVany5R1gC
No update to Clang.

Bug: angleproject:2930,angleproject:3481
Tbr: cnorthrop@google.com
Change-Id: If5369b42a9d3c3e994e502dd34b50044388d5e16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639545Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2900a0f4

Vulkan: Redo RewriteAtomicCounters · 186fe990

authored Jan 15, 2021

With MonomorphizeUnsupportedFunctionsInVulkanGLSL and
RewriteArrayOfArrayOfOpaqueUniforms transformations run, it is no longer
possible to encounter array of array of atomic counters, or have any
passed to functions.  As a result, RewriteAtomicCounters is greatly
simplified.  Additionally, it is no longer necessary to pass
binding/offset information for atomic counters around and they can use
constants.  This change removes dependency on the
shaderStorageBufferArrayDynamicIndexing Vulkan feature.

Bug: angleproject:3726
Bug: angleproject:3881
Change-Id: Ia43092a668f60d009eccbbceeed5deaf105a5895
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2633687Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

186fe990

Suppress incomplete texture tests on mac/arm · 64c89120

authored Jan 19, 2021

Bug: chromium:1168370
Change-Id: I5f3e1b76b4efd21f3655d6995293ff4bbbebea17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639273Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

64c89120

Vulkan: Retain OpSource in SPIR-V · 382f016d

authored Jan 19, 2021

Needed by AGI.  It's a small instruction, and there's only one of it.
This change makes the SPIR-V transformer retain this instruction even on
release.

Bug: b/177556123
Change-Id: I0a2ba8afe55018b08f25abd8a139b64b2a5f6f11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636691Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

382f016d

Revert "Add support for building in Flutter Windows UWP configuration" · 0739f07a

authored Jan 19, 2021

This reverts commit 68ac4e43.

Reason for revert: Crashes Chrome GPU process startup on Windows x86
See crbug.com/1168272

Original change's description:
> Add support for building in Flutter Windows UWP configuration
>
> Bug: angleproject:5527
> Change-Id: Idf5a4cbb6f84b24fa2448157cab1b6a3bce4d8be
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620580
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=geofflang@chromium.org,stuart.morgan@gmail.com,jmadill@chromium.org,james@clarkezone.io

# Not skipping CQ checks because original CL landed > 1 day ago.

Tbr: jmadill@chromium.org
Bug: angleproject:5527, chromium:1168272
Change-Id: Ifb37c8026253c6a7c334d5b6c83018c888a9f51c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2638572
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

0739f07a

Tests: Add Klondike Adventures trace · 08e385b4

authored Jan 15, 2021

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*klondike_adventures*
Bug: angleproject:5548
Change-Id: I1bab7696f3db6cb3b3be9d1f3e241891586a9cc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634204
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

08e385b4

Multithreading in D3D11 minimum viable product · 192a0147

authored Oct 08, 2020

Bug: b/168046573
Change-Id: I676a148333cbf5e9ca508768503e62cb14d8eeb0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2629618
Commit-Queue: Doug Horn <doughorn@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor David Black <vantablack@google.com>

192a0147

19 Jan, 2021 8 commits

Add a helper ShaderVariable method to facilitate member rename · 383442e5

authored Jan 19, 2021

Chromium uses ShaderVariable::structName directly, which makes it
impossible to rename this variable.

Bug: angleproject:3580
Change-Id: I328015b0e7f26d22d689451bac0d7a48999bef2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637419
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

383442e5

Capture/Replay: Serialize float states properly. · 2e0490ee

authored Jan 18, 2021

Previously we were always casting to int. Instead add a float
serialization helper function.

Bug: angleproject:5530
Change-Id: Ifc80e1dbad9da8a04b3b013c3a3ffa60444f6d26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634829Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2e0490ee

Suppress failing tests on mac ARM · 7489bb2e

authored Jan 19, 2021

Bug: chromium:1167763
Change-Id: I7f88bd60119dd630ea7733228baff97598bfd739
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636688Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

7489bb2e

Vulkan: Support GL_EXT_tessellation_shader. · b912eec5

authored Nov 27, 2020

Shader translator changes done in http://crrev.com/c/2633936

Adds a new DIRTY_BIT_PATCH_VERTICES state to Context.
Supportes state query and transform feedback.
4 test suppressions remain as follow-up fixes.
Adds a new varying packing mode for a simple Vulkan rule set.

Based on work by Mohan Maiya (m.maiya@samsung.com).

Test: dEQP-GLES31.functional.tessellation.*
Bug: angleproject:3572
Change-Id: I4cad2cca30adb754fd12c83027673906541f566a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568234Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

b912eec5

Vulkan: Add integer type incomplete texture tests · acf2985d

authored Jan 19, 2021

Add tests for both signed and unsigned integer
texture types.

Bug: angleproject:5502
Bug: angleproject:4432
Tests: IncompleteTextureTestES3.*IntegerType*
Change-Id: I22e451424d19c3e525cd08ad4c16e1150d9d2467
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613244
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

acf2985d

Tests: Add Asphalt 8 trace · dd6ac664

authored Jan 18, 2021

Test: angle_perftests --gtest_filter="*asphalt_8*"
Bug: b/150484427
Change-Id: I6a5f1feec61466eae55c1a2464272aba797ed56c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636602Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

dd6ac664

Fix image bindings with an image after an image array of array · f45e625f

authored Jan 18, 2021

The logic to calculate the image binding offset for each element of an
array of array of images was incorrect, in that it used the arraySize
accumulated so far to offset the next image's binding.

Bug: angleproject:5535
Change-Id: I2dc3ce7bbf7b77302d1b56b4701bec2e990fdae1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2635452Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

f45e625f

Test Runner: Prevent race by not resetting timeout. · feb470cc

authored Jan 19, 2021

This instead only sets the timeout when tests start to run. That
way the timeout should always be at least the default timeout
and we won't get into a situation where the watchdog times out
the test immediately when the test starts.

Bug: angleproject:5562
Change-Id: I6b12bb8fe8edcf35f46ba4fb106fdf80ff9402a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2637182Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

feb470cc