Having UNIMPLEMENTED be an error was problematic in a few places. Some
tests would pass despite hitting the macro. We were relying on this in
a bunch of places. Making it a warning is an easier solution than
fixing all of the cases.

Going forward we can fix the warnings and make warnings produce test
failures. This is similar to enabling warnings as errors in C++ code.

Bug: angleproject:2552
Change-Id: Iaf0479cd6bd6a9e85aaccbbee13c322166ff7b5a
Reviewed-on: https://chromium-review.googlesource.com/1064724
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This allows us access to the EGLDisplay handle. This will be useful for
passing along an error logging function.

Bug: angleproject:2552
Change-Id: I98a170f419d728ca93558954be4e5c0511b0316b
Reviewed-on: https://chromium-review.googlesource.com/1062790
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This fixes a bunch of minor style issues.

Bug: angleproject:2552
Change-Id: If0e8130cf85deb176a5dcbca568cca477d2c1068
Reviewed-on: https://chromium-review.googlesource.com/1062789Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2306

Change-Id: Icd1f830b666d75b30455dd4cbc2183cd431b97cc
Reviewed-on: https://chromium-review.googlesource.com/1065792
Commit-Queue: Lingfeng Yang <lfy@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

The alignment used to allocate VkBuffers in the VkBuffer needs to be at
least the size of the nonCoherentAtomSize defined in the limits of the
VkDevicePhysicalProperties. The latest roll of the
vulkan-validation-layers added that check and caused a bunch of errors.
This is fixing them.

Bug: angleproject:2565

Change-Id: Ia2ad506dce7966adb6220c52ea891903922c47d0
Reviewed-on: https://chromium-review.googlesource.com/1064950
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Refactor ValidateMakeCurrent to pass egl object pointers instead of handles.

BUG=angleproject:2464

Change-Id: I98859f56d238a38bd6755f00dce7344635690491
Reviewed-on: https://chromium-review.googlesource.com/1053877
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>

* update progress of Vulkan back-end
* add link to creating a new bug
* add link to Vulkan presentation

Bug: angleproject:1944
Change-Id: Ib14df65df833f758a4ace325df28b8d4a52c1ced
Reviewed-on: https://chromium-review.googlesource.com/1065525Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The tentative fix did not fix the issue on Android Nexus 5x.

This reverts commit 8688bf46.

NOTRY=true
Change-Id: If4a517028951a2232a87aeaf1045a5df731d17d3
Reviewed-on: https://chromium-review.googlesource.com/1065578Reviewed-by: Luc Ferron <lucferron@chromium.org>

Reintroduce the change that was previously reverted here:
https://chromium-review.googlesource.com/c/angle/angle/+/1064770

This includes a tentative fix the issue on Android that prompted the revert.

Bug: angleproject:2480
Change-Id: I04be55d9dead00500adaa5f56458cb93957f2535
Reviewed-on: https://chromium-review.googlesource.com/1065799
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Android Studio debugger needs the build-id to be able to
match up symbols with stripped libraries.

Bug: angleproject:2566
Change-Id: Ied6afd09c9ec0d379a16b4a08b56b827af11ca0d
Reviewed-on: https://chromium-review.googlesource.com/1064554
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2339
Bug: angleproject:2455
Change-Id: I12dfd1e95f18a4277f409d694000e0e775c8bffb
Reviewed-on: https://chromium-review.googlesource.com/1064814
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This reverts commit 82a420bb.

Reason for revert: breaks readPixels on Android, probably because memory there is not host coherent by default.

Original change's description:
> Vulkan: readPixels improvement - use DynamicBuffer
> 
> - Instead of using a new Staging image everytime, we now
> just use a DynamicBuffer that should be bit less wasteful.
> 
> Bug: angleproject:2480
> 
> Change-Id: I09edfb16f6ec49a0ca320d9e5dd9ce34e9dbf99e
> Reviewed-on: https://chromium-review.googlesource.com/1059452
> Commit-Queue: Luc Ferron <lucferron@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,lucferron@chromium.org

Change-Id: Id7c493915ec7131f5202a7224267a79cd53007d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2480
Reviewed-on: https://chromium-review.googlesource.com/1064770Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

- Instead of using a new Staging image everytime, we now
just use a DynamicBuffer that should be bit less wasteful.

Bug: angleproject:2480

Change-Id: I09edfb16f6ec49a0ca320d9e5dd9ce34e9dbf99e
Reviewed-on: https://chromium-review.googlesource.com/1059452
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Instead of dEQP_GLES2.Default/functional.blah...
Use dEQP.GLES2/functional.blah...

This makes them a bit easier to parse and reconstruct from memory.

Bug: angleproject:2557
Change-Id: I092dc6ef10d4451ddafe373e699a5d35247f8785
Reviewed-on: https://chromium-review.googlesource.com/1062065Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2561
Change-Id: I45de82466401e88bfacc2342e401adef69d07472
Reviewed-on: https://chromium-review.googlesource.com/1062192Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This reverts commit 10e7e501.

Reason for revert: Possible reason for anglebug.com/2561

Original change's description:
> Don't double-terminate a display.
> 
> Some dEQP tests call eglTerminate twice on the same display and cause crashes.
> 
> BUG=angleproject:2546
> 
> Change-Id: I8a13d00fd03692b3b24dee4813c245d83ea00862
> Reviewed-on: https://chromium-review.googlesource.com/1060335
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org

Change-Id: Iab32ed96443eab406afa65642f9a66f68dc8ebcd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2546, angleproject:2561
Reviewed-on: https://chromium-review.googlesource.com/1062728Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:2500
Change-Id: I9066861ed4db0330754b32995ed82c658d66a590
Reviewed-on: https://chromium-review.googlesource.com/1058034
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

- Enables all dEQP tests left for copySubImage.

Bug: angleproject:2501

Change-Id: I8ae301a94e9039f24e0a20b8fd4afdf7e65659f7
Reviewed-on: https://chromium-review.googlesource.com/1057904
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

- also enables all dEQP tests for functional.read_pixels.*

Bug: angleproject:2480

Change-Id: Ib7bcd6b046ff8b0ecf110e70f735036bedf17902
Reviewed-on: https://chromium-review.googlesource.com/1058149
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This parses the dEQP test name into a GoogleTest-friendly gtest_filter
automatically. This makes pasting in test case names from the
expectations file more straight-forward.

Bug: angleproject:2557
Change-Id: Ib5fbb46ad487a89352d728aebedc1752ddb0673d
Reviewed-on: https://chromium-review.googlesource.com/1058252
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

- Implement basic path that does a cpu readback for everything and
establish conformance for every case except the ones that need
conversion.
- Enables most copy sub image dEQP tests.

Bug: angleproject:2501

Change-Id: Ib67c184894625dde850f320c40fe51fe70ba974f
Reviewed-on: https://chromium-review.googlesource.com/1054387
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2546

Change-Id: Id81203cd42227f6df34edfcefdd312037826d55f
Reviewed-on: https://chromium-review.googlesource.com/1059940Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This patch adds the additional transform feedback rules required in
EXT_geometry_shader. In this extension, more draw commands and render
primitives are allowed for transform feedback.

BUG=angleproject:1941
TEST=dEQP-GLES31.functional.geometry_shading.vertex_transform_feedback.*
     angle_end2end_tests

Change-Id: Iedc27dca5c24ca45cd4226a1a0066107c0b40e1d
Reviewed-on: https://chromium-review.googlesource.com/1055192Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

Some dEQP tests call eglTerminate twice on the same display and cause crashes.

BUG=angleproject:2546

Change-Id: I8a13d00fd03692b3b24dee4813c245d83ea00862
Reviewed-on: https://chromium-review.googlesource.com/1060335Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:2546

Change-Id: I3ffc33649bad26f9d12580e398777b8b6c8ad542
Reviewed-on: https://chromium-review.googlesource.com/1059711Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

- Add vkCmdCopyImageToBuffer support in CommandBuffer
- Add a new function in the PixelBuffer to support staging changes
coming from an image.

Bug: angleproject:2500
Bug: angleproject:2501

Change-Id: Ic29101391edc6f25a71dcd318bc8a72b2ae1a054
Reviewed-on: https://chromium-review.googlesource.com/1054104
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:2546

Change-Id: I9ece2b5b38217afa43ba7f120ef311c2cf3ca4cb
Reviewed-on: https://chromium-review.googlesource.com/1059700Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:2557
Change-Id: Ica29c686ad3a71da3f8564f8a78bbe4f57ce304f
Reviewed-on: https://chromium-review.googlesource.com/1058251Reviewed-by: Luc Ferron <lucferron@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2546

Change-Id: I911842753e8065de8e86f0af1f6cdf2a388fec63
Reviewed-on: https://chromium-review.googlesource.com/1058280Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:2546

Change-Id: I9b62ef6331c03d185feaa91ad4f21f9a1380186f
Reviewed-on: https://chromium-review.googlesource.com/1058147Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=chromium:834269

Change-Id: Ia49f80f4c057ad467428a13e8cd4ca54ad48d5c4
Reviewed-on: https://chromium-review.googlesource.com/1058084Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:2546

Change-Id: I996c1344c93be7618ffbedd3e34e9aaa4855e25e
Reviewed-on: https://chromium-review.googlesource.com/1057989
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:2546

Change-Id: I74b376c07f94d77abe28129ff5e97bd19a26d0d0
Reviewed-on: https://chromium-review.googlesource.com/1057831Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:2546

Change-Id: I81c9786eccf50962b2928333272cee3eb556e707
Reviewed-on: https://chromium-review.googlesource.com/1057869Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This fixes an edge case when the app clears both color and depth at the
same time when a color mask is set. It also handles stencil clear, but
does not handle stencil masks.

Includes test suppressions for a few platforms that may have driver
bugs.

Bug: angleproject:2455
Bug: angleproject:2547
Bug: angleproject:2548
Change-Id: I5ac0a461a075328e5fc4e5e262c4d21f68f93434
Reviewed-on: https://chromium-review.googlesource.com/1052072Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The GN was including both libGLESv2.def and _autogen. This fixes the
GN to only include _autogen, and removes the .def include from the
static build target.

Bug: angleproject:2476
Change-Id: I2e856e3bbe875bdadd1add4517cef60a11227047
Reviewed-on: https://chromium-review.googlesource.com/1057451Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Brandon1 Jones <brandon1.jones@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

These casts could result in overflow.

Bug: chromium:842028
Change-Id: I998b638c58333a29f6bc9136ae3e81b90683cb72
Reviewed-on: https://chromium-review.googlesource.com/1057415Reviewed-by: Luc Ferron <lucferron@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This is the renderer code for GLES1 that delivers basic vertex
attributes, matrices, and allows texturing for unit 0 only (more units
mean implementing the multitexturing pipeline).

+ Sample
+ Update test expectations for GLES1 conformance tests

BUG=angleproject:2554
BUG=angleproject:2306

Change-Id: I398edc764f982fbfc4c5e0f9d6bfef1e91aec47c
Reviewed-on: https://chromium-review.googlesource.com/1057356Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>

Bug: chromium:842408
Change-Id: I8793e3bb9ed4661e49eceb55c7253d7ada06488a
Reviewed-on: https://chromium-review.googlesource.com/1057231Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit a6909921.

Reason for revert: New tests failing on gpu fyi bot.  anglebug.com/2554

Original change's description:
> GLES1: Renderer (minimal)
> 
> This is the renderer code for GLES1 that delivers basic vertex
> attributes, matrices, and allows texturing for unit 0 only (more units
> mean implementing the multitexturing pipeline).
> 
> + Sample
> + Update test expectations for GLES1 conformance tests
> 
> BUG=angleproject:2306
> 
> Change-Id: Id5d5603c967e577290085e5946f2cb7a03d7e017
> Reviewed-on: https://chromium-review.googlesource.com/1023988
> Commit-Queue: Lingfeng Yang <lfy@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org,lfy@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:2306
Change-Id: Ib6fd9db433cd1a13589d5a9e82cb2c40f3cf71ff
Reviewed-on: https://chromium-review.googlesource.com/1056229Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>