Commits · 46ccef1992a8ede16a596c3dd73cff13c047267d · Chen Yisong / angle

28 May, 2015 1 commit

Remove ref to intermediate.h. · 46ccef19

authored May 27, 2015

With
https://chromium-review.googlesource.com/213300
b9b5c105

the file intermediate.h was renamed Intermediate.h. However,
compiler.gypi now contains references to both, but the lower case
version doesn't exist anymore, so it should be removed.

Change-Id: I6b36bd561f110694daecd4ad911036c94300cd1f
Reviewed-on: https://chromium-review.googlesource.com/273593Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

46ccef19

27 May, 2015 15 commits

Encapsulate GL version and standard into a struct and enum. · 08dcfed6

authored May 25, 2015

Change-Id: I9f51971c1bfd51424605b2687b5fd107d58c9a67
Reviewed-on: https://chromium-review.googlesource.com/273139Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/273572Reviewed-by: Geoff Lang <geofflang@chromium.org>

08dcfed6

Revert "Encapsulate GL version and standard into a struct and enum." · 51d4f044

authored May 27, 2015

Linux didn't like compiling this.

This reverts commit 03f58912.

Change-Id: Ifd0824caeb02791b4acc5e4bca330ecdc8164b11
Reviewed-on: https://chromium-review.googlesource.com/273583Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

51d4f044

Encapsulate GL version and standard into a struct and enum. · 03f58912

authored May 25, 2015

Change-Id: Ib3c37627298976040d5a333f4c845a7b2620dd30
Reviewed-on: https://chromium-review.googlesource.com/273139Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

03f58912

Do not always use X11 for Linux builds, inherit Chromium's settings · 51e2ad14

authored May 26, 2015

This fixes project generation for Chromium for non-X11 builds

BUG=angleproject:1011

Change-Id: If528f63fb186d834d56a43ca379497d99e74777e
Reviewed-on: https://chromium-review.googlesource.com/273163Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

51e2ad14

Enable PbufferTest on Linux by not advertising bindable configs · 44aedf37

authored May 25, 2015

GLX Pbuffers are not bindable so implementing bindable pbuffers would
have to be one of the following:
 - Implement Pbuffer as GLXPixmaps, with complication arising in the
   initialization.
 - Implement Pbuffers as GL textures, which would require a large change
   of the EGL implementation.
 - Fake bindable Pbuffers with glCopyTexImage2D, with obvious
   performance problems.

BUG=angleproject:892

Change-Id: I7d9cd5a4aa2d35343244be3cbe55fc1e492f6928
Reviewed-on: https://chromium-review.googlesource.com/273056Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

44aedf37

Enable OcclusionQueriesTest on Linux · 5c798fe9

authored May 25, 2015

This includes an implementation of a cross platform Sleep function

BUG=angleproject:892

Change-Id: I1087a00ab204b37bafc5e95a9766962b194d97ef
Reviewed-on: https://chromium-review.googlesource.com/273133Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

5c798fe9

Constant fold vector relational built-ins · 9d0b1f9b

authored May 20, 2015

This change adds constant folding support for vector relational
built-ins.

BUG=angleproject:913
TEST=dEQP Tests
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.vector_relational*
(Fixes all 138 tests)

Change-Id: I291e332f2afb3ce3d6596e634f509995dbf35164
Reviewed-on: https://chromium-review.googlesource.com/272344Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9d0b1f9b

Revert "In D3D11, check for 16-bit texture support and use if possible" · 8e7549bd

authored May 27, 2015

Causing failures on Windows 8 bots running ES CTS and Windows 7 Intel bot running angle tests.

Example failures:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/14442
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Intel%29/builds/11627

This reverts commit d63f08fc.

Change-Id: I841aee5fb0973432f249277126424b909d5b3e17
Reviewed-on: https://chromium-review.googlesource.com/273416Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8e7549bd

When applying vertex array objects, update the currently applied index buffer. · 294cad9d

authored May 26, 2015

When binding a vertex array object, it was not changing the tracked index
buffer binding.  This was causing the buffer bindings to sometimes not be
updated between index and non-indexed draw calls.

Fixes:
 * Intermittent crashes in chromium startup.
 * conformance/rendering/many-draw-calls.html
 * conformance/rendering/framebuffer-switch.html
 * conformance/attribs/gl-bindAttribLocation-aliasing.html
 * conformance/attribs/gl-vertex-attrib-render.html
 * conformance/buffers/index-validation-verifies-too-many-indices.html

BUG=angleproject:883

Change-Id: I34ed1ebc65b339329c0f9ab9c28a392f552ed3d8
Reviewed-on: https://chromium-review.googlesource.com/273300Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

294cad9d

Bind a texture after creation so that it has a type. · 90d98afa

authored May 26, 2015

If a texture is bound to a framebuffer before any data is set on it, the
texture does not have a type because it has never been bound.  This
generates an INVALID_OPERATION because the attachment type cannot be
validated.

Fixes:
 * Many generated GL_INVALID_OPERATIONs in chromium

BUG=angleproject:884

Change-Id: I4f36f80fecc5a772b6522f8f82e0be9d3758e524
Reviewed-on: https://chromium-review.googlesource.com/273324Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

90d98afa

Check for null attribute buffers before binding. · 851cd580

authored May 26, 2015

Fixes:
 * Crash in conformance/extensions/oes-vertex-array-object.html

BUG=angleproject:880

Change-Id: I90eba9b26b2834644ce3ba0e78cab3417c2a7bd1
Reviewed-on: https://chromium-review.googlesource.com/273325Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

851cd580

Handle function calls where returned array is not used · 4f1af784

authored May 25, 2015

This is done by declaring a temporary variable which is passed as the
array out parameter defined by ArrayReturnValueToOutParameter.
SeparateExpressionsReturningArrays takes care of transforming the rest of
the cases where a function call returns an array into form that
ArrayReturnValueToOutParameter can handle.

BUG=angleproject:971
TEST=WebGL 2 conformance tests, dEQP-GLES3.functional.shaders.arrays.*

Change-Id: I70c07712ba5cd91efb4c2e575ecc49b9ef71bfd7
Reviewed-on: https://chromium-review.googlesource.com/273111Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4f1af784

Fix destructing TStrings through BuiltInFunctionEmulator after free · 950457b3

authored May 26, 2015

BuiltInFunctionEmulator gets destructed after the PoolAllocator has already
freed memory. That's why BuiltInFunctionEmulator can't hold any objects that
contain parts stored in the memory pool that would be accessed in its
destructor. Use only pointers to TType objects inside
BuiltInFunctionEmulator, so that the BuiltInFunctionEmulator destructor doesn't
access TStrings which have data in the memory pool.

Also fix style issues in BuiltInFunctionEmulator.

BUG=angleproject:1010
TEST=dEQP-GLES3.functional.shaders.builtin_functions.*

Change-Id: Ic35caf80bf125d0427c2ed2024e98657756103b6
Reviewed-on: https://chromium-review.googlesource.com/272738Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

950457b3

Check that #version 300 es directive is on the first line · c378cd8a

authored May 25, 2015

ESSL3.00 and 3.10 specs don't allow even newlines before the version
directive.

BUG=angleproject:1009
TEST=WebGL 2 conformance tests, angle_unittests

Change-Id: Id7967829077e35e03572c724e0eafffbed0c975b
Reviewed-on: https://chromium-review.googlesource.com/272719Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

c378cd8a

Fix small issues in array related AST transformations · a357236f

authored May 22, 2015

Make sure that user-defined bit stays in place when copying function call
nodes, and that mInFunctionWithArrayReturnValue gets reset correctly in
ArrayReturnValueToOutParameter.

BUG=angleproject:971
TEST=WebGL 2 conformance tests

Change-Id: I385f4ce4990597e44ddad4f0fa6db23b661771dc
Reviewed-on: https://chromium-review.googlesource.com/273110Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

a357236f

26 May, 2015 5 commits

Fix missing break statements. · 113bc73e

authored May 26, 2015

Fixes:
 * conformance/glsl/functions/glsl-function*

BUG=angleproject:883

Change-Id: I22a528c6ba4c4077ba47269e14396b4117d1c849
Reviewed-on: https://chromium-review.googlesource.com/273169Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

113bc73e

In D3D11, check for 16-bit texture support and use if possible · d63f08fc

authored May 21, 2015

BUG=angleproject:1002

Change-Id: I36a5ee774b38e9865b2eb6c6789afd316c4eff16
Reviewed-on: https://chromium-review.googlesource.com/272061Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

d63f08fc

Fix order of TearDown of EGLSurfaceTest · e6d82c6d

authored May 25, 2015

Previously the OS window was deleted before the EGL window surface which
caused the GLX window to be deleted after its X window was deleted. All
this was invalid and resulted in a crash.

BUG=angleproject:892

Change-Id: I394795b6ebce947ad7eeab9a70ad5f80fcd89241
Reviewed-on: https://chromium-review.googlesource.com/273055Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

e6d82c6d

WindowSurfaceGLX handle resizing the window on swap · aaa9eb94

authored May 22, 2015

This make the multi window sample work well.

BUG=angleproject:892

Change-Id: If98c6f995875b63c391cee9b6fddc6d138d48f8b
Reviewed-on: https://chromium-review.googlesource.com/272946Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

aaa9eb94

Report warning whenever constant folding results are undefined · 081c3f2e

authored May 25, 2015

With recent constant folding changes, we are reporting warnings
whenever constant folding results are undefined for values passed in,
this change adds that warning at all the places where it was missing.

BUG=angleproject:913
TEST=dEQP Tests, angle_unittests

Change-Id: Ief8380488e2a4807c91ddac06d342cb172433b9d
Reviewed-on: https://chromium-review.googlesource.com/272879Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

081c3f2e

25 May, 2015 13 commits

Use absolute paths in angle_perftests.gypi · b2b6dfaf

authored May 25, 2015

Otherwise in the Chromium build gyp might have a wrong cwd and then ninja
will fail to find the files to compile.

BUG=angleproject:892

Change-Id: I6b7beef5ecad62cc345b49253cedbde0ac166c17
Reviewed-on: https://chromium-review.googlesource.com/273161Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b2b6dfaf

Disable some tests due to failures on Intel OpenGL. · c422207e

authored May 25, 2015

BUG=angleproject:884

Change-Id: Iceb571807a2232dae22703953e12e1af4bba5a87
Reviewed-on: https://chromium-review.googlesource.com/273029Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c422207e

Merge separate definitions of include_dirs for perftests · 1ee5b60a

authored May 25, 2015

BUG=angleproject:892

Change-Id: Ifd108b3119ea73c05e984ca9138536fb8cf6839c
Reviewed-on: https://chromium-review.googlesource.com/273137Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

1ee5b60a

Add table entries for almost all the remaining GL texture formats. · f34d1db9

authored May 20, 2015

BUG=angleproject:884
BUG=angleproject:967

Change-Id: I113757dd9e1fae8fe0241a7286be979a90891b53
Reviewed-on: https://chromium-review.googlesource.com/270275Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/273135

f34d1db9

Revert "Add table entries for almost all the remaining GL texture formats." · 859dcb88

authored May 25, 2015

Missing include of <limits> for linux.

This reverts commit aa3a5fad.

Change-Id: Iafebfbc6154b4fe3a94e3f8b91b5ff496631c1f1
Reviewed-on: https://chromium-review.googlesource.com/273134Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

859dcb88

Rename path_utils to system_utils · db39e7f5

authored May 25, 2015

For inclusion of Sleep

BUG=angleproject:892

Change-Id: I1a9491102e9943d945eef0ba372a6779c30cd311
Reviewed-on: https://chromium-review.googlesource.com/273131Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

db39e7f5

Enable EGLSurfaceTest on Linux · 3d5cb774

authored May 22, 2015

BUG=angleproject:892

Change-Id: I142ab37e00e2ba7fc2316aff564cc449eeb22771
Reviewed-on: https://chromium-review.googlesource.com/273130Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

3d5cb774

Poll all windows in the multi window sample · 642488e5

authored May 22, 2015

On Linux all windows are polled separately contrary to windows in which
the callback is used on all windows.

BUG=angleproject:892

Change-Id: Ib1538f12ab2fa1864d29c91b9c5bfc2204cd1fa7
Reviewed-on: https://chromium-review.googlesource.com/272945Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

642488e5

Simplify the implementation of ANGLE_INSTANTIATE_TEST · 1ca3d015

authored May 22, 2015

I mistakenly submitted a refactor with +2 but not +1 so a comment wasn't
addressed, hopefully fixes it.

BUG=angleproject:892

Change-Id: I096c2424449be196dfa949cc6ef662b766036330
Reviewed-on: https://chromium-review.googlesource.com/272905Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

1ca3d015

Fix styling issues in ParseContext.cpp · 7e7e68de

authored May 22, 2015

There were lot of styling issues in ParseContext.cpp, mostly related to
opening braces on same line as conditional statement and pointers and
references not being tight to the variable in variable declarations,
this change fixes them.

TEST=angle_unittests

Change-Id: Ia225726254bcf5f315c13054ff41c5ff9cfe0992
Reviewed-on: https://chromium-review.googlesource.com/272846Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

7e7e68de

Add table entries for almost all the remaining GL texture formats. · aa3a5fad

authored May 20, 2015

BUG=angleproject:884
BUG=angleproject:967

Change-Id: I0b05841272f4410c33ee4e4c3654846f07b7c39b
Reviewed-on: https://chromium-review.googlesource.com/270275Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

aa3a5fad

Implement swapInterval for EGL on GLX · f4863b70

authored May 21, 2015

BUG=angleproject:892

Change-Id: I80d8d67270662c7f2be893f4a8318fbc0926f1fc
Reviewed-on: https://chromium-review.googlesource.com/272677Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

f4863b70

Add timer histogram for egl::Initialize time. · 7c2acaf3

authored May 21, 2015

This can help is track startup time regressions within ANGLE.

BUG=436191
BUG=angleproject:944

Change-Id: I73cf2449661b909dced4ddc11957037ed5535fc0
Reviewed-on: https://chromium-review.googlesource.com/272613Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

7c2acaf3

22 May, 2015 6 commits

Add an end2end test checking EGL context-surface compatibility · 3a1f3673

authored May 20, 2015

This has been very useful to figure out the FBConfig story for the GLX
EGL implementation.

BUG=angleproject:892

Change-Id: Ie4138dd1dd98f1450984a61317e3fc863c620ad3
Reviewed-on: https://chromium-review.googlesource.com/272371Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/272907

3a1f3673

Revert "Add an end2end test checking EGL context-surface compatibility" · 01f4062c

authored May 22, 2015

Failing due to a bug in the test:

BUG=angleproject:892

This reverts commit 08971bff.

Change-Id: I5f97f5e00f8b820874d575421b9a50829bb6f1e0
Reviewed-on: https://chromium-review.googlesource.com/272912Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

01f4062c

Pick return value from copyTexture. · 4f5659ae

authored May 22, 2015

Change-Id: Ia04358645348326c5577854053b550426121e64e
Reviewed-on: https://chromium-review.googlesource.com/272765Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cooper Partin <coopp@microsoft.com>
Tested-by: Minmin Gong <mgong@microsoft.com>

4f5659ae

Added compiler flags to enable Control Flow Guard. · 336551c9

authored May 20, 2015

Change-Id: I86e24b83e2e9b279c93c518ab9bc7dafd4b3d006
Reviewed-on: https://chromium-review.googlesource.com/272501Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

336551c9

X11Window: handling of ConfigureNotify, work when reparented · fb28d3c5

authored May 21, 2015

BUG=angleproject:892

Change-Id: Ib201a5fbf4fca39c90464ed76434dac5e5ded381
Reviewed-on: https://chromium-review.googlesource.com/272683Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

fb28d3c5

Add perftest parameters for OpenGL · 80a50949

authored May 21, 2015

BUG=angleproject:892

Change-Id: Ia22b8ab48456d6fbccb159404e943f9ef2650bdc
Reviewed-on: https://chromium-review.googlesource.com/272610Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

80a50949