Commits · 4898724284c4bf894ff8bc9dec44b0ead33be2c6 · Chen Yisong / angle

29 Apr, 2020 4 commits

Roll third_party/vulkan-tools/src 30eb0a301c33..c0f34c020d9d (1 commits) · 48987242

authored Apr 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/30eb0a301c33..c0f34c020d9d

git log 30eb0a301c33..c0f34c020d9d --date=short --first-parent --format='%ad %ae %s'
2020-04-28 petr_kraus@email.cz vulkaninfo: Meet extension version dependencies

Created with:
  gclient setdep -r third_party/vulkan-tools/src@c0f34c020d9d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I8effcdb9f56c3a85efd5c9e2ac51de0ed2a83c1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172702Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

48987242

Roll third_party/vulkan-loader/src 3336e65e8801..f39209eb4402 (1 commits) · a4975d8b

authored Apr 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3336e65e8801..f39209eb4402

git log 3336e65e8801..f39209eb4402 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 petr_kraus@email.cz docs: Fix typo

Created with:
  gclient setdep -r third_party/vulkan-loader/src@f39209eb4402

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6a1a921bec69cafaa6da4ef63d5735ce37d8bfbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172701Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a4975d8b

Roll third_party/spirv-tools/src 23d68608b007..49ca250b44c6 (3 commits) · cd2d62c9

authored Apr 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/23d68608b007..49ca250b44c6


Created with:
  gclient setdep -r third_party/spirv-tools/src@49ca250b44c6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I57a0d90e59d75d25f006a9b5ebd97c3ae93b8e6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172068Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cd2d62c9

Vulkan: Always query EGL_WIDTH and EGL_HEIGHT · 718ae508

authored Apr 28, 2020

This fixes the failures of the dEQP EGL resize tests on Android.
Those tests don't actually resize the window (which would allow the
tests to pass), but do change internal Android Surface values that
vkGetPhysicalDeviceSurfaceCapabilitiesKHR queries. Therefore, by
freshly querying these values the test passes.

Bug: b/153329980
Change-Id: Ie966f221bfaa14988c1503c7f5503f0b21476bcb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165639Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

718ae508

28 Apr, 2020 11 commits

Vulkan: Apply binding size in updateBuffersDescriptorSet. · 448b14bb

authored Apr 27, 2020

Previously we would bind the full Vulkan buffer size in cases of
unsized arrays in storage buffers. This then would lead to problems
when binding a dynamic buffer that used sub-allocation or larger
internal sizes. Instead use the GL binding size or GL buffer size as
the size limits.

Bug: angleproject:4380
Change-Id: Ia579bfeae3b8d068813336cbd5e1babee9f4f345
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168020Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

448b14bb

Ignore third_party/nasm in .gitignore. · 5f40f2fe

authored Apr 28, 2020

Was missed in the yasm->nasm update.

Bug: None
Change-Id: I6c3471d1aaea36ed129b445bfd3fa206f3437344
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2170909Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5f40f2fe

Take into account baseVertex for drawElementsImpl D3D11 · d9268889

authored Apr 22, 2020

Also add test for GL_DYNAMIC_DRAW and GL_STREAM_DRAW with vertex
color data updating before each draw call to make sure index range
is retrieved correctly.

Bug: angleproject:3402, angleproject:3911
Change-Id: I5f209292b6e316e4b50505a98b361eb8761a7d6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2162132Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>

d9268889

Capture/Replay: Simplify .gni integration. · 1398080c

authored Apr 27, 2020

Moves a lot of the code out of the gni file into tests/BUILD.gn. In
preparation for auto-generating the gni file as a simple array of trace
test names.

Bug: angleproject:4590 
Change-Id: Iaa2b7872dc6e705d59108fa7532594bdc65d365a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168359
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

1398080c

Update .clang-format. · 1f9e2a8f

authored Apr 28, 2020

Will fix the brace alignment issue. clang-format was finally updated to
a newer version in Chromium and the roll of Chromium DEPS picked up the
new version.

Bug: None
Change-Id: I3cb5aa7778fb9bf5a17a5d74dc0b108ba35aafc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2170406Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1f9e2a8f

Roll third_party/vulkan-validation-layers/src 1512acdf047f..72b2a3b275e5 (4 commits) · 80d3e268

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1512acdf047f..72b2a3b275e5

git log 1512acdf047f..72b2a3b275e5 --date=short --first-parent --format='%ad %ae %s'
2020-04-27 mikes@lunarg.com scripts: Object tracker optional handling
2020-04-27 tony@lunarg.com practices: Fix CreateFramebuffer
2020-04-27 petr_kraus@email.cz tests: Test swapchain image props
2020-04-27 petr_kraus@email.cz layers: Initialize image props for a swapchain

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@72b2a3b275e5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I11f38bb8b52ef36fca49615d57c0b5b2ababaa54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169970Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

80d3e268

Roll third_party/vulkan-headers/src 62becc509a88..4c19ae6b95e4 (1 commits) · 821575a7

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/62becc509a88..4c19ae6b95e4

git log 62becc509a88..4c19ae6b95e4 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 oddhack@sonic.net Update for Vulkan-Docs 1.2.139

Created with:
  gclient setdep -r third_party/vulkan-headers/src@4c19ae6b95e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=cnorthrop@google.com

Bug: None
Change-Id: If5e052ec795c2a47148494fbe5489a4031c12ad4
Tbr: cnorthrop@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169338Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

821575a7

Roll third_party/vulkan-tools/src 7774c964d3df..30eb0a301c33 (1 commits) · 34822e7a

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7774c964d3df..30eb0a301c33

git log 7774c964d3df..30eb0a301c33 --date=short --first-parent --format='%ad %ae %s'
2020-04-27 charles@lunarg.com vulkaninfo: fix queues not reporting presentation

Created with:
  gclient setdep -r third_party/vulkan-tools/src@30eb0a301c33

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I027e579d885068ef68529677939fe3ea63ec109c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169967Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

34822e7a

Roll third_party/SwiftShader 60aa34a990fa..2717702e9a1f (6 commits) · e5b82697

authored Apr 28, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/60aa34a990fa..2717702e9a1f

git log 60aa34a990fa..2717702e9a1f --date=short --first-parent --format='%ad %ae %s'
2020-04-28 capn@google.com Eliminate the ABORT() macro
2020-04-27 capn@google.com Record vkCmdBindDescriptorSets() as a single command
2020-04-27 capn@google.com Store binding information in the pipeline layout
2020-04-27 capn@google.com Don't expose individual descriptor set layouts to SPIR-V compilation
2020-04-27 capn@google.com Fix ordering of descriptor set bindings
2020-04-27 bclayton@google.com SpirvShader: Document activeLaneMask() and storesAndAtomicsMask()

Created with:
gclient setdep -r third_party/SwiftShader@2717702e9a1f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I1e6de4a3f586a4f06925138499142efeb91bed58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169968Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e5b82697

Roll third_party/spirv-tools/src 5547553a0c7b..23d68608b007 (7 commits) · 2597459f

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5547553a0c7b..23d68608b007


Created with:
  gclient setdep -r third_party/spirv-tools/src@23d68608b007

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie81ef413c12cd1e8744c6e7f28adb378db79bc07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169966Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2597459f

Roll third_party/glslang/src bcf6a2430e99..f03cb290ac10 (3 commits) · 7c83a445

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bcf6a2430e99..f03cb290ac10


Created with:
  gclient setdep -r third_party/glslang/src@f03cb290ac10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I4a270118c0d579d2125478dc44512cc98e708338
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169969Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7c83a445

27 Apr, 2020 11 commits

Roll chromium_revision fa9d5805c4..b0410bba02 (750702:763000) · 4395170e

authored Apr 27, 2020

Includes a change from yasm to nasm.

Change log: https://chromium.googlesource.com/chromium/src/+log/fa9d5805c4..b0410bba02
Full diff: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1cbf6469a..45ab3c89af
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4164a30562..204a35a2a6
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3e21eec53c..3993ef1f52
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c96dc32110..217407c478
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/493c9385c9..ec647b85b6
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/ce0e57e8e6..7e3ad79800
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/156be8c52f..ae385786ed
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d60a6a8084..04b99e7bf9
* tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/0bfd826f85..aae45d8d82
DEPS diff: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02/DEPS

Clang version changed 9284abd0040afecfd619dbcf1b244a8b533291c9:4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f
Details: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02/tools/clang/scripts/update.py

Tbr: jmadill@chromium.org
Bug: chromium:1070043
Change-Id: I8f2cd61950b1a94b946eace49a7f1da3447522ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168533
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4395170e

Vulkan: Add gles1 conformance support. · 4262ea04

authored Jan 31, 2020

For Khnoros CTS1 support, ANGLE needs to add conformant and
rendererType for OpenGL ES1 version.

Bug: angleproject:4457
Change-Id: I58ac4672352d3d42e4b8403b80f86154b6a76edc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160515
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4262ea04

Vulkan: Refactor AttachmentOpsArray. · fbc2f063

authored Apr 24, 2020

Will allow for more flexibly setting ops when we defer clears.

Bug: angleproject:4517
Change-Id: I7d9116bc92e90eb41a1030fea242eadf1cc74562
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165629
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

fbc2f063

OpenGL: Implement OES_draw_buffers_indexed · 6193fd69

authored Mar 07, 2020

OpenGL state sync issues as few GL commands as possible to update the
blend state regardless of an application input.

Enhanced ClearTestES3.MaskedIndexedClearMultipleAttachments
regression test.

Disabled OES_draw_buffers_indexed on Windows/AMD/OpenGL.

Bug: angleproject:4394
Change-Id: I244ac2975678bc559634152cf4eb997d9dbe83d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145874
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

6193fd69

Fix clearing compressed textures with Vulkan backend · 6e7d7296

authored Apr 24, 2020

When making sure a texture's data is initialized in ANGLE, it
is illegal to attempt to clear it when using the Vulkan backend.

The Vulkan spec, regarding vkCmdClearColorImage, mentions that:
"image must not have a compressed or depth/stencil format"

The proper way of initializing the memory of a compressed image
in Vulkan is to do a buffer to image copy instead. This was added
to ImageHelper::stageRobustResourceClear() so that it may now
handle compressed textures properly.

Bug: angleproject:4092
Change-Id: I073ed0603d9e92e787b9be8992751dbc0c8978db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165636Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

6e7d7296

Add BlendStateExt helper structure · d6c7bac9

authored Apr 18, 2020

It provides compact storage and comparison operations for
per-drawbuffer blend states.

Added BitSetT::Zero() static constexpr.

Bug: angleproject:4394
Change-Id: I66d6275facb7b28022fc24ff9cc0d8c3c976c99d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154669
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d6c7bac9

Add -Wno-pointer-to-int-cast · 226bba3c

authored Apr 24, 2020

This is the last remaining instance of the warning across Chromium. It's
fixed upstream but I can't seem to figure out how to successfully roll
deqp. So suppressing it here for now.

This can be removed once the deqp in Angle has
https://github.com/KhronosGroup/VK-GL-CTS/pull/199.

Change-Id: Ie954bb2a3d86ea0de644e2a78051531b396e88a8
Bug: chromium:1054220
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165365Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

226bba3c

Roll third_party/vulkan-loader/src 4fb0e0374a39..3336e65e8801 (1 commits) · 821726de

authored Apr 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4fb0e0374a39..3336e65e8801

git log 4fb0e0374a39..3336e65e8801 --date=short --first-parent --format='%ad %ae %s'
2020-04-24 lenny@lunarg.com loader: Check for null when creating a queue

Created with:
  gclient setdep -r third_party/vulkan-loader/src@3336e65e8801

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I6ba1a7862b89939aa652ce5c6eeb95376f1dfb5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167771Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

821726de

Roll third_party/glslang/src 7d65f09b8311..bcf6a2430e99 (3 commits) · 2a37fab2

authored Apr 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7d65f09b8311..bcf6a2430e99


Created with:
  gclient setdep -r third_party/glslang/src@bcf6a2430e99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I973b0f74a757339badbc21555940bd04a45365bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167780Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2a37fab2

Roll third_party/vulkan-validation-layers/src bb0380e3932a..1512acdf047f (2 commits) · 55b639e6

authored Apr 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bb0380e3932a..1512acdf047f

git log bb0380e3932a..1512acdf047f --date=short --first-parent --format='%ad %ae %s'
2020-04-24 karen@lunarg.com docs: update khronos_validation_layer.md
2020-04-24 lionel.g.landwerlin@intel.com Fix validation of blended attachments on imageless framebuffers

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@1512acdf047f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ib8cd5bbc69271183bf3dc2b9f391dab045db9d81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167774Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

55b639e6

Roll third_party/SwiftShader f42c698d784a..60aa34a990fa (1 commits) · a67630cd

authored Apr 27, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/f42c698d784a..60aa34a990fa

git log f42c698d784a..60aa34a990fa --date=short --first-parent --format='%ad %ae %s'
2020-04-24 capn@google.com Omit ASSERT() expression evaluation in Release builds

Created with:
  gclient setdep -r third_party/SwiftShader@60aa34a990fa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ia3d9e7ad2459696eff50e5666099c69ef1f5cd58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167772Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a67630cd

24 Apr, 2020 7 commits

Statically link vulkan-loader on Mac · 3cb9c4be

authored Mar 13, 2020

Disable angle_shared_libvulkan on Mac since we are the only client.
Re-add codepaths to support this.

Bug: angleproject:4477
Change-Id: Ie128c83adaae741636541bbfd6105d160d874a8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102954
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>

3cb9c4be

Vulkan: Clean up ClipRectToScissor. · 0f2747e9

authored Apr 24, 2020

Refactoring change only. Split off to make the main CL for deferring
clears simpler.

Bug: angleproject:4517
Change-Id: I5728a7dcf09de8952d5810061d1d8b135b625339
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165630
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

0f2747e9

Vulkan: Remove unicode character from error string. · 35e389cc

authored Apr 24, 2020

Will fix presubmit checks on Windows.

Bug: angleproject:4586
Change-Id: I36cec3e850c88a015f33d8a0bb7cc8f8c26402d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165628
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

35e389cc

Roll third_party/SwiftShader 5ab1f36a38aa..f42c698d784a (8 commits) · ab1a2f62

authored Apr 24, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/5ab1f36a38aa..f42c698d784a

git log 5ab1f36a38aa..f42c698d784a --date=short --first-parent --format='%ad %ae %s'
2020-04-24 bclayton@google.com SpirvShaderDebugger: Ensure frames are fully popped
2020-04-24 bclayton@google.com SpirvShaderDebugger: Implement globals, stub array types
2020-04-24 bclayton@google.com SpirvShader: Add WriteCFGGraphVizDotFile debug function
2020-04-24 pcc@google.com Don't unlock Android buffers immediately after locking them.
2020-04-23 digit@google.com LLVM: Do not map read-only data sections as executable.
2020-04-23 digit@google.com Vulkan: Add vk_icdInitializeConnectToServiceCallback()
2020-04-23 amaiorano@google.com Kokoro: fix SWIFTSHADER_LESS_DEBUG_INFO not being set
2020-04-23 digit@google.com Update tests/presubmit.sh to accept Fuchsia bugs as fxb/#

Created with:
gclient setdep -r third_party/SwiftShader@f42c698d784a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I40a8d09e11114449134a00d855d0708b5644b965
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2164871Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ab1a2f62

Roll third_party/spirv-tools/src 67f4838659f4..5547553a0c7b (2 commits) · 5a86ca60

authored Apr 24, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/67f4838659f4..5547553a0c7b


Created with:
  gclient setdep -r third_party/spirv-tools/src@5547553a0c7b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I9b1ae40819a0ab494d7d542abc6901aea1a3ef0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2164311Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5a86ca60

Roll third_party/vulkan-validation-layers/src 260a7c82e988..bb0380e3932a (3 commits) · d7f94536

authored Apr 24, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/260a7c82e988..bb0380e3932a

git log 260a7c82e988..bb0380e3932a --date=short --first-parent --format='%ad %ae %s'
2020-04-23 s.fricke@samsung.com tests: Add YCbCr Format Feature VUIDs
2020-04-23 s.fricke@samsung.com layers: Add YCbCr Format Feature VUIDs
2020-04-23 tony@lunarg.com gpu: Fix promoted buffer device address

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@bb0380e3932a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I3a3be970a68ae50dd95ea612aafc51e4516e4fdd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2164309Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d7f94536

Roll third_party/vulkan-headers/src 382bf3de06fc..62becc509a88 (1 commits) · 504ec9a1

authored Apr 24, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/382bf3de06fc..62becc509a88

git log 382bf3de06fc..62becc509a88 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 mikew@lunarg.com Revert "Export versioned targets for CMake"

Created with:
  gclient setdep -r third_party/vulkan-headers/src@62becc509a88

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=tobine@google.com

Bug: None
Change-Id: I016705256e4cfea044b9482975e1c2373e5846bb
Tbr: tobine@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2163918Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

504ec9a1

23 Apr, 2020 7 commits

Vulkan:Migrate events and queries to secondary Cmd Buffer · 21c5af31

authored Apr 20, 2020

Replace flushAndGetPrimaryCommandBuffer() function with
endRenderPassAndGetCommandBuffer() for events and queries. The end
result should be the same, but this allows a number of places that were
putting commands directly into the primary to put the commands into
ANGLE's custom SecondaryCommandBuffer (SCB) instead.

This also fixes a couple of minor bugs related to command buffer
ordering. flushAndBeginRenderPass() now flushes any outside
RenderPass (RP) commands first. Also, when insideRP commands are
flushed to the primary, set "mHasPrimaryCommands = true;"

Bug: b/153666475
Change-Id: I68413f25d27175afed0a20bc49f22f4c8d01e4fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156932Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

21c5af31

Vulkan: Disable EXT_texture_sRGB_R8 · 5578fc84

authored Apr 22, 2020

Due to a dEQP bug, EXT_texture_sRGB_R8 cannot be exposed before
EXT_texture_sRGB_decode is available. This change disables
EXT_texture_sRGB_R8 on the vulkan backend.

Bug: angleproject:3609
Test: dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.*
Change-Id: I261c80986484e489f6903eb54ac6865433050bfa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2161985Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

5578fc84

Vulkan: Manual Validation Layer Roll · 23621826

authored Apr 23, 2020

Latest Vulkan validation layer roll is hitting new error so added
exception and rolling manually.

Bug: angleproject:4583
Change-Id: Id9f8be7d2e20156ad8397ee0ba7ea5fcc12f6d28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2163133Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

23621826

EGL: Implement EGL_ANDROID_native_fence_sync on vulkan · e20f36f4

authored Apr 21, 2020

Check the following -
1. Vulkan ICD supports VK_KHR_external_fence_fd
2. ExternalFenceProperties and ExternalSemaphoreProperties
   support Android FD.

eglCreateSync - if FD was provided import to VkFence,
                else create VkFence with new FD and then
                flush and submit VkFence on next vkQueueSubmit.

eglGetSyncAttrib - for status call vkGetFenceStatus.

eglDupNativeFenceFdANDROID - return FD from vkGetFenceFD call.

eglClientWaitSync - call vkWaitForFences.

eglWaitSync - dup FD, create VkSemaphore and import FD, then
              flush() and add VkSemaphore to next vkQueueSubmit
              as a waiting semaphore.

Extended end2end test suite with nativefence test cases.

Bug: angleproject:2517
Test: angle_end2end_tests --gtest_filter=EGLSyncTest.AndroidNativeFence_*
Change-Id: I8f6a6f4c3d71d83007f662b78377aa015a740035
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2026177
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e20f36f4

Vulkan: Mask out implementation dirty bit in sync. · 963759a3

authored Apr 21, 2020

This would needlessly create many redundant sampler objects.

Bug: angleproject:4517
Change-Id: Ib8ef28b9bcbbeec804c493fbe677cbee7d9a750d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159296
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

963759a3

Vulkan: Track allocated sampler counts. · 492ec932

authored Apr 21, 2020

Helps to diagnose perf bugs where resources are over-allocated. Also
can be useful to evaluate caching strategies.

Bug: angleproject:4517
Change-Id: I48df5a09fbc394fa0b1712fa8cf28a179665e6e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159293
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

492ec932

Vulkan: Add a sampler cache. · 6fc0066a

authored Apr 21, 2020

This uses a packed sampler description to re-use samplers for multliple
VkImages. The samplers will persist for the lifetime of RendererVk. In
the future we could look at doing cache eviction for large object
counts.

Reduces the active VkSampler cache in Manhattan from over 1200 to 9.
Also should reduce the number of VkSamplers used with Chrome.

Bug: angleproject:4491
Change-Id: Idca00e4ed8cb660a0865281544aaa57cf884bbdb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160771Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6fc0066a