This uses a little helper list to map thread IDs into simple serials
that we output as 'tid' in our trace JSON file. We can use this to
analyze the behaviour of the command processor thread.

Bug: b/172704839
Change-Id: Ic1b5f3ec8427cb310833d1f589503daec4812681
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524542
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This gives the features the exact same name as the member variable.
It fixes a bunch of inconsistencies between the variable name and the
external string identifier.

Ideally these could be auto-generated from JSON.

Bug: b/172704839
Change-Id: Id75c01db544672234435c3dd727c927027b9236d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524541Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:4901
Change-Id: Ibc930a27887a3ba710168a9b122d46aac1530984
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523548Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

In order to fully suppot OES_shader_multisample_interpolation
rewrite interpolateAtOffset's offset parameter to account for
Y-coordinate flip.

Bug: angleproject:3589
Tests: dEQP-GLES31.functional.shaders.multisample_interpolation.
        interpolate_at_offset.*.default_framebuffer
Change-Id: I6bf72ceb1c0466ff5d4a92b72d1ec9e2552d6f2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524711
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

We can use this to produce AGI-like reports in standalone desktop.

Bug: b/172704839
Change-Id: Ifc510232e3da81210e22429b6cea9800e2723e06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524540Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

AHB backed EGL images create the VkImage through external sibling
images. Create those images with VK_KHR_image_format_list extension
support enabled.

Bug: angleproject:3756
Bug: angleproject:5281
Test: angle_end2end_tests.exe
          --gtest_filter=ImageTest*SourceAHB*Colorspace*Vulkan
Change-Id: I28c22f9d2f2423daa9228e4d42772b380ab7b8b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525109Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

ImageHelper::barrierImpl with secondary command buffer is used in
other translation units. Linking fails if compiler has optimized
out symbol for secondary command buffer.

Bug: angleproject:5324
Change-Id: I588d0d949a9b2eee04d8103effc485ab23d679c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2526082Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Addition of the entry points for EXT_external_buffer extension.

Bug: angleproject:5073
Change-Id: I5dc9f74dfd68c1e83e17ca15166df4cd4c20fca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525104
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/612ded0654a0..4ed9d3498dcf

2020-11-06 vhau@google.com Modify gralloc0 implementation
2020-11-06 jaebaek@google.com SpirvShaderDebugger: Correct member index for DebugValue

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I1ecdb3394c4fe8c52c3f09ab03ccbe178c495fcf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2526363Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/87451c55aa8b..670ffea9d61b

2020-11-09 oddhack@sonic.net Update for Vulkan-Docs 1.2.160

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Ia6d4d889cf62e7dc38a9fcb6de223fb256f21bbd
Bug: None
Tbr: courtneygo@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525861Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/52d33a46255e..61aafe6377ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc348c17b4..6dd14a4537
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c8d7f9564e..2de3a18349
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2d8c1340f0..0fe1450acb
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..434681c237
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df43926725..aa9ff5db33
* tools/skia_goldctl/linux: GVpht0r-QjWXa70RBjnj16oVOukePZsPqR9WjoyczEQC..O3XpMr3WCt1GviS8wGsldM7NCVb2wabpHx0lJZEemjIC
* tools/skia_goldctl/mac: E1HzztCcEvl2qwMi8jlWEeRipywovPX1tvzNMap-XFgC..9ofAReQA7h1bDa9kU-Rmr4_0AEQli7Pnj3lsid5AisAC
* tools/skia_goldctl/win: DsHjiYrgPxP5IjJ3QDF-DgcQwV_lMq60ESSU1CwXBSkC..lSgrnuo5FQl_aJkQyR7BSuMSrKb37G40wPe4xQBmTnEC
No update to Clang.

Bug: None
Tbr: courtneygo@google.com
Change-Id: If41692440b822876d6e49350b507daac47fa0e6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525680Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Previously we would leave an empty test suite name with no tests run.
According to the JSON test results spec this is likely a malformed
output and we should instead include just an empty "tests" key.

Bad:

"tests": {
  "angle_restricted_trace_gold_tests": {}
}

Good:

"tests": {}

Bug: angleproject:5299
Change-Id: I459da593df150d804130f9c63e05d031e77a16a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525147Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Should be void according to the spec. Noticed while working on texture
buffer.

Bug: angleproject:3584
Change-Id: I79a671c82fa117bab69bc2e6b35c840aa30429c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521241
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This patch does the following -
1. Expose EGL_KHR_image_gl_colorspace only if the underlying
   ICD supports VK_KHR_image_format_list extension
2. Create VkImageViews from EGLimage's format
3. Fix bugs in ImageTest colorspace tests

Bug: angleproject:3756
Bug: angleproject:5281
Test: angle_end2end_tests.exe
          --gtest_filter=ImageTest*Colorspace*Vulkan
Change-Id: I618ae009e83d0a6b27a0a50165f736784717e404
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523670
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This enables logging API commands to Android logcat.  It is enabled
via the following GN arg:

    angle_enable_android_api_logcat = true

On desktop, API commands can continue to be logged to the
"angle_debug.txt" file via a different mechanism, with the GN arg:

    angle_enable_trace = true

Bug: b/170249632
Change-Id: Id52e75f966a97692ec6d69eb3d254ba295a151c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519094
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>

This restores the prior path where angle_enable_trace would let ANGLE
write a debug.txt file without needing environment variables or
run-time annotator attachments.

Bug: b/170249632
Change-Id: I28693f038572638eb6531c5bb8e42d6cc7a65451
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523912Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

For interesting threading behavior need more than two command buffer
helper objects in the pool.

Bug: b/170328907
Change-Id: I394a583f2241ef094abba7a4645a200b9308e466
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518134
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

This change generates angle_deqp_gles*_rotate*_tests executables which
choose the appropriate mustpass file.

Bug: angleproject:4901
Change-Id: Ie6ac4b80d480b0f590b5baf1fa244fd601b5beed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522415
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

If the underlying ICD supports VK_KHR_image_format_list
extension we will have created both the linear and sRGB
image views, reuse them instead of refreshing them.

Bug: angleproject:3609
Bug: angleproject:4561
Bug: angleproject:5281
Change-Id: Ie34f08b3554a07f94911bebf925e38d702bc3c36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518387Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

This extension is core in GLES 3.2
This CL enables the extension, added 412 new dEQP tests for texture
buffer. 410 of these tests pass, but there are two tests that fail,
detailed in anglebug.com/4933

Also includes a fix for completeness checks.

Based on a CL by Jonah Ryan-Davis.

Bug: angleproject:3573
Bug: angleproject:4933
Change-Id: I45759d765c88c64f21b592eab01d910dc4bc8da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521239
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Can enable/disable ANGLE feature via Android properties:
debug.angle.feature_overrides_enabled and
debug.angle.feature_overrides_disabled which take a string of ':'
separated feature strings.

Bug: b/170328907
Change-Id: I815b42c5cfae85a39f0f753eabd56e264ea38baf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514200
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

GetEnvironmentVarOrAndroidProperty will first return the given
variableName from the processes enviroment if defined. If not defined
and running on Android, will look up the corresponding property and
store it in the environment.
The framecapture code wants to see when the Android property changes so
add an uncached version of GetEnvironmentVarOrAndroidProperty that
always does the getprop command (which can be time consuming).

Bug: b/170328907
Change-Id: I0624c0646889435cb6f6eb20a6d3cceb6ae3eb48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520107Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

This lets the default test time be 10 minutes when using a maximum
steps value. This will prevent the current 10 second limit from
kicking in and aborting. Also changes the --test-time override to
be more clearly a calibration time, and adds a new --test-time that
lets the user override the actual trial test time.

Bug: b/172480147
Change-Id: I630aa8d3c9e118bb5f0100b38f37e717e12f3538
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523371Reviewed-by: Paul Thomson <paulthomson@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Note: Hand edits required to compile this trace.
ANGLE_REPLAY_EXPORT was removed from each of the entry points in the
header. See build logs in patch set 1 of this CL for full output.

Test: angle_perftests --gtest_filter="*clash_of_clans*"
Bug: b/172626835
Change-Id: I63bab8f059a2c73c0a2fcd5b70fd92abf3bd4650
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521180
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: b/150458033
Change-Id: Ice5711a672b63a7dac0618749c7e56d862e0e5ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523373Reviewed-by: Geoff Lang <geofflang@chromium.org>

Emit code to reset all buffer bindings to how they were at the
beginning during MEC.

Test: Capture Clash of Clans
Bug: angleproject:4048
Bug: b/172626835
Change-Id: I5a5446304d119f51a018c8fe88ff386243d19749
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521179Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

rm will error when the file is missing without the -f flag. We delete a
few files without checking that they exist first.

Bug: b/150458033
Change-Id: I5a104d383f59d418eaa55534526194f626c88f57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523372Reviewed-by: Geoff Lang <geofflang@chromium.org>

We no longer require a specific version of the Windows SDK.
Also include updated instructions on how to setup Goma.

Bug: angleproject:1944
Change-Id: I5f9e714ebd69ba04eddc1b1fc2f95d1fde67a47f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522419Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Fixed by:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/50008

The specific flaky crash was reported here:
https://bugs.chromium.org/p/angleproject/issues/detail?id=4482#c15

Bug: angleproject:4482
Change-Id: Ia77b4b094446d14866bee5fd461a0a4eea52491e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521237Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>

This will limit the total number of steps run in the test.
When using this argument we skip warmp & calibration.

Renames the prior --steps argument to --steps-per-trial.

Bug: b/172480147
Change-Id: Iae7cce26d66ca0bbdb21c1f511a6bfa246bd204e

Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519404
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Bug: b/150458033
Change-Id: I17c605cbe02341b31855dc771225bf0c95445bfd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522009Reviewed-by: Geoff Lang <geofflang@chromium.org>

This prevents newer group keys from overwriting old ones.
Prevents bugs from creeping in like happened during texture buffer
development.

Bug: angleproject:3573
Change-Id: Iea69cac988e2cf4802a9f64c54cb694d32f1d3e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521238Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: b/150458033
Change-Id: I8b299f96d74499669495ca25d5b08711db90ce61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522008Reviewed-by: Geoff Lang <geofflang@chromium.org>

Some suppresions on the GLES3 dEQP expectations file were not removed.

Bug: angleproject:4249
Change-Id: Idcf2da50bb4ae4e6feb62fdb1d44d78aba9041a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522420Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c2b2b5788575..a61d07a72763

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I11dc44325b0992b14a43fc754586290828cbf1ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522887Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/ad54c71632cc..612ded0654a0

2020-11-05 srisser@google.com Merge changes I3c4f10f7,I5b7ddc75
2020-11-05 capn@google.com Fix Android.bp build after SPIRV-Tools update
2020-11-05 amaiorano@google.com Subzero: fix invalid arg access on Windows x86 for split variables
2020-11-05 amaiorano@google.com Subzero: fix non-deterministic stack layout and code-gen

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:4482
Tbr: courtneygo@google.com
Change-Id: Ia05307b40847dfa6c82b6a53d67706294848a392
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522886Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/51c1c5ab56d5..bd0ebb680792

2020-11-04 shannon@lunarg.com build: Update known-good files for 1.2.159 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I995f8b69aab80f8d96524459971bdf49fc844adb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522888Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/3c7580ad595f..52d33a46255e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/01b3fe480e..dc348c17b4
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b6526d9ad3..6302c11756
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f1516a7e59..c8d7f9564e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8b4d61dd3
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/952382f2b0..192a0edbbe
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/skia_goldctl/linux: TzGLaAGOIbgS9g3WS2NIL32_zXI1HeLIIIuDk25O4kwC..GVpht0r-QjWXa70RBjnj16oVOukePZsPqR9WjoyczEQC
* tools/skia_goldctl/mac: Yf-uk3I5Yz6gjKV3mct2yoXT580dpRG4hwbIx8CpW5MC..E1HzztCcEvl2qwMi8jlWEeRipywovPX1tvzNMap-XFgC
* tools/skia_goldctl/win: 6OGcfUna6B3W4PwFB6GuIVRffBaiDQ1HHaOxlOn9FvgC..DsHjiYrgPxP5IjJ3QDF-DgcQwV_lMq60ESSU1CwXBSkC
No update to Clang.

Bug: angleproject:4766
Tbr: courtneygo@google.com
Change-Id: I704ad78ca6474bfa46bed10e84d19b053d485273
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522879Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Bug: angleproject:2634
Change-Id: I56d13dda7a6c0ad002db15cb780d7bf6b430bf65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519712Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>

Deferred clears are not collected when syncing the READ framebuffer.
Prior to this change, we had in FramebufferVk::syncState:

    if (READ && deferredClears.any())
    {
        flushDeferredClears();
    }

However, this is impossible / unnecessary:

- Every operation whose syncState (for the DRAW framebuffer) collects
  deferred clears will flush the deferred clears.  In fact, it's an
  error for the next operation's syncState to encounter pre-existing
  deferred clears.
- The READ framebuffer is synced before the DRAW framebuffer.  This
  makes it impossible for there to be deferred clears when READ is
  synced.

It may be necessary to swap the order in which the READ and DRAW
framebuffers are synced.  See http://anglebug.com/5266.  In that case,
if the READ and DRAW framebuffers are identical:

- The DRAW framebuffer's sync will collect deferred clears.  The READ
  framebuffer's sync will see deferred clears, but it must not flush
  them!

Bug: angleproject:4988
Change-Id: I179002d739608ccb8bda95d4379dc6d54e2bf4bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511372
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>