Commits · 489ffc4d69656c2dbfdbe07e3fa6e38baeb3e072 · Chen Yisong / angle

11 Feb, 2015 8 commits

Allow varying structs to match between stages. · 489ffc4d

authored Feb 11, 2015

We would always expand a struct name to always include its symbol
ID. This workaround fixed scoped structs with the same name. It
would also block any possiblity of linking the structs successfully.

Instead we can use the workaround only on inner-scoped structs, and
leave global structs, which are by definition uniquely named, as
they are.

This fixes several tests in dEQP's shader.linkage.varying.struct.

BUG=angle:910

Change-Id: I81b8dadc7ea493152aff0c44d607114eaaabb142
Reviewed-on: https://chromium-review.googlesource.com/247242Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

489ffc4d

Fix struct uniform packing. · 2857f489

authored Feb 09, 2015

Our current code would not adapt properly for members that did
not fit in the previous register. Instead, use the correct adjusted
value as returned from the block layout encoder.

This fixes a dEQP WebGL test: gles2/shaders/linkage.

BUG=angle:910

Change-Id: Id77d0c76ce767665b3db97cb4d14e8008254fd9f
Reviewed-on: https://chromium-review.googlesource.com/247241Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2857f489

Implement equality ops for nested structs. · 55e79e09

authored Feb 09, 2015

This fixes the WebGL test glsl_misc_struct_equals as well as
several dEQP tests in functional.shaders.struct.

BUG=391957
BUG=angle:910

Change-Id: I09f3cd3f51bbc3541b64dbcfddfe01884ddba6f5
Reviewed-on: https://chromium-review.googlesource.com/247083Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

55e79e09

Return egl::Error from Renderer::initialize. · b2a5e342

authored Feb 11, 2015

This extra Error info can be useful for passing back additional info.
In the short-term this means we can implement a UMA histogram at some
point with a code that represents a more specific reason why the
init failed.

BUG=436191

Change-Id: If5e099a9ce32e87843754cd4f40d726dd5bad4b8
Reviewed-on: https://chromium-review.googlesource.com/246564Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b2a5e342

Cache sampler completeness in the Texture class. · 0fe40534

authored Feb 10, 2015

BUG=angle:909

Change-Id: I14e06e01d111e9d5eec415f4c2d831b61dcb1e3d
Reviewed-on: https://chromium-review.googlesource.com/248070Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0fe40534

Add Display getters for native display and attribs. · 38832d17

authored Feb 09, 2015

This simplifies the logic in the Renderer init.

BUG=angle:905

Change-Id: I01bf3701dd85f50e369e2c11e0e2a7cb638ccf00
Reviewed-on: https://chromium-review.googlesource.com/247650Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

38832d17

Reduce the calls to get[Width|Height|InternalFormat] in Texture.cpp. · b0eecdfd

authored Feb 10, 2015

BUG=angle:909

Change-Id: I8a66c1d317bcb7a01d79f9475390deb292e1ae2e
Reviewed-on: https://chromium-review.googlesource.com/248052Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b0eecdfd

Store the texture image information in a std::vector instead of a std::map. · 866dd2d1

authored Feb 10, 2015

BUG=angle:909

Change-Id: Ib595306f6cf0633b16bff6389373c2bb2cc29ec9
Reviewed-on: https://chromium-review.googlesource.com/248051Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

866dd2d1

09 Feb, 2015 12 commits

Implement eglQueryContext · 83107970

authored Feb 05, 2015

BUG=angle:895

Change-Id: I5e709f772d6222cdb7b5d7c060830a75eac9f815
Reviewed-on: https://chromium-review.googlesource.com/246490Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

83107970

Fix cstdint include in MemoryBuffer.h. · 959ad9a8

authored Feb 09, 2015

This syntax isn't compatible with OSX.

Change-Id: I3ec2bc856843637c4e1e7afb96a93ff6ea8296da
Reviewed-on: https://chromium-review.googlesource.com/247660Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

959ad9a8

Move rx::MemoryBuffer to common library. · 74ba76c4

authored Feb 09, 2015

This class is not D3D-specific so can be shared among other
back-ends, or other parts of the ANGLE codebase.

Change-Id: Ie00760eb5dae4db52e465ee7a2f97789bae8c0b0
Reviewed-on: https://chromium-review.googlesource.com/246500Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

74ba76c4

Add a script to generate a new Renderer. · 811b6352

authored Feb 09, 2015

Also refactor our current Impl headers slightly to facilitate
parsing by the generation script.

BUG=angle:905

Change-Id: Ib86cff71d18e7f911cf526b27b8a82757bacd738
Reviewed-on: https://chromium-review.googlesource.com/245497Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

811b6352

Catch errors in TextureStorage creation in TextureD3D::getNativeTexture. · b0e83f46

authored Jan 28, 2015

BUG=450257

Change-Id: Iba75d9f0607177fff0bec7fcd2564a8d2e26da8e
Reviewed-on: https://chromium-review.googlesource.com/243882Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b0e83f46

Only request PostSubBuffer support when the extension is available. · 15dc05fc

authored Jan 22, 2015

BUG=angle:658

Change-Id: I6828290ef89c57e8c794f0fca6e5991c492b67aa
Reviewed-on: https://chromium-review.googlesource.com/242572Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

15dc05fc

Move eglCreatePbuffer* validation into validationEGL. · f81b6a15

authored Jan 19, 2015

BUG=angle:658

Change-Id: I25d1be1ef86f82892186b08c9a8ff0133d520ac6
Reviewed-on: https://chromium-review.googlesource.com/242037Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f81b6a15

Move eglCreateWindowSurface validation into validationEGL. · 0eef0826

authored Jan 19, 2015

BUG=angle:658

Change-Id: Iaa7e6033fb323c1089907c9ed753746729887061
Reviewed-on: https://chromium-review.googlesource.com/242036Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0eef0826

Move eglCreateContext validation into validationEGL. · 33b6ae54

authored Jan 19, 2015

BUG=angle:658

Change-Id: Ibdf601725536edf40c0499aba0402fb160b2c841
Reviewed-on: https://chromium-review.googlesource.com/242035Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

33b6ae54

Add EGL validation helper files and move some validation to them. · dd43fccc

authored Jan 19, 2015

BUG=angle:658

Change-Id: Id560268a280f2fa7d75a7d0727dac830fe8de9f1
Reviewed-on: https://chromium-review.googlesource.com/242034Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

dd43fccc

Add a makeCurrent method to Display. · 1d8ae673

authored Jan 19, 2015

BUG=angle:658

Change-Id: If1830fb164d31e2ee8092414d012e127ec344d69
Reviewed-on: https://chromium-review.googlesource.com/242033Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1d8ae673

Implementing gl_InstanceID in the HLSL compiler. · b3dced29

authored Jan 12, 2015

Fixes:
dEQP-GLES3.functional.instanced.draw_arrays_instanced.instance_id
dEQP-GLES3.functional.instanced.draw_arrays_instanced.mixed
dEQP-GLES3.functional.instanced.draw_elements_instanced.instance_id
dEQP-GLES3.functional.instanced.draw_elements_instanced.mixed

BUG=angle:601

Change-Id: I6e120eebc90d00e025fc58f096064e6ed1da826b
Reviewed-on: https://chromium-review.googlesource.com/246911Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

b3dced29

06 Feb, 2015 1 commit

Revert "Track bound render targets in D3D9 with uintptr_t and dirty them with -1." · c38fa8a5

authored Feb 06, 2015

Failures on the Chromium GPU FYI bots:
http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Intel%29/builds/8695

This reverts commit 358c8a95.

Change-Id: I01d674929280364e097e4f65b06d7c3b1f928e92
Reviewed-on: https://chromium-review.googlesource.com/247091Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

c38fa8a5

05 Feb, 2015 7 commits

Fix instanced point sprites when gl_PointSize is specified but not used · 4e47b92f

authored Feb 03, 2015

Change-Id: I2350fa60cae55f02d7b484c34544c035acaba6ad
Reviewed-on: https://chromium-review.googlesource.com/245703Reviewed-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4e47b92f

Track bound render targets in D3D9 with uintptr_t and dirty them with -1. · 358c8a95

authored Jan 30, 2015

BUG=447419

Change-Id: Ia77e3b00db0f327eb278285de14cd438c5cf538b
Reviewed-on: https://chromium-review.googlesource.com/244664Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

358c8a95

Track bound render targets in D3D11 with uintptr_t and dirty them with -1. · cf077794

authored Jan 28, 2015

BUG=447419
BUG=452587

Change-Id: Ic36ebf108eca93e1239cc9c2a0d6479c84e93ace
Reviewed-on: https://chromium-review.googlesource.com/244663Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

cf077794

Move Renderer::getMajorShaderModel to RendererD3D. · 9c4264d9

authored Jan 09, 2015

BUG=angle:658

Change-Id: Ibf67a96ec9c0e8d6adc4f9c839da1e06058dc32f
Reviewed-on: https://chromium-review.googlesource.com/239904Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

9c4264d9

Remove swap interval queries from Renderer. · bb3f1802

authored Jan 09, 2015

BUG=angle:658

Change-Id: I7cd9cf3693c06c46ec6a4054e8fe1586f399273c
Reviewed-on: https://chromium-review.googlesource.com/239903Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

bb3f1802

Require 8 stencil bits in the BlitFramebufferANGLETest. · 784cc8f6

authored Feb 05, 2015

The test can fail if it uses a config where the default framebuffer does
not have a stencil buffer.

BUG=angle:658

Change-Id: I82eaf5b508182514439e69469e77591e1aceaf66
Reviewed-on: https://chromium-review.googlesource.com/246461Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

784cc8f6

Generate the full EGL configs in the Renderers. · f21a1080

authored Jan 09, 2015

Specify the default framebuffer formats in GL formats but still use BGRA
and ANGLEX formats for now.

BUG=angle:658

Change-Id: I7192db4ca76ab4b0b42daa43785a7ddd9528a9ca
Reviewed-on: https://chromium-review.googlesource.com/239902Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f21a1080

04 Feb, 2015 1 commit

Adds new robust initialization extensions. · c7ea21fa

authored Jan 07, 2015

Change-Id: I66d2ebbb0ce89bbfd1eda648e9ad0fb2edee0f31
Reviewed-on: https://chromium-review.googlesource.com/239286Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

c7ea21fa

03 Feb, 2015 10 commits

Implement ReadBuffer functionality. · b885e571

authored Feb 03, 2015

This enables ReadPixels from non-0 FBO attachments.

Tested with:
dEQP-GLES3.functional.negative_api.buffer.read_buffer
 (fails due to a possible error in dEQP)
dEQP-GLES3.functional.shaders.fragdata.draw_buffers
 (passes)

BUG=angle:903

Change-Id: Ib095e1d50b8fbbc6f197de25f19ec0993309145a
Reviewed-on: https://chromium-review.googlesource.com/244841Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

b885e571

Add stubs for primitive restart caps. · b4b53c5c

authored Feb 03, 2015

Allow dEQP to reset this particular state variable, while still
throwing an UNIMPLEMENTED error if we try to render with primitive
restart enabled.

BUG=angle:901

Change-Id: I1ab46ff4d8bff2775225b083f08d156b9422b9c5
Reviewed-on: https://chromium-review.googlesource.com/244840Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b4b53c5c

Update failing WebGL expectations. · 78d9fcf2

authored Feb 03, 2015

Change-Id: I0bde5c4e896aded773d2b9de7343883264625f52
Reviewed-on: https://chromium-review.googlesource.com/245807Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

78d9fcf2

Change Config to a struct and rename it's members. · c223dc6b

authored Jan 09, 2015

BUG=angle:658

Change-Id: I18dab915730fc28815db8080b3614da821f9c8b1
Reviewed-on: https://chromium-review.googlesource.com/239901Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c223dc6b

Rewrite ConfigSet and make EGLConfig synonymous with egl::Config. · 6812a55c

authored Jan 06, 2015

BUG=angle:658

Change-Id: I3c33faf18af0bfda00dc5babe6356d6c8661f032
Reviewed-on: https://chromium-review.googlesource.com/238862Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

6812a55c

Have the DisplayImpl create the Renderer and Contexts. · 5c39f688

authored Jan 06, 2015

BUG=angle:658

Change-Id: I726d87b90be8382c5dd8964e4d8686711e404ffe
Reviewed-on: https://chromium-review.googlesource.com/238861Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5c39f688

Fix conversion to bool warning. · 821f40a4

authored Feb 03, 2015

BUG=453543

Change-Id: I287cc3b6e86df71eb3dfa3c82316ae56950913b3
Reviewed-on: https://chromium-review.googlesource.com/245833Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

821f40a4

Extension behavior is now reset between each shader translation unit. · 0fbd128c

authored Feb 02, 2015

The extension behavior was being shared between translation units,
this was causing states to be cached between shader compilers. This
has been fixed now by adding a new ResetExtensionBehavior() function.

A unit test has also been added for testing extensions when compiling
shaders. A test has been included which tests that the internal state
of the extension behavior is being reset properly.

BUG=453543
Change-Id: Icb2a07019b5db972dc75cdbbdece4b7e9757c682
Reviewed-on: https://chromium-review.googlesource.com/245522Tested-by: David Yen <dyen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

0fbd128c

Add testfixturetypes.h to util.gyp · fcbf345b

authored Feb 03, 2015

Change-Id: I562bdca2c5c693155333a0ce168310be05b37531
Reviewed-on: https://chromium-review.googlesource.com/245741Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

fcbf345b

Add multithreaded create device flag in D3D9. · 39f2e2b0

authored Feb 03, 2015

This fixes a crash when we try to load a program executable in the
worker thread in the multi-threaded shader compilation. This fixes
the angle_end2end_tests.

BUG=angle:900

Change-Id: Id4494864c7121630c43c2fe64a92674326eabc69
Reviewed-on: https://chromium-review.googlesource.com/245681Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

39f2e2b0

02 Feb, 2015 1 commit

Add UNPACK_ROW_LENGTH support to D3D11 renderer · b8aee3bc

authored Jan 27, 2015

Change-Id: I31ccffddcb04a45f19d3c3eb9a396c30e794b218
Reviewed-on: https://chromium-review.googlesource.com/243951Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Minmin Gong <mgong@microsoft.com>

b8aee3bc