Commits · 49babcbc0779a68e46eeb750d3f998ae29ea6584 · Chen Yisong / angle

24 Feb, 2021 7 commits

Fix crash of MultithreadingTest end2end tests. · 49babcbc

authored Feb 20, 2021

Extension platformANGLEContextVirtualization is currently only
supported in the OpenGL backend, it's confused to validate it
when the test is set up by WithNoVirtualContexts(). It'll generate
crash when it's not OpenGL backend.

Bug: angleproject:5636
Change-Id: Ib04fb4a3d29beaac5162e63af5ef1fd80c8a420c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2709821
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

49babcbc

Stubs for OpenCL entry points. · 6623a70f

authored Feb 19, 2021

Bug: angleproject:5653
Change-Id: I7ec9692a47be2556fef5bdd7630b422cc2d369b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2708343
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

6623a70f

Remove redundant (c) from license headers. · 4a782eaf

authored Feb 11, 2021

According to the Chromium C++ style guide, there must be no `(c)` after
`Copyright`.

Bug: angleproject:5516
Change-Id: Id5b170b99a1aaf95ab7fabb35ed644b99b756ce1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690948
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

4a782eaf

Roll vulkan-deps from ca177df9b948 to 55434360b05d (16 revisions) · 9b9d683e

authored Feb 24, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/ca177df9b948..55434360b05d

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/e56beaee73..2e99822c14
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b35745ad1..ef3290bbea
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4edde62bf0..521bc47360

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I363fe8f165cfbc38bd06c08284384c6674113c94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717864Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9b9d683e

Roll Chromium from d163fd7c6905 to b90646417bd3 (481 revisions) · 838fc2df

authored Feb 24, 2021

https://chromium.googlesource.com/chromium/src.git/+log/d163fd7c6905..b90646417bd3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ac7b73c91d..72bbbc35a8
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/80d14c91e9..4c78ef9c38
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/cadb271846..677f5aa5b0
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..370c3d98a6
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bf8c8f36a1..cfd0f62809
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/29685916ca..bf8d1f051b
* tools/skia_goldctl/linux: ncanHC47RONr4iiaFn-Jh-KAhwJd11MQrAXp6Noh9x0C..FFNvbEArN40QplEcWmMIDG83rNyxP5fmhDHlHdE-Y94C
* tools/skia_goldctl/win: lfHdYxTMV17X3ADPkkVY0dyrgWWuUv9zJhTPER5ocbcC..DpXABD34NuP5941cN5RRg-EPNqCxgt0lA_ga3KIZg4AC
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ibd3819829738d7915fb34215974115d36d7a35e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717686Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

838fc2df

Add a test for sample after deferred clear · d81e5d17

authored Feb 18, 2021

To ensure that deferred clears are flushed before sampling.

Bug: angleproject:5070
Change-Id: I72bfef752074eb1e722c669edaa2d0b5ddfd20b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705027
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

d81e5d17

Vulkan: Don't break the render pass on dispatch calls · 39d7fc18

authored Feb 17, 2021

The only reason a dispatch call may need to break the render pass
implicitly is for read-after-writes where the write originates from the
render pass but is not through a storage buffer/image.  There are only
two such scenrios possible:

- Framebuffer attachment write -> texture sample
- Transform feedback write -> ubo read

All other uses of the buffers and textures that require breaking the
render pass are handled by `glMemoryBarrier`.

Bug: angleproject:5070
Change-Id: I92b50d69d8782097ee8ff477ac57da6209c326a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698998
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

39d7fc18

23 Feb, 2021 11 commits

Remove incorrect memory barrier tests · 5d7f4e80

authored Feb 18, 2021

The tests were written with the assumption that the X_BARRIER_BIT
implied two barriers, write->X and X->write.  However, they only imply
write->X, with the exception of SHADER_IMAGE_ACCESS_BARRIER_BIT and
SHADER_STORAGE_BARRIER_BIT which handle X->write for images and buffers
respectively.

Bug: angleproject:5070
Change-Id: Ic9bfac997d0663b70f1d40baca6c111a4dc300c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705701
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

5d7f4e80

Add Collabora, Ltd. to AUTHORS and CONTRIBUTORS · 08bfc351

authored Feb 11, 2021

This change adds Collabora, Ltd. to the AUTHORS file as described in the
ContributingCode guide.
Also adds Collabora, Ltd. and myself to CONTRIBUTORS.

Bug: angleproject:5516
Change-Id: Ie24ef8ec01720d9d207d36c4a4c21fab96d08dcd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690949Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

08bfc351

Roll VK-GL-CTS from 1a524349f06b to 9cdde06fb38a (1 revision) · 016c5ff0

authored Feb 23, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1a524349f06b..9cdde06fb38a

2021-02-23 alexander.galazin@arm.com Merge pull request #241 from enunes/gles2-EXT_texture_rg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:5674
Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com
Change-Id: Ie6e73c958321b224de7338c1bd5c3e7c719accb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714485Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

016c5ff0

Assert valid when using SPIR-V ids · df0a92e6

authored Feb 22, 2021

Useful for debugging when an uninitialized id is used in the SPIR-V
transformer.

Bug: angleproject:4888
Change-Id: If446187a8a27a06f5958d5df5bc00d02e98d20e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2713268
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

df0a92e6

capture_replay_tests: Fix repository path retrieval. · 1330aa2c

authored Feb 12, 2021

Use relation to retrieve angle repository path.

The previous way of detecting the root repository folder failed to
detect a correct path if the angle directory was in a path that
contained the string angle.

e.g. `/home/user/code/angle/angle`

Other paths that would fail with the current implementation:
`/home/user/my-angle-workspace/angle`
`/home/tangled/workspace/angle/`
`/home/user/code/angle-android`

This way the path is constructed with the known relation of the script
path inside the repository. Another advantage of this way is that the
`angle` repository could be checked out with a different name.

The disadvantage of this method is that whenever the script was moved,
the relative path must be updated.

Bug: angleproject:5645
Change-Id: I9a56aeba449b248273087382adceb0d6fba5a494
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2715323Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1330aa2c

Generators: Use fixed year in license headers. · 37752956

authored Feb 11, 2021

Remove dynamic year generation from generator scripts, as required by
the Chromium C++ style guide.
The dynamic year values were replaced by the current year at the time
the file was created according to git log. The code to dynamically
generate the year was removed.
This patch also refreshes generated files and hashes.

Bug: angleproject:5516
Change-Id: I735028bccb5c83217e92c380538f1abf0a906b2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690950
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

37752956

Remove old Win x64 bots from CQ · 918b22df

authored Feb 22, 2021

win-angle-chromium-x64-try + win-angle-x64-try replace
win-angle-rel-64 + win-angle-deqp-rel-64

Bug: angleproject:4483
Change-Id: I30145f15758b5e9ceac4bfaedf7566f909173f24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2713272Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

918b22df

Clean up entry point generation script. · 7b7e5cad

authored Feb 19, 2021

The main refactor from this change is to replace statements like this:

  decls, defs, export_defs, _, _, _, _ = get_entry_points(
    apis.EGL, eglxml.all_commands, egl_version_commands, False,
    egl_param_types, cmd_packed_egl_enums, EGL_PACKED_TYPES,
    egl_ep_to_object, TEMPLATE_EGL_ENTRY_POINT_EXPORT)

With statements like this:

  eps = EGLEntryPoints(eglxml, egl_version_commands)

This will make the script easier to maintain and extend.

Bug: angleproject:5653
Change-Id: Ibd0930d45b8629702b7782f43a2d7ebfa4dac9b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705156Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

7b7e5cad

Roll SwiftShader from d85a7a27b272 to 22186f076bf3 (4 revisions) · f19f319a

authored Feb 23, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/d85a7a27b272..22186f076bf3

2021-02-22 capn@google.com Remove color interpolation from image sampling benchmark
2021-02-22 capn@google.com Revert sampling parameter initialization workaround
2021-02-22 capn@google.com Eliminate stores succeeded by another store
2021-02-22 capn@google.com Implement propagation of stores to loads in single basic blocks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Id249f4e2fff10d900b9e31f65d01a2c3ee107214
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714624Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f19f319a

Roll VK-GL-CTS from a075fac2c633 to 1a524349f06b (4 revisions) · 661390f1

authored Feb 23, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a075fac2c633..1a524349f06b

2021-02-23 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
2021-02-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-02-19 ilkka.saarelainen@siru.fi Fix image format in memory model tests
2021-02-19 andreas.floejt@arm.com Remove RelaxedPrecision in test

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com
Change-Id: I9fb6a88ef2aa71dad474fd83334a95cbbc584e00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714192Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

661390f1

Roll Chromium from fa63f1264116 to d163fd7c6905 (388 revisions) · d677330f

authored Feb 23, 2021

https://chromium.googlesource.com/chromium/src.git/+log/fa63f1264116..d163fd7c6905

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d6803e2773..ac7b73c91d
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fe293b0f5a..80d14c91e9
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/8e668d627a..cadb271846
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..832539cc4d
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/bf44340d1b..348acca950
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6cf138ce6f..bf8c8f36a1
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: I881cf7ed23e21bf7bc61093c0aa78bdb49c90af4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714189Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d677330f

22 Feb, 2021 7 commits

Add const to optional parameters of SPIR-V instruction builders · 1a70e5a0

authored Feb 22, 2021

Bug: angleproject:4888
Change-Id: I70274042794a7d56db48490d9e3930e1eace02bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2713267Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

1a70e5a0

Vulkan: Refactor prerotation out of SPIR-V transformer · c2d14d03

authored Feb 18, 2021

The SPIR-V transformer performs multiple transformations in one pass.
This is part of a series of refactoring changes that detangle these
transformations and encapsulate them, while allowing the transformation
to remain single-pass.

Bug: angleproject:4888
Change-Id: Ia971da6d814b5d7c4f51132fe63b58675163c15f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705026
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

c2d14d03

Vulkan: Refactor xfb codegen out of SPIR-V transformer · 4a95488c

authored Feb 18, 2021

The SPIR-V transformer performs multiple transformations in one pass.
This is part of a series of refactoring changes that detangle these
transformations and encapsulate them, while allowing the transformation
to remain single-pass.

Bug: angleproject:4888
Change-Id: I3e3164803863c4d477364f5b2ed0679ed501ea3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705025Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4a95488c

Roll SwiftShader from 3ab17bd731f6 to d85a7a27b272 (10 revisions) · c624d410

authored Feb 22, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/3ab17bd731f6..d85a7a27b272

2021-02-20 capn@google.com Simplify If/Else lowering
2021-02-20 capn@google.com Don't materialize on insertion block changes
2021-02-20 capn@google.com Implement scalar replacement of aggregates
2021-02-20 capn@google.com Report back the Subzero optimizer results
2021-02-19 capn@google.com Fix lowering and optimization of 64-bit absolute addresses
2021-02-19 capn@google.com Eliminate code randomization support from Subzero
2021-02-19 amaiorano@google.com Fix Win32SurfaceKHR::getSurfaceCapabilities asserting when hwnd is no longer valid
2021-02-19 srisser@google.com Update requested SPIR-V Tools version to 1.5
2021-02-19 amaiorano@google.com Make vkGetPhysicalDeviceSurfaceCapabilitiesKHR provide a return code
2021-02-19 adelva@google.com Revert "Revert "Enable named mmap usage on Android""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I5db447d048a875d1a1218d662a2a8cc77eb8ddcd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2711967Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c624d410

Roll Chromium from db0c2c83776b to fa63f1264116 (548 revisions) · 196de52a

authored Feb 22, 2021

https://chromium.googlesource.com/chromium/src.git/+log/db0c2c83776b..fa63f1264116

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8874f335d1..d6803e2773
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c59926ad1d..8e668d627a
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b33c25cc0b..4a1e66d2e5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..832539cc4d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5a680f9050..29685916ca
* tools/skia_goldctl/linux: sm5PB3-BZYObubxkNie_5-C1p_sD1rtSOFVIc8PLymYC..ncanHC47RONr4iiaFn-Jh-KAhwJd11MQrAXp6Noh9x0C
* tools/skia_goldctl/mac: O-zkkp_UNP-ZoPmmK4xpuqYw9tpNzRGuUCNFH8I9PzwC..WCRXBnRqP4DfVUcrclUzE5_p_6x3RZZatC2SM1ZRX4IC
* tools/skia_goldctl/win: 0JpeSchnXAemMxcrvtlMxxr3uiYp4vpP_iKo4kKEfUoC..lfHdYxTMV17X3ADPkkVY0dyrgWWuUv9zJhTPER5ocbcC
No update to Clang.

Bug: None
Tbr: cwallez@google.com
Change-Id: Id4bd1565d7e8b2766723456d146dd649400aaf21
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2711724Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

196de52a

Skip more flaky crashing dEQP tests on Nexus 5X · 2be24692

authored Feb 21, 2021

Bug: angleproject:5665
Change-Id: I29f7cdd39c13d105c52ab0803e6241205fc743fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710908Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

2be24692

Suppress 2 failing dEQP GLES3 tests on Mac AMD Metal · 6eb7ae4f

authored Feb 21, 2021

Bug: angleproject:5666
Change-Id: Ie4b62868ebca6806bb40f78ce49f1fbf70f96fcf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710907Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

6eb7ae4f

21 Feb, 2021 6 commits

Vulkan: Refactor varying precision fix out of SPIR-V transformer · bd9a3b29

authored Feb 18, 2021

The SPIR-V transformer performs multiple transformations in one pass.
This is part of a series of refactoring changes that detangle these
transformations and encapsulate them, while allowing the transformation
to remain single-pass.

Bug: angleproject:4888
Change-Id: I587d601e02164c1372a09565d1713aac27cfbebb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705024
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bd9a3b29

Vulkan: Refactor inactive varying removal out of SPIR-V transformer · 454194e4

authored Feb 17, 2021

The SPIR-V transformer performs multiple transformations in one pass.
This is part of a series of refactoring changes that detangle these
transformations and encapsulate them, while allowing the transformation
to remain single-pass.

Bug: angleproject:4888
Change-Id: Ifd52be302c25392d3e8fc1c589795c113e44d354
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703792
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

454194e4

Vulkan: Refactor gl_PerVertex trimming out of SPIR-V transformer · c342647f

authored Feb 17, 2021

The SPIR-V transformer performs multiple transformations in one pass.
This is part of a series of refactoring changes that detangle these
transformations and encapsulate them, while allowing the transformation
to remain single-pass.

Bug: angleproject:4888
Change-Id: I41ba9165336487819dcf915af0d1ed868f73f724
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703791
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c342647f

Vulkan: Typed return value in SPIR-V transformer transform funcs · 8f65bb39

authored Feb 17, 2021

Use an enum class instead of a bool for readability.

Bug: angleproject:4888
Change-Id: I5fddec4ccc1cb7e28940c0566979f5fd5e051d60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2702652
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

8f65bb39

Vulkan: Don't break the render pass on indirect calls · 6e8cdd39

authored Feb 17, 2021

The render pass is now only broken if the indirect buffer was used as
transform feedback.  Any other write to the indirect buffer is
synchronized with `glMemoryBarrier`.

Bug: angleproject:5070
Change-Id: I67868ae9a8f08e1ab186440a3cbdc7439c66808e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698996
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

6e8cdd39

Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Nexus 5X · c03a4235

authored Feb 20, 2021

GTest complains that we don't run some tests on GLES backend.

Bug: chromium:1180570
Change-Id: I9427ac25c3b6f06f3c042caa3c0afc7000cf1599
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710783Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

c03a4235

20 Feb, 2021 3 commits

Skip more flaky crashing dEQP tests on Nexus 5X · 5c931b61

authored Feb 20, 2021

Bug: angleproject:5665
Change-Id: I17da18f451c90a767ac957ea03e1ce0eb38302d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710623Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

5c931b61

Vulkan: Refactor ID-discovery out of SPIR-V transformer · d3d30921

authored Feb 17, 2021

The SPIR-V transformer performs multiple transformations in one pass.
This is the first of a series of refactoring changes that detangle these
transformations and encapsulate them, while allowing the transformation
to remain single-pass.

Bug: angleproject:4888
Change-Id: I327f693d99496a0b89028abe627119e4a2b07c42
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2702651Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d3d30921

Skip flaky crashing dEQP tests on Nexus 5X · be943b3b

authored Feb 19, 2021

Bug: angleproject:5665
Change-Id: Ifccd1d11edcbdfc57765144ba5dc65d12de53af2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705766
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

be943b3b

19 Feb, 2021 6 commits

Vulkan: Optimize glMemoryBarrier · e96d1744

authored Feb 12, 2021

Previous to this change, glMemoryBarrier was processed as it is issued.
This made it impossible to know whether a draw call would follow or a
dispatch call, and what resources it would use. The render pass was
conservatively broken due to this limitation. To address this
limitation, handling of glMemoryBarrier is deferred until the next
draw or dispatch call.

Note that glMemoryBarrier acts as two barriers:

- An execution+memory barrier: shader writes are made visible to
subsequent accesses
- Another execution barrier: shader accesses are finished before
subsequent writes

An important observation is that for most resources, ANGLE actually
necessarily has to issue memory barriers automatically to conform with
Vulkan. In terms of memory barrier thus, ANGLE already does the right
thing except for when there's no binding change. This means WaW hazards
(i.e. storage buffer and image writes) with no binding change require a
memory barrier as a result of glMemoryBarrier. In all other cases, it's
enough for glMemoryBarrier to break the render pass if necessary and
ensure that corresponding bindings are marked dirty (for the execution
or memory barriers to happen automatically later).

Bug: angleproject:5070
Change-Id: Ide359c43362f8a78805ecf797a91de7aa79221f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693473Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e96d1744

Add Mac chromium.angle bots to CQ · 22aea430

authored Feb 18, 2021

Bug: angleproject:4483
Change-Id: I75fc58442e4cd713b4b657c1d03a4142e0e9a93e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705698Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

22aea430

Vulkan: Secondary sort shader enums by name. · 6af603e1

authored Feb 19, 2021

This preserves the primary sort by bits. If bits are equal we then
sort by name to produce a more stable sort.

Bug: angleproject:5653
Change-Id: I4cdbc21094fcbd1bb7ad17e124074949bdbf0439
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704825Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

6af603e1

Tests: Add Messenger Lite trace · 4b608a6c

authored Feb 17, 2021

Test: angle_perftests --gtest_filter="*messenger_lite*"
Bug: b/180562361
Bug: angleproject:5659
Bug: angleproject:5663
Change-Id: I9938b925962ea13fd626f2b82676655d07d78c0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703733Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

4b608a6c

Vulkan: Add VK_KHR_image_format_list support to initExternal · 4afd0f27

authored Feb 17, 2021

The code for initializing a VkImage with VK_KHR_image_format_list
extension support is now internal to initExternal. Also provides a flag
to inform callers when VK_KHR_image_format_list support is enabled.

Bug: angleproject:5520
Change-Id: Ie2ade93d1403ab3f9cbcf7d80684bbca201d5d8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2702159Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

4afd0f27

Roll VK-GL-CTS from beffa5287574 to a075fac2c633 (4 revisions) · b50c0b01

authored Feb 19, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/beffa5287574..a075fac2c633

2021-02-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-02-19 ari.suonpaa@siru.fi Test variable pointers on dynamic descriptors
2021-02-19 alexander.galazin@arm.com Support GL 4.5 in the textureGather tests
2021-02-19 alexander.galazin@arm.com Support GL 4.5 in the blend_equation_advanced tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC cwallez@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com,angle-bots+autoroll-info@google.com
Change-Id: I1c41d9d6272f84b64d53b76f9b1487053322853a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2706976Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b50c0b01