Test: angle_perftests --gtest_filter="*messenger_lite*"
Bug: b/180562361
Bug: angleproject:5659
Bug: angleproject:5663
Change-Id: I9938b925962ea13fd626f2b82676655d07d78c0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703733Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

The code for initializing a VkImage with VK_KHR_image_format_list
extension support is now internal to initExternal. Also provides a flag
to inform callers when VK_KHR_image_format_list support is enabled.

Bug: angleproject:5520
Change-Id: Ie2ade93d1403ab3f9cbcf7d80684bbca201d5d8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2702159Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/beffa5287574..a075fac2c633

2021-02-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-02-19 ari.suonpaa@siru.fi Test variable pointers on dynamic descriptors
2021-02-19 alexander.galazin@arm.com Support GL 4.5 in the textureGather tests
2021-02-19 alexander.galazin@arm.com Support GL 4.5 in the blend_equation_advanced tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC cwallez@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com,angle-bots+autoroll-info@google.com
Change-Id: I1c41d9d6272f84b64d53b76f9b1487053322853a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2706976Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

googletest CL 315255779 causes test binaries to fail when they include
test suites / parametrized tests that are not instantiated, and when
they include empty test suites.

This CL uses the GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST() macro
to annotate the suites / tests that are causing test failures. This is
necessary to get googletest rolled past CL 315255779.

Bug: chromium:1163396
Change-Id: I05c0619186ffc265b8e32e8b69d6680a6acdbb48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2701292Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/bb04803b8daf..3ab17bd731f6

2021-02-19 capn@google.com Fix iterating over instructions following a store
2021-02-19 capn@google.com Propagate stores of stack addresses into other local variables
2021-02-18 capn@google.com Test variable materialization edge cases
2021-02-18 capn@google.com Disable MSan unpoisoning of memory writes
2021-02-18 amaiorano@google.com VulkanWrapper: enable filesystem code on macOS with new Kokoro image
2021-02-18 swiftshader.regress@gmail.com Regres: Update test lists @ b3177eb4
2021-02-18 amaiorano@google.com VulkanBenchmarks: add validation layers and load via ICD
2021-02-18 capn@google.com Remove zero initialization of Triangle and Primitive
2021-02-18 swiftshader.regress@gmail.com Regres: Update test lists @ bb04803b
2021-02-17 sugoi@google.com Fix interpolation functions for push constants
2021-02-17 adlai@google.com Make MSAN-in-JIT flag optional for CMake builds
2021-02-17 adelva@google.com Fix support for named mmap usage on Android

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Ida8932b170000db9e57e9ae3a5126ff7bcbbd55e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2706651Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/vulkan-deps.git/+log/23a4efc36ed9..ca177df9b948

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/51b86c1a2b..e56beaee73
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/05cda81aba..1b35745ad1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I01dcd785cad7b97c52b0088b241ae6d56dbcf5bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2706963Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/45064257f2e6..db0c2c83776b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/206dd80fb5..8874f335d1
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a6c7ff6dbc..c59926ad1d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..832539cc4d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/92688e86c2..6cf138ce6f
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dbc1962514..5a680f9050
No update to Clang.

Bug: None
Tbr: cwallez@google.com
Change-Id: I55ca9992876b47a8291e8c23fc88ce268078d00d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705124Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/eab348e95425..beffa5287574

2021-02-18 alexander.galazin@arm.com Support GL 4.5 in the Built-in Constant Tests
2021-02-18 ari.suonpaa@siru.fi Add tests for mixing matrix packing in nested structs
2021-02-18 gleese@broadcom.com Extend CopyImage tests to test astc_sliced_3d
2021-02-18 mika.vainola@siru.fi Fix undefined behavior in FloatToHalf
2021-02-18 mikko.tiusanen@siru.fi Add tests for all ES 3.0 internal formats

Bug: angleproject:5661
Bug: angleproject:5662
Change-Id: Iab7a28e17523e0b69fb76fbd6281423db63569fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703517Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Test: angle_perftests --gtest_filter="*aliexpress*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/180565449
Bug: angleproject:5660
Change-Id: I61ac0e7dbfbe6fd23c71b63fa6f8c00b20a94006
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703735Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

https://chromium.googlesource.com/chromium/src.git/+log/6aa3b21e53d5..45064257f2e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/99c7b26e2b..206dd80fb5
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/eb69420f5c..a6c7ff6dbc
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..832539cc4d
* tools/luci-go: git_revision:77944aa535e42e29faadf6cfa81aee252807d468..git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a
* tools/luci-go: git_revision:77944aa535e42e29faadf6cfa81aee252807d468..git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a
* tools/luci-go: git_revision:77944aa535e42e29faadf6cfa81aee252807d468..git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/05e6764e8c..dbc1962514
No update to Clang.

Bug: angleproject:4483
Tbr: cwallez@google.com,ynovikov@google.com
Change-Id: I66df89e1fb2a2c51befa08f3d50b8c1ef24a11a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705678Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

googletest CL 315255779 causes test binaries to fail when they include
test suites / parametrized tests that are not instantiated, and when
they include empty test suites.

This CL uses the GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST() macro
to annotate the suites / tests that are causing test failures. This is
necessary to get googletest rolled past CL 315255779.

Bug: chromium:1163396
Change-Id: I13ffa09c4263a6dc8baf1749c3df5d2c54904e68
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704800Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/vulkan-deps.git/+log/0d42e83928f7..23a4efc36ed9

Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/6f1f6775f3..621884d709
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/74aa762a95..4edde62bf0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I7cc1ce192cc3dfceea64ea57912409e5bb8fa572
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703853Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This reverts commit 027bc47c.

Reason for revert: InstancingTests fail on Mac FYI Release (Intel UHD 630), see https://ci.chromium.org/ui/p/chromium/builders/ci/Mac%20FYI%20Release%20(Intel%20UHD%20630)/1729/overview

Original change's description:
> Workaround for Mac Intel drawArraysInstanced with first > 0
>
> Workaround by forcefully set instanced arrays (divisor > 0)
> as streaming attributes and apply extra offset at front. Recover
> those attribute bindings when first == 0 and other draw calls
> (drawElementsInstanced)
>
> Bug: chromium:1144207, chromium:1144247, chromium:1144373
> Change-Id: Ie7836cc71b45a290513f34f90d49bd15b14ddba8
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2661095
> Commit-Queue: Shrek Shao <shrekshao@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: chromium:1144207
Bug: chromium:1144247
Bug: chromium:1144373
Change-Id: Ia4a6026a8c446490346b373c33fe2b1724c1761f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704052
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

This reverts commit 2cb66715.

Reason for revert: Make DisplayGbm fail to compile. See: https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-compile-dbg/636833/overview

Original change's description:
> EGL: Merge DisplayAndroid into DisplayEGL.
>
> These two classes have a lot of duplicated code for no reason.
>
> Bug: angleproject:5563
> Change-Id: Ia9d8efeb50f3e52ffb1df6a6e462efdb20fd4a9a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636678
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Bug: angleproject:5563
Change-Id: Ic39071130727b37cc2a168d4b8e3c50f3e7184a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704051Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/794086037940..6aa3b21e53d5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/43c1e3a98a..99c7b26e2b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/dc82acba81..eb69420f5c
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..832539cc4d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6ec6688f3b..92688e86c2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bd7d7f71cf..05e6764e8c
No update to Clang.

Bug: None
Tbr: cwallez@google.com
Change-Id: I6f39978f097a37deda71875b555eebc225a912a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703736Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Workaround by forcefully set instanced arrays (divisor > 0)
as streaming attributes and apply extra offset at front. Recover
those attribute bindings when first == 0 and other draw calls
(drawElementsInstanced)

Bug: chromium:1144207, chromium:1144247, chromium:1144373
Change-Id: Ie7836cc71b45a290513f34f90d49bd15b14ddba8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2661095
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Clang has retired `-Wreturn-std-move-in-c++11`, which was a diagnostic
to help ensure backward compatibility with old versions of Clang.

Clang still has a similar-but-different `-Wreturn-std-move` that helps
find copies-on-return that can be changed to moves-on-return.

Bug: angleproject:5657
Change-Id: I4eaf9fb9eb8b4d7f9823025549e1267af2324f3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2702754
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The app "Car Parking Multiplayer" issues a ClientWaitSync() command
without having already flushed the sync object and without an active
context. We should return TIMEOUT immediately rather than attempting to
wait on the sync object, since we can't flush it and it'll never be
signalled.

Bug: angleproject:5613
Bug: angleproject:5656
Test: MultithreadingTest.NoFlushNoContextReturnsTimeout
Change-Id: Ieaf675ca9144f9c851c73b9ca399daaf4ed1cd0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693375
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

Switches to Python 3 support. Made a change to run_code_generation to
support this. Affects several generators. Also updates the generator
to make a few other small cleanups.

Bug: angleproject:5653
Change-Id: I045173c9ca85947c4eac22285701032c09f4c8d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699187
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Test: Fortnite MEC
Bug: b/180418810
Bug: angleproject:5658
Change-Id: I2025f0b88f7488a827159029e6d04a4cf4e9a1b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611558
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

VertexArray::syncState syncs all dirty bits, including
DIRTY_BIT_ELEMENT_ARRAY_BUFFER even for draw calls that don't use this
buffer, such as glDrawArrays.  If the element buffer is given 0 size,
this caused a crash in the Vulkan backend.

Bug: chromium:1172577
Change-Id: I02d78c9660c07b896f7403867b648901478251fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2701831Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Optimizing glMemoryBarrier can get very tricky.  This change adds tests
for every glMemoryBarrier bit in different scenarios for a total of
about 1500 tests.  With the current implementation, there are no syncval
errors running these tests.

Bug: angleproject:5070
Change-Id: I5358bfeed84f586a67c90ba5ab0fe624db6820b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698288Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:4483
Change-Id: I1d841cccf6bb88de287cbaac78f29b9bca068ddd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698931
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

EXT_shader_framebuffer_fetch_non_coherent is implemented using subpass
input attachments. The extension will be enabled in a follow up change
that adds required changes to the Vulkan translator.

Bug: angleproject:5454
Test: FramebufferFetchNonCoherentES31.*Vulkan
Change-Id: Ic73c66a476c4a21db5269431166a198841f1dc0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598059
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: chromium:1171371
Change-Id: I7cf00edbc337150e40e7afb4f6c5fc88862f0734
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2700332Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

These two classes have a lot of duplicated code for no reason.

Bug: angleproject:5563
Change-Id: Ia9d8efeb50f3e52ffb1df6a6e462efdb20fd4a9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2636678
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

The following failing without a clear reason (asides from PartitionAlloc
changes in Chromium maybe). This CL suppresses them while we find what
the issue is.

TBR=syoussefi@chromium.org
Bug: angleproject:5651
Change-Id: I6cba67351dfba37fd6d86a07ac748b7998665361
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2700511Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Bug: chromium:1179061
Change-Id: I89167eb9c6ed244072e00500b47c7df83ac2e80d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699188Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

The app "Car Parking Multiplayer" enables GL_SAMPLE_ALPHA_TO_COVERAGE,
which leads to a VVL error when LINE_RASTERIZATION_MODE_BRESENHAM is
also enabled:

VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766:
The Vulkan spec states: If the lineRasterizationMode member of a
VkPipelineRasterizationLineStateCreateInfoEXT structure included in the
pNext chain of pRasterizationState is
VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT or
VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT and if rasterization
is enabled, then the alphaToCoverageEnable, alphaToOneEnable, and
sampleShadingEnable members of pMultisampleState must all be VK_FALSE.

This CL adds the additional checking to
GraphicsPipelineDesc::initializePipeline() to ensure those conditions
are met before setting lineRasterizationMode to
VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT.

Bug: angleproject:5613
Test: StateChangeTest.AlphaToCoverageEnable
Change-Id: Ie2286078f6916c01a19ae6f932321a86619bd4e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2694094Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

Test: Capture and replay ES 3.2 apps
Bug: angleproject:5652
Change-Id: I2dac84d3cf6534ee1b10889ba1312ae247ae8f62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698391Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

The test has been failing on that configuration since it was introduced.

TBR=syoussefi@chromium.org
Bug: angleproject:5655
Change-Id: If852bcd574fa0cd4018220b7d6749b95a717a7c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698117Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

https://chromium.googlesource.com/vulkan-deps.git/+log/a1175c67dd67..0d42e83928f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies:
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/5789e3eed9..6f1f6775f3
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c79edd260c..05cda81aba
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6952dfcc1d..88ea55de92
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c62432713f..74aa762a95

Bug: None
Tbr: cwallez@google.com
Change-Id: I92bea4c6872f41614df4ec5216e9c0944b1c7898
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699422Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/539ef8e9426e..bb04803b8daf

2021-02-16 gavinmak@google.com Move metadata in OWNERS files to DIR_METADATA files
2021-02-16 amaiorano@google.com Remove uses of deprecated CreateAlignedLoad/Store builders
2021-02-16 sugoi@google.com Enable the sampleRateShading feature
2021-02-16 amaiorano@google.com vk-unittest: fix crash when unloading shared lib twice
2021-02-16 amaiorano@google.com Expose VK_EXT_headless_surface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I9b992002704a615546ce101bbff1e361baadc88f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699912Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/a04f3d444779..794086037940

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/bc28354170..43c1e3a98a
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/228b1c1883..fe293b0f5a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/838c3f15ee..dc82acba81
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..832539cc4d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbe0d801bb..6ec6688f3b
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f473fa69fa..bd7d7f71cf
* tools/skia_goldctl/linux: IY5qc7Fm3l7ofSvX0tx81d_UYTMJ1cVFlXp3beXxGacC..sm5PB3-BZYObubxkNie_5-C1p_sD1rtSOFVIc8PLymYC
* tools/skia_goldctl/mac: sThAFNVmUGB1KLYyFvxlfBZgrQvQm8C1jpik4b8Eq6QC..O-zkkp_UNP-ZoPmmK4xpuqYw9tpNzRGuUCNFH8I9PzwC
* tools/skia_goldctl/win: AshRD0sQsymS9bHa8cDgrecFq4NCi98zUJ9TNnD054AC..0JpeSchnXAemMxcrvtlMxxr3uiYp4vpP_iKo4kKEfUoC
No update to Clang.

Bug: angleproject:4483
Tbr: cwallez@google.com
Change-Id: I65e46b68b3453d7db5aeba9ad60dc4d4d3eb4565
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699419Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

... and move it to handleDirtyGraphicsRenderPass.

Bug: angleproject:5528
Change-Id: I416b2fedb1cd924d04fa739aecb65193fd845f6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686441
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1. The xfb counter buffer barrier issued was wrong, following a typo in
   the spec.  This barrier is now correctly issued using the usual
   barrier APIs.
2. A mechanism was added to automatically pause/resume transform
   feedback when a program pipeline needs to be rebound.  This is
   incorrect as it misses the xfb counter buffer barrier.  The render
   pass is broken instead if transform feedback is active/unpaused and
   the program pipeline is changed.
3. The transform feedback counter buffers are now disposed of when
   transform feedback is ended.  This avoids an unnecessary barrier that
   this change would have otherwise incurred (and hence render pass
   break) in Manhattan which repurposes the same transform feedback
   object.

Bug: angleproject:5528
Change-Id: I1ffe8b4b8975645ba43afd70e9cdbb0765529da5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651647Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Created:
- WindowsSurfaceVk::getRotatedWidth()
- WindowsSurfaceVk::getRotatedHeight()
- RenderTarget::getRotatedExtents()
- ImageHelper::getRotatedExtents()
- ImageHelper::getRotatedLevelExtents2D()

Note: The FramebufferVk class doesn't use any of these methods

Bug: b/175793022
Change-Id: I64395688bfdb172d32853763743fc5f266a6b792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686102
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Bug: None
TBR: geofflang@chromium.org
Change-Id: I60fd6bc18d8c86087d7640eb1145d575c4008edb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697986Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

HardwareBufferImageSiblingVkAndroid, RenderbufferVk, SurfaceVk
and TextureVk all had similar code to initialize VkImage with
VK_KHR_image_format_list extension support. Consolidate all of
them into a helper.

Bug: angleproject:5520
Change-Id: Ib7ac582a35a26c0da15879e688bcaf0c2a92ea87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2692641Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

CLIENT_MAPPED_BUFFER_BARRIER_BIT_EXT requires a memory barrier: shader
buffer write -> host read.  According to the spec, the data is only
available after a call to glFinish or wait on sync:

> The application must call MemoryBarrier with the
> CLIENT_MAPPED_BUFFER_BARRIER_BIT_EXT set and then call FenceSync with
> SYNC_GPU_COMMANDS_COMPLETE (or Finish). Then the CPU will see the
> writes after the sync is complete.

When a buffer is written to by the GPU, ANGLE calls
onHostVisibleBufferWrite(), which ensures a "memory write -> host read"
barrier is issued at the end of the command buffer.

Additionally, persistently mapped buffers use
VK_MEMORY_PROPERTY_HOST_COHERENT_BIT, so there's no need for a call to
vkInvalidateMappedMemoryRanges.

As a result, there's nothing necessary in ANGLE to do for this barrier
bit.  Note that should persistenly mapped buffers start using
non-coherent memory, this barrier should imply a call to
vkInvalidateMappedMemoryRanges for the persistently mapped buffers.

Bug: angleproject:5070
Change-Id: Iaeae019dadfa659a47d2dac41c0c09f1c15e584b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689380
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>