Don't add the same node pointer to the AST more than once, and assign
the right symbol ids to symbol nodes.

BUG=angleproject:1490
TEST=angle_unittests, angle_end2end_tests

Change-Id: I3f00e9234245fe4b81a2388df3f83e13c4c24856
Reviewed-on: https://chromium-review.googlesource.com/559534Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

The patch fixes a compilation bug caused from having local variable
names clash with the variables names from a parent scope.

BUG=angleproject:1815

Change-Id: I3d23faaafdea9be503da99512b204d7a50a3b228
Reviewed-on: https://chromium-review.googlesource.com/571000Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This will give the browsers the ability to control the cache size,
query and populate the contents, and trim cache contents on memory
pressure.

BUG=angleproject:1897

Change-Id: I6edaa7d307b890223db98792d5b074e4a7fdfaa4
Reviewed-on: https://chromium-review.googlesource.com/563606
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This change added 'buffer' qualifier support in shader which
corresponds to ESSL 3.1 spec, session 4.3.7 'Buffer Variables'.

BUG=angleproject:1951
TEST=angle_unittests:BufferVariablesTest

Change-Id: I2ecb5317d5ea9d378a60b03f86bdae04dbd89e9f
Reviewed-on: https://chromium-review.googlesource.com/534960Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

TextureD3D_3D::copySubImage worked around missing functionality in D3D11
for copying a framebuffer directly to a texture storage but didn't handle
the case of a texture storage already existing.  This caused the image to
have out-of-date data before the new data was copied into it.  Simply copy
the data from the storage back into the image before performing the copy
from the framebuffer and then copy back to the storage afterwards.

TEST=conformance2/textures/misc/copy-texture-image-webgl-specific.html

BUG=angleproject:1815

Change-Id: I308d6a1d3ecbc738f7d0e232bece433e6b353638
Reviewed-on: https://chromium-review.googlesource.com/567199
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

If a storage already existed, it may have old data in it.  Check if the
image is dirty and copy the initialized memory into the storage before
copying data from the framebuffer.

TEST=conformance/textures/misc/copy-tex-image-and-sub-image-2d

BUG=angleproject:1815

Change-Id: Ic69c5519b2e09e4b62025b1bf413d2a71a4a2afb
Reviewed-on: https://chromium-review.googlesource.com/568410Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The only place it was being used was when parsing array declarators.
The declarator only needs to be added to the AST when the variable
has successfully been declared, so this usage was not necessary.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I05b8851cfdebc9253c9fda8b12733f23da604ca6
Reviewed-on: https://chromium-review.googlesource.com/569160Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Passing COLOR_ATTACHMENTm, where m is greater or equal to
MAX_COLOR_ATTACHMENTS, to a FramebufferTexture* function should
generate an INVALID_OPERATION instead of an INVALID_VALUE error.

BUG=angleproject:2106
TEST=angle_end2end_tests

Change-Id: I99045defcbe5eb2afefac1b45062ee4245f50dd3
Reviewed-on: https://chromium-review.googlesource.com/569966Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Implement TexStorage2DMultisample api for d3d part.

BUG=angleproject:1590
TEST=angle_end2end_tests --gtest_filter=TextureMultisampleTest*
TEST=angle_deqp_gles31_tests --deqp-case=dEQP-GLES31.functional.texture.multisample.negative.fbo_*

Change-Id: Icbfba45b9c2965af02b54dd4060b7b49970cb74b
Reviewed-on: https://chromium-review.googlesource.com/457161
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Collect static functions that are used to create nodes in AST
transformations into a single file.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I6f87422988fa088f2f4b48986e378a2909705cb7

Uniforms and attribute names have global scope, according to:
GLSL 1.017 sections 4.2.6, 4.3.3 and 4.3.4.
Thus, they can't have same names.

BUG=angleproject:2014

Change-Id: Ibeb064aca877e404a67b9e3e9b57a0cc42e86f9f

A first test verifies the validation of the extension, and a second
compiles a simple shader and checks the cache behaviour.

These tests don't currently run since the extension is disabled,
but they will start running as soon as we expose it.

BUG=angleproject:1897

Change-Id: Id4a76b83090712a267576069b711eeee29aa81dd

GL_INVALID_ENUM should be generated if the type or format arguments were
not valid for any ReadPixels command.  This validation should happen
before validating if the combination of format and type is valid.

TEST=conformance/reading/read-pixels-test

BUG=angleproject:2000

Change-Id: If49d69655f5ab0a3abbde58b49541c84249c1750

When the mip level was greater than the maximum, it could cause an
out-of-bounds read when trying to query the Texture's size and format
later in the validation.

BUG=740426

Change-Id: Ibd6c977981e5f8b7368c161b7969d9e916c6095b

Add static use information to struct fields that mirrors the static
use information on the struct itself. This way dynamically generated
HLSL doesn't need special handling for initializing fragment inputs
if they are structs.

This fixes a problem with the previous code where dynamically
generated HLSL ended up trying to initialize structs that are not
declared in the HLSL output because they were not being referenced.

BUG=angleproject:2104
TEST=angle_end2end_tests

Change-Id: I21283ce4fe26515d62d95e61f8155dc9a9b44cf1

Gather counters from each shader and group them according the
layout qualifier 'binding' into each buffer.

BUG=angleproject:1729
TEST=angle_end2end_tests:AtomicCounterBufferTest

Change-Id: I8d0cd0d2bf65be37c035b0e1540481c8bee0bae4

TEST=conformance2/textures/misc/copy-texture-image-webgl-specific.html

BUG=angleproject:1815

Change-Id: I146fcf97a9c90f07d6270672c5e44e05602eecf8

This instruments the plumbing for the extension without adding any
functionality or exposing the extensions string.

The extension text is also updated to reflect the new entry point
design and naming. Also this corrects a few mistakes.

This will be followed up by the tests (which won't run) and then
the extension functionality in ANGLE.

BUG=angleproject:1897

Change-Id: I5b009e23bc27da06b067375525bd6fc574027702

The validation was iterating over maxDrawBuffers attachments when
default framebuffers only have one attachment. Use the framebuffer's
drawBufferCount instead.

Also adds a regression test in the form of a WebGLComptibility test for
glClearBuffer with the default framebuffer.

BUG=angleproject:2091

Change-Id: I07ee524db1fcb8a99dab4043248c0885100fd216

The patch enables viewport selection for multiview rendering in the
GLSL/ESSL vertex shader through the use of the GL_NV_viewport_array2
extension. The AST is modified only for GLSL and ESSL to include the
viewport selection expression after ViewID_OVR's initialization.

BUG=angleproject:2062
TEST=angle_unittests

Change-Id: Iee05bb5a4b687ed53ddbdd466f1572227b1f0cde

Previously, arrays were being incorrectly accepted as array indices.
This was because the isScalar() check only checked that the type was
not a vector or matrix, but still returned true for scalar arrays.

This patch changes the isScalar() check so that it returns false for
arrays. This makes usage of the term "scalar" more consistent in the
shader translator. Most of the code using isScalar() was compatible
with this change. Code in util.cpp that used to assume that isScalar()
doesn't care about arrayness is refactored to work with the new
behavior.

BUG=angleproject:2102
TEST=angle_unittests

Change-Id: I2a7f4c30fca7917d1099d0400efe3de859338b2a

This includes asserts in TConstantUnion to reveal incorrect usage of
union - reading a different field of an union that has last been set
is undefined behavior in C++.

Existing issues with accessing incorrect fields of constant unions
are fixed.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: Idd6b7a871d73e2928f117a9348c92043612fab82

Most of the functions were just simple wrappers around node
constructors. Dropping this extra redirection makes the code simpler.

The fold() functions of node types are simplified, so that if the node
can't be folded the pointer to the node itself is returned. This makes
the code in ParseContext more straightforward.

The few remaining functions in Intermediate are a bit more complex so
they should be handled separately, but they'll be removed eventually
as well.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I85e11919d1f62358cfba9c011b841e32bc25402f
Reviewed-on: https://chromium-review.googlesource.com/563393Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This adds support in blit11::copyTexture for LUMA, LUMA_ALPHA, and ALPHA
formats as destinations. Added is handling for each case to match up
the corresponding shader. This required new premultiply and
unmultiply D3D11 shaders for some cases.

Changed copyTextureCHROMIUM validation to allow new formats.

Tests have been created to demonstrate using copyTextureCHROMIUM with
the new formats with default parameters, as well as with the
unpackPremultiply and unpackUnmultiply parameters.

BUG=:angleproject:2101

Change-Id: Id8cd303a46fe70710bc18172fc938552a6e4cfaf

The patch adds a function in MatchOutputCodeTest to get the position
of the first occurrence of an expression in the translated output code.
This can help design more complicated tests like a test which checks
for the order of simple expressions.

BUG=angleproject:2062
TEST=angle_unittests

Change-Id: I1249d4762c247848c4eec64ecb8c1357b5e8d40a
Reviewed-on: https://chromium-review.googlesource.com/563659Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

The copied data is not supposed to have sRGB conversions applied to it
when written to the destination texture but an sRGB SRV is used by Blit11.
Instead of creating multiple sRGB and non-sRGB SRVs for textures, simply
fall back to the CPU copy path for this format for now.

Clip color channels that should not exist in the destination texture
formats in Image11::CopyImage.  This works around issues with texture
formats with emulated channels.

TEST=conformance2/textures/image_bitmap_from_canvas/tex-2d-srgb8-rgb-unsigned_byte
TEST=conformance2/textures/image_bitmap_from_canvas/tex-2d-srgb8_alpha8-rgba-unsigned_byte

BUG=angleproject:1932

Change-Id: Ieeda3569f80d016fda781e7eb498acd3b97568d0
Reviewed-on: https://chromium-review.googlesource.com/559857Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

queueReplacement is always called to replace the node that's currently
being visited in the traverser. The currently visited node can be
fetched automatically from the traversal path so it can be removed
from parameters of queueReplacement.

BUG=angleproject:2100
TEST=angle_unittests

Change-Id: I62ab6d1cd9c0d2b4c260af9f7c85bc156fb3f349
Reviewed-on: https://chromium-review.googlesource.com/562336Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Two simple fixes to make libANGLE compile for Fuchsia:
1. Added stubs typedefs for platform-specific primitives in
   EGL/eglplatform.h for Fuchsia.
2. src/common/platform.h updated to define ANGLE_PLATFORM_POSIX on
   Fuchsia.

Change-Id: I5f053de46632ac3f12bb93e57eeb94c3a34c867c
Reviewed-on: https://chromium-review.googlesource.com/563758Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Using a depth buffer format requires that the DSV and RTV have equal
quality levels; otherwise, the bound render target will discard writes.

BUG=angleproject:1917

Change-Id: Ife25b0a8958fa2b31b43a0d877d27e440916a9bf
Reviewed-on: https://chromium-review.googlesource.com/560716Reviewed-by: Bryan Bernhart <bryan.bernhart@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The OVR_multiview specification states that gl_ViewID_OVR is visible
at each pipeline stage. Previously to this patch the ViewID_OVR
impostor was declared only in the vertex shader and occurrences of
gl_ViewID_OVR in the fragment shader were not being handled. The
patch addresses the issue by declaring the ViewID_OVR variable as
a vertex output in the vertex shader and as a fragment input
in the fragment shader.

BUG=angleproject:2062
TEST=angle_unittests

Change-Id: I895953e81d3632d9bb873e8ac081fdf36f63f6b7
Reviewed-on: https://chromium-review.googlesource.com/559337
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>