Skip to content

A
angle
Switch branch/tag
  1. 25 Sep, 2018 5 commits
    • Fix issues with clearing deleted attachments · 4ebd8f3d
      Olli Etuaho authored 
      Deleting an object that was acting as a framebuffer color attachment
in the current framebuffer didn't previously update all of the
framebuffer state correctly. Fix this by going through the usual
resetAttachment path when any framebuffer attachment is deleted
instead of having custom code that only updated part of the state.

Also early out from clearbuffer calls in case of a missing color
buffer - even now that the draw buffer mask is being updated correctly,
some backend code doesn't take it into account. One example is
querying attachment format when the SRGB clear for linear framebuffer
attachments workaround is active.

BUG=angleproject:2831
TEST=angle_end2end_tests

Change-Id: I1071a60dc0251946fed00e88e43a244fe59f4863
Reviewed-on: https://chromium-review.googlesource.com/1235656Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    • Prevent crash in robust access mode when buffer has no data · 7620c739
      Olli Etuaho authored 
      This fixes a crash appearing in robust access mode when a buffer has
no data by stopping the draw call.

A better fix would be to ensure that fetches from an empty buffer
result in zero, but this fix requires a lot more effort. This is not
necessarily warranted since the client is either way doing something
incorrect in this case.

BUG=angleproject:2840
TEST=angle_end2end_tests

Change-Id: Ie4ef5b1ca7c0091d7d26f91678d6e4768cc0c650
Reviewed-on: https://chromium-review.googlesource.com/1238622Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    • Vulkan: Translate line loop indices from buffer. · 85c4b43e
      Frank Henigman authored 
      When a line loop is drawn with byte indices from a buffer, translate
to short.  Enable test.

BUG=angleproject:2802

Change-Id: Ie178ec866387be85b91291c28e1978db0a09c20a
Reviewed-on: https://chromium-review.googlesource.com/1237293Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
    • Avoid flush/invalidate of host-coherent memory · f5aad063
      Tobin Ehlis authored 
      For DynamicBuffer avoid calling vkFlushMappedMemoryRanges() or
vkInvalidateMappedMemoryRanges() if the underlying memory is host-
coherent. These calls are not required for host-coherent memory and
may negatively impact performance.

When currently allocating HOST_VISIBLE memory it's possible to also get
HOST_COHERENT memory even though it's not explicitly requested. Because
of this, the change updates the memory allocaiton interfaces through
the stack to pass back the actual allocated memory properties so that
it can be checked to see if it's host-coherent.

Bug: angleproject:2804
Change-Id: Ife95c4b98115b16d16c087dd72dba7d9661fdb46
Reviewed-on: https://chromium-review.googlesource.com/1234276
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
    • Vulkan: Merge append/beginWriteResource. · e2d2270a
      Jamie Madill authored 
      The new API is named 'recordCommands'.

These two APIs were basically doing the same thing. We don't need to
have an understanding of creating a new graph node to know that we
want to record some Vulkan commands to a command buffer. The prior
design was actually masking a bug where we would allow appending
commands to a command graph node that had already started a render
pass. Fix this by adding a render pass check to recordCommands.

Also removes 'hasStartedWriteResource' since this method wasn't used
anywhere.

Also renames 'onResourceChanged' to 'finishCurrentCommands'.

Bug: angleproject:2828
Change-Id: I00bd5b893fcfc37172b6c1706cb2f5fc57e79f54
Reviewed-on: https://chromium-review.googlesource.com/1235654
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
  3. 24 Sep, 2018 3 commits
  5. 22 Sep, 2018 1 commit
  7. 21 Sep, 2018 8 commits
  9. 20 Sep, 2018 2 commits
  11. 19 Sep, 2018 10 commits
  13. 18 Sep, 2018 5 commits
  15. 17 Sep, 2018 6 commits