Commits · 4fb29e83e02c5152ebc60733eb5351ea98c7097d · Chen Yisong / angle

11 Dec, 2020 7 commits

authored Dec 08, 2020

Bug: angleproject:5417
Change-Id: Idc058fe7b66f89bdbf8bcccc453ec15a3c5066e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2579749Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4fb29e83

Fix link validation with ambiguous instanceless interface blocks · 8326b26a

authored Dec 11, 2020

The following interface blocks should fail link:

    VS:
    layout(binding=0) buffer BufferBlockNameA
    {
        mediump float variable;
    };

    FS:
    layout(binding=1) buffer BufferBlockNameB
    {
        mediump float variable;
    };

Because `variable` is ambiguous.

Bug: angleproject:3580
Change-Id: I29576a6f152780819af0e9fb63249dbee7d9f2fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587450Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8326b26a

Roll VK-GL-CTS from 41331850eb21 to 54509765b18d (18 revisions) · d9318acc

authored Dec 11, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/41331850eb21..54509765b18d

2020-12-10 boris.zanin@mobica.com Basic tests for VK_EXT_conservative_rasterization
2020-12-10 ari.suonpaa@siru.fi Add test for image copy special case
2020-12-10 mikko.tiusanen@siru.fi Add tests for GLES3 vector construction from other types
2020-12-10 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master
2020-12-09 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2020-12-09 ari.suonpaa@siru.fi Add drawing tests for Android hardware buffer based color buffer
2020-12-09 rgarcia@igalia.com Test data spilling and unspilling around RT shader calls
2020-12-09 dominik.witczak@amd.com Add new tests that verify IgnoreIntersection/TerminateRay corner cases.
2020-12-09 rgarcia@igalia.com Test maxPipelineRayRecursionDepth can be zero
2020-12-09 gleese@broadcom.com Enable YCbCr filtering tests for non-separable chroma
2020-12-07 slawomir.cygan@intel.com Fix clang 10.0 build of ray tracing control flow tests
2020-12-07 slawomir.cygan@intel.com Remove merge conflict markers from mandatory_features.txt
2020-12-07 jan.mroczkowski@mobica.com Vulkan Portability support
2020-12-07 piotr.byszewski@mobica.com Disable conflicting fragment shading rate features
2020-12-07 alexander.galazin@arm.com Update Vulkan headers
2020-12-07 tzlatinski@nvidia.com Select SPIR-V for the robustness' compute shaders
2020-12-07 rgarcia@igalia.com Fix buffer offsets in push descriptor tests
2020-12-07 rgarcia@igalia.com Destroy deferred ops before destroying devices

Bug: angleproject:5461
Change-Id: I86f70ea9b77c114ed9495215d83a6fee61adc76a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2586995Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d9318acc

Roll SwiftShader from d94a77b304f4 to 0a64a9747555 (3 revisions) · a77bc1f1

authored Dec 11, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/d94a77b304f4..0a64a9747555

2020-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d94a77b3
2020-12-10 nicolascapens@google.com Update dEQP/Cherry setup documentation
2020-12-10 sugoi@google.com Context refactor: from OpenGL-like state to Vulkan-like state

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia5b74096de8b8c78e399bc97cbb39e4876fc2ef0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2586893Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a77bc1f1

Roll Chromium from 2db43e774b6e to 0c234289aa72 (451 revisions) · 7d832edd

authored Dec 11, 2020

https://chromium.googlesource.com/chromium/src.git/+log/2db43e774b6e..0c234289aa72

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/603673306a..1f2c9c8502
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/19df48277a..c51df537ee
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d5e21940e0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b07b7cb6aa..2a0543f912
No update to Clang.

Bug: angleproject:5174
Tbr: syoussefi@google.com
Change-Id: I9385c8ed5bd7d7cb6448fac1509b9a24ad7a7f98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2586566Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7d832edd

Add a scissored MSRTT test · ec1ff8f5

authored Dec 09, 2020

Covers a bug Skia's implementation of unresolve uncovered. ANGLE's
implementation is slightly different (in that the unresolve pass is full
screen), so it's not affected by this bug.

Bug: angleproject:4836
Change-Id: Ibc8010b0b5ef6912a45fd5f2612fb8b619e4407e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2582707Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

ec1ff8f5

Vulkan: Generalize FlipRotationSpecConst to SpecializationConstant · c75473c2

authored Nov 23, 2020

Specialization constant are used not just for flip/rotation. It also
used for other things. This CL merges all specialization constant usage
(lineRasterEmulation, flip, rotation, halfRenderArea) into one class and
rename FlipRotationSpecConst to SpecConst.

Bug: b/173800146
Change-Id: I8dc3354b6caedbb183cec29855fc1c301ec8872a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2555812
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

c75473c2

10 Dec, 2020 9 commits

Vulkan: clean up comments, rename per request · dcc0bebf

authored Dec 10, 2020

Bug: b/170312581
Change-Id: Iefecb5776cac07477266e6a2e77af7d3c9f38ad6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2585745Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

dcc0bebf

Docs: Add limitation for Android usage on all apps · 9912971c

authored Dec 10, 2020

ANGLE cannot be enabled for all apps on Android unless the
device has root access.

Test: Inspect the resulting markdown doc
Bug: angleproject:4347
Bug: b/175324620
Change-Id: Idc37d6062a12240cf038ef13f7d53d769fa824a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2585074
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

9912971c

Vulkan: Eliminate fence wait from SyncVk · 6d94471b

authored Nov 19, 2020

Waiting on a fence is problematic if using threaded worker to submit
work since code needs to know if the work has been submitted or not
before doing the wait.
Eliminate the wait by using a serial if available or if no serial check
the file descriptor directly. If no serial it's because we are waiting
on an imported file descriptor. Could call fence.wait in that
case but can also wait on the file descriptor.

Test: angle_end2end_tests --gtest_filter=EGLSyncTest.*/ES2_Vulkan

Bug: b/170312581
Change-Id: I392a5e73ac8f851d0d5bc53f06063568c0c90d2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2579042Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

6d94471b

Vulkan: Support XFB in non-Vertex stages. · f6df8692

authored Dec 09, 2020

This updates the code in several places to support Geometry and
Tessellation Evaluation shaders to output transform feedback.

Does not turn on any new tests but enables support for XFB when we
turn on GS/TS.

Bug: angleproject:3571
Bug: angleproject:3572
Change-Id: I6dcb768f2df4eeee81a4a500e999fcf16716f58f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2581941Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f6df8692

Add an option to copy the artifact to vendor partition · 8707811d

authored Dec 01, 2020

Add a --copy-to-vendor-partition optional argument to both roll_aosp.sh
and generate_android_bp.py. When specified the root targets will be
generated with vendor: true and a relative install path to egl folder,
so that we can use ANGLE as the Android OpenGLES driver when the system
starts up.

Test: run roll_aosp.sh --copy-to-vendor-partion, build the Android image
with m -j72, load the image with the Android emulator and find all ANGLE
related *.so's are under the /vendor/lib/egl folder.

Bug: angleproject:5456
Change-Id: I38c64e8ea3ad5f5d0cc0b8cd77856f49109b23c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568907
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

8707811d

Increase internal max uniform blocks limit to 60. · 4d9157a5

authored Dec 09, 2020

This will make space for the tessellation / ES 3.2 limit of 60 blocks.

Bug: angleproject:3572
Change-Id: Ie6cc6b24bdce2f5f67f62d11cdeefb10f3bd01d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2582708
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

4d9157a5

EGL: Update EGL headers/xml · 108b759e

authored Dec 04, 2020

The new EGL headers introduced 'EGL_NO_X11' which we could use
for ANGLE vulkan display/headless backend.

Changes in CL:

1. Updated include/EGL/egl*.h and scripts/egl.xml based on latest
   EGL repo: https://github.com/KhronosGroup/EGL-Registry
   Note: local modifications to the file were preserved in
   eglext.h, search keyword 'eglext_angle.h' for detail
2. run scripts to update entry_points/loader
   scripts/generate_entry_points.py
   scripts/generate_loader.py
   scripts/run_code_generation.py
3. Update ANGLE code on API 'eglSwapBuffersWithDamage'
4. Format with 'git cl format'

Bug: angleproject:5260
Change-Id: I70ed0dccecf0426929ef8b4775605554d66c5724
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2576314
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

108b759e

Roll SwiftShader from 84b9bb6621c7 to d94a77b304f4 (9 revisions) · 32f1a8e8

authored Dec 10, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/84b9bb6621c7..d94a77b304f4

2020-12-10 natsu@google.com Set prefersDedicatedAllocation for AHB
2020-12-09 natsu@google.com Treat AHB YUV as external format
2020-12-09 natsu@google.com Handle AHARDWAREBUFFER_FORMAT_YV12
2020-12-09 srisser@google.com Update SPIR-V version to VK_1_1_SPV_1_4
2020-12-09 natsu@google.com Handle VkExternalFormatANDROID in VkCreateImage
2020-12-09 srisser@google.com Add decorate operations new to SPIR-V 1.4
2020-12-09 natsu@google.com Handle more image properties from external device memory
2020-12-09 natsu@google.com Update AHB default YUV dataspace to YCBCR_709
2020-12-09 sugoi@google.com Make Constants a singleton instead of a global

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I31d0f7881c632d0402133b7bf26b7510066e49df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2583417Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

32f1a8e8

Roll Chromium from 3fc522ff6579 to 2db43e774b6e (469 revisions) · 55b7f38f

authored Dec 10, 2020

https://chromium.googlesource.com/chromium/src.git/+log/3fc522ff6579..2db43e774b6e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7c664f9cb5..603673306a
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/86a7f72ab1..ea9f1f7375
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7534b563e9..19df48277a
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/29b47fedf0..dfe5e0a3af
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d5e21940e0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1424e1194e..b07b7cb6aa
* tools/skia_goldctl/linux: U9IAKman_wN6alsQfNAUzIasErQFGDvx3wn9o0AQBlEC..bTvIvWnbZxg0-7ukJDOeVphyUCuVIkxtui-gilfeBScC
* tools/skia_goldctl/mac: xF94ClStkjWlYHAlxYXSOCFYEGhzEgxZEwB4zirJIjUC..6s5TRj110nqaPlBS8YO4HN2dRmhheX7a-pp3YWURcnoC
* tools/skia_goldctl/win: HYgBDvuNpEKiDYuVIssmP2wgCGe0FS-XKCe18wxZWKwC..4UEZlBTjAOzFCQchRqtALQwJDyYXa9Sj_52oUhXmNkoC
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ic8bd7ed7e2b78a2c3f5358a8ef70022532631ef6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2582428Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

55b7f38f

09 Dec, 2020 11 commits

Reland "Vulkan: Use specialization constant for halfRenderAreaWidth" · 067a12f0

authored Nov 19, 2020

This is a reland of ff38106d

Original change's description:
> Vulkan: Use specialization constant for halfRenderAreaWidth
>
> halfRenderArea is used by fragment shader to adjust gl_FragCoord for
> rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
> shader via specialization constant, thus allow compiler to consolidate
> the calculation into one MAD instruction.
>
> Bug: b/173800146
> Change-Id: Id66301278e3389e2582369b695825e632bccecee
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: b/173800146
Change-Id: Ifc36086f4c5d6a44fb5456aa6e31bc8a783bba71
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2579648
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

067a12f0

Vulkan: Add dirty bits instead of direct access FBO state · 1788355b

authored Dec 08, 2020

The CL crrev/c/2551541 causes intermittent Bot failure. I believe the
problem is that from ContextVk::onMakeCurrent call stack, the object
state may not in sync or even not completely specified. So instead of
accessing fbo state object here to update mGraphicsPipelineDesc, we
should insert dirty bit and let state validation code to handle it.

Bug: b/175157604
Change-Id: I5f6b9fd901cc4187068f6161bd12836c8bbf8e87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2580914
Commit-Queue: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1788355b

Suppress test requiring VK_EXT_transform_feedback on Nvidia/win7 · f9f569e2

authored Dec 09, 2020

Bug: angleproject:5450
Bug: angleproject:5435
Change-Id: I1925a4f926d10c81e5c69cfc62fcb26da2cec81d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2581940
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

f9f569e2

Add VK-GL-CTS autoroller link to wrangler doc · 855c5f1c

authored Dec 09, 2020

Bug: angleproject:4760
Change-Id: Id69f917c27dd2e2b85f434cc19002e644f42a44c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2582465Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

855c5f1c

Fix varying packing of I/O block fields · 8789457d

authored Dec 09, 2020

The sorting algorithm didn't keep the fields in order, which made them
receive arbitrary locations.  The SPIR-V transformer assigns the
location on the whole block instead of individual members, which was
incorrect in this situation.

The SPIR-V transformer could have been modified to decorate each field
of the I/O block with a location.  This change instead sorts the fields
in such a way that I/O block fields are allocated contiguously, which
allows the SPIR-V transformer to function unchanged.

Bug: angleproject:3580
Change-Id: I27df9e8122dd4207835bad448ffb8015692a1635
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2581076Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8789457d

D3D: throw a perf warning for uniform block · 378653f8

authored Nov 20, 2020

We had translated an uniform block only containing a large array member
into StructuredBuffer instead of cbuffer on D3D backend for slow fxc
compile performance issue with dynamic uniform indexing.
This patch throw a warning if a uniform block containing a large array
member fails to hit the optimization.

Bug: angleproject:3682
Change-Id: I33459b559923f16a8dfb70c6f46ec52f68d96e06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552365
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>

378653f8

Roll Chromium from a3984b7ec4ae to 3fc522ff6579 (498 revisions) · f0f79e08

authored Dec 09, 2020

https://chromium.googlesource.com/chromium/src.git/+log/a3984b7ec4ae..3fc522ff6579

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/115823df49..7c664f9cb5
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6302c11756..86a7f72ab1
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/baeb2e9897..7534b563e9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e43bd0925d
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/bbb828223e..e9a659a09e
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/dddd39ba5a..1424e1194e
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I5e6c022f18dc7c65a354ecc92babe20cde75167f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2581380Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f0f79e08

Don't output matrix qualifiers in I/O blocks · 8b851562

authored Dec 08, 2020

row_major and column_major only apply to uniform and buffer interface
blocks per GLSL ES 3.2 spec.

Bug: angleproject:3580
Change-Id: Iad0afeffc7ddb7bff2ebaec0ea0ec4eda26171a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2580191
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

8b851562

Vulkan: Fix query pause on framebuffer binding change · 36f74334

authored Dec 03, 2020

When a render pass is closed, render pass queries are paused.  The code
that pauses queries however is conditioned to the render pass being
open.  In ContextVk::syncState, when processing
gl::State::DIRTY_BIT_DRAW_FRAMEBUFFER_BINDING, `onRenderPassFinished()`
is called. Later on, when the render pass is actually finished, the
queries are not paused.

This change moves the logic to pause render pass queries to
onRenderPassFinished().

Bug: angleproject:5427
Change-Id: I3a87db2e4543ff698803ac5e154a370e85ac7985
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2573581
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

36f74334

Enable ComputeShaderTest/DrawDispatchDispatchDraw on Intel/Win/Vulkan · 54d95994

authored Dec 09, 2020

This patch enables ComputeShaderTest/DrawDispatchDispatchDraw on
Intel/Win/Vulkan after the upgrade of Chromium try bots.

Bug: angleproject:3871
Change-Id: I3e8d36020cbb01304a7b024d5b74923640402b4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2580112
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

54d95994

Fix build when angle_has_build == false · 27e52ca0

authored Dec 08, 2020

Need to declare use_xcode_clang when building outside chromium.

Bug: angleproject:5440
Change-Id: I4d622c1b6085d89b69c828b2c965d22c1f806f45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2579750Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

27e52ca0

08 Dec, 2020 13 commits

Vulkan: Support PrimitivesGenerated query · f691b3b5

authored Dec 02, 2020

This query uses the Vulkan transform feedback extension.  In GL,
GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN and GL_PRIMITIVES_GENERATED
queries can be independently begun/ended.  However, Vulkan requires that
queries from pools of the same type can only be active one at a time.
This forbids the two GL queries from being handled by two VK queries
when they are simultaneously begun.

This change makes these queries share their QueryHelper objects.  The
Vulkan transform feedback queries unconditionally retrieve both results
anyway, so this is just a matter of making sure the two GL queries are
merged as one when they are simultaneously used.

The change fixes a number of issues as collateral:

- TransformFeedbackPrimitivesWritten queries when !emulated were not
  released
- Stashed queries were never released
- If no render pass is open when a query ends, then getResult(no_wait)
  ended up waiting

Bug: angleproject:5404
Change-Id: I8ce13ea76ffd31b3152ded7c713c6466d0315504
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2573580
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f691b3b5

GLX: Expose EGL_ANGLE_window_fixed_size · fa9b803e

authored Dec 03, 2020

Right now the GLX backend checks for resize on every SwapBuffers
call. If EGL_ANGLE_window_fixed_size is used, it will only resize
when signaled by Chrome.

Bug: chromium:1132827
Change-Id: Ia4ddbbbf6dcf13f46ad564208eccc517de8be33c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572886Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

fa9b803e

Vulkan: Add ensureSubmission to queueSubmitOneOff · aafcb504

authored Dec 08, 2020

Some callers of queueSubmitOneOff require that the command being queued
to have been sent to the GPU. The new ensureSubmission parameter
indicates that behavior and when running with threaded worker will wait
for the worker queue to empty before returning.

Bug: b/170312581
Change-Id: Ib620fb37f4b9b4431451ccbd10807c0dff1842af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2579041Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

aafcb504

Log to stderr for warnings and more severe messages. · b1f094eb

authored Dec 04, 2020

This helps the WinCairo port of WebKit use ANGLE; warning messages
sent to stdout are causing layout test failures.

Bug: angleproject:5432
Change-Id: Idc6d3061a2dbf13d5f118285aa9b8438542966aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2576038Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

b1f094eb

Fix location validation for I/O blocks · 158089fd

authored Dec 07, 2020

I/O blocks can specify location for each member of the block separately,
in arbitrary fashion.  This change fixes up the code that validates
varying locations to take this into account.

Bug: angleproject:3580
Change-Id: If883347fc5db9f18722e41938d1b61fa64650d0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578047Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

158089fd

Vulkan: Add debugging code for SPIRV transformer. · 56f4a501

authored Dec 07, 2020

Requires a custom define for output.

Bug: angleproject:3572
Change-Id: I3721c4067c61f3e22ce7c047054b74d3fe468d8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578058Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

56f4a501

Vulkan: Fix validation errors with YUV · bcdd4e58

authored Nov 03, 2020

Had several validation errors with YUV ImageTests using Vulkan back-end.
This corrects those issues and tests now pass.

Initializing YUV AHardwareBuffers requires Android API 29. The CI bots
are not yet to Android 29 so this must be tested locally by compiling
with the appropriate api level in args.gn:
android32_ndk_api_level = 29
android64_ndk_api_level = 29

Test:
ImageTestES3.SourceYUVAHBTargetExternalRGBSampleInitData

Note: Some tests can run at api 26:
ImageTestES3.ClearYUVAHB
ImageTestES3.YUVValidation

Bug: angleproject:4852
Bug: b/172649538
Bug: b/175021871
Change-Id: I383d24faa9911f77a71bd9b764232ad519b54e9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2530454
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

bcdd4e58

Refactor varying location count and validation · 73d4d9fa

authored Dec 07, 2020

In preparation for support for mid-block location qualifiers.

Bug: angleproject:3580
Change-Id: Ia63f20c8dc26e8f0e90371c4f00913585a22267a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2577983Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

73d4d9fa

Roll SwiftShader from 7c84426d2abe to 84b9bb6621c7 (2 revisions) · 4f26a81e

authored Dec 08, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/7c84426d2abe..84b9bb6621c7

2020-12-07 ynovikov@chromium.org Add status host to CQ config
2020-12-07 sugoi@google.com Fix some minor tracing mistakes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: If0873584f3e5416e734c499111d7741dbab8592e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578666Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4f26a81e

Roll glslang from dd69df7f3dac to c594de23cdd7 (1 revision) · d9ffa8d8

authored Dec 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dd69df7f3dac..c594de23cdd7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia325f50d8b8b700c6eb14a261f4ddf4ef57f4614
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578665Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d9ffa8d8

Roll Chromium from bbe26af29575 to a3984b7ec4ae (468 revisions) · a13f6847

authored Dec 08, 2020

https://chromium.googlesource.com/chromium/src.git/+log/bbe26af29575..a3984b7ec4ae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b7fc8c9ce5..115823df49
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/95c0c5beb0..baeb2e9897
* third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/ad4fc19d61..2bb7b23b63
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e294aea80..29b47fedf0
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4565794f5e
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/500b2c2243..129acc201e
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c29ee8c9c3..2c183c9f93
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9ec0bb3220..36810de981
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/58c3aa7c7b..dddd39ba5a
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I44b0fdc9faf8d3bf5d978cdd1a210b10dcabbaef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2578642Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a13f6847

Suppress flaky multithreading swiftshader test · 4f315dcc

authored Dec 08, 2020

Bug: angleproject:5439
Change-Id: I218a4459897a9d543269effeea4caf05174e1589
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2577984Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4f315dcc

GL: Expose OES_shader_io_blocks · e59d8716

authored Dec 07, 2020

As extra validation that new tests are indeed correct.

Bug: angleproject:3580
Change-Id: I4792bd8e26f96ab6c988f2605f053ce5789a782f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2577818Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e59d8716