BUG=407309

Change-Id: Ic59bea88f0a4d7a6df9089238be0c79d654016e2
Reviewed-on: https://chromium-review.googlesource.com/269971Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The first bug was a result of constant-folding a vector swizzle that
was out-of-bounds. The second bug was a result of using a semicolon
in a preprocessor define.

BUG=angleproject:1425

Change-Id: Id6643b1f3e3b13cc021bd721ef2572487fe3c8d3
Reviewed-on: https://chromium-review.googlesource.com/357864Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Empty struct declarations with qualifiers are rejected by NVIDIA GL
driver version 367.27. For example this kind of construct that is
expected to be accepted by the WebGL conformance tests is rejected:

const struct a {
    int i;
};

Since qualifiers do not carry meaning unless a struct declaration
has declarators, they can be simply omitted from the translator
output in this kind of cases to work around this driver issue.

New unit test is added to check that pruning empty declarations works
correctly.

BUG=angleproject:1430
BUG=622492
TEST=WebGL conformance tests, angle_unittests

Change-Id: Id83f83124ae597fcdfa15100d336c2c207d9449c
Reviewed-on: https://chromium-review.googlesource.com/356362Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Certain warnings are suppressed in Chromium but not standalone ANGLE.
We should enable those warnings for ANGLE specifically, in a follow-up
CL.

BUG=angleproject:1382

Change-Id: I12491a61b0f349c5937a1e5d9985c8da1d76e0dc
Reviewed-on: https://chromium-review.googlesource.com/358107Reviewed-by: Jamie Madill <jmadill@chromium.org>

This implements instanced path rendering.

BUG=angleproject:1382

Change-Id: I4654251882975d707b22c7bb522af14ae34eb1a1
Reviewed-on: https://chromium-review.googlesource.com/355401Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Sami Väisänen <svaisanen@nvidia.com>

The MatchOutputCodeTest class makes it easier to implement tests that
do string matching on compiler output. Inheriting test classes set the
compiler settings, tests then call compile() with the shader string
and can call foundInCode() to check if the output code contains a
given string.

Various compiler unit tests that already did string matching are
refactored to make use of this new helper class. Some tests now use
SH_GLES3_SPEC instead of SH_GLES2_SPEC - this should not have a
significant impact on test coverage.

Some compileTestShader function variants that are now unused can be
removed from the code.

BUG=angleproject:1430
TEST=angle_unittests

Change-Id: I1fd3529d5a1c6ab192f95ace800cf162604e68e7
Reviewed-on: https://chromium-review.googlesource.com/357800Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

ANY_SAMPLES_PASSED and ANY_SAMPLES_PASSED_CONSERVATIVE queries can not
be active at the same time. The only place where the
State::isQueryActive function is used is validating whether a
BeginQuery call is correct, so it can be changed to check for this.

BUG=angleproject:1101
TEST=dEQP-GLES3.functional.negative_api.fragment.begin_query

Change-Id: Idadf129c6a036570f6e28857bdb24ffc11eeebe8
Reviewed-on: https://chromium-review.googlesource.com/356363Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Due to a bug in Adreno glTexImage2D with GL_UNPACK_SKIP_IMAGES.

BUG=angleproject:1429
TEST=Texture2DTestES3.UnpackSkipImages2D

Change-Id: Iccb4cc968915a623f0aed099b81e759c6e4343f7
Reviewed-on: https://chromium-review.googlesource.com/356494Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Due to Adreno bug in compiling struct function parameter in shader.

BUG=angleproject:1427
TEST=SamplerInStructAsFunctionParameterTest
     SamplerInStructArrayAsFunctionParameterTest
     SamplerInNestedStructAsFunctionParameterTest

Change-Id: I979312885f2047e78b61530c97703854a4be1586
Reviewed-on: https://chromium-review.googlesource.com/356125Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Swarmed Nexus 5X bot.
Mirroring Android Release (Nexus 5X) from chromium.gpu.fyi

BUG=chromium:617848, chromium:534814

Change-Id: I773c6accd3b4023822ddb165556e3af11ff5c6b1
Reviewed-on: https://chromium-review.googlesource.com/356470Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

BUG=598924

Change-Id: If97dbaa782595997b815c70d14f079e0f0c3d82a
Reviewed-on: https://chromium-review.googlesource.com/356710Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1436

Change-Id: I4f6c2eaf4bcb2f85fe31c0e0112c0a9651d4ad70
Reviewed-on: https://chromium-review.googlesource.com/357161Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1435

Change-Id: I4964c84f76991c156dfe49c99dae873ab451c8ab
Reviewed-on: https://chromium-review.googlesource.com/357151Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The validation previously checked that two matrices in compound
multiplication are the exact same size, which isn't correct for
non-square matrices introduced in ESSL 3.00.

Instead, check that the matrix multiplication is valid and that the
resulting value has the same number of columns as the lvalue. The
number of rows in the result is taken from the lvalue so it doesn't
need to be checked.

BUG=angleproject:1431
TEST=angle_unittests

Change-Id: I6f32b7dc037d72c3c5cfdfffcda5d996e8450283
Reviewed-on: https://chromium-review.googlesource.com/356411Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This is more accurate, and doesn't break platforms with no pkgconfig,
e.g. Android.

BUG=angleproject:1297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_rel;tryserver.chromium.android:android_compile_dbg

Change-Id: Iafbd66a5e81467d2a5431c3bb1ddd26a837888e7
Reviewed-on: https://chromium-review.googlesource.com/356481Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Simply using the ReadPixels code paths to unpack the framebuffer into a texture
was insufficient for handling cases like LUMA or RGB textures that are emulated
with RGBA textures in D3D11.  Instead, read the framebuffer's data into a
buffer and then use the loading functions which are aware of the emulated
formats to write the data to the destionation.

Fix LUMA format structure's logic for reading colors.  They aren't supposed
to do any averaging logic.

BUG=angleproject:1095
BUG=483282

Change-Id: Iad91d193d4c824573d9e9cafd28cf456d2de8be5
Reviewed-on: https://chromium-review.googlesource.com/354482Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

TEST=deqp/functional/gles3/negativetextureapi.html

BUG=483282

Change-Id: Ifd9674c2d29dc7e3a5e620b7a043cdb38a923ca0
Reviewed-on: https://chromium-review.googlesource.com/356680Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Blit11 refactorings enable re-using some code for multisample resolve
blits. Also some Renderer11 refactorings to use TextureHelper11 make
the code more flexible for the multisample resolve, to come later.

BUG=angleproject:1246

Change-Id: Id0c168cef75b0f487cb3995a906f6473989edcd5
Reviewed-on: https://chromium-review.googlesource.com/354420Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Transform feedback varyings that were optimized out were still being unpacked
causing HLSL compilation failures.

This was triggering failures in the conformance2/state/gl-object-get-calls.html
test.

BUG=angleproject:1422

Change-Id: I297cccd5b99435dfb69a3c2b0fd3086b6ddf0b3a
Reviewed-on: https://chromium-review.googlesource.com/354590Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

It's acceptable to have the same object attached to muliple framebuffer
attachments if they are not being drawn to.

This was triggering failures in the conformance2/state/gl-object-get-calls.html
test.

BUG=483282

Change-Id: If088ccd9b1189f060dfa33ebbe4d82f1f47559b0
Reviewed-on: https://chromium-review.googlesource.com/354570Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Due to Adreno compilation failure of two arrays in single line declaration.

BUG=angleproject:1428
TEST=GLSLTest_ES3.InitGlobalArrayWithArrayIndexing

Change-Id: I05d7c6b3a0eef8c879edf4d9cf24cdec0a2a403c
Reviewed-on: https://chromium-review.googlesource.com/356217Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Don't assume bucket name to start with 'master.'.

NOTRY=True
BUG=chromium:617627

Change-Id: I4e634fd2f485ac06c8e06af2de0cd86dbf425e9b
Reviewed-on: https://chromium-review.googlesource.com/355990Reviewed-by: Jamie Madill <jmadill@chromium.org>

Pick up ozone source when use_ozone = true.
Don't link X11 unless use_x11 = true.

BUG=angleproject:1297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_rel

Change-Id: I94e6242189646c8a18b00436294bccdd4c5a8785
Reviewed-on: https://chromium-review.googlesource.com/352251Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

BUG=angleproject:1421

Change-Id: I08f0fa5f178c8d25cd2b02e75cf92759254aa918
Reviewed-on: https://chromium-review.googlesource.com/355020Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Due to Adreno bug in GL_HALF_FLOAT support

BUG=angleproject:1420
TEST=Texture2DTestES3.TextureLuminance16ImplicitAlpha1

Change-Id: Id9bc12da21048a557325f076202ec482675320e3
Reviewed-on: https://chromium-review.googlesource.com/354782Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Cast the second parameter of eglGetPlatformDisplayEXT() to the correct
type to stop compiler complaining.

BUG=angleproject:1297

Change-Id: I37260edbd0fb6b92c24b556b15ea8206295e12d4
Reviewed-on: https://chromium-review.googlesource.com/354740Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Check for null pointers so DisplayOzone::terminate() doesn't crash when
DisplayOzone::initialize() wasn't completely successful.

BUG=angleproject:1419

Change-Id: I70e994490a7282083d5289e6c35b077676688b65
Reviewed-on: https://chromium-review.googlesource.com/354700Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Because this builtin uses a structure, certain shaders could trigger
the mangled name to be allocated during normal shader compilation.
Then when the scope is popped, the mangled name for DepthRange is
freed, and we're left with a dangling pointer.

Fix this temporarily by enforcing mangled name construction when
we initialize the builtins, but we should look for a more robust and
future-proof fix.

BUG=620937

Change-Id: If130c8b48a18054502abaec08f10264f282b4925
Reviewed-on: https://chromium-review.googlesource.com/354494Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antoine Labour <piman@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

mbstowcs needs stdlib.h header on mipsel

BUG=

Change-Id: Ia93d0a877b2e22d5c1c461f0dea9999ede725520
Reviewed-on: https://chromium-review.googlesource.com/354020Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit 13511a9c.

Change-Id: Ic5a91d14b59204c5667940797742bc55a137f177
Reviewed-on: https://chromium-review.googlesource.com/354706Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

Add tryserver.chromium.linux:linux_chromium_gn_chromeos_rel to ANGLE CQ
to build test with use_ozone=1.

BUG=angleproject:1412

Change-Id: Ib4e851b95f7cfbb7099b531affccd14f08418725
Reviewed-on: https://chromium-review.googlesource.com/352318Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

BUG=621932
R=cwallez@chromium.org

Change-Id: I10b0fd5a668d74b7062747002bc48ef0e0a6df9c
Reviewed-on: https://chromium-review.googlesource.com/354302Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1418
BUG=angleproject:1340

Change-Id: I8930845a2d398440a78b2569daaf655b51a30ee9
Reviewed-on: https://chromium-review.googlesource.com/354261Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=None

Change-Id: I3e2e7e845e9ad3814f7d85e56c12023a5e2ef0df
Reviewed-on: https://chromium-review.googlesource.com/354104Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1382

Change-Id: I63925fb7eeff2bdab26c1e541afd9cd1851485e6
Reviewed-on: https://chromium-review.googlesource.com/354083Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

https://android.googlesource.com/platform/external/deqp/+log/cc0ded6c77267b..f4f3d8079e7a37d7

BUG=None

Change-Id: I863f81d2c4c3f48862cb821b23c38266987a82a2
Reviewed-on: https://chromium-review.googlesource.com/340260Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1416
TEST=conformance/extention/ in core profile
R=jmadill@chromium.org,geofflang@chromium.org,cwallez@chromium.org

Change-Id: I89b815929535586a2e90489129a1c6692bb87b3c
Reviewed-on: https://chromium-review.googlesource.com/353820
Tryjob-Request: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>

BUG=angleproject:1382

Change-Id: I9fd6e20b9487f9d7817865bc9129a60fc833d0ca
Reviewed-on: https://chromium-review.googlesource.com/354030Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1382

Change-Id: I586cd4a03d06a6ec87b6a57342b7f8d0ed0d9cd8
Reviewed-on: https://chromium-review.googlesource.com/354031Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1092
BUG=angleproject:1095
BUG=angleproject:1323

Change-Id: I58550f841febbfdf45133707f72e7f3a62b20a1c
Reviewed-on: https://chromium-review.googlesource.com/353343
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>