Commits · 5d0458fa5c2d2e8f35b58e345a0455c8d38cc13a · Chen Yisong / angle

26 Oct, 2020 13 commits

Vulkan: Add OES_shader_multisample_interpolation support · 5d0458fa

authored Oct 23, 2020

Support OES_shader_multisample_interpolation extension if
maxInterpolationOffset >= 0.5

Bug: angleproject:3589
Tests: dEQP-GLES31.functional.shaders.multisample_interpolation.*
       dEQP-GLES31.functional.state_query.multisample_interpolation.*
Change-Id: I42997f10be82e3be8b63c56833cbbf791bf4be9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477905
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

5d0458fa

Capture/Replay: Test improvements. · 5c4c37dc

authored Oct 25, 2020

Streamlines some arguments.
Use a common subdirectory in out/.
Show process name when logging.
Clean up environment variable handling.

Bug: angleproject:5247
Change-Id: I85eb5b8194a64f90691c4d03db3ee65c5e9b2313
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497560Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5c4c37dc

Roll Vulkan-ValidationLayers from 7d11021098f2 to 03f6ffd1dc46 (27 revisions) · 218a939e

authored Oct 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7d11021098f2..03f6ffd1dc46

2020-10-22 s.fricke@samsung.com layers: Label copy2 00212
2020-10-22 s.fricke@samsung.com tests: Check clearAttachment implict VUs
2020-10-22 s.fricke@samsung.com layers: Remove redundant implicit check
2020-10-22 locke@lunarg.com layers: Pref improvement
2020-10-22 locke@lunarg.com layers: Bug fixed
2020-10-21 locke@lunarg.com tests: VerifyDynamicStateSettingCommands
2020-10-21 locke@lunarg.com layers: VUID 02859
2020-10-21 locke@lunarg.com tests: Test Vertex Binding
2020-10-21 locke@lunarg.com layers: VUID-02721
2020-10-20 jbauman@google.com Revert "layers: Fix wrong if statement"
2020-10-20 locke@lunarg.com tests: Remove VUID-02686
2020-10-20 locke@lunarg.com layers: Remove VUID-02686
2020-10-20 s.fricke@samsung.com layers: Label VUID 04477
2020-10-20 s.fricke@samsung.com layers: Improve ValidateCmdQueueFlags message
2020-10-20 s.fricke@samsung.com tests: Remove clang 10 warning for string copy
2020-10-20 locke@lunarg.com tests: Push constant update
2020-10-20 locke@lunarg.com layers: VUID-vkCmdDraw-None-02698
2020-10-19 mark@lunarg.com stateless: Changed bool checks from warnings to errors
2020-10-19 jleger@qti.qualcomm.com layers: Remove unneeded validation checks
2020-10-17 locke@lunarg.com tests: Fixed 02686 bug
2020-10-17 locke@lunarg.com layers: Fixed 02686 bug
2020-10-16 mail@maltekliemann.com build: Fix Vulkan header/registry detection for SDK
2020-10-16 mark@lunarg.com corechecks: Fix QueryPoolIndex bug and remove query func
2020-10-16 mark@lunarg.com test: Added tests for QueryPoolResults VUIDs
2020-10-16 mark@lunarg.com layers: Added some QueryPoolResults VUID checks
2020-10-16 mark@lunarg.com tests: Add multiViewport/ViewportWithCount positive test
2020-10-16 mark@lunarg.com stateless: Account for DynStateWithCount for multiViewport

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com,syoussefi@google.com
Change-Id: I3a54b8d0e0bef06297a04f90001343dbc4f7fe10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2499261Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

218a939e

GL: Use ANGLE_GL_TRY for draw calls. · a12072ca

authored Apr 03, 2020

Bug: angleproject:3020
Change-Id: Id3ff1828a9a63f4efe6e85dc938a22dc6a782a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135926Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

a12072ca

Output nullptr pointer parameters correctly. · 5dafe107

authored Oct 25, 2020

Fix by piping all pointer value parameter output to const
void *, which has a custom handler.

This fixes a case where non-void pointers were being output
as (nil) or other values. Fixes the Capture/Replay tests for
many cases.

Bug: angleproject:5249
Change-Id: I20c9e605d9c5a36e36e7a3d6c753a4e0de94ac4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497563
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

5dafe107

Re-enable crash testing in angle_unittests. · 21add124

authored Oct 25, 2020

This is an experimental test to see if this works now.
Disabled on Win/ASAN because of conflicts with the
crash callback.

Bug: angleproject:5239
Change-Id: I280b18ab8846de79b561f26716df9ba374cfd9a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496040Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

21add124

Fix uninitialize state in ProgramState. · d6d07359

authored Oct 25, 2020

The variable mLocationsUsedForXfbExtension was never initialized
which would give it an undefined value for the lifetime of a
Program. This was causing the capture replay tests to be very
flaky.

Bug: angleproject:5248
Change-Id: Id8d61b88fb2ca2c6340acfe9d6e3720378528987
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497562Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d6d07359

Roll SPIRV-Tools from 69f07da41b3b to abe2eff36f3c (3 revisions) · dd2b644a

authored Oct 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/69f07da41b3b..abe2eff36f3c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I542d49c1c7327849f25f8d0cd5d35dc20986cecb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2498124Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dd2b644a

Roll SwiftShader from 8012e62471be to bb66fa41a163 (3 revisions) · b5ba6933

authored Oct 26, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/8012e62471be..bb66fa41a163

2020-10-24 amaiorano@google.com LLVMJIT: fix asserts in latest LLVM
2020-10-24 capn@google.com Support MemorySanitizer builds with CMake
2020-10-23 srisser@google.com Implement VK_KHR_shader_subgroup_extended_types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Id7a486cea4f2bfed1766d952ccad394389f53cba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2498125Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b5ba6933

Roll Chromium from 4787c9ad2595 to 5f7e3cf264a2 (303 revisions) · 08c34aef

authored Oct 26, 2020

https://chromium.googlesource.com/chromium/src.git/+log/4787c9ad2595..5f7e3cf264a2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/41d615a966..6da208edba
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/36edd70447..3a9713b0fd
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/fde3620a8a..d24a1910b9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7874beb5c5
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/151bbd685f..7371bff096
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: Ic50fa1ff5494279e23ff70a55a692bf6040e436b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2498005Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

08c34aef

Tests: Add Fate/Grand Order trace · 0cec8f74

authored Oct 23, 2020

TBR: jmadill@chromium.org,courtneygo@google.com
Test: angle_perftests --gtest_filter="*fate_grand_order*"
Bug: b/171582504
Change-Id: I09b421ee5a245474ed1c797e9049a2f379d8dc11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495542Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

0cec8f74

Tests: Add Dragon Ball Legends trace · 29ca7186

authored Oct 25, 2020

TBR: jmadill@chromium.org,courtneygo@google.com
Test: angle_perftests --gtest_filter="*dragon_ball_legends*"
Bug: b/171652453
Change-Id: I668232f3a1e7ca9663f481fb4246b44fb9333b4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497104
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

29ca7186

Tests: Add World of Tanks Blitz trace · 258f17d6

authored Oct 23, 2020

Test: angle_perftests --gtest_filter="*world_of_tanks_blitz*"
Bug: b/171446929
Change-Id: I028bfde50baa583f1ff7bf30ad77fe40026c7ca7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495486
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

258f17d6

25 Oct, 2020 7 commits

Revert "Vulkan: Make DescriptorPoolHelper a Resource" · 9e3eec54

authored Oct 25, 2020

This reverts commit 5dcd29a6.

Reason for revert: Breaking the ANGLE -> Chromium roller:

https://chromium-review.googlesource.com/c/chromium/src/+/2496281

Original change's description:
> Vulkan: Make DescriptorPoolHelper a Resource
>
> Descriptor pools need to live as long as the descriptor sets that are
> allocated from them. Using Serials while building a command to judge a
> pool's lifetime is prone to errors, since a command's Serial value
> isn't known until the command is submitted, leading to deleting pools
> too early relative to when the descriptor set is actually used.
>
> This CL updates DescriptorPoolHelper to inherit from Resource, so the
> descriptor pools can be retain()'ed. This allows the Resource's counter
> to indicate that a pool is in use until the command's Serial is known
> and can be recorded to indicate when the command completes. This
> prevents descriptor pools from being destroyed before the command
> completes (while the descriptor sets are still in use), or even before
> the command has been submitted. Destroying a descriptor pool resets all
> of the descriptors that were allocated from it, which can trigger a
> variety of VVL errors depending on when it's erroneously performed.
>
> This CL also adds the necessary retain() calls for the descriptor pools.
> In particular, the pools need to be retained each time a cached
> descriptor set that was allocated from it is re-used. This is relatively
> simple with the current design, since we always clear the descriptor set
> caches whenever a new pool is allocated, so the descriptor pool binding
> is always accurate.
>
> Bug: angleproject:5030
> Test: MultithreadingTest::MultiContextDrawSmallDescriptorPools()
> Change-Id: I5fdeeb46159448dfd679d7169e423048348be5ab
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2437609
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

TBR=courtneygo@google.com,timvp@google.com,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:5030
Change-Id: I0fd6d9a0e1b0989b22368ef98652281288699deb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497222
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9e3eec54

Skip flaky tests on Win7/NVIDIA/GLES. · 2d6b6026

authored Oct 25, 2020

CopyTextureVariationsTest.CopyTexture/ES2_OpenGLES__AToRGBFlipYUnmultiplyAlpha
CopyTextureTest.CopyOutsideMipmap/ES2_OpenGLES

Bug: angleproject:5246
Change-Id: I388df27c690d2a082741f2018690bf2fa24a7594
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497224Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2d6b6026

Adjust TestSuite test timeout values. · 4968245c

authored Oct 25, 2020

This should prevent flakiness in this test.

Bug: angleproject:5245
Change-Id: I841de2cee093ea04b35763314f0a4f5497bcf778
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497223Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4968245c

Re-land "Link C++ histogram support into angle_perftests." · acd15cae

authored Oct 11, 2020

This is the first step in uploading histogram data instead of a gtest
special format. We  importing several new libraries:

- tools/protoc_wrapper
- third_party/protobuf
- third_party/catapult (was already used for Android)

No functional change. Only affects compilation. Protobuf support is
disabled when not available.

Bug: angleproject:5161
Change-Id: I64be0977648993b1012ff0d9e0439c5876697e36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497221Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

acd15cae

Metal: Fix 2D array texture's robust resource init · 6422d3b4

authored Oct 25, 2020

2D array texture's robust resource init didn't work due to
mtl::InitializeTextureContents() expects one slice at a time, however
TextureMtl::initializeContents() created entire layers index via
GetZeroLevelIndex() before passing to mtl::InitializeTextureContents().
Fixed by changing to GetLayerMipIndex() instead.

Bug: angleproject:2634
Change-Id: Ie8d80d927a987c2b393d913fda8288b6e06e97d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494527Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>

6422d3b4

Metal: Implement sampler object & shadow compare mode · 9ff58e26

authored Sep 27, 2020

Note: GL_TEXTURE_COMPARE_MODE=GL_NONE is not supported on shadow sampler
for now.

Bug: angleproject:2634
Change-Id: I470bad6322e78ef1408e4334e1e778821df7cbf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433332
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

9ff58e26

Check for precision match of uniforms only if there is static use · f037cdc4

authored Oct 23, 2020

There are legacy apps that have uniforms declared with
different precisions across shaders. There is some wiggle
room in the ESSL spec to accommodate such cases as long as
the uniforms are not statically used in shaders. We choose
this lenient interpretation since it allows for more apps
to be compatible with ANGLE.

This change allows BADLANDS to progress past a black screen.

Bug: angleproject:4971
Tests: angle_end2end_tests
           --gtest_filter=GLSLTest_ES31.UniformPrecisionMatchValidation*
Change-Id: Icdd2056c8415803eb34f2840b0758e1acf53c23a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495493
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

f037cdc4

24 Oct, 2020 10 commits

Expand Mac XFB suppression. · 23c12db2

authored Oct 24, 2020

TransformFeedbackTest.RecordAndDraw/ES3_OpenGL

Bug: angleproject:4992
Change-Id: I42118bba63e32901c3213f9a4ac5b87f2ab209f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495698Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

23c12db2

Suppress failing Windows 7 test. · 9990a814

authored Oct 24, 2020

ClearTestES3.ScissoredClearHeterogeneousAttachments/ES3_D3D11

Bug: angleproject:5237
Change-Id: I3f3c062e23d77b4621df13ea75f7910ed22ab983
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496144Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9990a814

Disable timing out Vulkan GLES 1 test. · 259d14e5

authored Oct 24, 2020

This test is timing out on a Windows 7 config.

Test: GLES1ConformanceTest.AmbLight/ES1_Vulkan
Bug: angleproject:5234
Change-Id: I4c3ccdeb58d793952aaa44d4902dedf7ce192ec3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496142Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

259d14e5

Metal: Partially implement EXT_debug_marker · 37e84651

authored Sep 27, 2020

Partially implemented to make it easier to debug.
Only debug group is supported for now.

Bug: angleproject:2634
Change-Id: I029dd4283790fb57a6964aad89c37d092e3378e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433331
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

37e84651

Metal: Implement glRenderbufferStorageMultisample(ANGLE) · 1c881dad

authored Sep 27, 2020

Bug: angleproject:2634
Change-Id: Ia4dd477cfbad298994036705b43f3a5877e3c9cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433330
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1c881dad

Metal: Support integer textures. · 80d4901a

authored Sep 26, 2020

Bug: angleproject:2634
Bug: angleproject:5154
Change-Id: Iffea26fe2c683557b4fa7c13fddf3523294b47d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433329
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

80d4901a

Vulkan: Dirty pipeline and desc set after mid-RP clear with draw · 96714af8

authored Oct 22, 2020

If UtilsVk::clearFramebuffer issues a draw call on the currently open
render pass (as opposed to starting one itself), ContextVk would be
unaware of the fact that the graphics pipeline and descriptor sets have
been changed.

This change sets the necessary dirty bits for ContextVk to recover from
a UtilsVk::clearFramebuffer call.

Bug: chromium:1141040
Change-Id: I865220fb5b3b78bf4c6b6b2896e57d8a7490c270
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2493184
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

96714af8

Vulkan: Assert that attributes in shader info map are active · 62d010f9

authored Oct 22, 2020

Attributes that are not active shouldn't have made it to the
ShaderInterfaceVariableInfoMap of gl::ShaderType::Vertex. This change
turns a few ifs to ASSERT in SpirvVertexAttributeAliasingTransformer.

Bug: angleproject:4249
Change-Id: I3da4ea773eae20fe2f126b82f7790e9f2cab0bc1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2491929Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

62d010f9

Fixes to roll ANGLE into AOSP · e99b8bc0

authored Oct 23, 2020

Rolling ANGLE into AOSP requires the following fixes:

1.) Update scripts/roll_aosp.sh to not delete third_party/abseil-cpp.
2.) Update BUILD.gn to add a dependency on libnativewindow for
"angle_common".

Test: AOSP Presubmit
Bug: angleproject:5230
Change-Id: If97c44ce041e576edc7c0c43700030b4538e8ab5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495550Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

e99b8bc0

Tests: Remove standalone duplication. · 2f7fc0f3

authored Oct 23, 2020

Also cleans up some compiler warnings that crept in because of how
we structured the test sources in GN. We also no longer need special
handling for the test "main" files.

Must land after http://crrev.com/c/2495003 rolls into ANGLE.

Bug: angleproject:5124
Change-Id: I43ff91b5c8f00214886cd8ac2403702e5026a840
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495281Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2f7fc0f3

23 Oct, 2020 10 commits

Revert "Link C++ histogram support into angle_perftests." · 4953f03d

authored Oct 23, 2020

This reverts commit 7a026354.

Reason for revert: Breaks roll of ANGLE into AOSP:

ERROR at //testing/test.gni:76:5: Assertion failed.
    assert(_use_raw_android_executable || enable_java_templates)
    ^-----
See //third_party/catapult/tracing/tracing/BUILD.gn:35:1: whence it was called.
test("histogram_unittests") {
^----------------------------
See //src/tests/BUILD.gn:262:17: which caused the file to be included.
      deps += [ "//third_party/catapult/tracing/tracing:histogram" ]
                ^-------------------------------------------------

Original change's description:
> Link C++ histogram support into angle_perftests.
>
> This is the first step in uploading histogram data instead of a gtest
> special format. We  importing several new libraries:
>
> - tools/protoc_wrapper
> - third_party/protobuf
> - third_party/catapult (was already used for Android)
>
> No functional change. Only affects compilation. Protobuf support is
> disabled when not available.
>
> Bug: angleproject:5161
> Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=ynovikov@chromium.org,bsheedy@chromium.org,jmadill@chromium.org

Change-Id: I62c4b926cbe82d10e460b28b5f864521e2b1f8ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:5161
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495549Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

4953f03d

Roll Chromium from e203e4bcf072 to 4787c9ad2595 (240 revisions) · cbcb2f23

authored Oct 23, 2020

https://chromium.googlesource.com/chromium/src.git/+log/e203e4bcf072..4787c9ad2595

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a9415691b8..41d615a966
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d41923d558..36edd70447
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7874beb5c5
No update to Clang.

Bug: angleproject:5124,angleproject:5213
Tbr: jonahr@google.com,jmadill@google.com
Change-Id: I2f5ebf5c3734c1b4038aee0b986e4f250c6abf4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495488Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cbcb2f23

Suppress VUID-vkCmdDraw-None-02698 validation · 6a35cadc

authored Oct 23, 2020

A bug in Vulkan-ValidationLayers is stopping changes from being rolled
into ANGLE. Suppress this warning for now, until the root cause is
addressed.

Bug: angleproject:5191
Change-Id: I7c6cb65055bdc7b2eb3679f26f09530b1cff3775
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495543Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

6a35cadc

Test Runner: Only run watchdog in child processes. · 31868665

authored Oct 23, 2020

For single test execution we don't need to be running the watchdog
thread. This only serves to cause timeouts in slow running tests.

Adds a new method to keep the --batch-id argument in the list of
parameters so other functions can process them.

Bug: angleproject:5124
Bug: angleproject:5218
Change-Id: I958230149b7d79830802cd55f67f0190de607200
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495282Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

31868665

Vulkan: Refactor how finishToSerial() retires commands. · e86b4257

authored Oct 21, 2020

This cleans up some of the logic around command completion. We no longer
query each Fence in order after a finishToSerial call. Instead we clear
out all the commands that have been completed up to the latest Fence.

Also cleans up ordering code. Because we now have a linear ordering of
Serials we can validate the ordering is "good".

Attempt at solving a suspicious ASSERT firing on AMD Win7.

Bug: angleproject:5198
Change-Id: I7750eff7f8d3aff397e7880f997ad86c9bf7d7a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2490342
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

e86b4257

Vulkan: Drop RelaxedPrecision from aliased attributes · cb5c0b01

authored Oct 21, 2020

Take the following example:

    attribute mediump vec4 a; // location 0
    attribute highp   vec2 b; // location 0

    f(b)

This was previously translated to:

    attribute mediump vec4 a; // location 0

    f(a.xy)

That difference here is that b was previously highp, but a.xy is
mediump.  This change drops RelaxedPrecision from attributes so that
they are all highp.

Note that the temporary SPIR-V ids these attributes are loaded into
still retain their RelaxedPrecision decoration (if any), and the
precision of calculations in the shader is not increased by this
change.

Bug: angleproject:4249
Change-Id: Idca0fc667ad6e36ddf428b65ea03706272a9ed9c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2488131
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

cb5c0b01

Vulkan: Reduce scope of clear workaround · de3a7180

authored Oct 23, 2020

Forcing draw for clear only appears to be needed on Pixel 2.

Test: angle_perftest --gtest_filter="*free_fire*"
Bug: angleproject:4836
Change-Id: I4446adc04a8e5cf7b0bfef68ec70122e847755a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495484Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

de3a7180

Make capture replay tests exectuable. · 5ffd778e

authored Oct 23, 2020

This makes them runnable directly on Linux.

Bug: angleproject:5134
Change-Id: Icf5ccf9d82b8cf09b16c5c60312e33752a9724e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495288
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

5ffd778e

Vulkan: sRGB cleanups. · 33e30205

authored Oct 17, 2020

A few fixes to how we check for the sRGB override in the
TextureVk class. In at least one instance there was a potential
edge case where in syncState we might not create the Texture
with the mutable bit the second time through the function.

Bug: angleproject:5176
Change-Id: I4f1ca6e469b10514c3a0de3120be9ade62568084
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482292Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

33e30205

Trace Tests: Print trace download progress. · a7c16c2d

authored Oct 21, 2020

As the hook runs, we'll now be printing each trace's
progress. This uses some tricks with Python's subprocess.

Bug: angleproject:5210
Change-Id: I4e776a89c2b3e06ba67f9a82969aa394b24208d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2491104
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

a7c16c2d