Generates lots of assertion failures when run, expectations and assertion fixes
to come.

BUG=angleproject:1139

Change-Id: Ia55b4b2ca3a7844d8d9d05cb7043cd42d55b86ed
Reviewed-on: https://chromium-review.googlesource.com/295243Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1138

Change-Id: I0dd4e1a092e889cdb9de4773162e5416ac9be65d
Reviewed-on: https://chromium-review.googlesource.com/295242Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Use R and RG textures with swizzle states to emulate them. A manual blit is
required when calling CopyTex[Sub]Image from a RGB[A] framebuffer to an
emulated L[A] texture so that the alpha channel ends up in the correct channel
of the destination texture.

Fixes the following tests when using the core profile:
 * conformance/extensions/oes-texture-float.html
 * conformance/extensions/oes-texture-half-float.html
 * conformance/textures/misc/tex-sub-image-2d.html
 * conformance/textures/misc/texture-formats-test.html
 * conformance/textures/misc/texture-npot.html

BUG=angleproject:1113

Change-Id: If5540e66d9017596bd83d95ec3ede043cbcfe0d2
Reviewed-on: https://chromium-review.googlesource.com/293905Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

DrawElements' range was of the form [start, end] while DrawArrays' was
of the form [start, end), which caused an out of bound array access in
the client vertex pointers.

This issue was detected while running angle_end2end_tests with
AddressSanitizer.

BUG=angleproject:1137

Change-Id: Id9abddf29eaf73bacfd08d1616a999be2fe616b8
Reviewed-on: https://chromium-review.googlesource.com/295122Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

HLSL doesn't support dynamic indexing of matrices and vectors, so replace
that with helper functions that unroll dynamic indexing into switch/case
and static indexing.

Both the indexed vector/matrix expression and the index may have side
effects, and these will be evaluated correctly. If necessary, index
expressions that have side effects will be written to a temporary
variable that will replace the index.

Besides dEQP tests, this change is tested by a WebGL 2 conformance test.

In the case that a dynamic index is out-of-range, the base ESSL 3.00 spec
allows undefined behavior. KHR_robust_buffer_access_behavior adds the
requirement that program termination should not occur and that
out-of-range reads must return either a value from the active program's
memory or zero, and out-of-range writes should only affect the active
program's memory or do nothing. This patch clamps out-of-range indices so
that either the first or last item of the matrix/vector is accessed.

The code is not transformed in case the it fits within the limited subset
of ESSL 1.00 given in Appendix A of the spec. If the code isn't within
the restricted subset, even ESSL 1.00 shaders may require this
workaround.

BUG=angleproject:1116
TEST=dEQP-GLES3.functional.shaders.indexing.* (all pass after change)
     WebGL 2 conformance tests (glsl3/vector-dynamic-indexing.html)

Change-Id: I024722ef4ca1e14d5ad47fdc540397e18858bed6
Reviewed-on: https://chromium-review.googlesource.com/290515Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

The register assignment stuff only applies to the D3D back-end.
Cleans up the GL back-ends use of PackedVarying, and will lead
to future cleanups relating to packing varyings.

BUG=angleproject:1123

Change-Id: Iaaa5fc03577e5b61ea6ae76ee1e15ad608037f34
Reviewed-on: https://chromium-review.googlesource.com/295190Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Compiling an assert in Program.cpp was failing at least on GCC 4.8
because it compared unsigned size_t to zero, a comparison that was always
true. The C standard defines size_t as unsigned, so the assert shouldn't
be necessary on other platforms either.

There was already a commit on top of the patch that added the bug, so it
is simpler to fix the problem by changing the assert rather than
reverting.

TEST=standalone debug build on Linux

Change-Id: Ifd910332a770f7360a15c31706beca740d0f289d
Reviewed-on: https://chromium-review.googlesource.com/294971Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

Resubmit with inconsistent override warnings fixed.

Removing dynamic indexing of vectors and matrices will require copying
the indexed nodes in case they are written. Any type of l-value node that
doesn't have side effects may need to be copied. Add a copying function
for all typed node classes so that this copying can be performed.

Private copy constructors are used to implement the deepCopy function in
order to make maintenance easier. With copy constructors, each subclass
only needs to take care of copying its own members, and not the base
class members, which reduces the possibility of errors. Copy constructors
are disabled for all node classes that don't support deep copying by
inheriting TIntermNode from angle::NonCopyable.

Assignment operator is disabled for all node classes through inheriting
angle::NonCopyable. This applies also to classes that now get the private
copy constructor.

Explicit copy constructor and assignment operator declarations are added
to some classes which show up in node member variables to make code
clearer.

BUG=angleproject:1116
TEST=angle_unittests

Change-Id: I7964976f5dac7dfd745b8c6612ca06fb01d271c4
Reviewed-on: https://chromium-review.googlesource.com/295080Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

BUG=angleproject:1137

Change-Id: Ic654b79aa56ae0c0a24097b85ab48f5af53ca1f7
Reviewed-on: https://chromium-review.googlesource.com/295154Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Due to the many merges and changes to
37c3979e the default framebuffer
deletion "disappeared". Add it back to the destructor of Surface.

Update Surface_unittests and remove one of the two tests as they were
equivalent.

BUG=524495
BUG=angleproject:1137

Change-Id: I1309285ea00976ae2685628ea3f92731a9259718
Reviewed-on: https://chromium-review.googlesource.com/295153Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

When the packed stride and source stride were different, the streaming
code path used a loop that added two times the offset for the start of
the index range.

BUG=angleproject:1135

Change-Id: I6d314a1a28abec4df22f7c798c1af87a18d8b7ec
Reviewed-on: https://chromium-review.googlesource.com/295225Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Also initialize this structure within Program instead of DynamicHLSL.
This should have benefits for other back-ends. Also these variables
weren't being serialized and de-serialized with the program binary,
which could mess up WebGL apps that use MRT.

BUG=angleproject:1123

Change-Id: Ic0dd4840f26441a1bee8527dfa178b24daf82f8a
Reviewed-on: https://chromium-review.googlesource.com/294571Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

This concept isn't strictly necessary for GL-side validation. Instead
we can use a bitset to track active attribs, and determine is a
particular location is active.

BUG=angleproject:1123

Change-Id: If7a920a3071672116bafffb3368671f721723b65
Reviewed-on: https://chromium-review.googlesource.com/294570Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

On a loaded machine, Sleep(0) can be very slow (40+ms) while Sleep(1) is
consistantly 1-2ms.

BUG=488571

Change-Id: I71de0b4cfc334a2476b7c613c103e77fe759041d
Reviewed-on: https://chromium-review.googlesource.com/273183Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

HLSL output needs uniform information generated by the collectVariables()
step to be able to write uniform registers.

Tested manually by compiling a shader with a uniform with
shader_translator.

BUG=angleproject:1132

Change-Id: I91d19b5fa789b7b33cf76a654ffbbd17d279db01
Reviewed-on: https://chromium-review.googlesource.com/294962Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

BUG=angleproject:970

Change-Id: I02caf1a5d15a8e32e68b63362e86e3a689dbdb5a
Reviewed-on: https://chromium-review.googlesource.com/293221Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Unless the RenderTarget9 is backed by a texture, it's not possible to
sample from it.  This is required to sample from D3D9 renderbuffers when
they are bound to texture targets.

BUG=angleproject:970

Change-Id: Id667a5e44c1f959609bc653a974ede5b93ec9a3e
Reviewed-on: https://chromium-review.googlesource.com/293290Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Simplifies a lot of logic when we don't have to maintain mappings between
the driver and gl-layer locations.

BUG=angleproject:882
BUG=angleproject:1123

Change-Id: Ia94257a322f768fdfa3167000a46a0715820ef4d
Reviewed-on: https://chromium-review.googlesource.com/295231Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Enabled loop indexing validation for fragment shaders compiled using renderers configured for FL9_3 and below.

BUG=angleproject:1130

Change-Id: I2b5d7091c394565354b14fbf9297276dce8d92a5
Reviewed-on: https://chromium-review.googlesource.com/294733Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Reland with a fix for the compilation on Windows.
Rereland with a fix for the Chromium compilation on Windowds.

Our angle_config.h was using "using namespace" in a header as a way to
import symbols to shim Chromium's base. This patch changes this to
import each function separately using "using".

This patch will allow our gpu_test_expectations to compile inside
Chromium on Linux.

BUG=angleproject:1127

Change-Id: Iefb9e253e278fa766a11e50fc6a69eceb2e81dd9
Reviewed-on: https://chromium-review.googlesource.com/295192Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Make the state setting functions of StateManagerGL public.

BUG=angleproject:1113

Change-Id: Ic435c06ece24064a2f2403119fa30309aba37608
Reviewed-on: https://chromium-review.googlesource.com/295240Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Re-land with a fix for a warning in 32-bit Windows.

Making the Program own the attribs, and the Impl only see a read-only
copy cleans up the Impl object. It also allows us to more cleanly
isolate certain coded into D3D.

BUG=angleproject:1123

Change-Id: I73bda4b6d9e675d87d087d44757c598437d607f2
Reviewed-on: https://chromium-review.googlesource.com/295191Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Once again a signed/unsigned mismatch warning in 32-bit.

src\libangle\renderer\gl\programgl.cpp(190) : warning C4018: '<' : signed/unsigned mismatch

BUG=angleproject:1123
This reverts commit 2d773183.

Change-Id: Icd26906ead1eaa06b4bd3ff7fc2b10bef4f46022
Reviewed-on: https://chromium-review.googlesource.com/295241Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Making the Program own the attribs, and the Impl only see a read-only
copy cleans up the Impl object. It also allows us to more cleanly
isolate certain coded into D3D.

BUG=angleproject:1123

Change-Id: I469051eb066fc56e55282affa2d5398b394ab8d2
Reviewed-on: https://chromium-review.googlesource.com/293826Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

When building in Chromium, on Windows, we got a symbol clash for
base::SysInfo::OperatingSystemVersionNumbers

This reverts commit d2eaa37d.

BUG=

Change-Id: Icffa01a26368cecc9eb3c2ada8bf41143bd3c50a
Reviewed-on: https://chromium-review.googlesource.com/295230Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This method should really be an Impl method, since it corresponds to
a specific OpenGL call. Making it an Impl method also allows us to
remove applyUniforms, which doesn't correspond to a GL call.

BUG=angleproject:1123

Change-Id: I2abee3cfaa7393cad44566782d51ed701e84846b
Reviewed-on: https://chromium-review.googlesource.com/293825Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Sharing the bindings with the Impl (read-only) allows us to clean out
the applyUniformBuffers method from the Impl class, and make it D3D-
only.

BUG=angleproject:1123

Change-Id: Icb51a90cb227bbbdd83319ea308b68aa1c4c325e
Reviewed-on: https://chromium-review.googlesource.com/293824Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Several of these methods that deal with the sampler mapping can be
made D3D-only quite simply by casting to ProgramD3D in the Renderer.

BUG=angleproject:1123

Change-Id: Ia6648d26744f9aa69a4a0facb356209df471fa7b
Reviewed-on: https://chromium-review.googlesource.com/293823Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Reland with a fix for the compilation on Windows.

Our angle_config.h was using "using namespace" in a header as a way to
import symbols to shim Chromium's base. This patch changes this to
import each function separately using "using".

This patch will allow our gpu_test_expectations to compile inside
Chromium on Linux.

BUG=angleproject:1127

Change-Id: I19b97c2a37accc683a35809859c604bcaf3dcc43
Reviewed-on: https://chromium-review.googlesource.com/295150Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This patch causes a compile failure, probably because some symbols had
been declared in the root namespace and should have been moved to base.
(but weren't compiled under Linux)

BUG=

This reverts commit f41e04db.

Change-Id: Ia2292bf9dcbf429f47c8c8632356574a91ff0a1d
Reviewed-on: https://chromium-review.googlesource.com/295110Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Two things were needed:
 - The re-enabling of exception and RTTI as it is disabled in Chromium
   and in a different way than in ANGLE standalone
 - Link decpp with dl

BUG=angleproject:1127

Change-Id: I9ac37545762dc13320c7fba418fba82d7961e83e
Reviewed-on: https://chromium-review.googlesource.com/294822Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Our angle_config.h was using "using namespace" in a header as a way to
import symbols to shim Chromium's base. This patch changes this to
import each function separately using "using".

This patch will allow our gpu_test_expectations to compile inside
Chromium on Linux.

BUG=angleproject:1127

Change-Id: I99a78ab9fddc11b81e3e5154d41cd8bbbb2ac28d
Reviewed-on: https://chromium-review.googlesource.com/294821Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This will avoid -Winconsistent-overrides in the future. Done using the
-Wsuggest-override warning of GCC 5.1

BUG=

Change-Id: I707a649dc368f5dd1e139fd144370abcac0b6263
Reviewed-on: https://chromium-review.googlesource.com/294920Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Reland the commit after fixing a bug in FramebufferAttachment.

This reverts commit 18fdcbcf.

BUG=angleproject:891

Change-Id: I07e08de52bfce8d84d070fc7bc15883009298a4d
Reviewed-on: https://chromium-review.googlesource.com/294831Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Otherwise attach will try to call onDetach on mResource, causing an UB
(and a segfault in most cases).

This fixes a crash when running angle_unittests on Mac with another
patch.

BUG=angleproject:891

Change-Id: I09d34d7246849059a13bc2fb00a61837cccd97d7
Reviewed-on: https://chromium-review.googlesource.com/294830Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This reverts commit d0d59aa4 and commit
76037953

To be fixed will be the newline at the end of IntermNode_tests.cpp and
the -Winconsistent-missing-override

BUG=

Change-Id: I57693bdff01f9e3f03b2fbb5dc53fa21e68c2789
Reviewed-on: https://chromium-review.googlesource.com/294820Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ESSL 1.00 specifies a set of minimum functionality, and ANGLE
automatically checks that WebGL shaders stay within this minimum
functionality. However, this should only apply to ESSL 1.00. ESSL 3.00
shaders compiled for WebGL 2.0 should not be subject to these
restrictions, since there is no similar spec for minimum functionality
for ESSL 3.00.

In case a non-WebGL based shader spec is used, the restrictions can be
toggled from outside by specifying the SH_VALIDATE_LOOP_INDEXING flag,
same as before this patch.

BUG=angleproject:1116
TEST=WebGL 2 conformance tests

Change-Id: Idaec0fb4c7c85cd72020d0b23112fddb1b020571
Reviewed-on: https://chromium-review.googlesource.com/293933Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

BUG=

Change-Id: Ie935486bf44bacb89660419c0dabd0ff38838c90
Reviewed-on: https://chromium-review.googlesource.com/294800Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

A refactoring bug slipped in that used the non-transposed row count
for non-square matrices, causing an ASSERT failure in Debug. It's
unfortunately not easy to revert the previous change, so instead
fix it here.

BUG=angleproject:1129

Change-Id: I0de66de46a24b402c93da68f189a2c65616c2006
Reviewed-on: https://chromium-review.googlesource.com/294641Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:891

Change-Id: Id61e61a2efff019e92316adbe34fc2378302aff5
Reviewed-on: https://chromium-review.googlesource.com/294600Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>