- 17 Feb, 2021 11 commits
-
-
Tim Van Patten authored
The app "Car Parking Multiplayer" enables GL_SAMPLE_ALPHA_TO_COVERAGE, which leads to a VVL error when LINE_RASTERIZATION_MODE_BRESENHAM is also enabled: VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766: The Vulkan spec states: If the lineRasterizationMode member of a VkPipelineRasterizationLineStateCreateInfoEXT structure included in the pNext chain of pRasterizationState is VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT or VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT and if rasterization is enabled, then the alphaToCoverageEnable, alphaToOneEnable, and sampleShadingEnable members of pMultisampleState must all be VK_FALSE. This CL adds the additional checking to GraphicsPipelineDesc::initializePipeline() to ensure those conditions are met before setting lineRasterizationMode to VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT. Bug: angleproject:5613 Test: StateChangeTest.AlphaToCoverageEnable Change-Id: Ie2286078f6916c01a19ae6f932321a86619bd4e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2694094Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Cody Northrop authored
Test: Capture and replay ES 3.2 apps Bug: angleproject:5652 Change-Id: I2dac84d3cf6534ee1b10889ba1312ae247ae8f62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698391Reviewed-by:
-
Corentin Wallez authored
The test has been failing on that configuration since it was introduced. TBR=syoussefi@chromium.org Bug: angleproject:5655 Change-Id: If852bcd574fa0cd4018220b7d6749b95a717a7c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698117Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/a1175c67dd67..0d42e83928f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/5789e3eed9..6f1f6775f3 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c79edd260c..05cda81aba * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6952dfcc1d..88ea55de92 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c62432713f..74aa762a95 Bug: None Tbr: cwallez@google.com Change-Id: I92bea4c6872f41614df4ec5216e9c0944b1c7898 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699422Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/539ef8e9426e..bb04803b8daf 2021-02-16 gavinmak@google.com Move metadata in OWNERS files to DIR_METADATA files 2021-02-16 amaiorano@google.com Remove uses of deprecated CreateAlignedLoad/Store builders 2021-02-16 sugoi@google.com Enable the sampleRateShading feature 2021-02-16 amaiorano@google.com vk-unittest: fix crash when unloading shared lib twice 2021-02-16 amaiorano@google.com Expose VK_EXT_headless_surface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I9b992002704a615546ce101bbff1e361baadc88f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699912Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/a04f3d444779..794086037940 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bc28354170..43c1e3a98a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/228b1c1883..fe293b0f5a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/838c3f15ee..dc82acba81 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..832539cc4d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbe0d801bb..6ec6688f3b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f473fa69fa..bd7d7f71cf * tools/skia_goldctl/linux: IY5qc7Fm3l7ofSvX0tx81d_UYTMJ1cVFlXp3beXxGacC..sm5PB3-BZYObubxkNie_5-C1p_sD1rtSOFVIc8PLymYC * tools/skia_goldctl/mac: sThAFNVmUGB1KLYyFvxlfBZgrQvQm8C1jpik4b8Eq6QC..O-zkkp_UNP-ZoPmmK4xpuqYw9tpNzRGuUCNFH8I9PzwC * tools/skia_goldctl/win: AshRD0sQsymS9bHa8cDgrecFq4NCi98zUJ9TNnD054AC..0JpeSchnXAemMxcrvtlMxxr3uiYp4vpP_iKo4kKEfUoC No update to Clang. Bug: angleproject:4483 Tbr: cwallez@google.com Change-Id: I65e46b68b3453d7db5aeba9ad60dc4d4d3eb4565 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2699419Reviewed-by:
-
Shahbaz Youssefi authored
... and move it to handleDirtyGraphicsRenderPass. Bug: angleproject:5528 Change-Id: I416b2fedb1cd924d04fa739aecb65193fd845f6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686441 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
-
Shahbaz Youssefi authored
1. The xfb counter buffer barrier issued was wrong, following a typo in the spec. This barrier is now correctly issued using the usual barrier APIs. 2. A mechanism was added to automatically pause/resume transform feedback when a program pipeline needs to be rebound. This is incorrect as it misses the xfb counter buffer barrier. The render pass is broken instead if transform feedback is active/unpaused and the program pipeline is changed. 3. The transform feedback counter buffers are now disposed of when transform feedback is ended. This avoids an unnecessary barrier that this change would have otherwise incurred (and hence render pass break) in Manhattan which repurposes the same transform feedback object. Bug: angleproject:5528 Change-Id: I1ffe8b4b8975645ba43afd70e9cdbb0765529da5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651647Reviewed-by:
-
Ian Elliott authored
Created: - WindowsSurfaceVk::getRotatedWidth() - WindowsSurfaceVk::getRotatedHeight() - RenderTarget::getRotatedExtents() - ImageHelper::getRotatedExtents() - ImageHelper::getRotatedLevelExtents2D() Note: The FramebufferVk class doesn't use any of these methods Bug: b/175793022 Change-Id: I64395688bfdb172d32853763743fc5f266a6b792 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686102 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
-
Cody Northrop authored
Bug: None TBR: geofflang@chromium.org Change-Id: I60fd6bc18d8c86087d7640eb1145d575c4008edb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697986Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Mohan Maiya authored
HardwareBufferImageSiblingVkAndroid, RenderbufferVk, SurfaceVk and TextureVk all had similar code to initialize VkImage with VK_KHR_image_format_list extension support. Consolidate all of them into a helper. Bug: angleproject:5520 Change-Id: Ib7ac582a35a26c0da15879e688bcaf0c2a92ea87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2692641Reviewed-by:
-
- 16 Feb, 2021 12 commits
-
-
Shahbaz Youssefi authored
CLIENT_MAPPED_BUFFER_BARRIER_BIT_EXT requires a memory barrier: shader buffer write -> host read. According to the spec, the data is only available after a call to glFinish or wait on sync: > The application must call MemoryBarrier with the > CLIENT_MAPPED_BUFFER_BARRIER_BIT_EXT set and then call FenceSync with > SYNC_GPU_COMMANDS_COMPLETE (or Finish). Then the CPU will see the > writes after the sync is complete. When a buffer is written to by the GPU, ANGLE calls onHostVisibleBufferWrite(), which ensures a "memory write -> host read" barrier is issued at the end of the command buffer. Additionally, persistently mapped buffers use VK_MEMORY_PROPERTY_HOST_COHERENT_BIT, so there's no need for a call to vkInvalidateMappedMemoryRanges. As a result, there's nothing necessary in ANGLE to do for this barrier bit. Note that should persistenly mapped buffers start using non-coherent memory, this barrier should imply a call to vkInvalidateMappedMemoryRanges for the persistently mapped buffers. Bug: angleproject:5070 Change-Id: Iaeae019dadfa659a47d2dac41c0c09f1c15e584b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689380 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
See https://chromium-review.googlesource.com/c/angle/angle/+/1661252 for context. This was accidentally broken during the command graph rework. This will eventually be validated by syncval. See https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2329. Bug: angleproject:5070 Change-Id: Ic16fa900e554d46e54b42fc3fbe0f96d5327fa0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689379Reviewed-by:
-
Shahbaz Youssefi authored
The following scenario was mishandled: - MSRTT draw with an unresolve operation (i.e. has two subpasses) - Deferred clear - Flush deferred clear with MSRTT framebuffer not needing unresolve (i.e. has one subpass) Bug: chromium:1178693 Change-Id: If3548e99897d698d61dfafbe9f86193723d06e5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697648 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Geoff Lang authored
Bug: None Change-Id: Ic23994efa3f4184c471eb21e7f3bb039f6b45057 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697947Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Peng Huang authored
Bug: chromium:1170339 Change-Id: I00c868e205a16a889e193383c35b2ed42d8a61ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693028Reviewed-by:
-
Peng Huang authored
https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/b1d65a2b3373..732a76d9d3c7 $ git log b1d65a2b3..732a76d9d --date=short --no-merges --format='%ad %ae %s' 2021-02-12 shawn.p.huang change the default gn target to include vma.cpp 2021-02-03 ehmaldonado Move metadata in OWNERS files to DIR_METADATA files Created with: roll-dep third_party/vulkan_memory_allocator Bug: chromium:1170339 Change-Id: I09c1683943c9343517536e96b1ca301e81c4d403 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693027 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d8a8a5c337df..eab348e95425 2021-02-16 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-02-16 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-02-15 caio.oliveira@intel.com Add VK_KHR_workgroup_memory_explicit_layout OpCopyMemory tests 2021-02-15 caio.oliveira@intel.com Add VK_KHR_workgroup_memory_explicit_layout maximum size tests 2021-02-15 caio.oliveira@intel.com Add VK_KHR_workgroup_memory_explicit_layout padding tests 2021-02-15 caio.oliveira@intel.com Add VK_KHR_workgroup_memory_explicit_layout zeroing aliased block tests 2021-02-15 caio.oliveira@intel.com Add VK_KHR_workgroup_memory_explicit_layout type aliasing tests 2021-02-15 caio.oliveira@intel.com Add new ShaderBuildOption to enable Workgroup scalar offsets 2021-02-12 slawomir.cygan@intel.com Ensure there is a committed ray intersection before calling rayQueryGetIntersectionInstanceIdEXT(..., true) 2021-02-12 michal.jakubek@mobica.com Tests for image OpImageWrite on mismatched vector sizes 2021-02-12 rgarcia@igalia.com Mix dynamic state with compute and transfer 2021-02-12 rgarcia@igalia.com Test not writing to the Position built-in 2021-02-12 venni.ihanakangas@siru.fi Add coverage for depth bias 2021-02-10 jbolz@nvidia.com Test FragCoord with per-sample input variable 2021-02-10 ilkka.saarelainen@siru.fi Add new samplerless descriptor tests 2021-02-10 toni.salmivalli@siru.fi Add a batch of GraphicsFuzz tests 2021-02-09 pawel.ksiezopolski@mobica.com Rename all *KHR enums and structs to core If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC cwallez@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com,angle-bots+autoroll-info@google.com Change-Id: I44151987348fc72847f32f7024831635139715b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697312Reviewed-by:
-
Corentin Wallez authored
This reverts commit 804226df. Reason for revert: breaks compilation on android-archive-dbg. See https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-dbg/7802/overview (seems the egl symbols can't be found?) Original change's description: > Link angle_util statically into angle_system_info_test > > Otherwise ANativeActivity_onCreate is not found in component build. > > Bug: angleproject:4483 > Change-Id: Ic4a9f66e5b7d150a3740529f866de9995550ea68 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689370 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=ynovikov@chromium.org,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=ynovikov@chromium.org Bug: angleproject:4483 Change-Id: I7f16f77979f7d8b1e5e5f61e48b379b910f3a743 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697067Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
Corentin Wallez authored
Bug: angleproject:5629 TBR=ynovikov@chromium.org Change-Id: Iafae8a8022b1c3de7b6ff52be9889ba96a1fc865 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697069Reviewed-by:
-
Corentin Wallez authored
It should be suppressed on Desktop GL and not GLES TBR=syoussefi@chromium.org Bug: angleproject:5649 Change-Id: I9752e0219e39cc9a8f3c1b90e15525d7e0384a91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697068Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/418fd62b5c0f..a1175c67dd67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6ab923c69d..51b86c1a2b * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/4741bbaa64..5789e3eed9 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a66ceba272..c5678a03db Bug: None Tbr: cwallez@google.com Change-Id: Ib9687b3d63ead8ddbb0eba72c183066950fcabab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2696867Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/17c6b31351cf..a04f3d444779 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/251bfc5101..bc28354170 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7dee089ce5..838c3f15ee * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41e7d0ccba No update to Clang. Bug: None Tbr: cwallez@google.com Change-Id: Iff409e870e61605f22b7aac4efcc2f835b75d49e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2696347Reviewed-by:
-
- 15 Feb, 2021 5 commits
-
-
Shahbaz Youssefi authored
Bug: angleproject:5644 Change-Id: I2e1fa8c4db8eba1beb74c83dcb24cbe2e70ddca6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2694076Reviewed-by:
-
Corentin Wallez authored
SimpleStateChangeTestES31.DrawThenSampleWithCompute was failing since it was introduced. TBR=syoussefi@chromium.org Bug: angleproject:5649 Change-Id: I46f531724bd4f12c760675de5038f2345eb21aac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2692816Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/673a7fe5c3ff..539ef8e9426e 2021-02-12 srisser@google.com Support querying for Vulkan11 properties 2021-02-12 sugoi@google.com Implement GLSLstd450Interpolate* functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia327c40ccf0c4721b9f2001cdfca846a72b7ecd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2695310Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/c409714366e9..418fd62b5c0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/4afd691772..6ab923c69d * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cfa1dadb1e..c79edd260c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ec2db85225..1d99b835ec * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/01c9ae9b47..c62432713f Bug: None Tbr: syoussefi@google.com Change-Id: I0b9179d9c7031886cb1aeca30573ba27cd396f38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2695289Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/59663a6eb4d6..17c6b31351cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3696926416..251bfc5101 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d2a884ad6d..7dee089ce5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..35976bfcac * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fea4246907..dbe0d801bb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/106e9dfc90..f473fa69fa No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I3f30b42de6724786d7dd669c201807ea17d5f4cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2695140Reviewed-by:
-
- 14 Feb, 2021 2 commits
-
-
Shahbaz Youssefi authored
When vkCmdCopyImageToBuffer is possible, it is used to implement glReadPixels with PBO instead of a CPU readback. A few tests are added to verify synchronization between pack/unpack and compute shader writes. Bug: angleproject:5070 Change-Id: Ia5da0feb31348f6b52d164b973ff95e2a0510582 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2691466 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
-
Mohan Maiya authored
This change allows all formats in the GLES 1.1 spec, table 3.4 to be used as a texture attachment. Also normalize values passed into glColorPointer if the format is of type GL_UNSIGNED_BYTE. These changes are needed for the android app, Kick the Buddy to render correctly. Bug: angleproject:5599 Tests: *DrawTextureTest.ColorArrayDifferentTypes* *FramebufferObjectTest.TextureObjectDifferentFormats* Change-Id: Ie9d27fc24d94106651262cf9b2080dd3f05af1c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690920 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
- 13 Feb, 2021 9 commits
-
-
Shahbaz Youssefi authored
Bug: angleproject:5070 Change-Id: I835a4e936cb50d3f4b1187bebbe1d1adc49d0b52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689366 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:5635 Change-Id: I756471fbad34660c494fb7f9ba1144accd5c08b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686119 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Mohan Maiya authored
Prior to a mutation of the bitset, mCurrentIterator would have been from mParent but post-mutation subsequent iterators are obtained from mParentCopy. Assert that the end() markers for both containers are the same. Bug: angleproject:3877 Change-Id: Ia29abd2acc0014522ef5856a88d8ec227cf9f19d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693813Reviewed-by:
-
Mohan Maiya authored
Remove the now unused IterableBitSet class. Bug: angleproject:3877 Change-Id: I161e5d062c8183e30a7eb9040f3018116fe6e69e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683494 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
Mohan Maiya authored
Add support for more unary and binary operators. In order to support setLaterBit and resetLaterBit in BitSetArray::Iterator there were 2 choices - 1. Make a copy of BitSetArray only if it is a mutating usecase 2. Always perform a copy in the constructor BitSetIteratorPerfTest was run with both patches - 1) Copy only when necessary - RESULT BitSetIteratorPerf.wall_time: run = 116.1067374961 ns 2) Copy always - RESULT BitSetIteratorPerf.wall_time: run = 242.7446459439 ns We settled on the copy only when necessary path. Bug: angleproject:3877 Change-Id: If1d3cc428c68c84857952b46237aa5f206f080cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690912 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: -
Austin Sullivan authored
This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. This CL uses the GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST() macro to annotate the suites / tests that are causing test failures. This is necessary to get googletest rolled past CL 315255779. Bug: chromium:1163396 Change-Id: I17c7cae1121079219f632cbbcf8cfc65a27bfdb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2691459Reviewed-by:
-
Brian Salomon authored
Bug: skia:11223 Change-Id: Ia634bf0bf7a157c759ae192501ff763a1baa8d2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2650986Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/764e5b48c0ab..59663a6eb4d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fd66250b4d..3696926416 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7e85fef7d9..228b1c1883 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/086ae0a486..d2a884ad6d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e4328db483 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/35e7868383..fea4246907 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/84eb9fba67..106e9dfc90 * tools/skia_goldctl/linux: FnrTtCqUzIkttLMcUafQ-E14XeYY8Yg79UKi-yF4k-gC..IY5qc7Fm3l7ofSvX0tx81d_UYTMJ1cVFlXp3beXxGacC * tools/skia_goldctl/mac: 33D5pMUWm9PcQ9nzgMNc-cv9Y67SNea1XX9S3h0q0zoC..sThAFNVmUGB1KLYyFvxlfBZgrQvQm8C1jpik4b8Eq6QC * tools/skia_goldctl/win: pjN_saVBekGyLe4KBiQ_-ZjYGUfDR6X9O33jfnvsZOwC..AshRD0sQsymS9bHa8cDgrecFq4NCi98zUJ9TNnD054AC No update to Clang. Bug: angleproject:4483 Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I600b3b598c79f1b023bd31106625b530ff4d3d50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2694097Reviewed-by:
-
Tim Van Patten authored
Update ValidateCopyImageSubDataBase() to take into consideration if the entire mip level is being written, even if the size of the mip level is smaller than the compressed block size. This also uncovered a bug in ImageHelper::initializeNonZeroMemory() where the image extents are not at least as large as the compressed format block size: VUID-vkCmdCopyBufferToImage-imageExtent-00207 This CL adds isAllocateNonZeroMemoryEnabled() to allow skipping the test when that feature is enabled while that bug is chased. Bug: angleproject:5592 Bug: angleproject:5634 Bug: angleproject:5643 Test: Texture2DTestES3.CopyCompressedImageMipMaps Change-Id: I0381e0d3490fb148604b61dc3bae8f96ba8b5f8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673069 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
-
- 12 Feb, 2021 1 commit
-
-
Tim Van Patten authored
The default uniform descriptor set is reset while recreating the pipeline layout during handling of immutable samplers and then is never re-allocated and bound before the next draw. The call stack to allocate the program uniforms descriptor set: ProgramExecutableVk::allocUniformAndXfbDescriptorSet ProgramVk::updateUniforms ContextVk::setupDraw ContextVk::drawArrays Context::drawArrays Unfortunately, this occurs before the pipeline layout is reset (and the descriptor sets are reset) due to the presence of an immutable sampler: ProgramExecutableVk::reset <<---- mDescriptorSets.fill(VK_NULL_HANDLE); ProgramExecutableVk::createPipelineLayout ContextVk::updateActiveTextures ContextVk::invalidateCurrentTextures ContextVk::syncState Context::syncDirtyBits Context::prepareForDraw Context::drawArrays This CL calls setAllDefaultUniformsDirty() for the Program/PPO to ensure the default uniforms descriptor sets are re-allocated and re-bound before the next draw command. Bug: b/178424566 Bug: angleproject:5624 Test: CtsCameraTestCases Change-Id: If54a9f2cc09809a5103bc3eac641c77f56362229 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677385Reviewed-by:
-
