- 31 Mar, 2014 2 commits
-
-
Jamie Madill authored
The expression limit validation check needs to be in front of other tree traversal to prevent stack overflows. Also, call depths of sufficient size (80k+) could overflow the depth check itself, necessitating an upper bound on initial tree traversal. This fixes crashes in the WebGL long-expressions bug test. BUG=angle:584 Change-Id: Ib48294bf77a5923d230f237fbd63a36a5662e317 Reviewed-on: https://chromium-review.googlesource.com/191931Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Nicolas Capens <nicolascapens@chromium.org> Tested-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
The stack-memory traversal is prone to stack overflow. See the WebGL conformance test long-expressions-should-not-crash. BUG=angle:584 Change-Id: I02d72bc2e4101b7141d609c50303403ea8298e60 Reviewed-on: https://chromium-review.googlesource.com/191930Reviewed-by:
-
- 28 Mar, 2014 5 commits
-
-
Geoff Lang authored
BUG=angle:521 Change-Id: I6d00333ac7761f15ee83a47dc3e6e3cc13c675cd Reviewed-on: https://chromium-review.googlesource.com/188195Reviewed-by:
Shannon Woods <shannonwoods@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Geoff Lang authored
Instead of always compiling D3D11 shaders with shader model 4, compile with the latest profile that the current feature level allows. BUG=angle:495 Change-Id: I478d3d4a1aadf24d893508eee1a8c11e501bc084 Reviewed-on: https://chromium-review.googlesource.com/190340Reviewed-by:
-
Geoff Lang authored
BUG=angle:495 Change-Id: Ib9c19130dfbc44a99998c5d6d8160bfc2b683eb9 Reviewed-on: https://chromium-review.googlesource.com/185037Tested-by:
-
Geoff Lang authored
BUG=angle:521 Change-Id: I72f063664b43d3cfafe03c8f060076596bedea0f Reviewed-on: https://chromium-review.googlesource.com/188194Reviewed-by:
-
Geoff Lang authored
BUG=angle:521 Change-Id: I3b1d3a02214850bf52c1d5c468f5696076065b88 Reviewed-on: https://chromium-review.googlesource.com/188193Reviewed-by:
-
- 27 Mar, 2014 4 commits
-
-
Shannon Woods authored
BUG=angle:581 Change-Id: I0ab637db35afd51ff4c516bb97e954f4f2cdad3d Reviewed-on: https://chromium-review.googlesource.com/191710Reviewed-by:
-
Shannon Woods authored
BUG=angle:581 Change-Id: I05824051789a77c8169ec5830731e6155c507fc4 Reviewed-on: https://chromium-review.googlesource.com/191650Reviewed-by:
-
Geoff Lang authored
BUG=angle:521 Change-Id: I887257193af3130447c4691bb72303cc978b96fe Reviewed-on: https://chromium-review.googlesource.com/188192Reviewed-by:
-
Geoff Lang authored
BUG=angle:521 Change-Id: If1fc6198dbbe44f0ade5539cff540e3e086f2a3b Reviewed-on: https://chromium-review.googlesource.com/188722Reviewed-by:
-
- 26 Mar, 2014 4 commits
-
-
Jamie Madill authored
BUG=angle:568 Change-Id: I4b60084f2be0c04bb2f7dd78e78e2ef2825adc00 Reviewed-on: https://chromium-review.googlesource.com/191552Reviewed-by:
-
Geoff Lang authored
BUG=angle:495 Change-Id: I41a0177fd3eb43c9f4ab9e54faeadac3eb483c2c Reviewed-on: https://chromium-review.googlesource.com/185035Reviewed-by:
-
Geoff Lang authored
BUG=angle:493 Change-Id: I8841af50dcb90e7fb8a811b95d015bfdd2c5d226 Reviewed-on: https://chromium-review.googlesource.com/191035Reviewed-by:
-
John Bauman authored
BUG=320021 Change-Id: I97cdd65ac17ee142700dbf0f363891500e967571 Reviewed-on: https://chromium-review.googlesource.com/184205Reviewed-by:
John Bauman <jbauman@chromium.org> Tested-by:
-
- 25 Mar, 2014 1 commit
-
-
Jamie Madill authored
We can use angle_path instead of angle_build_scripts_path to locate enumerate_files.py. Also pass angle_path to the post-build script hook, as this information is necessary to locate the root angle folder. BUG=angle:592 Change-Id: I06b3f0201751d90b7c1efdefe8db07d114bd87dd Reviewed-on: https://chromium-review.googlesource.com/191082Reviewed-by:
-
- 24 Mar, 2014 1 commit
-
-
Jamie Madill authored
It got broken in r2423. We were referring to field-name as struct-name. This patch fixes the regression and also improves the error message by adding the field-name. BUG=angle:459 R=kbr@chromium.org Review URL: https://codereview.appspot.com/12891043 Change-Id: I9ac9a8dafcad1857f7d39e6d494e457d1fc50f70 Reviewed-on: https://chromium-review.googlesource.com/190530Reviewed-by:
-
- 18 Mar, 2014 7 commits
-
-
Geoff Lang authored
This reverts commit 4251b758. Change-Id: I95afebcaf91ee38a121df20f403eb06f19b2510a Reviewed-on: https://chromium-review.googlesource.com/190560Reviewed-by:
-
Shannon Woods authored
Would cause UNREACHABLE to be triggered if target was invalid, and INVALID_VALUE to be returned instead of INVALID_ENUM if it were the only erroneous argument. Change-Id: I2606e77379fa2832a50b3a299e6474a4b2f68afa Reviewed-on: https://chromium-review.googlesource.com/189701Reviewed-by:
-
Geoff Lang authored
BUG=angle:493 Change-Id: Ibeae41da2b83ab63d237912602ba5d2aad0bbec2 Reviewed-on: https://chromium-review.googlesource.com/185036Tested-by:
-
Jamie Madill authored
In D3D11, map-discard is reserved for DYNAMIC usage buffer, which are resources that live on the GPU. Staging buffers don't have the notion of map-discard, and using them with discard gives a D3D11 error. This patch fixes crashes in dEQP buffer.map.write.invalidate. BUG=angle:587 Change-Id: Ie225e72d4e226c69e73826c9fb67bbb940bbc466 Reviewed-on: https://chromium-review.googlesource.com/190072Reviewed-by:
-
Jamie Madill authored
We were incorrectly setting the signed parameter to true in the vertex format table. This fixes a dEQP test in vertex_arrays.output_types. BUG=angle:586 Change-Id: I84dcdee89a95369cc8e41d451f96dbb8daa37b6d Reviewed-on: https://chromium-review.googlesource.com/190056Reviewed-by:
-
Jamie Madill authored
The dEQP varying struct linkage tests were triggering asserts when we tried to query component info of struct types. BUG=angle:580 Change-Id: I61e33573c5577a327c58fec7a07ae7718690ac42 Reviewed-on: https://chromium-review.googlesource.com/189194Reviewed-by:
-
Jamie Madill authored
We can't assume we have a simple mapping between input attribs and shader attribs. The app specifies matrix input attribs as several vector inputs, while the shader uses a single matrix type. BUG=angle:576 Change-Id: I4e3cdde4a14a5f06b86052dfe0325113cbe8e599 Reviewed-on: https://chromium-review.googlesource.com/189193Reviewed-by:
-
- 17 Mar, 2014 5 commits
-
-
Shannon Woods authored
bug=angle:582 Also performs format checks for non-subimage copies, and permits unsized format textures as destination for the copy. Change-Id: Id647bb968416fbd35e1c70e5da21c81367e08f07 Reviewed-on: https://chromium-review.googlesource.com/189431Reviewed-by:
-
Scott Graham authored
This is the initial draft of a spec that extends EGL_EXT_platform_base to allow choosing a particular ANGLE D3D backend. Change-Id: I1d80fa8b3c4a59fe998f6d15aa0f393bdb9d26c1 Reviewed-on: https://chromium-review.googlesource.com/184975Reviewed-by:
Scott Graham <scottmg@chromium.org> (cherry picked from commit dc18dc30) Reviewed-on: https://chromium-review.googlesource.com/190026Reviewed-by:
-
Geoff Lang authored
D3D10 cards perform poorly when the pixel shader outputs to multiple render targets that are not bound. BUG=325581 Change-Id: I13f6f98861ffeb77cd21f7401ded4425e4ea7841 Reviewed-on: https://chromium-review.googlesource.com/185400Reviewed-by:
-
Geoff Lang authored
Cherry-pick of bd79517a. Change-Id: I87d790c14d68789524df76f63a61fc30a8792e4e Reviewed-on: https://chromium-review.googlesource.com/190350Reviewed-by:
-
Geoff Lang authored
Since a DirectBuffer11 may return different buffers from getBuffer depending on the required buffer type and if the internal buffers are dirty or not, the current serial is not reliable. Use the actual buffer object so that there can be no missmatch. BUG=350581 Change-Id: I6ea1616273346117a17646edb68e6518e584f2b1 Reviewed-on: https://chromium-review.googlesource.com/189435Reviewed-by:
-
- 14 Mar, 2014 4 commits
-
-
Jamie Madill authored
We should use the cross-platform os.path.join() to support platforms other than Windows. BUG=angle:577 Change-Id: I9d96fc1b13731a57ffcd97469632f0acedb8e5c7 Reviewed-on: https://chromium-review.googlesource.com/188879Reviewed-by:
-
Geoff Lang authored
Change-Id: I135c4457fdc95f2d331e2924104a30f90a40bd1a Reviewed-on: https://chromium-review.googlesource.com/189456Reviewed-by:
-
Jamie Madill authored
Move ReadPixels error generation out of the implementation and into the API level. BUG=angle:571 Change-Id: I0b32294f359fedd13d1af2c95baf37a3e5ac1d5b Reviewed-on: https://chromium-review.googlesource.com/188014Reviewed-by:
-
Jamie Madill authored
GetBufferPointerv, GetBufferParameteri64v, and new values for GetBufferParameteriv. BUG=angle:565 Change-Id: I179a3193987b2bff1b0628e47f6a0d627541b0cf Reviewed-on: https://chromium-review.googlesource.com/188203Reviewed-by:
-
- 12 Mar, 2014 1 commit
-
-
Nicolas Capens authored
BUG=348205 Change-Id: I9be17832b1a35d2995725ab147977992c2732274 Reviewed-on: https://chromium-review.googlesource.com/188711Tested-by:
-
- 11 Mar, 2014 2 commits
-
-
Jamie Madill authored
Change-Id: I0a385ff823ef492b4fced89a734d8053fdb0ffd0 Reviewed-on: https://chromium-review.googlesource.com/189474Reviewed-by:
-
Zhenyao Mo authored
We use hashing to map all variables/strcuture field names, etc, so we no longer need this option. Checked with Firefox and WebKit, they no longer use this option either. Time to remove it. Change-Id: Ie3e79b91a05258b04af419a9c42b2fd1b00e67c4 Reviewed-on: https://chromium-review.googlesource.com/189236Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
- 10 Mar, 2014 1 commit
-
-
Shannon Woods authored
Change-Id: I2fe1d02cdf59409cb2d8a68b407bbd01ab7d8c0a Reviewed-on: https://chromium-review.googlesource.com/188954Reviewed-by:
-
- 07 Mar, 2014 3 commits
-
-
Zhenyao Mo authored
1) Before this workaround is hardwired on mac, now we move it behind a compil 2) Fix the issue where "break" inside the loop isn't handled while unrolled. BUG=338474 TEST=webgl conformance test sampler-array-using-loop-index.html Change-Id: I4996a42c2dea39a8a5af772c256f8e3cb383f59a Reviewed-on: https://chromium-review.googlesource.com/188079Reviewed-by: -
Geoff Lang authored
BUG=angle:575 Change-Id: Ibad77fda193c850c29483aa56d0d2275c131429a Reviewed-on: https://chromium-review.googlesource.com/189163Tested-by:
-
Geoff Lang authored
Instead of opening and closing the debug log file with each message, keep it open permanently and flush it with each message, allowing the OS to flush to disk as needed. With debug logging enabled, performance is improved by 100x! Also, dynamically size the output buffer to the max message size. When running all the samples, the largest debug message was 318 characters so an initial size of 512 (instead of 32768) seems reasonable. BUG=angle:575 Change-Id: If4a1387431fc2d32a6b2d1f9ca1f2590473feb86 Reviewed-on: https://chromium-review.googlesource.com/188713Reviewed-by:
-
