Skip to content

A
angle
Switch branch/tag
  1. 17 May, 2018 3 commits
  3. 16 May, 2018 9 commits
  5. 15 May, 2018 5 commits
  7. 14 May, 2018 11 commits
  9. 12 May, 2018 2 commits
    • Revert "GLES1: Renderer (minimal)" · 66aafcb4
      Frank Henigman authored 
      This reverts commit a6909921.

Reason for revert: New tests failing on gpu fyi bot.  anglebug.com/2554

Original change's description:
> GLES1: Renderer (minimal)
> 
> This is the renderer code for GLES1 that delivers basic vertex
> attributes, matrices, and allows texturing for unit 0 only (more units
> mean implementing the multitexturing pipeline).
> 
> + Sample
> + Update test expectations for GLES1 conformance tests
> 
> BUG=angleproject:2306
> 
> Change-Id: Id5d5603c967e577290085e5946f2cb7a03d7e017
> Reviewed-on: https://chromium-review.googlesource.com/1023988
> Commit-Queue: Lingfeng Yang <lfy@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org,lfy@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:2306
Change-Id: Ib6fd9db433cd1a13589d5a9e82cb2c40f3cf71ff
Reviewed-on: https://chromium-review.googlesource.com/1056229Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
    • D3D11: Fix out-of-range access with robust access. · 18e323ab
      Jamie Madill authored 
      When using a vertex buffer with DYNAMIC usage, with robust buffer
access enabled, we would sometimes read out-of-bounds when using very
large values for the index range. An unchecked signed addition would
overflow and lead to reading a negative offset.

Fix this problem by keeping the value size_t whenever possible. Also do
clamped casts when converting to a smaller values.

Also adds a regression test.

Bug: chromium:842028
Change-Id: Ie630ac857c6acfc0bace849a03eebfbaa2fbe89a
Reviewed-on: https://chromium-review.googlesource.com/1055928
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
  11. 11 May, 2018 8 commits
  13. 10 May, 2018 2 commits
    • Micro-optimize uniform updates. · 2fc0806f
      Jamie Madill authored 
      This CL is adapted from work by matavenrath@nvidia.com. It does the
following small optimizations:

* inlines a bunch of accessors.
* reorders checks to hit the cache more often

Also some small style updates.

Bug: angleproject:1671
Change-Id: I8f21318e6644dcfe1f99c98f7f377742fcad78d3
Reviewed-on: https://chromium-review.googlesource.com/1054367
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    • Vulkan: Fix use-after-free with DynamicBuffer. · 61859817
      Luc Ferron authored 
      The implementation of DynamicBuffer before my changes could have some
issues in the following use case:
- Allocate buffer 1 for Texture 1 (with size as big as the full buffer
size)
- Allocate buffer 2 for Texture 2 (triggers creation of a new underlying
BufferVk and releases the buffer 1 to the Renderer)
- Render with Texture 2 (texture 1 hasn't been flushed yet)
- swap buffers (causes garbage in the renderer to be cleaned up)
- Try rendering with Texture 1, and you'll get an error stating that
the buffer we're trying to copy is not valid (because its already been
freed).

This set of changes:
- Add a new test that specifically triggers this case.
- enables the texture.filtering.cube* tests in dEQP.
- Fixes the issue by adding a manual releasing pattern of the buffers
in DynamicBuffer.

Bug: angleproject:2505
Change-Id: I207ce4a694016766f008cca67d82b252f460e0df
Reviewed-on: https://chromium-review.googlesource.com/1052551Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
Commit-Queue: Luc Ferron <lucferron@chromium.org>