Commits · 6fad384bb6b00aa917dd5b92885dfd1f1297a135 · Chen Yisong / angle

06 Jun, 2020 2 commits

Vulkan: Add test for RT created from mip-incomplete texture · 6fad384b

authored Jun 04, 2020

The Vulkan backend creates an image with 3 mips, while it should only
create one with a single mip.

Bug: angleproject:4686
Change-Id: Ide7f9612c9440bfb9d9650637f6a1ad42be61208
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230797Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

6fad384b

Roll Vulkan-ValidationLayers from 4685ffce93ad to f1b11cc29c58 (7 revisions) · a8970861

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4685ffce93ad..f1b11cc29c58

2020-06-04 s.fricke@samsung.com tests: Validate VK_KHR_multiview features
2020-06-04 s.fricke@samsung.com layers: Validate VK_KHR_multiview features
2020-06-04 tony@lunarg.com gpu: Record destroy of buffers and devices
2020-06-04 mark@lunarg.com tests: Leave handle wrapping enabled at all times
2020-06-04 s.fricke@samsung.com layers: Label VUID 01386 and fix log messages
2020-06-04 s.fricke@samsung.com tests: Add YCbCr BufferImageCopy VUID
2020-06-04 s.fricke@samsung.com layers: Add YCbCr BufferImageCopy VUID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I18a190951f7517723b499032f6a9fb904e9e673f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232221Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a8970861

05 Jun, 2020 17 commits

Vulkan: Zero-init ContextVk dirty bit handlers. · 6b946a7b

authored Jun 05, 2020

This allows for a better debugging experience and can solve some
potential invalid ASSERTs due to some dirty bit handlers not being
initialized.

Bug: angleproject:4622
Change-Id: Ib34e35dea6c6c7de250ae6600576f0324c150ae6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233403
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6b946a7b

GL: Work around drivers that generate mipmaps in linear color space · 60803838

authored May 20, 2020

Mac drivers generate mipmaps in linear color space. To work around
this, copy the sRGB texture to a linear texture, generate mipmaps
and then copy back.

TEST=conformance2/textures/misc/tex-srgb-mipmap.html

BUG=angleproject:4646

Change-Id: I8675d0ab004bcd2985f685d64cbb84deff5f1c86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2211083Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

60803838

Make GLES 1 tests use ANGLE EGL headers. · 9fa671d5

authored Jun 05, 2020

This will allow us to more easily support a different test target
topology for the standalone test harness that uses an intermediate
source_set. Also it's better in the long run to only have to worry
about one set of EGL headers.

Bug: angleproject:3162
Change-Id: I738dbb68df1abc0c0569748e18d6826914d90a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233399Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9fa671d5

Skip MultisampledBGRAToRGBA, MultisampledRGBAToBGRA tests on Vulkan · 925d1e7b

authored Jun 05, 2020

VVL report VUID-vkCmdResolveImage-srcImage-01386 in these two.

Bug: angleproject:4694
Change-Id: I4a4af598cfa77af18ccf6e322cde92749cb9ad70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233401Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

925d1e7b

Vulkan: Pass API version to VMA. · 17b4a877

authored May 26, 2020

This apparently can save on memory usage in the allocator.

Reported by penghuang@chromium.org.

Bug: angleproject:4685
Change-Id: I6f29280e3fe16f3388c4f8412e0acb09d7f16e58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216714Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

17b4a877

Fix FramebufferVk::getScissoredRenderArea() for pre-rotation · a91dcb62

authored Jun 05, 2020

This fixes cases where pre-rotation wasn't occuring for small scissors
used with glClear().  There are around 1000 tests that do this.

Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_fragment_ops_depth_stencil_*
Bug: angleproject:4431
Bug: b/157933235
Bug: b/157933198
Change-Id: I469d51975e3bc3a7bfc9521a3817c919e809f7dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2228211Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

a91dcb62

Reduce dependency on ProgramExecutable::mProgram[Pipeline]State · 77851053

authored May 26, 2020

Remove the dependency on mProgramState/mProgramPipelineState for the
following functions in ProgramExecutable:

hasUniformBuffers()
hasStorageBuffers()
hasAtomicCounterBuffers()
hasTransformFeedbackOutput()
getTransformFeedbackBufferCount()

The data structures those function were querying were recently moved
into the ProgramExecutable, so the call stack was:
ProgramExecutable -> ProgramState -> ProgramExecutable

This change updates the functions to return the results immediately.

Remaining functions to be cleaned up in later CLs:

hasDefaultUniforms()
hasTextures()
hasImages()

Bug: angleproject:4520
Test: Build/CQ
Change-Id: Ieaa041ff128e389f322745d55f688d4b07a5a23d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216764Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

77851053

Fill in missing GL methods for MemorySizeTest · 550bc069

authored Jun 03, 2020

Implements captures of glGetRenderbufferParameteriv,
glGetBufferParameteriv, and glgetAttachedShader. Fix FrameCapture and
CaptureReplay sample so that it has single-frame capture and replay
capabilities.

Bug: angleproject:4681
Bug: angleproject:4682
Change-Id: I12c25a3857a88f2f40b3c3e8624da1379a950339
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2229069Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

550bc069

Revert "Add trace event to angle Program compilation API" · be04c047

authored Jun 05, 2020

This reverts commit 7685a79e.

Reason for revert: Causing TSAN failures, see issue.

Bug: chromium:1091723

Original change's description:
> Add trace event to angle Program compilation API
> 
> Bug: chromium:1064662
> Change-Id: I2ee48718ff3946ab9307ba27177a02858bf436b0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230789
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=etienneb@chromium.org,jmadill@chromium.org

Change-Id: I92148677ac53c1ff7a9bc880e0a0834a03fc92ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1064662
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231870Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

be04c047

Fix UtilsVk::clearFramebuffer() for pre-rotation · ae9d1227

authored Jun 04, 2020

This fixes cases where pre-rotation wasn't occuring when glClear() was
implemented by a small shader.  A specialized viewport was generated
(thus, not with ContextVk::updateViewport()) for the entire
framebuffer.  However, the framebuffer width and height were not
swapped for 90/270-degree rotation cases, and so the wrong viewport.y
value was calculated.

Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_color_clear*
Bug: b/157933235
Bug: b/157933198
Change-Id: I1ac158c84ef812c8863dee01c6c8bfe9295b900e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231597Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

ae9d1227

Roll VK-GL-CTS from 80dc8399b063 to a60f89ffcba2 (8 revisions) · eef10995

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/80dc8399b063..a60f89ffcba2

2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master
2020-06-04 ari.suonpaa@siru.fi Test multiple fragment output locations
2020-06-04 rgarcia@igalia.com Try spec constants with more sizes and packing
2020-06-04 pawel.ksiezopolski@mobica.com Add tests for VK_EXT_filter_cubic
2020-06-04 pdaniell@nvidia.com Fix VkPhysicalDeviceMemoryBudgetPropertiesEXT
2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master
2020-06-04 dcastagna@google.com Fix compilation on clang 11
2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com
Change-Id: I882e93a2b23ad3d42e7684f484bf9c30a5585805
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232182Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eef10995

Roll SwiftShader from 0711869b5f20 to e3eb327e8c3c (1 revision) · 6dfa959b

authored Jun 05, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/0711869b5f20..e3eb327e8c3c

2020-06-05 caio.oliveira@intel.com Convert Vulkan headers from CRLF to LF endings

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Id6e28b1cfb3a6acc40ce2767ff1d596e81e74856
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232224Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6dfa959b

Roll Vulkan-Tools from 322784a873be to 5b40c4aa0dba (1 revision) · d3552246

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/322784a873be..5b40c4aa0dba

2020-06-04 tobine@google.com icd:Correctly Support Vulkan 1.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ie781511cd2b3bdf126fe6aa5c9604b92abdeff0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232223Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d3552246

Roll SPIRV-Tools from 636f449e1529 to 74130f2d3ab1 (1 revision) · 8e5f60d3

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/636f449e1529..74130f2d3ab1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I4e27322e13ee837891602b588d66cdd85823b0a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232220Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8e5f60d3

Roll glslang from 232ba0d848d1 to 8111268575a4 (2 revisions) · 1115df9c

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/232ba0d848d1..8111268575a4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I3dccd282ff457da63900059f4127e07bfd013ba6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232222Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1115df9c

Vulkan: Enable passing tests · 57f7b690

authored Jun 05, 2020

Bug: angleproject:3950
Change-Id: I091d99951772479ef2fbdb2ac51e5bf52a263da7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231983Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

57f7b690

Vulkan: Fix clear of non-zero-base-level images · da958a59

authored Jun 04, 2020

The staged resource updates adjusted their level to take base level into
account, but clear updates used a cached unadjusted value.

Bug: angleproject:3148
Change-Id: I9a49d5341083b2f870baa1ee6053e54baef35086
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230786
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

da958a59

04 Jun, 2020 14 commits

doc: Chromium branch autorollers · b10f4b94

authored Jun 04, 2020

Bug: angleproject:1944
Change-Id: I8359bcc99389fd416d2c8cedc880bc2c00291bee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230793Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

b10f4b94

Add trace event to angle Program compilation API · 7685a79e

authored Jun 04, 2020

Bug: chromium:1064662
Change-Id: I2ee48718ff3946ab9307ba27177a02858bf436b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230789
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7685a79e

Allow lines up to 72 characters in commit messages · 462e40f2

authored Jun 04, 2020

72 is the limit, not 71.  See:

    https://stackoverflow.com/a/17792445/912144

Bug: angleproject:4683
Change-Id: Icb53f2d532b9b55e31e3f1593bd2302a3011095e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230785Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

462e40f2

Roll third_party/vulkan_memory_allocator/ dac952eb0..431d6e572 (4 commits) · b22ecc6f

authored Jun 04, 2020

https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/dac952eb0a27..431d6e57284a

$ git log dac952eb0..431d6e572 --date=short --no-merges --format='%ad %ae %s'
2020-06-04 adam.sawicki Fix VmaAllocator_T::ImportVulkanFunctions_Dynamic for cases when Vulkan 1.1 is used
2020-05-25 adam.sawicki Remove invalid outdated assert in vmaBeginDefragmentationPass
2020-05-08 Adam.Sawicki Clarified documentation in few places to mention textures need to use LINEAR layout when accessed from the host
2020-05-03 hartmut.behrens fix(docs): instance not optional in quick start

Created with:
  roll-dep third_party/vulkan_memory_allocator

Bug: angleproject:4685
Change-Id: Icdc6123529971d8b7392da8d332efcc8a4873ea4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230902Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

b22ecc6f

Rename Platform.h to PlatformMethods.h. · 0df92012

authored Jun 03, 2020

"platform.h" is too common a name and causes headers to be
included incorrectly. Disambiguate the header using a more
specific name.

Solves a problem that came up with the GLES 1 tests and the
standalone test harness.

Bug: angleproject:3162
Change-Id: I88229a2c9407e0db57f5beee44daa11a4075f700
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2229065
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

0df92012

Allow line formats to pass description body's line length check · 505b6eb1

authored Jun 04, 2020

1. Lines starting with 4 spaces will not be checked for line length
2. Lines with no space in it will not be checked for line length

Bug: angleproject:4683
Change-Id: Ic648b8b1084762da208d89ee5fbff2b02b69cf12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230899Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

505b6eb1

Re-enable ShouldClearOpaqueFdRGBA8 on Pixel2 Vulkan · 0117ba26

authored Jun 03, 2020

Bug: angleproject:4630
Change-Id: Ib1e7ecd9bedf6841489f7fb5bba9cae8881aa33e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2229067
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0117ba26

Vulkan: Cleanup unused variable in submitFrame() · 3afad5b7

authored May 26, 2020

Bug: angleproject:2046
Change-Id: I9cc7c2cbb0bf9535885cc909a046d36691b8fcc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230385Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

3afad5b7

Roll glslang from 78a3c915a1d7 to 232ba0d848d1 (1 revision) · cabedcaf

authored Jun 04, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/78a3c915a1d7..232ba0d848d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I9c37a9d48a9f601dadbd891ae09f28c9d3110375
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230298Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cabedcaf

Roll Vulkan-ValidationLayers from d43f5107400d to 4685ffce93ad (5 revisions) · 23d4caea

authored Jun 04, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d43f5107400d..4685ffce93ad

2020-06-03 tony@lunarg.com tests: Test push descriptor image layout validation
2020-06-03 tony@lunarg.com layers: Allow validation of push descriptors
2020-06-03 s.fricke@samsung.com layers: Label and fix Maintenance1 VUs
2020-06-03 mark@lunarg.com practices: Avoid null pApplicationInfo deref
2020-06-03 christophe@lunarg.com docs: Fix link to LAYER_CONFIGURATION.md, issue #1902

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Id57b5dd011dca2cb2950187f1894cb0255c676d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230358Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

23d4caea

Roll SwiftShader from 3ad285a60d82 to 0711869b5f20 (1 revision) · 6cd99a0c

authored Jun 04, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/3ad285a60d82..0711869b5f20

2020-06-04 ari.suonpaa@siru.fi Add Z mirroring support for image blit.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I01a30c9a29e11f19b6b146a57221fcd20258f3a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230338Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6cd99a0c

Remove workaround for fixed compiler bug · 989c790d

authored Jun 03, 2020

Bug: chromium:951458
Change-Id: If55b10fb2db12fe37b9475d78266b7e6b92fcca7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227816
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

989c790d

Update and de-duplicate expectations file format comment · fabecfa7

authored Jun 03, 2020

Bug: angleproject:4675
Change-Id: Ieff7a4eae22a6d802c1fca6010cb74627d6e5777
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227815Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

fabecfa7

Add EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE · 8ba5cf99

authored May 28, 2020

This CL adds a new attribute that helps to identify
lower platform angle should use. We identified
several different use cases that ANGLE must
comply with when choose a display implementation.
Please refer to the
Support Matrix for EGL_ANGLE_platform_angle table

Bug: chromium:1084458
Change-Id: I6ea3d5081012ddf450f1c641343d1ba1a673483b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2210151
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>

8ba5cf99

03 Jun, 2020 7 commits

No-op incomplete framebuffer invalidation. · 98865915

authored Jun 02, 2020

It's always legal in GL to no-op framebuffer invalidation. When the
FBO is incomplete we can't pull RTs safely so no-oping incomplete
invalidate calls saves us from fuzzer bugs and crashes.

Bug: angleproject:3971
Change-Id: Ide550a22e6c17a28e5042165831dd684567d81fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227038
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

98865915

Fix validation of PVRTC compressed texture sizes. · 3ecaa283

authored May 22, 2020

The PVRTC format, as pointed out by Le Hoang Quyen and Geoff Lang,
uses 4x4 or 8x4 blocks, but due to sampling from adjacent blocks,
requires a minimum size of 2x2 blocks per the OpenGL extension:
https://www.khronos.org/registry/OpenGL/extensions/IMG/IMG_texture_compression_pvrtc.txt
. Thanks to Quyen and Geoff for pointing out the intricacies.

Add a helper function to formatutils.cpp which returns the minimum
number of blocks (width and height) for a given compressed texture
format, and incorporate this into the compressed texture size
computation.

This patch makes WebKit on ANGLE pass WebGL's PVRTC compressed texture
test on iOS hardware.

Bug: angleproject:4652
No-Presubmit: True
Change-Id: I1046a091321b7948d712d16686ee0cb8795b8c99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2213676
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3ecaa283

Vulkan: Correct the viewport before intersecting it with the scissor. · f2d4abb2

authored May 25, 2020

Eliminate the potential for integer overflow when clippling a large
viewport rectangle by first limiting it to the Vulkan viewport size
limits.

BUG=chromium:1078378

Change-Id: I2648c6136d2d27d67a3fc5dae2de821279d70d81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2215308Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

f2d4abb2

Vulkan: Remove validation error suppressions for VVL bug · b131d25f

authored Jun 03, 2020

These warnings were generated due to a validation layer bug, which is
presumably fixed now.

Bug: angleproject:4572
Bug: angleproject:4577
Bug: angleproject:4578
Bug: angleproject:4579
Bug: angleproject:4580
Bug: angleproject:4583
Change-Id: I8799c4e33bc38f83e0fdd364cf6e7eb607c39890
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227810Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

b131d25f

Vulkan: Remove validation error suppression for fixed issue · 8f3aa154

authored Jun 03, 2020

Bug: angleproject:3450
Change-Id: Ie88aedae6e4573b2c31e389f7d0ff5c8d1059647
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227856Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8f3aa154

Vulkan: Pre-rotate dFdx() & dFdy() for Android · 11d7b952

authored Jun 02, 2020

Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_shaders_derivate
Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest.OrientedWindow
Bug: b/157476241
Change-Id: I7b60b7a33313ba91731755d289792bd0968515c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2222825
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

11d7b952

Presubmit script to enforce commit message formatting · ebc6d0a4

authored May 27, 2020

1. The first sentence description should be one line <= 64 characters
2. The description body should be wrapped to <= 71 characters
3. Blank lines between the description and the body,
and the body and the meta-tags like Bugs

Bug: angleproject:4662
Change-Id: I966c79d96175da9eee92ef6da20db50d488137b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2218696Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

ebc6d0a4