This reverts commit b1917fe1.

Reason for revert: Not the root cause. See bug.

Original change's description:
> Revert "Vulkan: Use specialization constant for halfRenderAreaWidth"
>
> This reverts commit ff38106d.
>
> Reason for revert: Speculative revert to clear up AMD. See bug.
>
> Bug: chromium:1154356
>
> Original change's description:
> > Vulkan: Use specialization constant for halfRenderAreaWidth
> >
> > halfRenderArea is used by fragment shader to adjust gl_FragCoord for
> > rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
> > shader via specialization constant, thus allow compiler to consolidate
> > the calculation into one MAD instruction.
> >
> > Bug: b/173800146
> > Change-Id: Id66301278e3389e2582369b695825e632bccecee
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
> > Commit-Queue: Charlie Lao <cclao@google.com>
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Tim Van Patten <timvp@google.com>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
>
> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com
>
> Change-Id: Idab612bcad4f179857c41ffc4bf8fa2355fae946
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: b/173800146
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568244
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

# Not skipping CQ checks because this is a reland.

Bug: chromium:1154356
Bug: b/173800146
Change-Id: I5b86bbee8600c6597620f31d8d7b08ca8b3d2d57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568246Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

MultithreadingTestES3.MultithreadFenceDraw
MultithreadingTestES3.MultithreadFenceTexImage

Fail with Mesa 20.0.8

Bug: angleproject:5418
Change-Id: Ie4254fe4a9c3f8b95fde30181065ddb31190fb99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568551Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This is a reland of abcabb47
only we continue to suppress the validation error

Original change's description:
> Vulkan: Fix incorrect exposure of sRGB extensions
>
> When we check to see what formats we can reinterpret for sRGB
> extensions, we need to make sure we can match the image usage
> flags as well. If the original format supports framebuffer
> attachment usage, we need to make sure that the reinterpreted
> format can support it as well.
>
> Bug: angleproject:5309
> Change-Id: I7e84d01004504f854a3e22227e99b1740ed1a2b2
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2549156
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5309
Change-Id: I0efb6180b7be4e14d24b4bb339de01a2b9177e7e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2556571
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This reverts commit ff38106d.

Reason for revert: Speculative revert to clear up AMD. See bug.

Bug: chromium:1154356

Original change's description:
> Vulkan: Use specialization constant for halfRenderAreaWidth
>
> halfRenderArea is used by fragment shader to adjust gl_FragCoord for
> rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
> shader via specialization constant, thus allow compiler to consolidate
> the calculation into one MAD instruction.
>
> Bug: b/173800146
> Change-Id: Id66301278e3389e2582369b695825e632bccecee
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

Change-Id: Idab612bcad4f179857c41ffc4bf8fa2355fae946
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/173800146
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568244Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will prevent symbol collision with X11. This fixes the
build integration with Skia.

Bug: angleproject:2621
Bug: angleproject:5416
Change-Id: I6949a375cf9fcdd790b4c40ffb82c7c25bc15315
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567644
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

When a test mark as flaky fails consistently we need to avoid marking
the test as flaky. We treat is as a deterministic failure. This means
we output "PASS" as the expected result instead of "PASS FAIL". That
change will produce the correct behaviour with the test scripts.

Also adds missing test runner output when we retry a flaky test.

Bug: chromium:1152515
Change-Id: I9e3cbaf04ea57a198717ee81505b5d63a9183410
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568231Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We were leaking BufferHelper pointers in a couple cases. Fix these
systematically by using a unique_ptr template.

This leak was detected running ANGLE with LSAN enabled.

Bug: angleproject:5377
Change-Id: I30ab235105cf74fae2cfc62a22dde534e2d07e81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567641Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reduces the proliferation of small entry point files.

Bug: angleproject:2621
Change-Id: Ib882fd9e32e165279439d5d6cab7205eae0732ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2566592
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

This reduces code duplication in a few generator scripts. The version
lists are now located in registry_xml.

Bug: angleproject:2621
Change-Id: Ia1470f2863753d78d8def1132a20e81d3f8ec4a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2566591Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/9dff6a3bb595..bfb211914759

2020-11-30 aeubanks@google.com Fix swiftshader_reactor_llvm_unittests under UBSan Vptr
2020-11-30 srisser@google.com Accept Sign/Zero Extend operands in OpImageRead
2020-11-30 srisser@google.com Implement shaderSubgroupBroadcastDynamicId
2020-11-30 bclayton@google.com SpirvShaderDebugger: Fix crash when attempting to display nullptrs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I5fac2d07d616a3dc71651a69963d49e0125bfde8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567669Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/2232da5cfdfa..db49fa80f93d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3328d0bdee..70bbe68c87
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/88c7098f26..8a83254bed
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5537c03942
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/20f5376c29..8636efe70f
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/212bc84e4e..1e9edde7ad
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: I9b263ae7702473b66663e53b7a46764a217e65c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567712Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Expose OES_framebuffer_object extension for GLES1 contexts.

Bug: angleproject:5401
Test: FramebufferObjectTest*
Change-Id: I63b504f580cdab4655b4bfbd3438bcd807b422ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561795
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

halfRenderArea is used by fragment shader to adjust gl_FragCoord for
rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
shader via specialization constant, thus allow compiler to consolidate
the calculation into one MAD instruction.

Bug: b/173800146
Change-Id: Id66301278e3389e2582369b695825e632bccecee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This adds two final auto-generated files for the EGL and EXT extension
entry points. It adds a new data file that stores a mapping between
object types and entry points for associating labeled objects with
certain methods. When we generate errors we record the associated
object in the debug message output.

This places the remainder of the hand-written code in "stub" files.
Going forward the work for implementing new extension entry points
for EGL will be to update the registry XML files and then implement
the corresponding stub methods. Event logging, parameter packing,
and validation are all handled by the auto-generated code.

Bug: angleproject:2621
Change-Id: I28153432802c37b929ff2ea1e1a3e3ce9de91605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562680
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

Frames were captured in Surface::swap, but not in
Surface::swapWithDamage. Adds the same callback in
Surface::swapWithDamage and Surface::swapWithFrameToken.

Bug: b/174256233
Change-Id: I3425fa2b9ae388f62f616dd2c9444797358ba148
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2560726Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will allow us to use the same method with EGL without
complications.

Bug: angleproject:2621
Change-Id: I03dea2291adc13025723fe02eb47b76a74cef911
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562679
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

This both generalizes the GL entry point enum to include other APIs
like EGL and inserts the EGL and WGL entry points into the enum.

This will faciliate EGL entry point auto-generation and also frame
capture for EGL entry points.

Bug: angleproject:2621
Change-Id: Iaf4310e03b3d55839dd1328362fb29dcef918fab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2555861
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

This will enable accurate XFB primitive counts when using tessellation
and geometry shaders. Adds new vk::QueryResult and gl::QueryTypeMap
helper classes.

Based on contributions by Mohan Maiya (m.maiya@samsung.com).

Bug: angleproject:3572
Change-Id: Ie3f496deda887c13bb4ad7ab430e31d615849bfd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2564002
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>

When iterating over a bitset of stages, they are now processed in the
same order as the rendering pipeline.

Bug: angleproject:5405
Change-Id: If9e0f24be047b060f759e0e1db622a91e24e9646
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2564008Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8756b1cb930a..ce0450b9e8e5

2020-11-29 lionel.g.landwerlin@intel.com tests: Add  test for DRM_FORMAT_MOD 02248 check
2020-11-29 lionel.g.landwerlin@intel.com layers: Add VK_EXT_image_drm_format_modifier flag VUID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ie6c9fde1beb8f1c231231aa1f0755d2cc56f11fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2564209Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

If any JSON files get out of whack this will print which file is
malformed. Also will show any temporary files (e.g. .rej or .orig)
as untracked in the code generation hashes dir.

Bug: angleproject:3691
Change-Id: I534e87bd2ea692182aa558bb80e09fb526e441b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2564000Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/553b5bcd72c7..2232da5cfdfa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/169d15ccdb..3328d0bdee
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/913fc377e5..88c7098f26
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7598272651
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5726acbc16..20f5376c29
* tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e
* tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e
* tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e
* tools/skia_goldctl/linux: 7OAln1cRnDCb00TBld5dPAV-X6ezVIxW3xzBDZW9CCkC..qmz8kJxTUN_Mt51qpFOU1gn2Es-tf5fUQbm_dwWR4WsC
* tools/skia_goldctl/win: yZ7VbaW1KAIyuzwfeFwPomNFownHQYrrzEEe9ZdOpZsC..VR4k806B8ASaIGHP_wz13-mO3s-X-NxvU7dSULraOMEC
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: I095829440625539b0851e53d1cec470ec21453d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2564888Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Fails on Windows and Linux.

Bug: angleproject:5412
Change-Id: I0a8a0d194c63a92ede0f10cd89eb3db703b93ea2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562756Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:5404
Change-Id: I51df1ad69a65b17621a3cbe4e5d55621cc9ae6ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562683Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/43bb60e1fa11..9dff6a3bb595

2020-11-26 rharrison@chromium.org Roll SPIRV-Headers and SPIRV-Tools

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I6979f43bb1d14f26f17596519f7cb7fd45018832
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2563246Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1835944edcfa..8756b1cb930a

2020-11-26 mark@lunarg.com threading: Check DevWaitIdle ext sync on all device queues

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I5680ab2a1ad29b69e1c8f021423a46189d6dcec7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2563247Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/730f0fe9e50a..553b5bcd72c7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7b7e25e69c..169d15ccdb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c3ae330521..913fc377e5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ae003f552e
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/41850cbe98..5726acbc16
No update to Clang.

Bug: None
Tbr: jmadill@google.com
Change-Id: I16054c13a2481e7c544c046289b4de5e0dcdeb83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2563278Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

When a varying precision mismatch is present between two stages, the
SPIR-V transformer transforms the following:

    in precision1 type1 inVar;
    out precision2 type2 outVar;

    void main()
    {
        f(inVar);
        outVar = g();
    }

to:

    in precision3 type1 inVarModified;
    out precision4 type2 outVarModified;
    precision1 type1 inVarTurnedPrivate;
    precision2 type2 outVarTurnedPrivate;

    void main()
    {
        // Input preamble
        inVarTurnedPrivate = inVarModified;

        f(inVarTurnedPrivate);
        outVarTurnedPrivate = g();

        // Output preamble
        outVarModified = outVarTurnedPrivate;
    }

This doesn't work for geometry shaders as they take the varying outputs
on EmitVertex() as opposed to return from main.  This change simply
places the output preamble before every EmitVertex() instead of at the
end of the shader, if it's a geometry shader.

Bug: angleproject:5403
Change-Id: Ie395a3270c6903c54b49f64a26bc5297044cbaeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561939
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3588
Change-Id: I5b7d3151b34a77998b25dd4fa5761c92d74d8c81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562120Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Moves some include definition blocks into constants. Also fixes a
small case error in the capture headers.

Bug: angleproject:2621
Change-Id: I0e5eadcfd8e16969f3502339f58dbf13eb53f43c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2555860Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Partial support for GS was added by jaedon1.lee@samsung.com already.
This change enables the extension and adds suppressions for GLES3.1 dEQP
tests.  Suppressions for KHR GLES3.2 will be updated separately as
currently GS shaders in "version 320" fail validation.

Bug: angleproject:3571
Change-Id: Ic6ed65554937fd0cce2d0f6ea0ac2eb7e6ed9f10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561445Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

In GL ES, depth is always clamped to [0,1].
The same is true in Vulkan, but not for implementations affected by
Nvidia bug 3171019. This patch implements a workaround.
The workaround introduced test failures on Linux with Nvidia Quadro P400
and driver version 418.56, so it's only applied conditionally, and as a
result the test failure expectations are not removed completely.

Bug: angleproject:3970
Change-Id: I0d9f855d7f3df72fea4af9f9b134ae3177cf820d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514377
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Moves the generators from SpirvVertexAttributeAliasingTransformer to the
base class, and makes SpirvTransformer use the same functions.

Bug: angleproject:4889
Change-Id: I1f105e2ac764fc7b36c8c75d2cf5f30dec841f97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561938Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fc78e93ce895..1835944edcfa

2020-11-25 s.fricke@samsung.com layers: Label VU 04563
2020-11-25 locke@lunarg.com tests: Fix wrong descriptor type
2020-11-25 locke@lunarg.com layers: Skip some CMD_TYPE
2020-11-25 mark@lunarg.com tests: Add some checks for imageFormatMaybeLinear & 02259
2020-11-25 mark@lunarg.com stateless: Calculate correct state for 02257, add 02259
2020-11-25 mark@lunarg.com corechecks: Use named initializing for vuid structs
2020-11-25 mark@lunarg.com drawdispatch: Use named initializing for DrawDispatch structs
2020-11-25 mark@lunarg.com corechecks: Moved some #defines to static consts
2020-11-25 mark@lunarg.com cmddraw: Align non-CF'd source

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I52a4be5687c435eacd719b46652fe26693291313
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562032Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/4b04564d4cb2..730f0fe9e50a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/66f22dbb61..7b7e25e69c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/70017627a0..c3ae330521
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dea56e139b..5d6094bfbc
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ae003f552e
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/74b8b81586..212bc84e4e
* tools/skia_goldctl/linux: F1V3MxURYBy3ZkQCqWrW-_qo1aZFer1oyHdGOjT_CZoC..7OAln1cRnDCb00TBld5dPAV-X6ezVIxW3xzBDZW9CCkC
* tools/skia_goldctl/mac: Z_FxtkL4vnfqaGkZhy2qkTcVwRXIfMzIP0gDJO5O6HkC..VNy9awCiFUEMvA_Yv0NaAUvTu5qcX1KK9w7RAp7kua8C
* tools/skia_goldctl/win: qZ2Cb5DPSSKjIrxhfYGgVzooq2ElNVLxNOVjsMKgfV0C..yZ7VbaW1KAIyuzwfeFwPomNFownHQYrrzEEe9ZdOpZsC
No update to Clang.

Bug: angleproject:3379,angleproject:4852,angleproject:5391
Tbr: jmadill@google.com
Change-Id: I101efb4811fdded81e24480b1bf0fec0cb8b314c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561424Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

The copy between emulated RGB formats can take a number of paths:

- Sample from src (reinterpreted as UINT), output to dst
- Sample from src, output to temp buffer, copy to dst
- Copy src to temp buffer, output to dst
- Copy src to temp buffer, convert to another temp buffer, copy to dst

While directly sampling from src and outputting to dst is more
efficient, these are not always possible.  The former may not have
SAMPLED_IMAGE usage bit for the reinterpreted UINT format, and the
latter may not have STORAGE_IMAGE usage at all.

This change takes the universal approach of using two temp buffers.  The
ConvertVertex shader is used to transform between RGB and RGBA when
copying from the first temp buffer to the second.

Bug: angleproject:5278
Change-Id: I63d916cfdb4c389f5b817d89cd7348fdea703ce5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2556467
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Schade <b.schade@samsung.com>

A test is added that uses the RedGreenGradient shader, which doesn't
include gl_SampleID, gl_SamplePosition or the sample qualifier, but uses
GL_SAMPLE_SHADING to perform per-sample shading.  The samples from the
resulting image are copied to a buffer in compute and verified.

Bug: angleproject:5395
Change-Id: I3567329e4d567d149e4548eb12222b8dd5255bba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2559266
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>

In prepration for EXT_copy_image taking advantage of ConvertVertex.
Also a small optimization to this ALU heavy shader.

Bug: angleproject:5278
Change-Id: I6520391fe1af608db66f8c362f1038786b2c65e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2556466Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:5395
Change-Id: I5cebb30fa71ad3c6f04a185ee992f77a900e6b26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2558931
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The shader directly used v_position.xy as output color, but for half of
the image x and y are negative and the respective channel became zero.

This change makes the shader use v_position.xy*0.5+0.5.  Additionally,
the tests that use this shader are changed to mathematically derive the
pixel colors instead of using magic numbers.

Bug: angleproject:5395
Change-Id: Ic11c362c22ca725aa173faa5fd6033a02a4303fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2559265Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>