Commits · 736164ff79bedba62706112e3858b7b2af5247ef · Chen Yisong / angle

19 Nov, 2019 12 commits

Headers: Add EGLAPI to SwapBuffersWithFrameTokenANGLE · 736164ff

authored Nov 15, 2019

Bug: angleproject:4116
Change-Id: I83392c7bad002d9b6b939983385ace7c9ebcc090
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919633Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

736164ff

Vulkan: Ensure consistent limits for texture & framebuffer · d8531638

authored Nov 14, 2019

GLES 3.1 requires that the maximum framebuffer width & height be
at least as large as the maximum texture size. Vulkan doesn't have
that requirement and for SwiftShader the values are different
(4096 for FB, 8192 for texture). Use the smaller of the two to
keep things consistent.

Test:
  angle_deqp_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP-GLES31.functional.state_query.integer.max_framebuffer_*

Bug: angleproject:4102
Change-Id: Ie04a5272084c5f6a19ac06d952281b7df9fe9a06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1917130
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

d8531638

EXT_multisampled_render_to_texture clean up and prep for 2DMultisampleArray. · 3b43647f

authored Nov 15, 2019

1) Added new Multisampled Image Index. For the upcoming
multisampled array case, we cannot automatically create the same
MS image index during resolve. So the correct MS image index is created and
saved during the initial creation of the MS Texture. It seems to be more
streamlined as well, only creating the MS image index once, and not using
hardcoded values to get the subresourceIndex.
2) reordering resolveTextureHelper to remove duplicated code.

Bug: angleproject:3107
Change-Id: Ifd91136a64efb5e7bd296e09cd876a6e6eb8e77e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919555
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3b43647f

Skip crashing KHR tests on Nvidia · cbabb453

authored Nov 19, 2019

Tests were previously disabled on Nvidia, but this was erroneously
narrowed to Linux.

Bug: angleproject:4128
Change-Id: I9b96e84341c7c3352eaefbba73fdc5b2c67a921e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924791Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

cbabb453

Skip TextureNorm16Test on Nexus6P · 9107577c

authored Nov 18, 2019

Since either revert of the original patch or the new fix is failing
some bots, suppress it first.

https://chromium-review.googlesource.com/c/angle/angle/+/1917423
https://chromium-review.googlesource.com/c/angle/angle/+/1914127

TBR=geofflang@chromium.org

Bug: 1024387, angleproject:4089
Change-Id: I56fe0ba7e8a33f72b287528e920d6733e9cb5037
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1922602Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>

9107577c

Add support for gl_HelperInvocation · 240befe5

authored Nov 15, 2019

Added HelperInvocation to builtin_variables.json, regenerate the codegen
portions of compiler, and plumb support for HelperInvocation through the
rest of the compiler.

Skipping some fails on Android and Swiftshader for this initial change and
will debug/fix those issues in a follow-on.

Bug: angleproject:4110
Change-Id: I781a2782ace84200bc615a2cc26b908a62e2aa26
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1922061
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

240befe5

Add suppressions for failures on Intel/Linux · 377b8caf

authored Nov 19, 2019

The refactor to angle_end2end_tests added tests to OpenGL ES and
some of these tests are failing on Intel/Linux. Skip those tests
for now.

Bug: angleproject:4121
Change-Id: I7a56099faac558a4e18d98eb5f0b25522d656e61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924061
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

377b8caf

GN: Make X11 optional, based on a user-defined variable. · d22b8be4

authored Nov 15, 2019

Not all Linux platforms will have X11 available (Wayland, GGP), so we have to
declare a variable that checks use_x11 separately.

Bug: angleproject:4116
Change-Id: I7e33956da6344b8db4d4e32dbbd1b42f58f7019c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919632Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d22b8be4

Metal: support texture's incomplete image definitions. · 53e45360

authored Nov 09, 2019

glTexImage*, glCopyImage* will copy data to the image at the respective
index, then during draw call, the image data will be transferred to
real Metal texture.

Test done: MipmapTest.DefineValidExtraLevelAndUseItLater

For implementation notes, see
src/libANGLE/renderer/metal/doc/TextureDataCompleteness.md

Bug: angleproject:2634
Change-Id: I0ca24c8beff2e109a794260c436985e9f4650d83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906609
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

53e45360

Roll third_party/spirv-tools/src c3f22f7cba60..57b4cb40b21d (1 commits) · 24d7e23e

authored Nov 19, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c3f22f7cba60..57b4cb40b21d


Created with:
  gclient setdep -r third_party/spirv-tools/src@57b4cb40b21d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=courtneygo@google.com
Change-Id: Id232a52bf6585b6920bcc89c90f5d4a78303c3db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1923343Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

24d7e23e

Roll third_party/vulkan-validation-layers/src e2441190bb0c..c2bd11586919 (2 commits) · 7b70f75a

authored Nov 19, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e2441190bb0c..c2bd11586919

git log e2441190bb0c..c2bd11586919 --date=short --no-merges --format='%ad %ae %s'
2019-11-18 petr_kraus@email.cz tests: Test swapchain acquire for sync param
2019-11-18 petr_kraus@email.cz layers: Migrate swapchain acquire check to stateless

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@c2bd11586919

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=courtneygo@google.com
Change-Id: I30072791f6789163859db13874da74ad611cabf3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1923342Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7b70f75a

Roll third_party/SwiftShader aba1020d3914..79afb7620a69 (5 commits) · d47076f2

authored Nov 19, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/aba1020d3914..79afb7620a69

git log aba1020d3914..79afb7620a69 --date=short --no-merges --format='%ad %ae %s'
2019-11-18 chrisforbes@google.com Remove vulkan.hpp
2019-11-18 bclayton@google.com Pipeline: Add custom debug printers for SamplerFunction.
2019-11-18 bclayton@google.com Reactor: Change the signature of PrintValue::Ty
2019-11-18 bclayton@google.com Reactor: Handle more implicit casting for Call() arguments
2019-11-18 swiftshader.regress@gmail.com Regres: Update test lists @ aba1020d

Created with:
gclient setdep -r third_party/SwiftShader@79afb7620a69

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=courtneygo@google.com
Change-Id: Iae58f8caf12a61d228d2d6ae937ab437313e1f2b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1923340Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d47076f2

18 Nov, 2019 6 commits

Update front-end image test failures' bug number · e4b31369

authored Nov 18, 2019

Bug: angleproject:3563
Bug: angleproject:4124
Change-Id: I105c3ddecb5a558fd4fcbaa824c1374bd01234ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1921631Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e4b31369

Vulkan: Fix col-major transformation of unsized arrays · db3e5183

authored Nov 14, 2019

If the row-major expression that was being transformed was in the form:

     arr.length()

where `arr` is an SSBO unsized array, the translator transformation was
attempting to transpose the `arr` expression, which is both wrong and
impossible.  Note that length() is removed through a prior
transformation except for this particular case.

This change recognizes this usage and supports it by keeping the
expression as is (as the length() would be identical pre or post
transformation).

Bug: angleproject:3443
Change-Id: I8efacb7b12d5e53047eb56ab5d86830d81952d86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1917422Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

db3e5183

Roll third_party/vulkan-headers/src d42d0747ee1b..ba6cbb047868 (1 commits) · 430d4059

authored Nov 18, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d42d0747ee1b..ba6cbb047868

git log d42d0747ee1b..ba6cbb047868 --date=short --no-merges --format='%ad %ae %s'
2019-11-18 oddhack@sonic.net Update for Vulkan-Docs 1.1.128

Created with:
gclient setdep -r third_party/vulkan-headers/src@ba6cbb047868

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com,borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=borenet@google.com, courtneygo@google.com

Bug: None
Change-Id: I7ae8bd8f3081239cb71b5f7f1ddf328a356eaac1
Tbr: courtneygo@google.com,borenet@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1921815Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

430d4059

Roll third_party/vulkan-validation-layers/src f8ea20adee82..e2441190bb0c (42 commits) · 95488813

authored Nov 18, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f8ea20adee82..e2441190bb0c

git log f8ea20adee82..e2441190bb0c --date=short --no-merges --format='%ad %ae %s'
2019-11-15 s.fricke@samsung.com layers: Add ext mem check for vkGet*MemReqs
2019-11-14 camden@lunarg.com tests: Add test file for BP and move 1 test
2019-11-14 camden@lunarg.com CMake: Add vklayertests_best_practices.cpp to CMake
2019-11-14 camden@lunarg.com layers: Remove DrawCmd perf warning from Buf Val
2019-11-14 camden@lunarg.com layers: Add DrawCmd perf warning to Best Practices
2019-11-14 mark@lunarg.com tests: Verify reset/use of qpool in different command buffers
2019-11-14 mark@lunarg.com corechecks: Enable querystate tracking across multiple submitInfos
2019-11-13 tony@lunarg.com tests: Add mechanism to deal with duplicate errors
2019-11-12 mark@lunarg.com tests: Add secondary CB VkSubmitInto validation check
2019-11-12 mark@lunarg.com corechecks: Add secondary CB VU check
2019-11-12 mark@lunarg.com corechecks: Fix propagation of skip in CB state validation
2019-11-12 mark@lunarg.com build: Add VUID coverage text file to AppVeyor artifacts
2019-11-07 pdaniell@nvidia.com tests: Add tests for VK_KHR_separate_depth_stencil_layouts
2019-11-07 PDANIELL@nvidia.com layers: Add support for VK_KHR_separate_depth_stencil_layouts
2019-11-05 shannon@lunarg.com build: Update known-good for 1.1.127 header
2019-11-04 jbolz@nvidia.com layers: Update ValidateShaderStageInputOutputLimits to new spec rules
2019-11-01 mark@lunarg.com cmake: Restore creation of standard validation json file
2019-11-01 jmacnak@gmail.com tests: Add RT shader group tests
2019-11-01 jmacnak@gmail.com layers: Add RT shader group validation
2019-10-31 mikes@lunarg.com tests: Add macOS loader filename
2019-10-31 locke@lunarg.com tests: Swapchain image layout
2019-10-31 locke@lunarg.com layers: Swapchain pluarl bound_images
2019-10-30 tony@lunarg.com gpu: Add more positive tests
2019-10-30 mark@lunarg.com tests: Remove android limits workaround
2019-10-30 mark@lunarg.com tests: Allow hw limits to override baked-in test GL limits
2019-10-29 bob@lunarg.com Android: Make tests more reliable
2019-10-28 shannon@lunarg.com build: Update known-good commits for SDK 126
2019-10-25 jeremy@lunarg.com layers: Fix attachment unused false positive
2019-10-25 mark@lunarg.com tests: Exclude GetomInputOutputComps limit test from Android
2019-10-25 mark@lunarg.com tests: Fix filter key for shaderc failure messages
2019-10-25 camden@lunarg.com layers: best_practices-Fix MemoryFree Exception
2019-10-25 camden@lunarg.com layers: Initialize numMemObjects in BP
2019-10-24 jeremy@lunarg.com layers: Validate specialization constants
2019-10-24 jeremy@lunarg.com build: Update glslang
2019-10-24 mark@lunarg.com layers: Removed obsolete layer-specific readme file
2019-10-24 mark@lunarg.com docs: Add layer configuration doc, shared with the SDK
2019-10-24 jbolz@nvidia.com tests: Add tests for externsync descriptorset updates
2019-10-24 jbolz@nvidia.com layers: Relax UPDATE_AFTER_BIND externsync rules in ThreadSafety
2019-10-23 bob@lunarg.com tests: Don't filter logcat messages
2019-10-22 shannon@lunarg.com build: Update known-good for 1.1.126 header
2019-10-22 jbolz@nvidia.com tests: Test CmdTraceRays with no descriptor set bound
2019-10-22 jbolz@nvidia.com layers: Add PreCallValidateCmdTraceRaysNV

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@e2441190bb0c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I6295c45e6bf565a98b22d05d4650c42d89d80c22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1921749Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

95488813

Roll third_party/glslang/src 37dcb894574e..f4d4668529f1 (1 commits) · bbdabb3b

authored Nov 18, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/37dcb894574e..f4d4668529f1


Created with:
  gclient setdep -r third_party/glslang/src@f4d4668529f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: Ibf838a97de16946b159063747250fc9338b0684a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1921747Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bbdabb3b

Roll third_party/SwiftShader 102fd19c65f4..aba1020d3914 (7 commits) · 37f7316e

authored Nov 18, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/102fd19c65f4..aba1020d3914

git log 102fd19c65f4..aba1020d3914 --date=short --no-merges --format='%ad %ae %s'
2019-11-15 bclayton@google.com Remove the now unused sw::Event.
2019-11-15 bclayton@google.com VkQueryPool: Migrate from sw sync to marl
2019-11-15 bclayton@google.com VkDevice: Migrate to using marl::Event::any()
2019-11-15 bclayton@google.com VkFence: Migrate to marl::Event
2019-11-15 bclayton@google.com Merge changes Ifb21caa2,Iaca5897d
2019-11-15 swiftshader.regress@gmail.com Regres: Update test lists @ cc221e83
2019-11-15 chrisforbes@google.com Update deqp to b64acc6c3371607583b3aa6d12c7290b4aaae747

Created with:
gclient setdep -r third_party/SwiftShader@aba1020d3914

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: Ie779409c1316d9b30cb91c6ad0df18a71ebfa634
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1921748Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

37f7316e

15 Nov, 2019 10 commits

Update dEQP 3.1 expectations · 51b5a322

authored Nov 15, 2019

Set bug 4110 for dEQP-GLES31.functional.shaders.helper_invocation.*

Bug: angleproject:4110
Bug: angleproject:1442
Change-Id: Ic1b62e5f1a1a47fd92420fb1aeab7f97dd9f75dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919549Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

51b5a322

Expose EGL_CHROMIUM_sync_control via GLX_OML_sync_control · a829c0b9

authored Nov 14, 2019

On GLX, we can expose the EGL_CHROMIUM_sync_control extension by
forwarding to GLX_OML_sync_control when it's available. This will help
with accurate vsync times for Chrome

Bug: 1020252
Change-Id: I9b1e8cf0f8b1a548cc7cc7202fac2d0cdb01d74d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918104
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

a829c0b9

Vulkan: Update Expectations with GLES 3.1 Conformance Failures · e4aa7235

authored Nov 13, 2019

Update the following expectations files with GLES 3.1 conformance
failures to help tracking:

deqp_gles31_test_expectations.txt
deqp_khr_gles31_test_expectations.txt

Bug: angleproject:4098
Bug: angleproject:4099
Bug: angleproject:4100
Bug: angleproject:4101
Bug: angleproject:4102
Bug: angleproject:4103
Bug: angleproject:4104
Bug: angleproject:4105
Bug: angleproject:3443
Bug: angleproject:4107
Bug: angleproject:4106
Bug: angleproject:4108
Test: None (test failures were collect with Khronos conformance run)
Change-Id: I9ea818f99c6b74602ea5321f393f0066bc115905
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914131Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

e4aa7235

Enable Metal backend. · deae1fce

authored Nov 09, 2019

Metal will be secondary default backend after OpenGL for now.

The tests will be enabled for metal in
CL http://crrev.com/c/1906607.

Bug: angleproject:2634
Change-Id: I109c641d749c2a207bbb7d500bc281ffb0b13848
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906612
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

deae1fce

Update GLES31 Expectations · 20f11f58

authored Nov 14, 2019

The following tests need to have their bugs corrected in
deqp_gles31_test_expectations.txt:

dEQP-GLES31.functional.separate_shader.*
dEQP-GLES31.functional.program_interface_query.program_input.resource_list.compute.empty
dEQP-GLES31.functional.program_interface_query.shader_storage_block.buffer_data_size.*

Bug: angleproject:3570
Bug: angleproject:3596
Test: None
Change-Id: I09807d86a2cec153fcb7d6b22407bdd0d84c44ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918045Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

20f11f58

Add a test to capture bug with LUMA blit workaround · 1c795d9e

authored Nov 12, 2019

This test captures a bug with state tracking in the BlitGL LUMA
texture workaround.

Bug: 1022080
Change-Id: I22d2eb0d653778be300ab4a1f6b27e67f8cf1cbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1912140Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

1c795d9e

Add android_ndk and catapult to .gitignore · 86f65119

authored Nov 15, 2019

BUG=angleproject:4026

Change-Id: I58ed4dea3c962c6a7c46deb69400b984d8a2ea30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918569
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

86f65119

Roll third_party/spirv-tools/src 3da910d55f20..c3f22f7cba60 (2 commits) · 4207870b

authored Nov 15, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3da910d55f20..c3f22f7cba60


Created with:
  gclient setdep -r third_party/spirv-tools/src@c3f22f7cba60

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: Ibf9f114a42ab052536d3106b07227bd3cd6c0651
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918960Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4207870b

Roll third_party/SwiftShader b2407dd746de..102fd19c65f4 (4 commits) · 36fbe602

authored Nov 15, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/b2407dd746de..102fd19c65f4

git log b2407dd746de..102fd19c65f4 --date=short --no-merges --format='%ad %ae %s'
2019-11-14 amaiorano@google.com PixelRoutine: const-qualify reference parameters
2019-11-14 swiftshader.regress@gmail.com Regres: Update test lists @ b2407dd7
2019-11-14 capn@google.com Rasterize 'Bresenham' line segments as parallelograms
2019-11-14 sugoi@google.com Negative baseVertex support

Created with:
  gclient setdep -r third_party/SwiftShader@102fd19c65f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I624498c405221a12cfb1a6fbc5e62e5484457edf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1918961Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

36fbe602

Fix performance issue with EXT_multisampled_render_to_texture · 5f4db6a7

authored Nov 11, 2019

Adding a dirty flag to the mMSTexInfo struct so that the multisampled
texture does not get unnecessarily resolved on each call.

Bug: chromium:1019199
Change-Id: Ia9b24cd0a7f2d82f83f20f7e60f9f2b23383ec6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910531Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5f4db6a7

14 Nov, 2019 9 commits

Manually copy dEQP data files to output directory · 11c487a8

authored Oct 25, 2019

dEQP has data files that live in several directories within dEQP's
source tree. For example, GLES3 has data files that live within:

data/gles3/data/
external/graphicsfuzz/data/gles3/

However, we can only tell dEQP about a single data directory during
initialization of dEQP. To get around this, we are manually copying all
of the necessary data files to the output generated files directory and
pointing dEQP to this single directory. This also helps us solve a
second problem related to the paths that dEQP uses when accessing
graphicsfuzz data files.

For the graphicsfuzz tests, dEQP will attempt to open the necessary
shaders by accessing them with the path:

data/gles3/graphicsfuzz/

However, those files would normally live at the path that matches their
location within the source tree:

external/graphicsfuzz/data/gles3/graphicsfuzz/

As part of the manual copy of these data files, we are also able to
strip the extra 'external/graphicsfuzz/' portion of the path.

Bug: angleproject:2322
Test: dEQP
Change-Id: Ibc96442c221485e2f246890fa8fe51f090c5e222
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881759
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

11c487a8

Refactor end2end test macros · 1a01b4b3

authored Nov 11, 2019

This is a foundational CL to enabling the end2end tests on swiftshader.

Refactored infrastructure with new ANGLE_INSTANTIATE_TEST_ES*
macros that will run tests over all various combinations of all
platforms for different ES versions.

Just skipping failing tests initially to get the refactor landed.

Bug: angleproject:4081
Bug: angleproject:4092
Change-Id: I017f6c3267179e49b6ae08cc7488096b423dcdb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1904635
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

1a01b4b3

Treat VK_TIMEOUT as an error · 968df09e

authored Nov 11, 2019

The fence wait time was increased to 120 seconds, so we don't expect
VK_TIMEOUT to be returned by a healty GPU. This change makes it so that
when VK_TIMEOUT is returned, we will treat this as an error and
propagate it to the GLES application as a GL_INVALID_OPERATION.

It is expected that the GL application will re-initialize ANGLE which
will also reinitialize the Vulkan device (and hopefully clean up the
error). This is not our final design for ANGLE's VK_TIMEOUT handling,
since we expect to expand our Vulkan device lost error handling when
implementing the GLES 3.2 robustness requirements. This will likely
improve ANGLE's VK_TIMEOUT handling as well.

Bug: angleproject:4043
Test: Manually force VK_TIMEOUT (lower kMaxFenceWaitTimeNs)
Change-Id: I2449ad214ada176014a1702a9b3417d4498d070f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910722
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

968df09e

Vulkan: Enable 3.0 as default context version · 0e5d019e

authored Nov 08, 2019

Now that 3.0 support is passing dEQP, always return that as the
context version to use (unless app asks for 1.0).

Test: angle_end2end --gtest_filter=EGLBackwardsCompatibleContextTest.BackwardsCompatibleEnabledES3/*
Bug: angleproject:3750
Change-Id: I0402ac015acfc22e84a985fe75346999bcc47188
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906202Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

0e5d019e

Vulkan: Add 565 and validate pixel formats: Windows · edc560fe

authored Oct 31, 2019

Add support for 565 to Windows. Also includes code that verifies
generated configs can actually be supported by Vulkan.
Test:
--use-angle=swiftshader --deqp-gl-config-name=rgb565d0s0ms0 --gtest_filter=dEQP.GLES3/functional_fragment_ops_interaction_basic_shader_80

Bug: angleproject:4016
Change-Id: Idcfd4dd368c4a30ef177aa89e1035d2f00570c99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1885378Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

edc560fe

Support standalone Android builds in ANGLE. · 6e687af2

authored Oct 17, 2019

By disabling apk generation, we can build all of our targets in a
standalone ANGLE checkout on Linux.

This allows tools like gn desc to give us useful information about
Android builds.

BUG=angleproject:4026,angleproject:2344

Change-Id: Ic46348fd06c5174ce5e5a4d89ceb391246c6ac6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1866080Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

6e687af2

Roll third_party/spirv-tools/src ab3cdcaef56e..3da910d55f20 (3 commits) · 515f9beb

authored Nov 14, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab3cdcaef56e..3da910d55f20


Created with:
  gclient setdep -r third_party/spirv-tools/src@3da910d55f20

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: I8b6eea801806cefacb0db8f63f05609f5478029d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1915880Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

515f9beb

Roll third_party/SwiftShader 88632cac30e1..b2407dd746de (3 commits) · ae55a94f

authored Nov 14, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/88632cac30e1..b2407dd746de

git log 88632cac30e1..b2407dd746de --date=short --no-merges --format='%ad %ae %s'
2019-11-13 chrisforbes@google.com regres: Don't ignore abnormal exits
2019-11-13 swiftshader.regress@gmail.com Regres: Update test lists @ 88632cac
2019-11-13 digit@google.com [vulkan] Implement VK_KHR_external_memory_fd for Linux and Android.

Created with:
  gclient setdep -r third_party/SwiftShader@b2407dd746de

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cnorthrop@google.com
Change-Id: Ib24713050daecfc44bd0075f4896283e7232225f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1915881Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ae55a94f

Vulkan: Update bug numbers for GLES 3.1 "debug" expected failures · 1b52f058

authored Nov 13, 2019

I triaged these failures and put cross-backend failures in 2324, and
Vulkan-specific failures in 3590.

Bug: angleproject:2324
Bug: angleproject:3590
Change-Id: Iac806334f410d660c9af42a5c9101b26364911bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914928Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

1b52f058

13 Nov, 2019 3 commits

Roll third_party/vulkan-headers/src d287523f48db..d42d0747ee1b (6 commits) · f533355b

authored Nov 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/d287523f48db..d42d0747ee1b

git log d287523f48db..d42d0747ee1b --date=short --no-merges --format='%ad %ae %s'
2019-11-06 jmadill@chromium.org GN: Add support for Google Games Platform.
2019-11-06 8729214+jonahryandavis@users.noreply.github.com build: BUILD.gn missing defines for MacOS
2019-11-04 oddhack@sonic.net Update for Vulkan-Docs 1.1.127
2019-10-28 shannon@lunarg.com vulkan: Fix typo for `operator==` in `vulkan.hpp`
2019-10-25 shannon@lunarg.com vulkan: Update `vulkan.hpp` for VS2015 VT fix
2019-10-21 oddhack@sonic.net Update for Vulkan-Docs 1.1.126

Created with:
gclient setdep -r third_party/vulkan-headers/src@d42d0747ee1b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I36b0e8d3141bf621fdee054cd45d0e98cd3b70c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914130Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f533355b

Vulkan: Fix glMemoryBarrier* implementation · b3c4dffd

authored Nov 12, 2019

The indirect bit handling is no longer necessary, as setup*Indirect
functions already add the barriers if necessary.  The framebuffer bit
is unnecessary as the image layout transition from storage image to
framebuffer attachment would already add the necessary barrier.  Image
access bit was indeed necessary, but so is shader storage bit which is
added.

Bug: angleproject:3574
Bug: angleproject:3879
Bug: angleproject:3934
Change-Id: I9da722e7a34941932731335af2313783295031ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1913080
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b3c4dffd

ES31: Update Vulkan skip list for SSBO · feb3fb1a

authored Nov 12, 2019

This test is passing on multiple implementations locally, including
SwiftShader on Android.  Suspect a driver bug, will follow up with
vendor.

dEQP-GLES31.functional.synchronization.in_invocation.ssbo_alias_overwrite

Bug: angleproject:3602
Bug: angleproject:4097
Change-Id: I363ca6fe150419f4338988cf88c7926c689914b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1911293Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

feb3fb1a