- 06 Nov, 2020 24 commits
-
-
Courtney Goeltzenleuchter authored
Can enable/disable ANGLE feature via Android properties: debug.angle.feature_overrides_enabled and debug.angle.feature_overrides_disabled which take a string of ':' separated feature strings. Bug: b/170328907 Change-Id: I815b42c5cfae85a39f0f753eabd56e264ea38baf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514200 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Courtney Goeltzenleuchter authored
GetEnvironmentVarOrAndroidProperty will first return the given variableName from the processes enviroment if defined. If not defined and running on Android, will look up the corresponding property and store it in the environment. The framecapture code wants to see when the Android property changes so add an uncached version of GetEnvironmentVarOrAndroidProperty that always does the getprop command (which can be time consuming). Bug: b/170328907 Change-Id: I0624c0646889435cb6f6eb20a6d3cceb6ae3eb48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520107Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
-
Jamie Madill authored
This lets the default test time be 10 minutes when using a maximum steps value. This will prevent the current 10 second limit from kicking in and aborting. Also changes the --test-time override to be more clearly a calibration time, and adds a new --test-time that lets the user override the actual trial test time. Bug: b/172480147 Change-Id: I630aa8d3c9e118bb5f0100b38f37e717e12f3538 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523371Reviewed-by:
Paul Thomson <paulthomson@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
Note: Hand edits required to compile this trace. ANGLE_REPLAY_EXPORT was removed from each of the entry points in the header. See build logs in patch set 1 of this CL for full output. Test: angle_perftests --gtest_filter="*clash_of_clans*" Bug: b/172626835 Change-Id: I63bab8f059a2c73c0a2fcd5b70fd92abf3bd4650 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521180 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Geoff Lang authored
Bug: b/150458033 Change-Id: Ice5711a672b63a7dac0618749c7e56d862e0e5ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523373Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Cody Northrop authored
Emit code to reset all buffer bindings to how they were at the beginning during MEC. Test: Capture Clash of Clans Bug: angleproject:4048 Bug: b/172626835 Change-Id: I5a5446304d119f51a018c8fe88ff386243d19749 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521179Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Geoff Lang authored
rm will error when the file is missing without the -f flag. We delete a few files without checking that they exist first. Bug: b/150458033 Change-Id: I5a104d383f59d418eaa55534526194f626c88f57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523372Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Jamie Madill authored
We no longer require a specific version of the Windows SDK. Also include updated instructions on how to setup Goma. Bug: angleproject:1944 Change-Id: I5f9e714ebd69ba04eddc1b1fc2f95d1fde67a47f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522419Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Antonio Maiorano authored
Fixed by: https://swiftshader-review.googlesource.com/c/SwiftShader/+/50008 The specific flaky crash was reported here: https://bugs.chromium.org/p/angleproject/issues/detail?id=4482#c15 Bug: angleproject:4482 Change-Id: Ia77b4b094446d14866bee5fd461a0a4eea52491e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521237Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
-
Jamie Madill authored
This will limit the total number of steps run in the test. When using this argument we skip warmp & calibration. Renames the prior --steps argument to --steps-per-trial. Bug: b/172480147 Change-Id: Iae7cce26d66ca0bbdb21c1f511a6bfa246bd204e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519404 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Geoff Lang authored
Bug: b/150458033 Change-Id: I17c605cbe02341b31855dc771225bf0c95445bfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522009Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Jamie Madill authored
This prevents newer group keys from overwriting old ones. Prevents bugs from creeping in like happened during texture buffer development. Bug: angleproject:3573 Change-Id: Iea69cac988e2cf4802a9f64c54cb694d32f1d3e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521238Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Geoff Lang authored
Bug: b/150458033 Change-Id: I8b299f96d74499669495ca25d5b08711db90ce61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522008Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Shahbaz Youssefi authored
Some suppresions on the GLES3 dEQP expectations file were not removed. Bug: angleproject:4249 Change-Id: Idcf2da50bb4ae4e6feb62fdb1d44d78aba9041a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522420Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c2b2b5788575..a61d07a72763 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I11dc44325b0992b14a43fc754586290828cbf1ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522887Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ad54c71632cc..612ded0654a0 2020-11-05 srisser@google.com Merge changes I3c4f10f7,I5b7ddc75 2020-11-05 capn@google.com Fix Android.bp build after SPIRV-Tools update 2020-11-05 amaiorano@google.com Subzero: fix invalid arg access on Windows x86 for split variables 2020-11-05 amaiorano@google.com Subzero: fix non-deterministic stack layout and code-gen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:4482 Tbr: courtneygo@google.com Change-Id: Ia05307b40847dfa6c82b6a53d67706294848a392 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522886Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/51c1c5ab56d5..bd0ebb680792 2020-11-04 shannon@lunarg.com build: Update known-good files for 1.2.159 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I995f8b69aab80f8d96524459971bdf49fc844adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522888Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/3c7580ad595f..52d33a46255e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/01b3fe480e..dc348c17b4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b6526d9ad3..6302c11756 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f1516a7e59..c8d7f9564e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8b4d61dd3 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/952382f2b0..192a0edbbe * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/skia_goldctl/linux: TzGLaAGOIbgS9g3WS2NIL32_zXI1HeLIIIuDk25O4kwC..GVpht0r-QjWXa70RBjnj16oVOukePZsPqR9WjoyczEQC * tools/skia_goldctl/mac: Yf-uk3I5Yz6gjKV3mct2yoXT580dpRG4hwbIx8CpW5MC..E1HzztCcEvl2qwMi8jlWEeRipywovPX1tvzNMap-XFgC * tools/skia_goldctl/win: 6OGcfUna6B3W4PwFB6GuIVRffBaiDQ1HHaOxlOn9FvgC..DsHjiYrgPxP5IjJ3QDF-DgcQwV_lMq60ESSU1CwXBSkC No update to Clang. Bug: angleproject:4766 Tbr: courtneygo@google.com Change-Id: I704ad78ca6474bfa46bed10e84d19b053d485273 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522879Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Alexey Knyazev authored
Bug: angleproject:2634 Change-Id: I56d13dda7a6c0ad002db15cb780d7bf6b430bf65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519712Reviewed-by:
Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by:
Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
-
Shahbaz Youssefi authored
Deferred clears are not collected when syncing the READ framebuffer. Prior to this change, we had in FramebufferVk::syncState: if (READ && deferredClears.any()) { flushDeferredClears(); } However, this is impossible / unnecessary: - Every operation whose syncState (for the DRAW framebuffer) collects deferred clears will flush the deferred clears. In fact, it's an error for the next operation's syncState to encounter pre-existing deferred clears. - The READ framebuffer is synced before the DRAW framebuffer. This makes it impossible for there to be deferred clears when READ is synced. It may be necessary to swap the order in which the READ and DRAW framebuffers are synced. See http://anglebug.com/5266. In that case, if the READ and DRAW framebuffers are identical: - The DRAW framebuffer's sync will collect deferred clears. The READ framebuffer's sync will see deferred clears, but it must not flush them! Bug: angleproject:4988 Change-Id: I179002d739608ccb8bda95d4379dc6d54e2bf4bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511372 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
This changes the script to query the command from mb.py then call swarming trigger with -raw-cmd and -relative-cwd. See http://crbug.com/chrome-operations/94 Bug: None Change-Id: I1e11cd2e1314a4e96e1ee5a42b311f0c3cb5058b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521240 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
James Darpinian authored
Dean Jackson made this change downstream in WebKit: https://bugs.webkit.org/show_bug.cgi?id=216722 Change ANGLE to dynamically load either EAGL (OpenGLES) or CGL (OpenGL) depending on both compile and runtime configurations. Intel Mac -> CGL Intel Mac Catalyst -> CGL Intel iOS Simulator -> EAGL iOS Device -> EAGL Apple Silicon Mac -> CGL Apple Silicon Mac Catalyst (with Mac app) -> CGL Apple Silicon Mac Catalyst (with iOS app) -> EAGL The trickiest bit is Apple Silicon Mac Catalyst, which depends on the type of the application it is attempting to run. In that case ANGLE must compile both the CGL and EAGL interfaces and then pick one to use after launch. Bug: angleproject:5253 Change-Id: Iba167b3cc3105e457dcfc9bc14147d0fc3e70bac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2500185 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
Jamie Madill authored
This extension is core in 3.2 Based on a CL by Jonah Ryan-Davis. Bug: angleproject:3573 Bug: angleproject:4933 Change-Id: Ib5ce038414075a5cdce36e9404e25d7af33fb39c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519401 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
This optimization allows iterating only over updates of a certain level or range of levels, instead of having to iterate over every update and filter out the ones matching the desired level(s). Bug: angleproject:4891 Change-Id: Ied04f4b28f05d37b9add61c7f4d54cc328c0be86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519095Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
- 05 Nov, 2020 10 commits
-
-
Alexey Knyazev authored
Added BitSetIteratorTest.IterationOrder Bug: angleproject:2634 Change-Id: I0e9c6ad4d19bbb7d691e46b7ec720e918b170371 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520956 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
Take the following scenario: 1. glClear 2. glScissor(half of framebuffer) 3. glDrawArrays The clear in step 1 is deferred. When FramebufferVk::syncState is called in step 3, the deferred clear was applied using vkCmdClearColorImage because the draw call is scissored. This causes loadOp=LOAD to be used after the clear because the render pass is started too small (the same size as the scissor). This change makes scissored operations also take advantage of loadOp=LOAD with deferred clears. A number of changes are made to this effect: - FramebufferVk::syncState no longer limits collecting deferred clears to no-scissor. - FramebufferVk::startNewRenderPass automatically expands the render area to full size if it's clearing any attachment. - A number of bugs are fixed where FramebufferVk::flushDeferredClears is called with the scissor area. Instead, flushDeferredClears now unconditionally uses the complete render area. Note that these bugs didn't have symptoms as "scissor" and "deferred clears" were mutually exclusive. Bug: angleproject:4988 Change-Id: I24fc3d88bf9c8998869b36c863692d0f0acce994 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511371Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Alexey Knyazev authored
Refine DXT1CompressedTextureTest.DXT1Alpha to pass on more configurations. Fix the test's payload so that all 16 pixels use code 3. Refine texture swizzling detection. Bug: angleproject:2634 Bug: angleproject:5049 Change-Id: If9e1ab63220170a54954234ea205e19583b0df0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2467896Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
-
Jamie Madill authored
This will make the names of the failures show up in Milo. Bug: angleproject:5310 Change-Id: I64e1f5ffff04ec70a44f8f3d0c339da2bca6b216 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520539Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bcf5b211db92..c2b2b5788575 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I0e311dd24d753720f6f39b9a84a64b233d96963e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520387Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/19f01495a8a1..ad54c71632cc 2020-11-04 capn@google.com Fix Vulkan benchmarks build 2020-11-04 capn@google.com Fix unaligned access on depth values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ia785672bddd6980e55d5ababdf634d46f8bb5bb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520622Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/07bbf14a831b..f635feea18cb 2020-11-02 shannon@lunarg.com build: Update known-good files for 1.2.159 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I1ca4934966a757e62ba4ae9655b7ab43af96f824 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520530Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/9c36b5262108..3c7580ad595f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/465d72166f..01b3fe480e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/95fa84e35d..b6526d9ad3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/616adef0a3..f1516a7e59 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dbf0550693..2d8c1340f0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8b4d61dd3 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d044036fd8..eedd6353ca * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c37ae578a8..952382f2b0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/28a51d0a2e..df43926725 No update to Clang. Bug: None Tbr: courtneygo@google.com Change-Id: I32b2e5755aa2f72ea3c08767b095c3ec72175c3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519866Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Brandon Schade authored
Add support for GL_EXT_copy_image which allows image data transfer between image objects. This is implemented by using the vkCmdCopyImage API call. Bug: angleproject:3593 Test: dEQP-GLES31.functional.copy_image.* Change-Id: I30a34a8711b5d2e5834064d7453e03d6ec0df478 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2393955 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Mohan Maiya authored
This test would create an sRGB format texture without checking for the GL_EXT_texture_sRGB extension. Skip the test if it is not supported. Bug: angleproject:5281 Change-Id: I491e874201c26c9f828772a0fbebaea307ab57a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519865 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 04 Nov, 2020 6 commits
-
-
James Darpinian authored
This is a reland of e70f6aa6 Original change's description: > ANGLE_platform_angle_device_context_volatile_* extensions > > Change from Kimmo Kinnunen downstream: > https://bugs.webkit.org/show_bug.cgi?id=216106 > > Add two extensions for EAGL and CGL backends to declare the > underlying platform context being "volatile". It means that > the thread-global current context is being modified behind > ANGLE. If ANGLE context is marked volatile for a particular > API, it will sync the underlying context for every EGL > function that needs the context. Most intuitive use is > for the client to call eglMakeCurrent before calling any > gl function if the client knowns the platform state might > be dirty. > > Implement eglReleaseThread for EAGL and CGL backends. > Releasing thread will unset the platform current context. > > Fix a bug of omitting EGL_ANGLE_device_eagl from being > advertised. > > Bug: angleproject:5104 > Change-Id: I1ec98ad35bc0caada23556ae8697fdef20f65b1a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486548 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:5104 Change-Id: I88265625a4bb4c1412532768d17d7b4356c7be41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508842Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
-
Geoff Lang authored
https://bugs.webkit.org/show_bug.cgi?id=215630 Fix an issue with the OpenGL backend where entire arrays of uniforms would be marked as unused if a single element was reported as unused by the driver. Bug: angleproject:5006 Change-Id: I9bbb75a5f113472393e8d9f1fb60a7865aa9529a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486540Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
-
Shahbaz Youssefi authored
Prior to this change, the render area was decided when the render pass was started, and remained fixed. If a small scissor was initially used, this created a render pass with a small area. If then the scissor region was expanded, the render pass was broken. This change instead expands the render area on scissor change to avoid breaking the render pass. If glInvalidateSubFramebuffer previously successfully resulted in storeOp=DONT_CARE, this optimization may need to undo that. As a result, the invalidate area is stored in the render pass and if the render area grows beyond that, invalidate is undone. Bug: angleproject:4988 Change-Id: I4e8039dec53a95a193a97cb40db3f71e397568d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508983 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
This change 7bbe497a accidentally disabled support for GL_EXT_buffer_storage extension for the Vulkan backend, enable it again. Bug: angleproject:5056 Tests: angle_end2end_tests --gtest_filter=BufferStorageTestES3*Vulkan Change-Id: If4da2fe2c3e8b098875c89643d366f15fd0ea8b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519875 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Ian Elliott authored
Bug: angleproject:5309 Change-Id: Iafe91565138a5b94c482aeff7607d09c10d2aeaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519874 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
The prior fix still didn't work. Add logging to debug why. Bug: angleproject:5299 Change-Id: I758cfa87066e1cdf4a5d1289c030943e9bded58d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519400Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-