- 25 Oct, 2019 21 commits
-
-
Ian Elliott authored
Some tests fixed. Others only fail on Android. Bug: angleproject:4016 Bug: angleproject:4019 Bug: angleproject:4045 Change-Id: If3b915fdd1c54cefa17589f025ea8a93935377c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880165Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Jamie Madill authored
Will be used for mid-execution capture. Only has a stubbed-out implementation right now. Bug: angleproject:3944 Change-Id: I6ddae07907ecbdbd3be9a5d2d3fcafeb425445e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1878888 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/883e817b14bf..f44f7c066a67 git log 883e817b14bf..f44f7c066a67 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 amaiorano@google.com Fix LLVM7 partially initialized ManagedStatic 2019-10-24 sugoi@google.com Fixed using an offset in Blitter::blitFromBuffer() 2019-10-24 sugoi@google.com Fix stencil+MSAA 2019-10-24 paulthomson@google.com Add LESS_DEBUG_INFO CMake option Created with: gclient setdep -r third_party/SwiftShader@f44f7c066a67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4037,angleproject:4013,angleproject:4044 TBR=jonahr@google.com,jmadill@google.com Change-Id: If8150d05ff1e222c24c1f8dc09b99cbb42bffa10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880455 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Jamie Madill authored
A compile error slipped in due to lack of test coverage. Bug: angleproject:3611 Change-Id: Id34ce239f3913efb0ed1abab77321981419cab44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880160Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Bug: angleproject:1944 Change-Id: I8eabf5e8ec5cd7bfeab4db9b7bd5422f5168744e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880159Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
These were not implicitly added in the Skia build. Bug: angleproject:4046 Change-Id: I0acdb4056e4598ea372b650dbd8044fe680187b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877483Reviewed-by:
-
Jamie Madill authored
Again these were showing up in Skia. Bug: angleproject:4046 Change-Id: Ia295ac02b1e1d7bd4186243fc2bf38dffce43c2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877482Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/feb154921397..b34fa731931b Also rolling transitive DEPS: third_party/spirv-headers/src 842ec9067462..af64a9e826bf Created with: gclient setdep -r third_party/spirv-tools/src@b34fa731931b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=jonahr@google.com Change-Id: I19a2870cef1000757fa7767ef45b5fbac8a3a4a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880801Reviewed-by:
-
Jamie Madill authored
Should be samples/capture_replay not samples/capture_and_replay. Bug: angleproject:3611 Change-Id: I5de4849c875add39df36f7875482e4dc91ca0ca6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880158Reviewed-by:
-
Jamie Madill authored
This will fix the issue where gclient didn't support checking out DEPS-inside-DEPS. We pass a 'googletest_revision' variable to third_party/googletest via recursedeps. Bug: chromium:1017514 Change-Id: I4ef3785e385775910f24e13e60e284b8ab2996d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881023Reviewed-by:
-
Jamie Madill authored
Change log: https://chromium.googlesource.com/chromium/src/+log/9325340209..60074bf9e0 Full diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/592281c03c..a193dcc697 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6752fa027a..f712af4fd9 * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c721b68dde..60616473f7 * third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/48246a0995..571788934b * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9d3bf3e968..bc13578529 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ddebad26cf..403ca5ad3a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6bc727d9d8..662cbb8d60 DEPS diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0/DEPS No update to Clang. TBR=jmadill@chromium.org, BUG=None Change-Id: I429a0179f2941ebe04a41a1e25068c2bc41e66c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881022Reviewed-by:
-
Jamie Madill authored
This is a final warning used by Skia. Bug: angleproject:4046 Change-Id: I3970e30e4bd2aef07cddadd7322ef120ac857493 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877481Reviewed-by:
-
Jamie Madill authored
This is purely a code style and consistency warning. Enabled to support building in Skia. Bug: angleproject:4046 Change-Id: Ibdcd06ded0195123e52c693851c43d0864e54ad1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877480Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7662586844f4..b131630e7c74 Created with: gclient setdep -r third_party/glslang/src@b131630e7c74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=jonahr@google.com Change-Id: Ia4ef9eeef7404245de43d5adf1636e395c4e61f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880657Reviewed-by:
-
Jamie Madill authored
A couple cases popped up where we were using an undefined cast. Fix them by rearranging assignment macros to use decltype. Another warning that is enabled in Skia. Bug: angleproject:4046 Change-Id: Ibdbae0b2a96909b101a259ff805b8b2d43a5174b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877479 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
Test: StateChangeTestES3.VertexArrayObjectAndDisabledAttributes Bug: angleproject:4049 Change-Id: Ibda86585e9117686283081a76df213b2b2db0b6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879582Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Geoff Lang authored
This workaround appears to cause problems on Mac ASAN builds. Disabling it while investigating the root cause. BUG=1017337 BUG=angleproject:3997 Change-Id: I16a2f07f8fc69ec4d5ab40a5bf521c43f6854a49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879873Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Jamie Madill authored
This one is also required by Skia. It's purely for consistency and code readability. Bug: angleproject:4046 Change-Id: I9ed418a0bf6c7661f0970fef6da7088ca6ae6204 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877478Reviewed-by:
-
Jamie Madill authored
This is another warning required by Skia. This one didn't find anything that surprising. Enabling the warning does help enforce code consistency and avoids a bit of possible undefined behaviour. Bug: angleproject:4046 Change-Id: Ifec7f4afad49cd820bf3c0a79df3f46559473ee2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877477 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This warning verifies we don't give variables names that shadow fields. This is another good warning to enable that Skia requires. This CL also fixes a small number of points in code that used this bad pattern. We have to disable the warning for Glslang for now. Bug: angleproject:4046 Change-Id: I072a686e3023b60cfafa778525fe712ce1fb5a50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877476Reviewed-by:
-
Jamie Madill authored
This is used by Skia. It seems like a good this to enable in any case. It verifies that we don't do pointless comparisons like "int < INTMAX". Fix the one instance by using the base checked numeric helpers. Bug: angleproject:4046 Change-Id: Ie14a9cb2754df52929591281062d92ef70df8f97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877474Reviewed-by:
-
- 24 Oct, 2019 10 commits
-
-
Jamie Madill authored
This uses the new setting added to depot_tools. The diff lines of context setting was removed. Bug: angleproject:4003 Change-Id: I6f7d471d3cce066cd3a6caa200828d09ccfca5ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879577Reviewed-by:
-
Jamie Madill authored
This file will be used with multi-frame captures to share common code. Common code is global state, resource maps, and a list of frame replay functions. This should make converting a CPP replay into a functional test quite a bit simpler. The replay files will now be something like: angle_capture_context1.cpp angle_capture_context1.h angle_capture_context1_frame000.cpp angle_capture_context1_frame001.cpp ... etc Also adds a template for adding a capture/replay sample. Instructions are located in samples/BUILD.gn and docs in doc/CaptureAndReplay.md. Bug: angleproject:3611 Change-Id: I437b338fd84689d670a7d9e3e219d9334de25fd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869543 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tobin Ehlis <tobine@google.com> Reviewed-by:
-
Tobin Ehlis authored
Unsized DS formats should not pick up support from ES3 automatically. Also unsized DEPTH COMPONENT textures should not be allowed as texture attachments without also having support for GL_ANGLE_depth_texture or GL_OES_depth_texture extensions. This change modifies some unsized formats to require extension support for TextureAttachment use. There are a couple of tests bugs that were exposed by this change so updated those tests as well. This CL only changes TextureAttachment support, but it's quite possible that renderbuffer (and texture) support may also need to be updated. Will attempt that in a follow-on. Bug: angleproject:3952 Change-Id: I75d15330dc418c421cd2855135e1e8100a89b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877135Reviewed-by:
-
Jamie Madill authored
Introduces a few ways of controlling capture via: * `ANGLE_CAPTURE_ENABLED`: Can be set to "0" to disable capture entirely. * `ANGLE_CAPTURE_OUT_DIR`: Can specify an alternate directory than the CWD. * `ANGLE_CAPTURE_FRAME_END`: This variable can override the default of 10 frame to capture. Also adds a simple usage guide document. Bug: angleproject:3611 Change-Id: I49d32d5bae2c490dcbeb0f1ce3c6038e433adfaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869542Reviewed-by:
-
Ian Elliott authored
Issue 4011 had 2 root causes, one of which was fixed and the other split out into 4037. Bug: angleproject:4011 Bug: angleproject:4037 Change-Id: I460588d7667429751416c1904863a5117a8a4b1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1878889Reviewed-by:
-
Jamie Madill authored
These now pass with all the prior work. One test case is left disabled on Linux due to timeouts. Bug: angleproject:2464 Change-Id: If41f59f44f78160cf1b26dc05f560afd286996bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1832526Reviewed-by:
-
Jamie Madill authored
This was blocking using our GN files in Skia. Bug: angleproject:4046 Change-Id: I12887a53c5f92b0e00206f8d391a8d03433b5e6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877475Reviewed-by:
-
Geoff Lang authored
- Use the existing utility function for computing the primitive restart index. - Fix bad merge that removed the unfoldShortCircuits feature. BUG=1017337 BUG=angleproject:3997 Change-Id: I4ba5ada9816731bdd29a0e518ce225bdd69a762e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1876453Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7738ed713e7b..883e817b14bf git log 7738ed713e7b..883e817b14bf --date=short --no-merges --format='%ad %ae %s' 2019-10-23 webmaster@saschawillems.de Added vkGetPhysicalDeviceWin32PresentationSupportKHR to Vulkan ICD Created with: gclient setdep -r third_party/SwiftShader@883e817b14bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=jonahr@google.com Change-Id: If101eb655a556a70884b6b65d8f628d98901e73a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877852Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5e634c8999e6..7662586844f4 Created with: gclient setdep -r third_party/glslang/src@7662586844f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=jonahr@google.com Change-Id: Ibaa281c82997e29b0d27a1e67c828a8f693c79d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877851Reviewed-by:
-
- 23 Oct, 2019 9 commits
-
-
Tobin Ehlis authored
Re-tested this and it's now passing so turning it on. Bug: angleproject:3255 Change-Id: Iccf63cfaa4386dfda5628e189362631e655953f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1876081Reviewed-by:
-
Xinyi He authored
ANGLE always enables the Mipmap. The fix does redefining the image with mipmaps and replace the origin one only when it is necessary. Bug: angleproject:3737 Change-Id: Ia33a16fd7feae303fb114988059c4eec58c4232d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1750627 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Tobin Ehlis authored
Update loader to version that will make sure the VK_ICD_FILENAMES env variable is always picked up on Windows. Bug: angleproject:2464 Change-Id: I6c161c00e0af708f288f59fc62b9cb9d6f131626 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1876451Reviewed-by:
-
Tobin Ehlis authored
Our format caps table was incorrectly reporting GL_DEPTH_COMPONENT32_OES supported as a texture or texture attachment if OES_depth32 extension is supported. However, the OES_depth32 extension spec says: This extension enables 32-bit depth components as a valid render buffer storage format. So texture and texture attachment should not be reported as supported if OES_depth32 is available but neither GL_ANGLE_depth_texture or GL_OES_depth_texture are supported, which is currently the case for swiftshader. Bug: angleproject:3952 Change-Id: Ia29853229de9ff0918d6752631edfccf5f2ba3f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1874007Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
-
Tobin Ehlis authored
On 32bit builds we were only storing 32bit handles for non- dispatchable objects. This resulted in the handles getting shrunk from 64-bits which then led to false validation errors. Fixed this by using VK_DEFINE_NON_DISPATCHABLE_HANDLE() macro in GarbageObject instead of VK_DEFINE_HANDLE(). Also MSVC on Win32 didn't like reinterpret_cast<> with the updated 64bit handles so migrated a number of GarbageHandle casts to be c-style which is contrary to style guide, but is preferable to conditional code. Bug: angleproject:3924 Bug: angleproject:3946 Change-Id: Icb4139e34989179e46ac1f0c76269ff49ab1e897 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1873244 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a68a80a4dbf9..7738ed713e7b git log a68a80a4dbf9..7738ed713e7b --date=short --no-merges --format='%ad %ae %s' 2019-10-22 amaiorano@google.com Fix sRGB conversion not applying generally 2019-10-22 bclayton@google.com regres: Automatically build dEQP based on new config file 2019-10-22 amaiorano@google.com Fix unary minus warnings 2019-10-21 sugoi@google.com Enable support for Bresenham lines 2019-10-21 sugoi@google.com Fix queries with arrays containing other structures 2019-10-18 amaiorano@google.com Fix Win32SurfaceKHR resize issues Created with: gclient setdep -r third_party/SwiftShader@7738ed713e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4011,angleproject:4034 TBR=jonahr@google.com Change-Id: If970eee12d3553e8fdc2c333028b8289ebf6832a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1875374Reviewed-by:
-
Jamie Madill authored
This will allow for the capture/replay sample to disable the warnings. We'd like to keep them enabled for most of ANGLE code. Bug: angleproject:3611 Change-Id: I3cc7af26fa54c03cc5b79727e7b403a1b218a903 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869544 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Le Quyen authored
Metal backend will reuse Vulkan's GlslangWrapper code. The Metal backend will use this code to translate glsl to spirv then cross compile to Metal Shading Language using spirv-cross. So the source code of GlslangWrapper should be moved outside vulkan folder. Bug: angleproject:2634 Change-Id: I208062daf0d77756c9d32cfdab925b7dfdf83e05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1858042Reviewed-by:
-
Jamie Madill authored
Includes a fix necessary for multithreading tests. Bug: angleproject:2464 Change-Id: I009e48be611ef7b96ad9caba8e0729881e1a8fb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1872789Reviewed-by:
-
