Commits · 788efd1c721a82e3d67daf4eb6ce3133fb4fd060 · Chen Yisong / angle

27 Apr, 2021 1 commit

D3D11: Disable CompositorNativeWindow11 in Chromium builds. · 788efd1c

authored Apr 22, 2021

CompositorNativeWindow11's IsValidNativeWindow can only return true or
crash. If a user passes in an invalid window handle, ANGLE's D3D11
backend will always crash.

Ideally this window type would be exposed through an extension and
the user passes in an enum telling ANGLE that the window is an
ISpriteVisual instead of ANGLE trying to detect it from a void pointer.

Bug: chromium:1176118
Change-Id: Ia7568adcd929dcd9200c7da2d0a991da55e1e89a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846800Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
(cherry picked from commit da791e3e)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854216Reviewed-by: Geoff Lang <geofflang@chromium.org>

788efd1c

22 Apr, 2021 1 commit

D3D11: Skip blits if there is no intersection of dest areas · 43cdda6a

authored Apr 19, 2021

Blit11 would clip the destination rectangle with the destination size
but ignore the result. gl::ClipRectangle returns false when the
rectangles do not intersect at all, indicating the blit can be skipped.

This could lead to an out-of-bounds write to the GPU memory for the
destination texture.

Mark ClipRectangle as nodiscard to prevent future issues.

Bug: chromium:1199402
Change-Id: I260e82d0917b8aa7e7887f2c9f7ed4b1a03ba785
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836786Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
(cherry picked from commit b574643e)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846983Reviewed-by: Geoff Lang <geofflang@chromium.org>

43cdda6a

19 Apr, 2021 1 commit

[M91] Ignore subclass when finding GPU PCI devices · 242d79eb

authored Apr 12, 2021

When enumerating PCI devices to find GPUs, only filter on the base
class. This allows devices with class PCI_CLASS_DISPLAY_OTHER to be
found.

Bug: b/178748337
Change-Id: Ia0cd29dddc49a16428da16c1ef1b94040c1221f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2817973Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
(cherry picked from commit 0615bbde)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2833496

242d79eb

08 Apr, 2021 3 commits

Roll vulkan-deps from 575b36060ded to c18d8cd5016c (3 revisions) · 83c90f24

authored Apr 08, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/575b36060ded..c18d8cd5016c

Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8bb72ad221..f563b367c7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I6175915edc5f9da742b0076e9700190959bf05c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2814338
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

83c90f24

Roll Chromium from 743bf032b75b to c8a676460af3 (490 revisions) · 619cdbd0

authored Apr 08, 2021

https://chromium.googlesource.com/chromium/src.git/+log/743bf032b75b..c8a676460af3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3e210bf13a..77edba11e2
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a136a3b8e9..d0f33885a2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/05632231e5..a9d80f02d0
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3cd3442b05..5447d00cc9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..44319b56ef
* tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:63310fdc83db00f27d0902961627ff98043076e0
* tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:63310fdc83db00f27d0902961627ff98043076e0
* tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:63310fdc83db00f27d0902961627ff98043076e0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8311fb760c..93c8ae3a54
* tools/skia_goldctl/linux: -rExHiWOcks_RlkFBMnAOYEVLEGvm3sncdHy7RIQUvUC..hppkAohY9Cc45kW6zZWYXtdLKzo9CQ9XvcqLNIBaqQQC
* tools/skia_goldctl/mac: vJzRxG9eh8Zl9oN4Li63sfRu7kHPvf54fXvv-nMXJZcC..JnqYnN3TwP__L0jvUBgcLpPQsBgz9ZcBk8-bsbiez6QC
* tools/skia_goldctl/win: Uc9sbdhlwsqNbi5Q4fAmKXKL665j5gsdf3Ifpe4qnr0C..0el4SjlMxSJWhUyzmXXYXqGT59IZHXzEaDTufNH8bOwC
No update to Clang.

Bug: None
Tbr: geofflang@google.com
Change-Id: Idc95dd300300cb1d8eb49f95acaa51f017bb9b3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2812961
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

619cdbd0

Tests: Add Disney Tsum Tsum trace · fc28c1db

authored Apr 07, 2021

Test: angle_perftests --gtest_filter="*disney_tsum_tsum*"
Tbr: timvp@google.com,jmadill@google.com
Bug: b/184770989
Bug: angleproject:5835
Change-Id: I2ee74f95391fa30b0d5bfa88be5fc7dd59fd6f70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2811644Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

fc28c1db

07 Apr, 2021 22 commits

Vulkan: Update layer provoking vertex for geometry shaders · 5af6306a

authored Mar 31, 2021

Set the GS layer provoking vertex value to
GL_LAST_VERTEX_CONVENTION if the provoking vertex extension
is enabled. Otherwise, use GL_FIRST_VERTEX_CONVENTION as
vulkan follows this convention for provoking vertex.

Tests: dEQP-GLES31.functional.geometry_shading.layered.layer_provoking_vertex_*
Bug: angleproject:5452
Change-Id: Ie385f3b713486c54114dbfcefd799d180701bb60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2799033
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5af6306a

Capture/Replay: Ignore deletes of buffer 0 · d49f7351

authored Apr 07, 2021

Per the spec for DeleteBuffers:
> Unused names in buffers are silently ignored, as is the value zero.

Haven't seen an app delete unknown buffers yet, but just hit one that
deletes 0 a lot.

Test: MEC for Disney Tsum Tsum
Bug: b/184770989
Bug: angleproject:5835
Change-Id: I2070b753d89fdcf390203072cd7ec2c9f915089c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2811643
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d49f7351

Vulkan: Refactor to descriptor offset array. · efc53d0f

authored Apr 03, 2021

This is in preparation for using dynamic offsets for other sets than
the default descriptors.

Bug: angleproject:5736
Change-Id: I546e688ad57a35b380f8d7f303ffc0c62773ac18
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2804813
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

efc53d0f

restricted_traces: Remove sha1 remains. · 4640dbff

authored Apr 07, 2021

This deletes redundant sha1 files that are not required anymore since
the migration to CIPD.

Bug: angleproject:5811
Change-Id: Ib1131f9cdda0b00b8f605f8b6dff6650d262ce25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810789Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4640dbff

Expand CL plumbing support to cover all versions · 84a62266

authored Apr 01, 2021

The OpenCL CTS assumes that libOpenCL has symbols for all versions as it
usually expects to link against the Khronos loader. Since we're not
using that, we have to expose all the symbols it wants, whether we
intend to implement all versions or not. All the 2.x stuff will likely
remain stubs forever as it is made optional again in 3.0.

In the generator scripts, work around a small issue where one function
takes an array-typed parameter, which confused just_the_name and
produced invalid code.

Bug: angleproject:5819
Change-Id: I6c3591dc9229c5276f14ff66ee3ee6362e8bf622
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807531
Commit-Queue: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: John Plate <jplate@google.com>

84a62266

Perf Tests: Trigger test failure on API errors. · 68f06888

authored Mar 23, 2021

A prior refactor had broken the method we used to cause test steps to
fail on API errors. This CL restores the path. We detected this when
analyzing a particular GLES trace that contained invalid GLES calls.

Bug: angleproject:5788
Change-Id: I26940e49cf73ce6050ea6ee274d5c5748835a167
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782008
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

68f06888

Scripts: Update bootstrap.py to python3 · 8135dccf

authored Apr 07, 2021

Bug: angleproject:5829
Change-Id: I564fadee92b6ff301c055cf95a163ffb3c838685
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810338Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8135dccf

Handle trace prerequisites. · b4cb63a5

authored Apr 06, 2021

real_gangster_crime: external images
avakin_life: external images
hill_climb_racing: skip on Adreno

Bug: angleproject:5822
Bug: angleproject:5823
Change-Id: I7c6a27eab72ba69464748928c93dda57fa8094f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809653
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

b4cb63a5

Capture/Replay: Fix upload script · bd82de95

authored Apr 07, 2021

Small fix to info level logging.

Bug: angleproject:5811
Change-Id: I7c6c762e17b652eedcbde0719996532e730e2a39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809889
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bd82de95

Improve Angle Android gtest support · bf0c6ae1

authored Mar 09, 2021

This CL makes angle_test() use an angle-specific gtest launcher -
AngleUnitTestActivity.java. This enables building standalone Android
angle without //base

Chromium-Bug: 1149922
Bug: None
Change-Id: Id84f3e2bd84c5017ed1988ca07534f424ebfa596
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745535Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bf0c6ae1

perf_test_runner: Enable all trace tests. · 2ef1e0fc

authored Apr 06, 2021

Will allow running "null" Mock ICD tests.

Also fixes a crash running the Mock ICD with the overlay.

Bug: angleproject:5736
Change-Id: I42e3943a0de00dbab3ee125f1946afd22b38fec6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809096Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2ef1e0fc

restricted trace tests: Fix script. · 31d48df1

authored Apr 07, 2021

This script was not parsing the trace list properly and was
running no tests.

Bug: angleproject:5811
Change-Id: I925bc16ac476823ca2f850d4a9e208b9bb5deb62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810805Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

31d48df1

Add Mesa Vendor ID · 6a606231

authored Apr 06, 2021

ANGLE doesn't recognize the Mesa vendor ID, leading to a crash in
GetVendorString(). This is exposed when trying to capture traces of
ANGLE captures with RenderDoc.

Bug: angleproject:5824
Change-Id: I6c45a01dba78fa6057df26b38ca3db89cacf865e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809878Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

6a606231

Refactor roll_aosp.sh · 4bd370dd

authored Apr 02, 2021

roll_aosp.sh can now generate an Android.bp file without having to
perform a roll. This facilitates on demand generation of Android.bp.
Provide an option to enable API traces with "--enableApiTrace" flag.

Usage -
    # Generates Android.bp and perform a roll
    ./scripts/roll_aosp.sh

    # Generates Android.bp
    ./scripts/roll_aosp.sh --genAndroidBp

    # Generates Android.bp with API tracing enabled
    ./scripts/roll_aosp.sh --genAndroidBp --enableApiTrace

Bug: angleproject:5774
Change-Id: I3a2bd505f5d75d6d5fc331d61fa9517d6042db70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774758Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

4bd370dd

capture: Implement capturing GLES1 vertex pointers. · fddbc9c7

authored Mar 04, 2021

Implement capturing glVertexPointer, glTexCoordPointer, glNormalPointer,
glColorPointer and glPointSizePointerOES using a new
CaptureVertexPointerGLES1 helper function.

This is done by using fixed indices for gClientArrays that are retrieved
from the GLES1Renderer.

Bug: angleproject:5751
Change-Id: I6c774ff21942ea3422c4c77a615f88299901c0ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773288Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

fddbc9c7

EGLWindow: Append noError context attribs only if enabled. · df72ea36

authored Mar 31, 2021

Push EGL_CONTEXT_OPENGL_NO_ERROR_KHR only to the context attribute list
if it's enabled in the mConfigParams. Prior to this patch the attribute
was pushed with a EGL_FALSE value if noError was disabled but available.

This resolves issues on EGL implementations which expose the extension
but fail if it's in the attrib list if certain conditions are met.

This is the case for mesa 21.0 when EGL_CONTEXT_MAJOR_VERSION_KHR is set
to 1 / GLES1.

Mesa upstream issue:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/4586

Bug: angleproject:5809
Change-Id: I91dfafe2a89f0488556942813087e54499895088
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797331Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

df72ea36

Fixed OpenCL headers for Windows · 2489a0c1

authored Apr 06, 2021

Bug: angleproject:5761
Change-Id: I29d1fd3bf862728a3e78418a4f98219828394452
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807717
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2489a0c1

Roll vulkan-deps from fac6f6b00985 to 575b36060ded (3 revisions) · 15b34197

authored Apr 07, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/fac6f6b00985..575b36060ded

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/5878bcb17e..1481399549
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/7ea01c139f..64cc17099c
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/36e147f591..8bb72ad221

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I43ef7e9e9c61fb68ce0c97bd105bbb32dbea91db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809887
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

15b34197

Roll Chromium from 9bacc030553c to 743bf032b75b (182 revisions) · 0c6efe64

authored Apr 07, 2021

https://chromium.googlesource.com/chromium/src.git/+log/9bacc030553c..743bf032b75b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/83694c4d99..3e210bf13a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/41c8c7acfb..05632231e5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41a5e5e465
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/52aea199fe..8311fb760c
No update to Clang.

Bug: None
Tbr: geofflang@google.com
Change-Id: I3c4b79720e47d29353ee72211051b462d49a731f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810336
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c6efe64

Vulkan: Remove initImmutableImage and use initImage instead · 6d905c76

authored Apr 01, 2021

This is follow up of crrev.com/c/2368038. There was concern that
initImmutableImage and initImage are a bit duplicated. This CL gets rid
of initImmutableImage and uses initImage instead.

Bug: b/181800403
Change-Id: I2c73c7ce979792cc762214f1e5ef9978eeab6212
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800422
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

6d905c76

Vulkan: Remove maxLevel and immutable from ImageHelper::initExternal · 92d3912d

authored Apr 01, 2021

Now that we have removed mBaseLevel and mMaxLevel from ImageHelper class
in previous two CLs. The initExternal function can be modified to not
pass in base/max level information. This CL also removes immutable from
argument and let caller directly pass in firstLevel to it.

Bug: b/181800403
Change-Id: I595c1faffabc7582af35a9578b2ecdf00c39207f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800414
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

92d3912d

Roll Chromium from 99ef73b66e73 to 9bacc030553c (0 revision) · 2143ffc2

authored Apr 06, 2021

https://chromium.googlesource.com/chromium/src.git/+log/99ef73b66e73..9bacc030553c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/728a23351d..83694c4d99
* buildtools/linux64: git_revision:a95c8a3ccc7de65eb740aa68a0d021cdc8550205..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92
* buildtools/mac: git_revision:a95c8a3ccc7de65eb740aa68a0d021cdc8550205..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92
* buildtools/win: git_revision:a95c8a3ccc7de65eb740aa68a0d021cdc8550205..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/9a03e1204d..41c8c7acfb
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41a5e5e465
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ada51aa113..a387faa2a6
No update to Clang.

Bug: None
Tbr: geofflang@google.com,ynovikov@google.com
Change-Id: Ic4d83afa511c9cf906c298c23e0fc194e2672500
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808704
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2143ffc2

06 Apr, 2021 12 commits

Vulkan: Suppress draw-time push constant VVL warnings. · f34b40da

authored Apr 06, 2021

    VUID-vkCmdDraw-None-02698
    VUID-vkCmdDrawIndexed-None-02698
    VUID-vkCmdDrawIndirect-None-02698
    VUID-vkCmdDrawIndirectCount-None-02698
    VUID-vkCmdDrawIndexedIndirect-None-02698
    VUID-vkCmdDrawIndexedIndirectCount-None-02698
    VUID-vkCmdDispatch-None-02698

Bug: angleproject:5821
Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f34b40da

Vulkan: Remove mMaxLevel from ImageHelper class · afd32d8e

authored Mar 30, 2021

This CL removes mMaxLevel from ImageHelper class. Instead, it now uses
front end's max level information when possible.

Bug: b/181800403
Change-Id: Ie0f6bd11e3ca0d4ddfc98f21261396c4d71b7140
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796153
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

afd32d8e

Mark most draw modes valid when no program is bound · 4756d5e6

authored Mar 22, 2021

gpu_angle_passthrough_fuzzer discovered a crash when glDrawArrays() is
called without a program bound. This was caused by assuming it's an
error to draw certain primitive types without a program bound, which is
incorrect. This fix is to mark all draw modes except Patches valid when
there is no program bound. Patches is handled separately by TS
validation.

Bug: chromium:1185267
Bug: angleproject:5483
Test: gpu_angle_passthrough_fuzzer
Test: SimpleOperationTest31.DrawWithoutProgramBound
Test: KHR-GLES31.core.draw_indirect.basic-mode-*adjacency
Change-Id: I294078b8695e0b8f36d3b7ad3c1aa71d2a275038
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780971Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

4756d5e6

Support GL_EXT_texture_type_2_10_10_10_REV on D3D backend · 5ee3826e

authored Apr 01, 2021

Bug: angleproject:5817
Change-Id: Ie572a252946f87d125f9074f2144928bb43d78b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2802861Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>

5ee3826e

Vulkan: Remove mBaseLevel from ImageHelper class · 08b7c55c

authored Mar 30, 2021

This removes mBaseLevel from ImageHelper class. With the
mFirstAllocatedLevel tracking exactly which GL level has been allocated,
this cached mBaseLevel is no longer needed.

Bug: b/181800403
Change-Id: I99d66c93b0c8f1bd20a5811b51f512a27927201e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2795275
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

08b7c55c

Vulkan: Use constants for descriptor types. · 41a34d6b

authored Apr 03, 2021

This will make it easier to substitute in the future.

Bug: angleproject:5736
Change-Id: I0686c4c396e9f12cfb71253ccd9aa491a7942826
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2804812Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

41a34d6b

GL: Align emulated ETC1 handling with other backends · ad55bdbe

authored Apr 02, 2021

Use emulatedEtc1 limitation to hide it from WebGL.

Bug: chromium:1048244
Change-Id: Id2fd6b5d934f3caeb455e8f0fc198445e8c00084
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2803136Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>

ad55bdbe

Vulkan: Make storage actually immutable for immutable textures · b5a71140

authored Aug 20, 2020

The immutable textures are intended to be "immutable". Right now we are
still re-allocating VkImage object based on base_level and max_level.
This causes a problem for rendering to a level that is beyond
[base_level, max_level], which is totally within OpenGL spec. This CL
makes an immutable texture always allocate from 0 to max levels that are
specified by a glTexStorage call. Changing base_level will not trigger
re-allocation of VkImage object.

Bug: b/181800403
Change-Id: I4b4ddea17b7f6f7bfd8f36bfe8bb3a35b5c180b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368038Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

b5a71140

Vulkan: Fix geometry shader validation with vertex shaders · 969b8f31

authored Mar 25, 2021

Added validation to disallow usage of geometry shaders
without a vertex shader

Bug: angleproject:5579
Test: KHR-GLES32.core.geometry_shader.api.fs_gs_draw_call
Test: KHR-GLES32.core.geometry_shader.api.pipeline_program_without_active_vs
Change-Id: Ieeec544d514ac772416ab0427c1c1c5058276f98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796151Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

969b8f31

Lacros: Fix xvfb condition in angle · 3036ff2d

authored Apr 02, 2021

For Lacros, xvfb is only used in Linux-Lacros, but not on-device
config, so this CL fixes the problem.

Bug: chromium:1195415
Test: built Chromium and Angle from source
Change-Id: Ia9adf706716c424b14a395189755932e445b7050
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2802854Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

3036ff2d

Vulkan: Assign XFB location first then assign varying location · 4cdbdf90

authored Mar 25, 2021

Varying location is determined based on XFB location. If the transform
feedback stage is Vertex, there is no problem. But if the transform
feedback stage is GS or TES, previous implementation can cause shader
interface mismatch.

Bug: angleproject:5557
Test: KHR-GLES32.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_in
Change-Id: I1ecc7913a178c9e674307c528d1bdf13aabcb665
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2784713Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

4cdbdf90

Factor common Vulkan build_overrides in vulkan_common.gni · def0aa27

authored Apr 06, 2021

This matches what's done in Chromium and was found while trying
to add a build override for VulkanMemoryAllocator.

Bug: tint:700
Bug: chromium:1195554
Change-Id: I50e71fb985169a89c03623b0959f57d5e43bb91a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807714
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

def0aa27