- 22 Apr, 2020 9 commits
-
-
Jeff Vigil authored
Set SyncVk's SyncHelper to inherit from vk::Resource. Bug: angleproject:2517 Change-Id: I499414d97e611d029abc12622f19436cbdb3e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160126 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Re-land fixes ASSERT on Android GLES. Previously we were only forwarding Texture staging changes to the Framebuffer for re-sync. We could miss out on clears that were staged in Surfaces and Renderbuffer attachments. Complete the chain by making the SurfaceVk and RenderbufferVk forward notifications from the VkImage. Bug: angleproject:4517 Change-Id: I91d31213b115a58546b574caa574eebbb098266c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159294Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Tim Van Patten authored
When a Program is used to draw, the buffers to hold uniforms are allocated as part of updateUniforms(), and then if a buffer is allocated, a corresponding descriptor set is allocated for each shader stage with uniforms. However, if that Program is later bound to a PPO, the PPO's descriptor set list is cleared as part of creating the pipeline layout. This means the uniform descriptor sets need to be re-allocated but using the previously allocated buffers so the 'anyNewBufferAllocated' flag isn't enough - we also need to check if the PPO's list of descriptor sets is empty. Bug: angleproject:3570 Test: KHR-GLES31.core.sepshaderobjs.StateInteraction Change-Id: Id8df587b4f5552012590a29d120b6899bbdf677b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156936Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
-
Le Hoang Quyen authored
- Built-in variable gl_ClipDistance has been added to compiler. - Desktop GL: gl_ClipDistance is supported since GL 3.0. Enable/Disable each gl_ClipDistances[i] works out of the box via glEnable(). - Vulkan/Metal: Use uniform variable to control writing to each gl_ClipDistance. One bit flag controls one element in the gl_ClipDistance array. The writing to the disabled element in vertex shader will be ignored, and turned into zero assignment instead. - Direct3D/Mobile GL: Not implemented yet. - Added ClipDistanceTest to gl_tests and compiler unittests. - GL_APPLE_clip_distance is a subset of GL_EXT_clip_cull_distance, so GL_EXT_clip_cull_distance could be implemented in future if needed. Bug: angleproject:4452 Change-Id: I571ac8b56826989808a680226a04bec4cf59988e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2084324 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Charlie Lao authored
If driver returns error code that we do not know, we simply output "unknown vulkan error code". Instead we should at least include the actual errorCode here so that people can search up to see what it is. Also remove the double period at the end of string and added a few other vulkan error strings. Bug: b/154665382 Change-Id: Ic4138e90534b4e7d97520fe10ac1477d2930d9c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160130 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Courtney Goeltzenleuchter authored
This allows us to capture Angry Birds 2 traces. Bug: b/153652100 Change-Id: I99a47f9e41a84218b3bb3d9740df4bb7fc2a01fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2144763Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/09f4b08483bb..36d7cca6fdc9 git log 09f4b08483bb..36d7cca6fdc9 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 tony@lunarg.com layers: Fix renderpass2 tracking Created with: gclient setdep -r third_party/vulkan-validation-layers/src@36d7cca6fdc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Iddad6155212d216fb1bcee45006707a0ffc2d451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160273Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ff772a7bcc98..ceb6258ae101 git log ff772a7bcc98..ceb6258ae101 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 amaiorano@google.com CMake: fix astc code not being enabled correctly Created with: gclient setdep -r third_party/SwiftShader@ceb6258ae101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I469606bfc8fd7433d14770f2158954ea8d78458a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160274Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3f4e5c456306..c9b28b9f3388 Created with: gclient setdep -r third_party/glslang/src@c9b28b9f3388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I82d61d8560b2d48d54f405d879aa20f5e8197f16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160275Reviewed-by:
-
- 21 Apr, 2020 17 commits
-
-
Mohan Maiya authored
The VMA allocator has a handy feature where during memory allocation we can request persistently mapped memory. This saves IOCTL overhead for apps that update buffers frequently. Bug: angleproject:2162 Change-Id: I870d880033beec343efae6de06f1c5935de4c2c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155131Reviewed-by:
Tobin Ehlis <tobine@google.com> Reviewed-by:
-
Tobin Ehlis authored
If the remaining allocation size for commands in the SecondaryCommandBuffer class is equal to the command allocation size and the follow-on header, then we can fill the allocation. Previously we were conservative and if the size needed exactly equals the size remaining, we would allocate a new block. Bug: b/154030403 Change-Id: Ie31f0f5d33782d12adbaea9e3b02598a004d7643 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158817Reviewed-by:
-
Geoff Lang authored
If the GL driver version is below 3.1, we cannot set the primitive restart fixed index (ES3 wont be supported anyway). Make sure the feature is disabled. Speculative fix for crbug.com/1073020 BUG=chromium:1073020 BUG=angleproject:3997 Change-Id: I67756b377aa951da2e70c26f7db978ede9010586 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159289 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Charlie Lao authored
EGL1.5 spec says depth/stencil data are undefined after swap. This CL will track the depth/stencil data and mark it as undefined and skip the load if it is undefined. Bug: b/153885625 Change-Id: Ifb3d88d442da547fa78c1eae091cbae08a20d0ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148179Reviewed-by:
-
Tobin Ehlis authored
A strictly cosmetic change to move code into alphabetical order. In working with SecondaryCommandBuffer commands in separate CLs, it can be difficult/annoying to track which commands are already in place as some of them are out-of-order. This change puts the command enums, functions, and processing in alphabetical order to simplify searching and adding new commands. Bug: b/154030403 Change-Id: I6dba4cf48d6f27c056585ac633c694e083b1a263 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158816Reviewed-by:
-
Geoff Lang authored
VMA_IMPLEMENTATION is defined in the build files, it doesn't need to be redefined in vk_mem_alloc_wrapper.cpp. BUG=angleproject:2162 Change-Id: Ie4eceedd2dd3051f8431c7c8c86403250e93f98b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154538 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Jamie Madill authored
This reverts commit 3fb33ade. Reason for revert: Causing WebGL test failures on GLES/ANGLE/Android. Bug: chromium:1072739 Original change's description: > Vulkan: Forward RenderBuffer/Surface dirty messages. > > Previously we were only forwarding Texture staging changes to the > Framebuffer for re-sync. We could miss out on clears that were staged > in Surfaces and Renderbuffer attachments. Complete the chain by making > the SurfaceVk and RenderbufferVk forward notifications from the > VkImage. > > Bug: angleproject:4517 > Change-Id: I15f36c225517e915f656d0c2464a99631ef9f945 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150699 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=cnorthrop@google.com,timvp@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:4517 Change-Id: I4fd4d79dc11da0ba86065d3a80975de4c791a2a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159288Reviewed-by:
-
Tobin Ehlis authored
Manually roll validation layers to latest and ignore two more VUIDs that are being flagged with latest layers. Bug: angleproject:4578 Bug: angleproject:4579 Bug: angleproject:4580 Change-Id: I4fc46d9df3fa3be4be1f8b773eb2d63e6f4bbd92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158265Reviewed-by:
-
Geoff Lang authored
Quotes were around the entire list of emails instead of around individual ones. Change-Id: Ice783622eb31981f606f49f57984a15771ace995 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159290 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Corentin Wallez authored
This was found while trying to fix https://github.com/glfw/glfw/issues/1169 VulkanSurfaceMtl and metal/SurfaceMtl already handle contentsScale correctly. Change-Id: I234d7b0901dd7c075cf1e9d58466f52140ab1e2b Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154670Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/50eaecd721a2..4fb0e0374a39 git log 50eaecd721a2..4fb0e0374a39 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 petr_kraus@email.cz docs: Fix link in interface docs Created with: gclient setdep -r third_party/vulkan-loader/src@4fb0e0374a39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I663809ab903c97827ccca4c8b9f290e59a0a1ffd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158781Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/61b7de3c39f0..67f4838659f4 Created with: gclient setdep -r third_party/spirv-tools/src@67f4838659f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I55e966b6836899c1fc656620c271b0f8d8db0b0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158783Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/068611f07d28..ff772a7bcc98 git log 068611f07d28..ff772a7bcc98 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 capn@google.com Don't use deprecated llvm::Type::getVectorNumElements() Created with: gclient setdep -r third_party/SwiftShader@ff772a7bcc98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Icb8097e2c135d1dbb7dc3cd3258f65b28066cda3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158784Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8824107d57d3..84463fe2902f git log 8824107d57d3..84463fe2902f --date=short --first-parent --format='%ad %ae %s' 2020-04-20 petr_kraus@email.cz repo: Update the clang style from VVL Created with: gclient setdep -r third_party/vulkan-tools/src@84463fe2902f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ic492d090c5c2e1b5e75ed9ed5f586b23f4f13942 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158779Reviewed-by:
-
Cody Northrop authored
Test: Temple Run MEC capture and replay Bug: b/152512564 Bug: angleproject:3662 Change-Id: I31be6e7ad9d290c2077f2f4d975c2d66779eb558 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155490 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
Cody Northrop authored
During mid-execution capture, when processing uniforms for a program, capture their values and repopulate during replay. Test: Temple Run MEC capture and replay Bug: b/152512564 Bug: angleproject:3662 Change-Id: If84711ead144b7c88710e6b12d0968e80e263c69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155489 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
Cody Northrop authored
When we detect a texture is immutable, create it with TexStorage and populate with TexSubImage. Test: Temple Run MEC capture and replay Bug: b/152512564 Bug: angleproject:3662 Change-Id: I1948a0376d2634957329d1da35d60ded3608479a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155488 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
- 20 Apr, 2020 13 commits
-
-
Tobin Ehlis authored
The latest VVL roll is generating many new errors for VUID-vkCmdClearColorImage-image-01993. This CL will suppress the error messages to prevent the test failures until they can be fixed. Bug: angleproject:4577 Change-Id: I3ea4986c1f43c7d7921761e537d6d51cac3327e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157853Reviewed-by:
-
Charlie Lao authored
The EGL spec says depth/stencil value are undefined after swap. We dont need to store depth/stencil value if this is the very last renderpass of a presentable surface and the endRenderpass call is from swap call. Bug: b/153885625 Change-Id: Ie853d2686c8eb15a4fa9dbdd80eb66e9fc037d24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157886Reviewed-by:
-
Tobin Ehlis authored
Bug: angleproject:1944 Change-Id: I200ee1bbd2c1e856e97db24dff2ab550292ba248 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157888Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
-
Charlie Lao authored
This detects the last renderpass is actually rendering to the image we are going to present and this is the very last renderpass to that image. We use finalLayout of the renderpass to do layout transition to VK_IMAGE_LAYOUT_PRESENT_SRC_KHR instead of a standalone barrier call. Bug: b/153885625 Change-Id: Ifc17c77a1ba12f22c9d6038775f3e254c35655ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155250 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
-
Tim Van Patten authored
The latest VVL roll is generating many new errors for VUID-vkCmdCopyImageToBuffer-srcImage-01998. This CL will suppress the error messages to prevent the test failures until they can be fixed. Bug: angleproject:4572 Test: BindUniformLocationES31Test.ArrayOfArrays/ES3_1_Vulkan_SwiftShader Change-Id: I6b36ab64cea8490e577f9077bb44fc7e5023fbda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154833 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Tim Van Patten authored
This CL adds cclao@ and timvp@ to watch for vulkan CLs so they can be notified for reviews. Bug: None Change-Id: Iea55a95aa2037ae5c141665dfa494c809a5befa2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152946Reviewed-by:
-
Geoff Lang authored
This workaround is needed when the GL driver is less than 4.3 (all MacOS). The driver will generate many errors during execution without this enabled which blocks GL driver error checking. Add additional workarounds for Intel drivers that need a sufficiently large primitive restart index when doing DrawArrays calls. BUG=angleproject:3997 Change-Id: Idd293ff1dbc0a3609b11ea1d6b30da0a99e8f5c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141714 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Ian Elliott authored
When the vertex array binding is changed, the value of ContextVk::mLastIndexBufferOffset must be reset so that an old/cached offset (from a previous draw call) is not used for a new draw call. This addresses rendering artifacts and Vulkan validation errors seen with running NBA 2K20 on Android (or the ANGLE trace on Windows). Bug: b/153682968 Bug: angleproject:4575 Bug: angleproject:4576 Change-Id: I69089964b8d278c7fc8610ab003548864a215dab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152850 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
-
Alexey Knyazev authored
Bug: angleproject:4394, angleproject:2169 Change-Id: I6c218af3871a1215c2b103847250bbc782159cb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2149645Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Jamie Madill authored
We ended up needing this to recover the image type in the RenderTarget. Otherwise we don't have direct access to this information in the FramebufferVk sync state code. Bug: angleproject:4517 Change-Id: I387947e0b7394e1f63f313dd4792bb042b8da73a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2151170Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/454ab259c1b8..8824107d57d3 git log 454ab259c1b8..8824107d57d3 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 locke@lunarg.com icd: Set texel size is 32 Created with: gclient setdep -r third_party/vulkan-tools/src@8824107d57d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I5b93c96db1e0a2cdd4fbf83bbbda85bf741c3083 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156119Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d25ce8725224..068611f07d28 git log d25ce8725224..068611f07d28 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 capn@google.com Fix JIT on separate thread 2020-04-17 bclayton@google.com Use Thread Safety Analysis annotations throughout SwiftShader. 2020-04-17 digit@google.com CMakeLists: Fix Fuchsia build. 2020-04-17 bclayton@google.com Merge changes Ia8226c11,If413b9d6 2020-04-17 bclayton@google.com LLVMReactor: Drop codegenMutex, now thread safe. 2020-04-17 bclayton@google.com LLVMJIT: Remove the TargetMachine cache. 2020-04-17 bclayton@google.com LLVM 7: Set LLVM_ENABLE_THREADS to 1 2020-04-17 bclayton@google.com SpirvShader: Fix ASSERT firing in debugger Created with: gclient setdep -r third_party/SwiftShader@068611f07d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I186bb705c9af7638abb1e20edb0bc0011de6cc95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156120Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4d2298bfd78a..3f4e5c456306 Created with: gclient setdep -r third_party/glslang/src@3f4e5c456306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I4e94af432409212f47a17bbd9d2d54126d6f3134 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156118Reviewed-by:
-
- 18 Apr, 2020 1 commit
-
-
Tim Van Patten authored
The function ShaderVariable::getNestedArraySize needs to return at least 1 entry for unsized arrays to ensure the shader buffer sizes are reported correctly. This also allows ANGLE to treat unsized arrays of structs and basic types the same way, allowing for the special treatment of unsized arrays in TraverseStructArrayVariable() to be removed. Bug: angleproject:3596 Test: dEQP-GLES31.functional.program_interface_query.shader_storage_block.buffer_data_size.* Change-Id: I3b2a3a68c25e0913b79e989d7c719b34ce9b75fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934952 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
-
