- 23 Dec, 2020 6 commits
-
-
Shahbaz Youssefi authored
Validation and generation of transform feedback varyings that specify an I/O block member are implemented in this change. The GL backend is able to pass the added tests. Bug: angleproject:3606 Change-Id: I66d02bed8ca9161555d0d1e7a32ae9ef4d9e813f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599952 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This reverts commit 11c31e0a. Reason for revert: Broke ANGLE -> Skia roll because of GN error. Bug: angleproject:5489 Original change's description: > Changes to build inside a Dawn checkout. > > Add an "angle_standalone" flag that can be disabled by Dawn. > Put test definitions behind angle_standalone || build_with_chromium. > > Bug: angleproject:5462 > Change-Id: I58c9b18723384334156e2a3dd86ed3f89afcaade > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587451 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=senorblanco@chromium.org,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5462 Change-Id: I4363d1d35b03e00d970e25ddd3d7eac51ad2da2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600078Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/78f4bbcd4cb1..a5e4417becc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b4b7adbdc2..d4fcf57b4e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d83fdb696..36d8b4b883 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3b78ceeade..ea63baff14 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2752abe7e2 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/e9a659a09e..09efc26aff No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ic57fe979eda136816aca4bcf9f38eb476e07cb56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601584Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Jamie Madill authored
We need the higher limit for tessellation shaders and ES 3.2. Unfortunately this means we are no longer using a packed 64-bit bitset for the active textures and images. We fallback to using std::bitset. Also keeps the 64 texture limit if tessellation is not available. The higher limits was causing timeouts in WebGL tests. Bug: angleproject:3572 Change-Id: I1953955600b56d7c66178bd610de53453151dc8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2586996 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
James Darpinian authored
Type confusion on the index buffer. It should be unsigned shorts. Fixes a crash on iOS. Bug: angleproject:4992 Bug: angleproject:5417 Change-Id: I18179a89dd81fff2582636496ea9684e432f4400 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601162Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
Manually update deqp.gni to include new es3cNumberParsingTests files. https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/54509765b18d..b29bf0434c16 2020-12-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2020-12-18 alexander.galazin@arm.com Raise min CMake version to 3.10.2 2020-12-18 jeremyg@lunarg.com Fix Renderpass storeOp synchronization hazards 2020-12-18 jeremyg@lunarg.com Fix back-to-back transfer command synchronization hazards 2020-12-18 gleese@broadcom.com Simplify code for subgroup builtin mask tests 2020-12-18 jeremyg@lunarg.com Fix end of Renderpass synchronization hazards 2020-12-18 jeremyg@lunarg.com Fix additional RenderPass loadOp/stencilLoadOp sync hazards. 2020-12-18 jeremyg@lunarg.com Fix RenderPass stencilLoadOp synchronization hazards. 2020-12-18 jeremyg@lunarg.com Fix RenderPass loadOp synchronization hazards. 2020-12-17 mikko.tiusanen@siru.fi Tests for GLES3 number parsing 2020-12-17 mikko.tiusanen@siru.fi Tests for multiple clears within render pass 2020-12-17 rgarcia@igalia.com Enable nullDescriptor for AS ray query tests 2020-12-15 piotr.byszewski@mobica.com Test dynamic indexing of AS 2020-12-15 rgarcia@igalia.com Test dynamic indexing of ray queries 2020-12-13 piotr.byszewski@mobica.com Test procedural geometry with complex BB sets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: I59e4aabcfbf496d02e18ba7b7aa06391ba90f434 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600639Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
- 22 Dec, 2020 5 commits
-
-
Shahbaz Youssefi authored
An assertion was fired which was only valid when emulating transform feedback. The relevant block is conditioned to the respective feature. Bug: angleproject:3571 Change-Id: I287ef6d94c920ccda742e4032bfc389409a38e1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599951Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
Bug: angleproject:5478 Bug: angleproject:5479 Change-Id: If7ae7b6e0960c66dde697726381bc68c6809b3c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599940Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
This pipes through to a system call via JNI. This will allow Chromium changes to land that were prevented because ANGLE hard-coded some parts of this path. This in turn will allow us to more easily override these paths for changes needed for Android R support. Bug: chromium:1094062 Change-Id: I20d75b8ee40d418ba5c057f618640ef896248299 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315483 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Shahbaz Youssefi authored
Clean up change in preparation for changes that add more options. Bug: angleproject:5478 Change-Id: Id35825b337dba153a5c28dfcc311b344ce257f78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599941 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/4545fb53923b..78f4bbcd4cb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/34da458aa2..b4b7adbdc2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c28f31863b..9d83fdb696 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d43e58994 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d324a17c34..1283870fa3 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I9782920f655b361fcf171cecd29f06f671fe5d8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600183Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 21 Dec, 2020 4 commits
-
-
Stephen White authored
Add an "angle_standalone" flag that can be disabled by Dawn. Put test definitions behind angle_standalone || build_with_chromium. Bug: angleproject:5462 Change-Id: I58c9b18723384334156e2a3dd86ed3f89afcaade Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587451Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
-
Charlie Lao authored
If glMapBufferRange is called with GL_MAP_INVALIDATE_BUFFER_BIT bit set, caller indicates that it don't care about the previous content. If the buffer is busy, instead of wait for GPU to finish and then map the buffer, we should just allocate a new memory and return it. brawl_stars is hitting this case. With this CL, the frame time is cutting to half on the pixel device. Bug: b/175905404 Change-Id: If1220f07ebf53dd28fe6a4732eaba84e2e57598e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2597784Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
The move constructor was calling the move assignment operator, which used std::swap on the members. However, `this` was not constructed, so std::swap was operating on uninitialized values. Caught by UBSAN. Bug: chromium:1159444 Change-Id: I65f2f0affd1461f880c59780f31a368779411f24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599936Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/af73f1e9f8c8..4545fb53923b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/68fec68de7..34da458aa2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e5bbe1bc6f..c28f31863b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d43e58994 No update to Clang. Bug: None Tbr: cwallez@google.com Change-Id: Ib5357a8c44f44245b5df8e583e8460b9ac84a70f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2597052Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 19 Dec, 2020 2 commits
-
-
Le Hoang Quyen authored
Previously, spirv-cross would automatically do this (converting to void function) if shader writes to XFB buffers, however this behavior is changed in latest spirv-cross version. So the rasterization disable must be explicitly specified via spirv-cross’s options now. Bug: chromium:1159974 Change-Id: I9f34e1cd9d2f1386e8a8d030a800fbd7341eb68f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2596914 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
jchen10 authored
The driver fix is available already. Bug: angleproject:2906 Change-Id: Id607fa5217360afd99e5de0d2e5f35f79615d160 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2594323 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 18 Dec, 2020 6 commits
-
-
Kenneth Russell authored
There are bugs in Apple's OpenGL driver when uploading to textures of these formats via pixel buffer objects. Because automatic graphics switching might activate the AMD GPU at any time, use this workaround on dual-GPU MacBook Pros even if the Intel GPU is active. Fixes the following WebGL 2.0 conformance tests: deqp/functional/gles3/texturespecification/ teximage2d_pbo_2d_00.html teximage2d_pbo_2d_01.html texsubimage2d_pbo_2d_00.html texsubimage2d_pbo_2d_01.html texsubimage2d_pbo_cube_01.html Bug: angleproject:5469 Change-Id: I7d65dc5f664159b4b59d46400a8d9c492f67040b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2595245 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
This will allow the entire set of Vulkan DEPS to be rolled as one. Bug: angleproject:5390 Change-Id: I10ca4f966f986baf3aab7250935802a3ed1065f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587671 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1ca6504eb7bb..1cc5b3357d2f 2020-12-17 amaiorano@google.com Optimize reciprocal sqrt operation 2020-12-17 amaiorano@google.com Optimize reciprocal operation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I138802959ca39114cf2d4373171b47b3a1911681 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598359Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/45e7154d4b07..af73f1e9f8c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/de4c58d749..68fec68de7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/13342b6ee2..e5bbe1bc6f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d43e58994 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/36810de981..d324a17c34 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f9059111fd..bd7d73d146 No update to Clang. Bug: angleproject:5390 Tbr: cwallez@google.com Change-Id: I86fb4663eaf9eed3992dcc2721b489d5bbd6add2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598280Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
jchen10 authored
This disables forceCpuPathForCubeMapCopy as well Bug: angleproject:2822 Bug: angleproject:3055 Change-Id: Iecb37d0c2d109e319c67310dd64ad8d4bbc14fd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2594707 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Tim Van Patten authored
ValidateBufferStorageEXT() has a copy/paste error where the flag GL_MAP_PERSISTENT_BIT_EXT is enabled twice while GL_MAP_COHERENT_BIT_EXT is not enabled at all during parameter checking, causing ANGLE to reject valid calls to glBufferStorageEXT(). Bug: angleproject:5473 Test: BufferStorageTestES3.BufferStorageFlagsPersistentCoherentWrite Change-Id: I05596f54d48118f609ef1c88ca222d9fcdb2dd3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2596956 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
- 17 Dec, 2020 5 commits
-
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/0592a5f8d414..45e7154d4b07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cwallez@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/deb698d48d..de4c58d749 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6e6d8d1651..13342b6ee2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dfe5e0a3af..3b78ceeade * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5039608d33 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/9be8079c29..ec1e3f2e46 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9cb7877086..f9059111fd * tools/skia_goldctl/linux: bTvIvWnbZxg0-7ukJDOeVphyUCuVIkxtui-gilfeBScC..Ac-h0vLh65FkA8CAYh5B6yg9X0l3cJFf5XCZkVByG1AC * tools/skia_goldctl/mac: 6s5TRj110nqaPlBS8YO4HN2dRmhheX7a-pp3YWURcnoC..NYEeKAWq6p8n1jHl0h3emCE3hdfWkaYbeoEPrnFO5dEC * tools/skia_goldctl/win: 4UEZlBTjAOzFCQchRqtALQwJDyYXa9Sj_52oUhXmNkoC..HHMFtoVyIQfQIhJgSOb5RkIHwzApVNZXRtDNjBCx3tEC No update to Clang. Bug: angleproject:5390 Tbr: cwallez@google.com,jmadill@google.com Change-Id: I8affb75cd7a06e38825d305ddbf043788cbe3721 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2597779Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Jonah Ryan-Davis authored
This reverts commit fa9b803e. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1157748 Original change's description: > GLX: Expose EGL_ANGLE_window_fixed_size > > Right now the GLX backend checks for resize on every SwapBuffers > call. If EGL_ANGLE_window_fixed_size is used, it will only resize > when signaled by Chrome. > > Bug: chromium:1132827 > Change-Id: Ia4ddbbbf6dcf13f46ad564208eccc517de8be33c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572886 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> TBR=syoussefi@chromium.org,jonahr@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1132827 Change-Id: I1110c5dd5d806b3c6c59308d4865f0d3aa57fc3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2595197Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a5be11bd8b3f..6d5916d4a91e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I46f0450f451d441565c70d292bc7d38fbf3711ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2596610Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fa44979d90aa..1ca6504eb7bb 2020-12-15 amaiorano@google.com Fix ReactorBenchmarks build failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I5b1c3a951a05843e44461ba9a30b7585d980864b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2594712Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Tim Van Patten authored
This is a reland of 5cf7472d The ShareGroupVk::mResourceUseLists was not being cleared each call to RendererVk::submitFrame(), so it was growing indefinitely. Each vk::ResourceUseList within it was cleared, so it was holding an essentially "infinite" list of empty lists, but that caused the loop in RendererVk::submitFrame() to take more and more time until the tests timed out. The fix is to do 'resourceUseLists.clear()' once the loop to release all resources has completed, like releaseResourceUsesAndUpdateSerials() does for each individual list. Additionally, ASSERTs are added to guarantee that the lists are empty when the ContextVk and ShareGroupVk are destroyed. Original change's description: > Vulkan: Ignore glFlush to reduce vkQueueSubmits in Asphalt 9 > > Multithreaded apps can use the following pattern: > > glDrawElements() > glFenceSync() > glFlush() > glWaitSync() > > This currently results in a vkQueueSubmit for every glFlush() to ensure > that the work has landed in the command queue in the correct order. > However, ANGLE can instead avoid the vkQueueSubmit during the glFlush() > in this situation by instead flushing the ContextVk's commands and > ending the render pass to ensure the commands are submitted in the > correct order to the renderer. This improves performance for Asphalt 9 > by reducing frame times from 150-200msec to 35-55msec. > > Specifically, ANGLE will call flushCommandsAndEndRenderPass() when > there is a sync object pending a flush or if the ContextVk is currently > shared. > > Additionally, on all devices except Qualcomm, ANGLE can ignore all other > glFlush() calls entirely and return immediately. For Qualcomm devices, > ANGLE is still required to perform a full flush (resulting in a > vkQueueSubmit), since ignoring the glFlush() reduces the Manhattan 3.0 > offscreen score by ~3%. > > Bug: angleproject:5306 > Bug: angleproject:5425 > Change-Id: I9d747caf5bf306166be0fec630a78caf41208c27 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552718 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5306 Bug: angleproject:5425 Bug: angleproject:5470 Change-Id: I14ee424d032f22e5285d67accbec078ad1955dd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2595811 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 16 Dec, 2020 8 commits
-
-
Mohan Maiya authored
The 2 end2end tests added by a62ee4d1 no longer fail with latest Pixel ICDs. Enable those tests as regression checks. Tests: angle_end2end_tests --gtest_filter=*SamplerPassthrough*Vulkan* Bug: angleproject:5457 Change-Id: I53fb06fffa3fc76ef6f9a9e811ef5b833577ed67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2595389Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
Jamie Madill authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross/+log/f38cbeb814c7..be527632a6c8 $ git log f38cbeb81..be527632a --date=short --no-merges --format='%ad %ae %s' 2020-11-25 comexk spirv_msl: Don't add fixup hooks for builtin variables if they're unused. 2020-11-23 cdavis MSL: Don't mask off inactive bits in ballot masks. 2020-11-20 cdavis MSL: Adjust FragCoord for sample-rate shading. 2020-11-23 post GLSL: Fix buffer_reference with aliased names. 2020-11-23 post GLSL: Emit storage qualifiers for buffer_reference. 2020-11-23 post HLSL: Fix validation with FXC for test. 2020-11-23 post Normalize all internal workaround methods to use spv prefix. 2020-11-21 scribam CMake: Set minimum required version to 3.0 2020-11-18 cdavis MSL: Expand subgroup support. 2020-11-12 git GLSL: Require GL_ARB_vertex_attrib_64bit for double input in pre-4.10 2020-11-14 cdavis MSL: Expose some more features on iOS. 2020-11-11 post MSL: Add missing reference file. 2020-11-11 post Fix switch fallthrough 2020-11-09 git GLSL: Legacy / extension fallbacks for textureSize and texelFetch 2020-10-29 jsikorski MSL: extract global variables from subgroup ballot operations 2020-11-08 post Run format_all.sh. 2020-11-08 post Update texture gather test result. 2020-11-07 git GLSL: Add error checking and extension fallback for textureGather 2020-11-07 git GLSL: Remove unused `lod` argument from legacy_tex_op() 2020-11-05 git GLSL: implement transpose() in GLSL 1.10 / ES 1.00 2020-11-06 git GLSL: Fix round/roundEven for legacy GLSL. 2020-11-05 git GLSL: Fix support for textureLod in legacy vertex shaders 2020-11-06 post MSL: Fix regression in image gather handling. 2020-11-02 cdavis MSL: Support pull-model interpolation on MSL 2.3+. 2020-11-03 git HLSL: Support roundEven() in HLSL SM 4.0 and above 2020-11-03 git HLSL: Add regression test for SM3.0 texture samplers 2020-10-31 git HLSL: Support depth comparison texture sampling in SM 2/3. 2020-11-03 post HLSL: Add option to flatten matrix vertex input semantics. 2020-11-03 post Parser: Don't assume OpTypePointer will always take a SPIRType. 2020-11-02 bill.hollings Syntax and format updates from code review. 2020-11-02 crisserpl2 Updated ref file for subgroups_basicvoteballot.vk.comp 2020-10-31 devsh.graphicsprogramming Fix some bad assumptions about emulating `subgroupBarrier` 2020-10-30 bill.hollings Minor format and typo updates from code review. 2020-10-27 cdavis MSL: Allow Bias and Grad arguments with comparison on Mac in MSL 2.3. 2020-10-30 post GLSL: Fix nonuniformEXT injection. 2020-10-30 atyuwen fixed compile error with -std=c++20 2020-10-30 atyuwen added metal keyworld: "level" (#1501) 2020-10-29 bill.hollings MSL: Support run-time sized image and sampler arrays (GL_EXT_nonuniform_qualifier/SPV_EXT_descriptor_indexing). 2020-10-27 cdavis MSL: Allow framebuffer fetch on Mac in MSL 2.3. 2020-10-27 cdavis MSL: Allow post-depth coverage on Mac in MSL 2.3. 2020-10-27 post Handle case where block is loop header, continue AND break block. 2020-10-14 post GLSL: Support a workaround for loading row-major matrices. 2020-10-20 cdavis MSL: For 2.1+, don't disable rasterization for vertex writes. 2020-10-26 post MSL: Do not use component::x gather for depth2d textures. 2020-10-26 post Update TravisCI python reference. 2020-10-21 cdavis MSL: Cast broadcast booleans to ushort. 2020-10-20 cdavis MSL: Mask ballots passed to Ballot bit ops. 2020-10-20 cdavis MSL: Support vectors with OpGroupNonUniformAllEqual. 2020-10-20 cdavis MSL: Correct definitions of subgroup ballot mask variables. 2020-10-20 cdavis MSL: Don't remove periods from swizzle buffer index exprs. (...) 2020-06-18 post MSL: Deal with loading non-value-type arrays. 2020-06-18 post MSL: Add tests for array copies in and out of buffers. 2020-06-18 post MSL: Improve handling of array types in buffer objects. 2020-06-18 post Clean up some deprecation warnings when building with Makefile. 2020-06-18 post Remove unused member in MSLShaderInput. 2020-06-13 cdavis MSL: Fix up input variables' vector lengths in all stages. 2020-06-16 post HLSL: Fix texProj in legacy HLSL. 2020-06-12 git GLSL: Require GL_ARB_draw_instanced for gl_InstanceID in GLSL < 1.40 2020-06-08 post GLSL: Handle the rest of GL_ARB_sparse_texture_clamp. 2020-06-08 post GLSL: Support uint code for sparse residency query. 2020-06-05 post Refactor texture fetch function generation. 2020-06-06 AlexanderMeissner Fix missing switch cases in Y'CbCr conversion 2020-06-04 post GLSL: Implement sparse feedback. 2020-06-04 post MSL: Remove obsolete MSLVertexAttr members. 2020-06-04 post HLSL: Add native support for 16-bit types. 2020-05-28 bryan.bernhart Prefer set/binding API 2020-05-28 post Document all CLI options. 2020-05-28 post Do not mask writes to remapped variables in all cases. 2020-05-27 bryan.bernhart HLSL: Add option to treat certain SSBO bindings as UAV, even with readonly. 2020-05-25 post Handle physical pointers in reflection API. 2020-05-22 post GLSL: Improve support for GL_ARB_shader_draw_parameters in desktop GLSL. 2020-05-21 dsinclair Roll SPIRV-Tools, SPIRV-Headers and GLSLang. 2020-05-20 dsinclair Roll dependencies 2020-05-20 post GLSL: Add more test shaders for hit attribute types. 2020-05-20 post GLSL: Support ray payloads and hit attributes declared as Block. 2020-05-20 post GLSL: Add some more focused RT test shaders. 2020-05-19 post HLSL: Implement image queries for UAV images. 2020-05-08 post Support gl_InstanceID in RT shaders. 2020-05-06 post MSL: Avoid packed arrays in more cases. 2020-05-06 post Add missing reference files from PR merge. 2020-05-06 lehoangq Fix #1359: MSL: If the packed type is scalar, don't emit "pack_" prefix. 2020-04-30 post MSL: Redirect member indices when buffer has been sorted by Offset. 2020-04-30 cwallez Fix -Wmicrosoft-enum-value 2020-04-28 rharrison Update SPIR-V Headers to 1.5 rev 3 2020-04-27 post Work around odd deadlock in test_shaders.py in --parallel mode. 2020-04-27 post Implement OpAtomicLoad/OpAtomicStore. 2020-04-27 post MSL: Fix case where subpassInput is passed to leaf functions. 2020-04-27 alexis.payen Fixed recursion in combined_decoration_for_member Members in nested structs were not properly iterated on, and as a result, flags like row major for matrices could be not propagated properly. 2020-04-23 dsinclair Roll GLSLang, SPIRV-Tools and SPIRV-Headers. 2020-04-21 post GLSL: Support f16x2 <-> f32 bitcast. 2020-04-21 post Be a bit more careful what nonuniform state is propagated. 2020-04-21 post Handle RayQueryKHR type. 2020-04-21 post Update SPIR-V headers. 2020-04-18 devsh.graphicsprogramming Fix issue #1327 2020-04-21 post HLSL: Add parens in unpackUint2x32 for clarity. 2020-04-21 post HLSL: Only allow 64-bit integers in SM 6.0. 2020-04-21 post Ensure unpack/pack2x32 tests are compatible with test suite. 2020-04-17 bingkan GLSL/HLSL: Support packUint2x32 and unpackUint2x32 2020-04-21 post MSL: Deal correctly with initializers on Private variables. 2020-04-20 post MSL: Support edge case with DX layout in scalar block layout. Created with: roll-dep third_party/spirv-cross/src Bug: angleproject:5390 Change-Id: If2ccfd70739a4377b929813cd819067c4c5aa3a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2593554 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
jchen10 authored
The test can pass on 26.20.100.8141 now. Bug: angleproject:2805 Change-Id: I8049c43ed7eca6c2001a8d8745aa6f9c2a2192a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2594349 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Corentin Wallez authored
This reverts commit 5cf7472d. Reason for revert: causes timeouts, see anglebug.com/5470 Original change's description: > Vulkan: Ignore glFlush to reduce vkQueueSubmits in Asphalt 9 > > Multithreaded apps can use the following pattern: > > glDrawElements() > glFenceSync() > glFlush() > glWaitSync() > > This currently results in a vkQueueSubmit for every glFlush() to ensure > that the work has landed in the command queue in the correct order. > However, ANGLE can instead avoid the vkQueueSubmit during the glFlush() > in this situation by instead flushing the ContextVk's commands and > ending the render pass to ensure the commands are submitted in the > correct order to the renderer. This improves performance for Asphalt 9 > by reducing frame times from 150-200msec to 35-55msec. > > Specifically, ANGLE will call flushCommandsAndEndRenderPass() when > there is a sync object pending a flush or if the ContextVk is currently > shared. > > Additionally, on all devices except Qualcomm, ANGLE can ignore all other > glFlush() calls entirely and return immediately. For Qualcomm devices, > ANGLE is still required to perform a full flush (resulting in a > vkQueueSubmit), since ignoring the glFlush() reduces the Manhattan 3.0 > offscreen score by ~3%. > > Bug: angleproject:5306 > Bug: angleproject:5425 > Change-Id: I9d747caf5bf306166be0fec630a78caf41208c27 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552718 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=timvp@google.com,jmadill@chromium.org,cclao@google.com Change-Id: I9886bf901a835d408b6a4b8be7ea408fa2121be0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5306 Bug: angleproject:5425 Bug: angleproject:5470 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2595032Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c0bcfaf3bae9..a5be11bd8b3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I639bd35c4d16e4e69acf60b70c6649c3dd441a73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2594711Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/5a03bdd6e398..0592a5f8d414 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3156ee0cf9..deb698d48d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/715d9573da..6e6d8d1651 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f600415e92 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b93f034c30..9cb7877086 No update to Clang. Bug: angleproject:5390 Tbr: cwallez@google.com Change-Id: I8dc12fad910dbfcf737fe1f0589a41b065cd3d8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2594635Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Jamie Madill authored
This should fix the duplicate target definition for the layers. Bug: angleproject:5390 Bug: angleproject:5468 Change-Id: Iaafe9e059fee823b2e4b9145ea38dc61b6d767db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2593565Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
The CacheStats of all internal caches are accumulated by the renderer. In order to see the hit ratios of all caches, the following GN args must be enabled: is_debug = true angle_enable_perf_counter_output = true Bug: angleproject:5447 Test: Manual verification with angle_end2end_tests Change-Id: Iaca3249192e9e4e130d8291b7759c459d79b06ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2588430 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 15 Dec, 2020 4 commits
-
-
Tim Van Patten authored
Multithreaded apps can use the following pattern: glDrawElements() glFenceSync() glFlush() glWaitSync() This currently results in a vkQueueSubmit for every glFlush() to ensure that the work has landed in the command queue in the correct order. However, ANGLE can instead avoid the vkQueueSubmit during the glFlush() in this situation by instead flushing the ContextVk's commands and ending the render pass to ensure the commands are submitted in the correct order to the renderer. This improves performance for Asphalt 9 by reducing frame times from 150-200msec to 35-55msec. Specifically, ANGLE will call flushCommandsAndEndRenderPass() when there is a sync object pending a flush or if the ContextVk is currently shared. Additionally, on all devices except Qualcomm, ANGLE can ignore all other glFlush() calls entirely and return immediately. For Qualcomm devices, ANGLE is still required to perform a full flush (resulting in a vkQueueSubmit), since ignoring the glFlush() reduces the Manhattan 3.0 offscreen score by ~3%. Bug: angleproject:5306 Bug: angleproject:5425 Change-Id: I9d747caf5bf306166be0fec630a78caf41208c27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2552718 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Paul Thomson authored
The WhatsApp trace was previously captured with the GL_NV_shader_noperspective_interpolation extension enabled. This re-capture was made with the extension disabled so the trace can replayed on devices that don't support the extension. Test: angle_perftests --gtest_filter="*whatsapp*" Bug: b/174256233 Change-Id: I9dbf580ed5849b919a72944879be35193632e34a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2593191 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Charlie Lao authored
If specialization constant is used, driver uniform data structure should be reduced to minimum to increase cache locality. Bug: b/175479076 Change-Id: I1fc50666542c6763c60bfe011cde5bc77ccc08e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2588549Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
-
Mohan Maiya authored
Addition of shader autogen code for EXT_clip_cull_distance extension. Bug: angleproject:5458 Change-Id: I299528957c0e747fd84987c420588c314f54aae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2590989 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-