https://swiftshader.googlesource.com/SwiftShader.git/+log/488d35ac0b1c..5fc197dc7669

git log 488d35ac0b1c..5fc197dc7669 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 jonahr@google.com Disable MSVC warning 4065
2020-01-15 bclayton@google.com Vulkan: Disable SPIR-V preprocessing when debugging
2020-01-15 capn@google.com Produce less debug info in Kokoro builds
2020-01-15 capn@google.com Refactor binary group operations
2020-01-15 capn@google.com Replace positive/negative_inf() with infinity()
2020-01-15 bclayton@google.com SpirvShader: Stub OpenCL.DebugInfo.100
2020-01-15 bclayton@google.com System/Types.hpp: Make vec(T replicate) constexpr
2020-01-15 bclayton@google.com SpirvShaderDebugger: Add flag for printing opcodes
2020-01-15 bclayton@google.com SpirvShader: 2-way imported extensions lookup
2020-01-15 bclayton@google.com .vscode: Add spirv-tools-ext to include path
2020-01-14 bclayton@google.com C++14: Use enum class builtin hashing
2020-01-14 bclayton@google.com C++14: Use std::enable_if_t instead of our own
2020-01-14 chrisforbes@google.com Add initial stub implementation of AHB

Created with:
  gclient setdep -r third_party/SwiftShader@5fc197dc7669

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4299
Tbr: jonahr@google.com
Change-Id: I0badcf80f1be1ca17654a1d2f09f420e313dd540
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003124Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Bug: angleproject:3569
Bug: angleproject:3596
Bug: angleproject:4106
Bug: angleproject:4108
Bug: angleproject:4300
Change-Id: Iab88bf5db19af802ad41ef8bf68f643420857989
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003233Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Found two issues when native OVR_multiview and OVR_multiview2 extensions are generated.
1. OVR_multiview got replaced by the OVR_multiview2 in the translated shader (ESSL & GLSL)
2. Duplicate #extension OVR_multiview2 (for Fragment & Vertex) and 'layout (num_views=x)' (for Vertex) got generated into the translated shader.

Bug: angleproject:4247
Change-Id: I9a550883eeb326d95af4557578f8202a9493f4ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983802Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Originally authored in the WebKit repository:
https://bugs.webkit.org/show_bug.cgi?id=205618

Has been tested with WebKit's WebGL backend on top of ANGLE inside the
iOS Simulator. TODOs will be addressed in forthcoming CLs.

Bug: angleproject:4263
Change-Id: Ic879866aaee5f933599d956b0646d0c01db55d0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1995824Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

Bug: angleproject:3829
Change-Id: I872118f145886eecaed1680268e95419385b9d9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001237Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This was done based on the incorrect assumption that Vulkan GLSL doesn't
allow layout qualifiers on interface block fields.  This was due to
glslang compile failures in some shaders that included mixed row- and
column-major fields in interface blocks.

However, the failures were only in the case the interface block is
inactive, in which case glslang wrapper previously replaced the
layout/qualifier of the interface block with |struct|, which left the
shader with an unused struct definition with fields that have layout
qualifiers; an invalid shader.

The change introduced in
https://chromium-review.googlesource.com/c/angle/angle/+/1951523
removes inactive shader interface declarations.  The above scenario thus
never occurs, rendering the row- to column-major transformation
unnecessary.

Bug: angleproject:3443
Change-Id: Ice34a0fc6e047b79a4d44f04b730ec59bdfafe33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961098Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Makes sure P010 stream can work correctly.

Bug: chromium:1033416
Change-Id: I1b49568cd667697337335a0eca74504bd0e36f5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1996912Reviewed-by: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Previously we were still calling GoogleTest directly. This change
switches the test main funtions to call the standalone harness. Only
affects standalone and shouldn't affect the tests in Chromium or on
the current test setup.

Bug: angleproject:3162
Change-Id: Ia5a5a73d47c0b47b4df8f54cd6df71da2d878847
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998661
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Adds special handling for the DISABLED_ GTest test name. Fixes the test
for the test suite harness itself when run with the new "--bot-mode"
flag.

Bug: angleproject:3162
Change-Id: Idf34098d2d6bcb78263773be7b01c55df9ec624b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998660
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Reorganizes the build files to work with a more divided setup. It is
unclear if we'll ever be able to run tests in a UWP config. This at
least sets up the organization so it would at some point be possible.

Bug: angleproject:4182
Change-Id: I49dddfcdc0118b11466fe171f949c28d101ac6a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953484
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:4211
Change-Id: I9e9cdacd4f24131101029d17932625e2e3c7d7e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957836
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Prepratory clean up for WinUWP support.

Bug: angleproject:4182
Change-Id: I97cc6cb42a50c6b57ca7d375d1e0a6b3da7aa9d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998673
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b96d6528883e..834baaf8b227

git log b96d6528883e..834baaf8b227 --date=short --first-parent --format='%ad %ae %s'
2020-01-13 petr_kraus@email.cz layers: Default vuid links to spec repo search

Created with:
  gclient setdep -r third_party/vulkan-validation-layers/src@834baaf8b227

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Id4efc3fd3e1d19026e52bcbb27ef7c0e260f2797
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999621Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/b0ca2a89e255..488d35ac0b1c

git log b0ca2a89e255..488d35ac0b1c --date=short --first-parent --format='%ad %ae %s'
2020-01-13 bclayton@google.com Vulkan/Debug: Fix `DAP_LOG` macro
2020-01-13 bclayton@google.com CMakeLists.txt: Copy OpenCLDebugInfo100.h to new dir
2020-01-13 bclayton@google.com .vscode: Define ENABLE_VK_DEBUGGER
2020-01-13 bclayton@google.com Regres: Roll dEQP 1.1.6 forward
2020-01-13 capn@google.com Rename NonNormalized to Unnormalized
2020-01-13 capn@google.com Disable the GL_NV_framebuffer_blit extension
2020-01-13 capn@google.com Disable the GL_APPLE_texture_format_BGRA8888 extension
2020-01-13 capn@google.com Allow verbal bug IDs
2020-01-13 capn@google.com Validate the bug ID format in Kokoro presubmit

Created with:
  gclient setdep -r third_party/SwiftShader@488d35ac0b1c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I7ee074ac9e4fa93dfc71ec5248e5e67668984ada
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2000043Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/18b3b94567a9..8013d477aeac


Created with:
  gclient setdep -r third_party/spirv-tools/src@8013d477aeac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Ic2d9f5ab6e006d389604537be974a94eb050017e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999622Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Changing SwiftShader to return:

    VK_SAMPLE_COUNT_1_BIT | VK_SAMPLE_COUNT_4_BIT for

for VkPhysicalDeviceLimits::sampledImageIntegerSampleCounts fixes two
tests that were failing with SwS.

This also fixes the expectations file for another test.

Bug: angleproject:4260
Bug: angleproject:4259
Bug: angleproject:3565
Change-Id: I698468ff8421b1c8556c8671b173e1cfde6b7f6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999484Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Bug: angleproject:4267
No-Try: True
Change-Id: I5d9846779e4ac27313ec57b6ded935dbb40e1970
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1995829
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/51813670627c..d203754bc116


Created with:
  gclient setdep -r third_party/glslang/src@d203754bc116

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I83c4c132afd6203fe09fe709721faca0c03614c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993888Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/110236f3ce70..b0ca2a89e255

git log 110236f3ce70..b0ca2a89e255 --date=short --first-parent --format='%ad %ae %s'
2020-01-11 bclayton@google.com Pipeline: Implement the SpirvShader debugger.
2020-01-11 swiftshader.regress@gmail.com Regres: Update test lists @ 0f8f361a
2020-01-10 swiftshader.regress@gmail.com Regres: Update test lists @ 110236f3
2020-01-10 sugoi@google.com Removed a few parentheses for slightly better clang formatting
2020-01-10 sugoi@google.com A2R10G10B10 Support
2020-01-10 ianelliott@google.com Change sampledImageIntegerSampleCounts to sampleCounts
2020-01-10 srisser@google.com Add the PowerVR SDK as a git submodule

Created with:
  gclient setdep -r third_party/SwiftShader@b0ca2a89e255

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I598844bc14cd0c3654a6ace7f17bd2040cc80a36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993886Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c17344df6cca..b96d6528883e

git log c17344df6cca..b96d6528883e --date=short --first-parent --format='%ad %ae %s'
2020-01-10 mark@lunarg.com tests: Fix YCbCr sampler test
2020-01-10 pdaniell@nvidia.com corechecks: Fix issues with separate depth/stencil layouts
2020-01-10 petr_kraus@email.cz layers: Report valid spec links on error
2020-01-10 petr_kraus@email.cz tests: Test vkCmdExecuteCommands into a Secondary
2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01618
2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01608
2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01588
2020-01-10 s.fricke@samsung.com layers: Added VK_IMAGE_CREATE_DISJOINT_BIT validation
2020-01-10 s.fricke@samsung.com tests: Added 01564 test to DSAspectBitsErrors
2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01564
2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01648
2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01648
2020-01-10 s.fricke@samsung.com tests: Added 01560 test to ImageBufferCopyTests
2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01560

Created with:
  gclient setdep -r third_party/vulkan-validation-layers/src@b96d6528883e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I7b9edbae8b42a41042e8adec7a5c3b12dd8be724
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993887Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb2e819819ef..18b3b94567a9


Created with:
  gclient setdep -r third_party/spirv-tools/src@18b3b94567a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Ied4595d3d1b2ea5d7352f719c441c9b2d8baa75f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993889Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

For current WEBGL_video_image implementation, VideoImage texture type translates to its
native texture type in blink layer.

A refactory for this implementation is required but is complicated and need much time.
Currently, we need a workaround in ANGLE to support this extension.

Current end2end tests can monitor this workaround well.

BUG=chromium:776222, angleproject:3889
Change-Id: I864bc2734cfffc8c5aea6166466767e3fb31c1c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989864
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bind the driver uniforms set only when actually updating them.

Bug: angleproject:4261
Change-Id: Ie1f1ab61eef58c5e0c713d285050c79c4cfccb32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986928
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>

The programs have a different shader interface, to force rebinding
descriptor sets in the Vulkan backend.

Bug: angleproject:4261
Change-Id: I7a18a441483dfe34bd40b5a30ca34b7fd0dc3219
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990085
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The test had two array sizes swapped, causing failure on vendors that
statically verified index-out-of-bound accesses.

Bug: angleproject:3831
Change-Id: I8ec32e9c11b38b69f03b1a22e60dfb6c6e82c2a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947123Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This function was unconditionally calling finishImpl().  This is changed
to finishToSerial() to only wait until the serial that actually used the
buffer.

Bug: angleproject:3072
Change-Id: Ida89bb119b4ba6420f12404b911af0e3b4583a51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993407
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Under robustBufferAccess, Vulkan states that:

Vertex input attributes are considered out of bounds if the offset of
the attribute in the bound vertex buffer range plus the size of the
attribute is greater than either:

- vertexBufferRangeSize, if bindingStride == 0; or
- (vertexBufferRangeSize - (vertexBufferRangeSize % bindingStride))

The latter implies that if the buffer size is not a multiple of the
vertex attribute stride, what lies beyond the last multiple of stride is
considered out of bounds.

It also says:

Out-of-bounds buffer loads will return any of the following values:

- Values from anywhere within the memory range(s) bound to the buffer
  (possibly including bytes of memory past the end of the buffer, up to
  the end of the bound range).
- Zero values, or (0,0,0,x) vectors for vector reads where x is a valid
  value represented in the type of the vector components and may be any
  of ...

The first bullet point indicates that the driver is allowed to load the
attribute values from the buffer if its range still lies within the
buffer size.

Take the following example:

- Buffer size = 12
- Attribute stride = 8
- Attribute offset = 0
- Attribute size = 4

Basically the buffer is thus laid out as follows:

          attr stride
      _________/\_________
     /                    \
    +----------+----------+----------+
    | vertex 0 | padding  | vertex 1 |
    +----------+----------+----------+
     \___ ____/
         V
     attr size

In the above example, the attribute for vertex 1 is considered out of
bounds, but the driver is allowed to either read it correctly, or return
(0, 0, 0, 1) for it.

Most drivers implement the former, while AMD implements the latter.
This change introduces a workaround for AMD where
GL_MAX_VERTEX_ATTRIB_STRIDE is limited to 2048 (the common value for it
according to gpuinfo.org) and conservatively rounds up every buffer
allocation to that size.

While technically, this workaround should be applied on any device with
the robustBufferAccess feature enabled, it is currently limited to AMD
to avoid the inefficiency.  A possible future revision of Vulkan may
relax the above restrictions.

Bug: angleproject:2848
Change-Id: Ida5ae5d777da10f22ce8be5a09a7644b5bbd778e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991709Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

When the program binding changes, we set the descriptor sets binding
dirty bit if the program had any textures, UBOs, SSBOs, images or atomic
counters.  The check for default uniforms was missing.  So if the two
programs had no resources and were only using default uniforms, then
drawing with one after the other didn't update the descriptor set
binding of the default uniforms for the second draw.

Bug: angleproject:4277
Change-Id: I631a1619658ee713484cfaee99fe1e39987e16e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993408
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Bug: angleproject:2970
Change-Id: Ie14725b0cf30738d394320c24a72bc947135f5cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993204Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Added a small helper function (LimitVersionTo) to prevent future mistakes.

Bug: angleproject:4168
Change-Id: Ia19312459540adbc2788ad0a5cb3d19ef1ff784f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1992185
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Also added a few assertions to ensure that timestamp queries aren't attempted
when support is missing.

Bug: angleproject:4114
Change-Id: Ie6d7d5face59f9bc137aebd86c9d0e965773e6e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1992184
Commit-Queue: Eric Binet <ericbinet@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Swiftshader does not have support for D24_S8 (typical fallback for
32bit DEPTH_COMPONENTS) but does have D32_FLOAT, so add fallback to
that format. This then allows ANGLE to support OES_depth_texture
extension when using Swiftshader which is needed to allow Vulkan
swiftshader to replace GL swiftshader.

Bug: angleproject:4232
Change-Id: Iaf04fcf0bea8d9cca0b9e7a18e3351ce8c704355
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986413
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

winuwp-x64-dbg and winuwp-x64-rel CI and Try bots.

Bug: angleproject:3928
Change-Id: Ifc54f6daae1090f9c68be6edcd8b1a069f0c5fc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993691
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ac72777ef763..c17344df6cca

git log ac72777ef763..c17344df6cca --date=short --first-parent --format='%ad %ae %s'
2020-01-09 petr_kraus@email.cz scripts: Report unassigned VUIDs in stats
2020-01-09 petr_kraus@email.cz scripts: Add best practices tests to stats

Created with:
  gclient setdep -r third_party/vulkan-validation-layers/src@c17344df6cca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I670cc25dee3714a451636bfa1e66145d8f77181f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994252Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/77c89ff847b6..110236f3ce70

git log 77c89ff847b6..110236f3ce70 --date=short --first-parent --format='%ad %ae %s'
2020-01-09 sugoi@google.com Enable filtering depth+stencil formats
2020-01-09 bclayton@google.com Kokoro: Disable ASAN for debug mac builds
2020-01-09 bclayton@google.com SpirvShader: Move extension list out of for loop.
2020-01-09 bclayton@google.com C++14: Use std::make_unique where possible.
2020-01-09 swiftshader.regress@gmail.com Regres: Update test lists @ 77c89ff8

Created with:
  gclient setdep -r third_party/SwiftShader@110236f3ce70

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Ibe4bccbad9c9f306953164aa7c0faf8c778ba68c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994251Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Added the EAGL backend authored by Dean Jackson from Apple, and the
refactoring changes needed to support it side-by-side with the macOS
backend. Ran "git cl format" against these diffs.

Defined the EGL_ANGLE_device_eagl extension and allocated an enum out
of ANGLE's reserved range.

The iOS backend is not yet included in any of the GN files.

Bug: angleproject:4263
Change-Id: I631c32930433c03bb16a242955ffedf55174bb29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987278Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

Dependencies seem to be incorrectly tracked in some Intel OpenGL
drivers (on macOS specifically), causing crashes in glDeleteTextures
if a GL command buffer is being constructed where those textures are
destinations of CopyTexImage2D/CopyTexSubImage2D. Work around this bug
by flushing before texture deletion if CopyTex{Sub}Image have been
called recently. The tracking is only done on a per-context rather
than a per-device basis, but seems sufficient to work around the
problem as identified.

Tested both with new ANGLE test on affected hardware, and in WebKit's
ANGLE backend for WebGL. Works around the crash reported in
https://bugs.webkit.org/show_bug.cgi?id=205707 .

Bug: angleproject:4267
Change-Id: I2266a5590759f6a3f19080def08710ef4b66d463
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987932
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Need to explicitly specifly volk LICENSE.md filename in README.chromium
file.

Bug: angleproject:4225
Change-Id: I5d71ef0c28063f6e036f94ddb7d2c9e289fe79d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993397Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

In https://crrev.com/c/1838418 I added the ability to disable
ARB_texture_rectangle so that we can use it in the WebGL implementation
but disable it when compiling user shaders. Unfortunately disabling
and re-enabling the extension causes the shader translator to be
reinitialized which turns out to be more expensive than the actual
work of shader translation, at least for small shaders. It's slow enough
to cause timeouts in WebKit's WebGL conformance test runs.

This introduces an alternate method of disabling ARB_texture_rectangle
in the translator which is much faster because it avoids reinitializing
the translator.

Bug: angleproject:3956
Change-Id: I5d31b683ff19a59bdfd289cfd3c609f64ef5e25b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991969Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70b009b0f1e..fb2e819819ef


Created with:
  gclient setdep -r third_party/spirv-tools/src@fb2e819819ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com,jmadill@google.com
Change-Id: Ife103b6f2c902c3ec357ab5058c1afe0c5648119
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993380Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>