Commits · 8b74bdc2df163584697c5fe82d0c606621c1df2c · Chen Yisong / angle

13 Dec, 2019 10 commits

Vulkan: Refactor glslang wrapper's varying location assignment · 8b74bdc2

authored Dec 10, 2019

Instead of multiple ifs that test for various combination of shader
stages and calling AssignVaryingLocations for the appropriate pairs,
that function loops over all stages and assigns a location to the
varying in any stage it is active.

This change will help keep this code simpler with the introduction of
tessellation shaders.

Bug: angleproject:3571
Change-Id: Iaf3ee67990bd219080314237b314bd2770a43085
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961096Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8b74bdc2

Restructure textureGatherOffset* builtin declarations · 19868b7e

authored Dec 13, 2019

This is in preparation of textureGatherOffsets support.

Bug: angleproject:3569
Change-Id: I4ce5a1e102790181c8f843735961b9c249a69221
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965720Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

19868b7e

Vulkan: Have the translator output in/out qualifiers · b8e056dd

authored Dec 11, 2019

Currently, when assigning varying locations, we assign in/out qualifiers
based on whether the varying name is present between different shader
stages.

This is broken for separate shader objects as there is possibly no pair
of shaders to be able to tell which is input and which is output (by
trying to find the same varying in a stage before or after the shader).

Bug: angleproject:3571
Change-Id: Id928a3eaa16e917c81bae0b3414c41842eb2b664
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961993
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b8e056dd

Validate that image array indices are constant · e181f2f7

authored Dec 10, 2019

Also adds compiler tests for dynamic indexing of SSBOs and images.

Bug: angleproject:3569
Change-Id: I84b90813840ffad5a9a3cd8e7f12bd637a57b327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961095Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e181f2f7

Fix GGP build · bf47a17e

authored Dec 13, 2019

Bug: angleproject:4221
Change-Id: I625b78795dbc826d176660e47af9b51d3f8d417b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966410Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bf47a17e

Roll third_party/vulkan-validation-layers/src 6a35bc9967d9..d2c3daeb56e9 (3 commits) · e1822727

authored Dec 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6a35bc9967d9..d2c3daeb56e9

git log 6a35bc9967d9..d2c3daeb56e9 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 jzulauf@lunarg.com layers: Improve const shared pointer handling
2019-12-12 mark@lunarg.com corechecks: Correct swapchain validation error text
2019-12-12 tony@lunarg.com gpu: Add validation for VK_KHR_buffer_device_address

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@d2c3daeb56e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Iafb69556fd7a48e7df8e1f08d8f38fd23a659f9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966026Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e1822727

Roll third_party/SwiftShader 07958d452f93..ebb0bec91552 (4 commits) · f139f976

authored Dec 13, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/07958d452f93..ebb0bec91552

git log 07958d452f93..ebb0bec91552 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 sergeyu@chromium.org Use allocateExecutable() in LLVMReactor
2019-12-12 sugoi@google.com Fix BCn related SwANGLE test failure
2019-12-12 capn@google.com Prevent clang-format from splitting shift operator
2019-12-12 sugoi@google.com Support for BC1, BC2, BC3, BC4 and BC5

Created with:
  gclient setdep -r third_party/SwiftShader@ebb0bec91552

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: If0eb478a35cabd6c09007f70a75dad0757749605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966024Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f139f976

Roll third_party/spirv-tools/src 5c019b5923c1..96354f5047bf (1 commits) · 06db147e

authored Dec 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5c019b5923c1..96354f5047bf


Created with:
  gclient setdep -r third_party/spirv-tools/src@96354f5047bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Ia02eda3a904131e1efa5f401e6259e09bf9848a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966023Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

06db147e

Roll third_party/glslang/src 6c479796f6e4..ebf634bcaa3e (1 commits) · ef11f849

authored Dec 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6c479796f6e4..ebf634bcaa3e


Created with:
  gclient setdep -r third_party/glslang/src@ebf634bcaa3e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I5d36e291b54c1d57688e413a9b8e6a794b15277f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966025Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ef11f849

Add flag to label captures · 1d77542f

authored Dec 03, 2019

Add an optional parameter (ANGLE_CAPTURE_LABEL) to
ANGLE frame capture that tags files and functions
uniquely, allowing multiple frame captures to be
replayed by a test harness.

Example:

  ANGLE_CAPTURE_LABEL=foo

Results in filenames like this:

  foo_capture_context1.cpp
  foo_capture_context1.h
  foo_capture_context1_files.txt
  foo_capture_context1_frame000.angledata
  foo_capture_context1_frame000.cpp
  foo_capture_context1_frame001.angledata
  foo_capture_context1_frame001.cpp
  ...

Functions wrapped in namespaces like this:

  namespace foo
  {
      void ReplayContext1Frame0();
      void ReplayContext1Frame1();
  }

For use like this:

  foo::SetupContext1Replay();
  for (...)
  {
      foo::ReplayContext1Frame(i);
  }

Bug: angleproject:3630
Change-Id: Ibe27dc4d40a36606ee40678a9e4d43b5a4baf976
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949603
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1d77542f

12 Dec, 2019 8 commits

gn: Add 'test_only' label to util targets. · 554b453c

authored Dec 12, 2019

Clarifies that angle_util is only used in tests and samples.

Bug: angleproject:3162
Change-Id: I9a578cf7a9a09b2c3fd4683155824ed2e72f68cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964934Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

554b453c

util: Always export default visibility. · 270e2e88

authored Dec 12, 2019

This should fix the CFI build compatibility with class exports.

Bug: chromium:1030192
Bug: angleproject:3162
Change-Id: I228d6d387f8b29c0a500038de962f9f216454d7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964933Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

270e2e88

Roll chromium_revision d209d45ba4..e1633af636 (719599:724302) · e0f8b5d0

authored Dec 12, 2019

Change log: https://chromium.googlesource.com/chromium/src/+log/d209d45ba4..e1633af636
Full diff: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ebec9c5ad4..dfe5662014
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/72e16daaa5..c1b508625d
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/60616473f7..f8eeeb06c0
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e77e1c06c8..f262c1b3c4
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/05979d8cad..a9190d6699
DEPS diff: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636/DEPS

Clang version changed e84b7a5fe230e42b8e6fe451369874a773bf1867:c2443155a0fb245c8f17f2c1c72b6ea391e86e81
Details: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636/tools/clang/scripts/update.py

TBR=jmadill@chromium.org,
BUG=None

Change-Id: I3e2d6b59263870a6713b8e3d2161c2411b932cf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965436Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e0f8b5d0

Roll third_party/vulkan-tools/src 0dc201a808ec..c1a7421f0f93 (3 commits) · 0bf3c4b5

authored Dec 12, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0dc201a808ec..c1a7421f0f93

git log 0dc201a808ec..c1a7421f0f93 --date=short --first-parent --format='%ad %ae %s'
2019-12-11 charles@lunarg.com build: update vulkaninfo.hpp to fix windows build warnings
2019-12-11 mark@lunarg.com build: Update to verson 1.1.130 of the Vulkan Headers
2019-12-11 charles@lunarg.com vulkaninfo: reduced spurious warnings for msvc

Created with:
gclient setdep -r third_party/vulkan-tools/src@c1a7421f0f93

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Id6562a8b6967909c70aef10ea8f6c9fead24c0c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963622Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0bf3c4b5

Roll third_party/spirv-tools/src 00ca4e5bdfdb..5c019b5923c1 (3 commits) · e2d7cbf6

authored Dec 12, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/00ca4e5bdfdb..5c019b5923c1


Created with:
  gclient setdep -r third_party/spirv-tools/src@5c019b5923c1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I58aada86788183ec7904ec51e8a68df29c77f2b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963623Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e2d7cbf6

Roll third_party/vulkan-validation-layers/src da451cc7cd04..6a35bc9967d9 (6 commits) · d5ac2e89

authored Dec 12, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/da451cc7cd04..6a35bc9967d9

git log da451cc7cd04..6a35bc9967d9 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 jbolz@nvidia.com tests: Add tests for VK_KHR_buffer_device_address
2019-12-12 jbolz@nvidia.com layers: Add VK_KHR_buffer_device_address support
2019-12-11 tobias.hector@amd.com tests: Added tests for new vkAllocateMemory validation
2019-12-11 tobias.hector@amd.com layers: Introduce validation for vkAllocateMemory VUIDs
2019-12-11 jeremy@lunarg.com tests: Test overlapping push constant ranges
2019-12-11 jeremy@lunarg.com corechecks: Fix overlapping push constant ranges

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@6a35bc9967d9

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Ib8f078d1fb93bee521567b67fa87c6ccc078eaaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963625Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d5ac2e89

Roll third_party/SwiftShader 544ae91ee039..07958d452f93 (10 commits) · 62602e94

authored Dec 12, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/544ae91ee039..07958d452f93

git log 544ae91ee039..07958d452f93 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 bclayton@google.com src/Vulkan/Debug: Add scope for case block
2019-12-11 bclayton@google.com Vulkan/Debug: Add Server
2019-12-11 bclayton@google.com Vulkan/Debug: Add Context
2019-12-11 bclayton@google.com Tweaks to make clang-format produce better code
2019-12-11 amaiorano@google.com Add EmulatedReactor.cpp to Subzero.vcxproj
2019-12-11 bclayton@google.com Regres: Fix debug macro detection
2019-12-11 capn@google.com Do not indent C++ namespace contents
2019-12-11 bclayton@google.com Vulkan: Add description methods to all commands.
2019-12-11 bclayton@google.com .vscode: Add cppdap to includePath
2019-12-11 swiftshader.regress@gmail.com Regres: Update test lists @ 544ae91e

Created with:
gclient setdep -r third_party/SwiftShader@07958d452f93

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I5576ab6409124dd99dd903c949598797479894cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963624Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

62602e94

Vulkan: Avoid linear search in shader on varying location assignment · 6381d7f1

authored Dec 10, 2019

Glslang wrapper was trying to identify whether the varying is declared
in each of the out/in shaders by looping through the macro symbols that
need replacement.

This change instead adds stage information to PackedVarying assigned
when collecting varyings.  Glslang wrapper then simply tests the
bitfield for the stages of interest.

Bug: angleproject:3571
Change-Id: I29614e3e62d7df88e413c1732ac04e24243f167a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954677Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

6381d7f1

11 Dec, 2019 10 commits

Suppress more dEQP-GLES31.functional.shaders.helper_invocation.* tests · 3c75d244

authored Dec 11, 2019

Failures discovered when running locally on Pixel 2 with recent OS.

Bug: angleproject:4110
Change-Id: I14cde5456a0d7802c60ed3bc771fc371b0834087
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1962541Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

3c75d244

Presubmit check forbidding tab characters in source files. · 4dff9956

authored Dec 10, 2019

WebKit's Subversion repository forbids tab characters in source files.
Follow-up to:
https://chromium-review.googlesource.com/c/angle/angle/+/1954410

Bug: angleproject:3439
Change-Id: I7ab170cae6985c62ee2f163c15d2746f620fe648
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959750
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

4dff9956

Vulkan: Fix descriptor pool init in presence of atomic counters · 49135f68

authored Dec 10, 2019

The descriptor pool was initialized with the number of atomic counter
buffers, but we always use 8 storage buffers for atomic counter buffer
emulation regardless of how many atomic counter buffers there.

This change fixes the descriptor pool initialization by requesting 8
storage buffer descriptors if there are any atomic counter buffers.

Bug: angleproject:4199
Change-Id: Ide58c013cba8ac46228dba795a82304b97ee83ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959489
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

49135f68

Vulkan: EXT_gpu_shader5 support: dynamically uniform indexing · e4eb75da

authored Dec 06, 2019

Bug: angleproject:3569
Change-Id: I5abb7f2889fa5173457497d4156a3dadbcf77640
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954613
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

e4eb75da

Vulkan: Update Linux-specific multisample failures · fa467885

authored Dec 11, 2019

Bug: angleproject:3565
Change-Id: I429268ba679dff924b229d289ced7148c1d86fdb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961594Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

fa467885

Return valid qualifier after error · 4ad8b55e

authored Dec 03, 2019

Using EvqLast for the variable causes us to hit an assert in
sh::getQualifierString when we try to print a later error message.
Just use the appropriate qualifier regardless that it's not valid
for a compute shader, we've output the error.

Bug: angleproject:4187
Change-Id: If6fa5dea07d7b6e0d3307485f41d59c5ea7f1c4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948525
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

4ad8b55e

Roll third_party/vulkan-tools/src 5ceb7be9a3bf..0dc201a808ec (3 commits) · 1ed23f2d

authored Dec 11, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5ceb7be9a3bf..0dc201a808ec

git log 5ceb7be9a3bf..0dc201a808ec --date=short --first-parent --format='%ad %ae %s'
2019-12-10 jeremyk@lunarg.com vulkaninfo: Add VK_EXT_metal_surface info
2019-12-10 jeremyk@lunarg.com windows: Change winrt name
2019-12-10 slawomir.cygan@intel.com vulkaninfo: load user32.dll dynamically

Created with:
gclient setdep -r third_party/vulkan-tools/src@0dc201a808ec

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I6dc514f4bb5718acc6d344870fc936f7c1274a8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961569Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1ed23f2d

Roll third_party/vulkan-validation-layers/src a749c31b749b..da451cc7cd04 (5 commits) · ac107569

authored Dec 11, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a749c31b749b..da451cc7cd04

git log a749c31b749b..da451cc7cd04 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 mark@lunarg.com layers: Remove vuid mapping file
2019-12-10 mark@lunarg.com build: Update for 1.1.130 version of Vulkan header
2019-12-10 mark@lunarg.com tests: Fix stray VUID ref in buffer_image_memory_sampler
2019-12-10 mark@lunarg.com tests: Fix stray VUID refs in positivelayertests
2019-12-10 mark@lunarg.com corechecks: Fix incorrect CmdSetViewportWScalingNV names

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@da451cc7cd04

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I5e2f985bf0066e5249dfd79c17ba3a5af413fb29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961572Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ac107569

Roll third_party/SwiftShader 31916f494c2e..544ae91ee039 (29 commits) · 11c42996

authored Dec 11, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/31916f494c2e..544ae91ee039

git log 31916f494c2e..544ae91ee039 --date=short --first-parent --format='%ad %ae %s'
2019-12-11 capn@google.com Enable vk-unittests with Subzero JIT
2019-12-10 bclayton@google.com Kokoro: Split tests into Debug and RelWithDebInfo
2019-12-10 chrisforbes@google.com Accept ImageCubeArray SPIRV capability
2019-12-10 bclayton@google.com Vulkan/Debug: Add Thread and EventListener
2019-12-10 bclayton@google.com Vulkan/Debug: Add Location
2019-12-10 bclayton@google.com Vulkan/Debug: Add File
2019-12-10 bclayton@google.com Vulkan/Debug: Add WeakMap
2019-12-10 bclayton@google.com Vulkan/Debug: Add Value and Variable
2019-12-10 bclayton@google.com Vulkan/Debug: Add Type
2019-12-10 bclayton@google.com CMakeLists: Fix logic of BUILD_CPPDAP
2019-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d00dfe49
2019-12-10 chrisforbes@google.com Advertise VK_PRESENT_MODE_MAILBOX_KHR
2019-12-10 bclayton@google.com Regres: Reduce scope of regres CI emails
2019-12-10 amaiorano@google.com Fix REACTOR_DEFAULT_OPT_LEVEL not actually applying
2019-12-10 capn@google.com Remove Visual Studio Vulkan project files
2019-12-10 bclayton@google.com Vulkan/Debug: Add ID
2019-12-09 chrisforbes@google.com Remove Float->UInt conversion workaround
2019-12-09 capn@google.com Add Float to UInt unit test
2019-12-09 amaiorano@google.com Add REACTOR_DEFAULT_OPT_LEVEL macro
2019-12-09 amaiorano@google.com Subzero: fix alloca return address allocation
2019-12-09 amaiorano@google.com Subzero: proper fix for assert(Dest->hasReg())
2019-12-09 bclayton@google.com CMakeLists: Add CMake rules for Vulkan debugger
2019-12-09 bclayton@google.com Add github.com/google/cppdap as a third_party dependency
2019-12-09 bclayton@google.com Add github.com/nlohmann/json as a third_party dependency
2019-12-09 capn@google.com Enforce int and short to be 32- and 16-bit respectively
2019-12-09 sugoi@google.com Cubemap array support
2019-12-09 amaiorano@google.com Revert "Fix materialization of function arguments"
2019-12-09 bclayton@google.com Kokoro: Add ReactorUnitTests to windows presubmits
2019-12-09 capn@google.com Remove coverage asserts for tested code

Created with:
gclient setdep -r third_party/SwiftShader@544ae91ee039

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Icc4faea0596e4e01d0d997a2d2d0a07aa1d993cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961571Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

11c42996

Roll third_party/spirv-tools/src 983b5b4fccea..00ca4e5bdfdb (2 commits) · e5c2089f

authored Dec 11, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/983b5b4fccea..00ca4e5bdfdb


Created with:
  gclient setdep -r third_party/spirv-tools/src@00ca4e5bdfdb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: If27692a6f0255eecb19794c13d3f4b3e4d6ad6eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961570Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e5c2089f

10 Dec, 2019 8 commits

Remove tabs from source files. · d6053daa

authored Dec 05, 2019

WebKit's Subversion repo refuses to commit source files that contain
tabs.

Bug: angleproject:3439
Change-Id: I0a804bcfa0375a98e19945e20297c90d31106827
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954410
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

d6053daa

Vulkan: Implement Transform Feedback support via extension · caa6eccd

authored Oct 27, 2019

Implemented transform feedback extension path. Where
VK_EXT_transform_feedback is supported, extension path will be taken
over an emulation path. Extension path has advantages in terms of
performance.

BUG=angleproject:3206
Test: dEQP-GLES3.functional.transform_feedback.*
      angle_end2end_tests --gtest_filter=TransformFeedbackTest*

Change-Id: Ia07c23afb289d9c67073469a97b714ec96f5265a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1882767
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

caa6eccd

Roll third_party/glslang/src d519167d2ecb..6c479796f6e4 (3 commits) · ccea6b5b

authored Dec 10, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d519167d2ecb..6c479796f6e4


Created with:
  gclient setdep -r third_party/glslang/src@6c479796f6e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I0a2e7eff7a803818df5ad331b5ff0fe75eb83588
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959779Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ccea6b5b

Roll third_party/vulkan-validation-layers/src f34b9fb086b3..a749c31b749b (3 commits) · 4059f49c

authored Dec 10, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f34b9fb086b3..a749c31b749b

git log f34b9fb086b3..a749c31b749b --date=short --first-parent --format='%ad %ae %s'
2019-12-10 tony@lunarg.com tests: Add pos test for GetProcAddr with extensions
2019-12-10 tony@lunarg.com layers: Fix GetProcAddr for promoted extensions
2019-12-09 shannon@lunarg.com build: Update known-good for 1.1.129 Vulkan header

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@a749c31b749b

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I34b27bb71b6806f20019976863dd7760c9fed0cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959774Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4059f49c

Vulkan: Update bugs for multisample texture failures · 9906bccc

authored Dec 10, 2019

After additional debugging, new bugs were filed and bug numbers were
updated.

Bug: angleproject:3565
Bug: angleproject:4197
Bug: angleproject:4212
Bug: angleproject:4213
Change-Id: I7211df7d19280f2fba482394c23a887e6ea5e002
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959490Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

9906bccc

Vulkan: EXT_gpu_shader5 support: fma · 9af3e137

authored Dec 05, 2019

Add the fma() builtin function to ESSL.

Bug: angleproject:3569
Change-Id: Ic8419b4c117ecdd8b47aa733bf7aff9ee7579bbf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954484Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

9af3e137

Fix potential indexing into an empty vector in ANGLE tests · 351307eb

authored Dec 10, 2019

The tests are failing after "Warning: incomplete system info collection"
which suggests systemInfo.gpus is empty. Check for that before indexing
into the vector; defaulting the active index to zero in
https://chromium-review.googlesource.com/c/angle/angle/+/1925031 was not
sufficient and the line still needs a bounds check.

Bug: chromium:923166, chromium:1032552
Change-Id: Ic9716830403e0dfcfa5d11539537c2a39e0e2386
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959488Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

351307eb

Vulkan: Add options to select more device types · 3eaf6294

authored Nov 25, 2019

Add support to set a default device type
using existing ANGLE_DEFAULT_PLATFORM
environment variable. The valid vulkan options
are as follows:

vulkan              - vulkan with device hardware
vulkan-null         - vulkan with null device (Mock ICD)
swiftshader         - vulkan with swiftshader

Bug: angleproject:3998
Change-Id: I15f00e8024818fbaf674ca6fcdbcdac5a90cace2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1956140
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

3eaf6294

09 Dec, 2019 4 commits

Fix out-of-bounds access bug in ANGLE tests · f60da874

authored Nov 19, 2019

When not filled in, as in Android, activeGPUIndex is -1. This is fine
for Android because it doesn't use vendorID, but the function computed
vendorID unconditionally without checking for -1.

Default activeGPUIndex to 0 instead of -1. Note code still needs to
check for systemInfo.gpus.empty().

This caused crashes when _LIBCPP_DEBUG=0 was enabled.

Bug: chromium:923166
Change-Id: If4d1dff9553a580fd92bc0497fc092789d07ed93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925031Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

f60da874

Add metal display type to angle_deqp_tests · 6e4004dd

authored Dec 06, 2019

Adds --deqp-egl-display-type=angle-metal for running the deqp tests
on Mac. Note: does not add any test suppressions for metal.

Bug: angleproject:2634
Change-Id: I8f8d3a83cf93a5b930b05af9f0075a9ce435823a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954612Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

6e4004dd

Roll third_party/vulkan-headers/src 2b89fd4e2734..0e57fc1cfa56 (1 commits) · 01553e0e

authored Dec 09, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2b89fd4e2734..0e57fc1cfa56

git log 2b89fd4e2734..0e57fc1cfa56 --date=short --first-parent --format='%ad %ae %s'
2019-12-09 oddhack@sonic.net Update for Vulkan-Docs 1.1.130

Created with:
  gclient setdep -r third_party/vulkan-headers/src@0e57fc1cfa56

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=ianelliot@google.com

Bug: None
Change-Id: Ie028ebf3b6be0b833e980658b755ef428250614c
Tbr: ianelliot@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957400Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

01553e0e

Roll third_party/SwiftShader b9f03f47d5f5..31916f494c2e (7 commits) · 5a1add39

authored Dec 09, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/b9f03f47d5f5..31916f494c2e

git log b9f03f47d5f5..31916f494c2e --date=short --first-parent --format='%ad %ae %s'
2019-12-07 digit@google.com [Subzero] Remove assert that breaks Shuffle operations.
2019-12-06 bclayton@google.com SpirvShader: Use struct for MemoryVisitor callback.
2019-12-06 bclayton@google.com Regres: Update dEQP to include fence timeout fix.
2019-12-06 bclayton@google.com Vulkan: Tidy VkCommandBuffer.cpp
2019-12-06 bclayton@google.com Reactor: Rename Blend() to Shuffle()
2019-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ b9f03f47
2019-12-06 bclayton@google.com Reactor: Switch swizzles over to 16-bit hex codes

Created with:
gclient setdep -r third_party/SwiftShader@31916f494c2e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Icfd2b4304841ad6d7b419d5c7d5d477faef45505
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957973Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5a1add39